[00:58:36] <Colourless> Malignant_Manor, it *shouldn't* be a game breaker as the game itself only expects the quality or quantity flag to be set on items where its saved.
[00:58:48] <Colourless> however its an issue for mods
[01:00:58] <Malignant_Manor> I have no idea if it is the initial read or the save that causes the problem.
[01:01:07] <Colourless> both
[01:01:23] <Colourless> the save game only saves quant or qual if the item class has it
[01:01:34] <Colourless> the item type flags determine if its saved
[01:02:02] <Colourless> its a case of keeping the savegame format as close as possible to the originals
[01:02:16] <Malignant_Manor> Quality flags saved at least temporary flag and it doesn't.
[01:02:37] <Malignant_Manor> I thought it saved the quality too.
[01:06:22] <Malignant_Manor> Maybe I'm mistaken on that though.
[01:10:37] <Colourless> if you look at Ireg_game_object::write_ireg() in iregobs.cc you can see quality is only conditionally written
[01:10:55] <Colourless> actually
[01:10:59] <Colourless> i'm wrong ther
[01:11:10] <Colourless> no wait, i'm write
[01:11:12] <Colourless> *right
[01:11:17] <Colourless> the code is just confusing
[01:11:45] <Colourless> quality isn't always saved
[01:11:56] <Colourless> or is it...
[01:12:37] <Colourless> the code seems to indicate quality is always saved, but the field in the save game is used for other things too
[01:13:17] <Colourless> for most items quality is save, for some however the field is used to store extra flags
[01:14:33] <Malignant_Manor> Unless temporary is the default,, BG saved the temporary flag.
[01:15:09] <Colourless> there 'may' be code in exult that clears the temporary flag in some conditions
[01:15:52] <Malignant_Manor> I'm not sure of any script or schedule created quality flags items that are permanent offhand to test against though.
[01:18:28] <Colourless> ok looking at the restore code, temporary flag is only restored for ojects that are 10 bytes long
[01:20:51] <Colourless> which is *most* objects
[01:22:38] <Malignant_Manor> I don't see why Exult would not need to save item quality or temporary flag.
[01:42:21] <Malignant_Manor> Quality flags items do save the temporary quality in the original. Tested with bread (temporary) and sling (permanent).
[03:32:52] <-- Malignant_Manor has left IRC (Quit: ChatZilla 0.9.86 [Firefox 3.6.13/20101203075014])
[11:04:24] --> Dominus has joined #exult
[11:04:24] --- ChanServ gives channel operator status to Dominus
[11:17:20] <Dominus> wjp, in http://exult.sourceforge.net/forum/read.php?f=1&i=345076&t=345076 do you have any idea why that fails again at usecodeparse.cc? I thought we only have problems with very old bison/flex?
[11:17:55] <Dominus> or is that bison version the user reported (bison 2.4.1.dfsg-3) somehow not fully compatible or so?
[11:55:47] <wjp> the errors point at something with flex, I think
[11:56:18] <wjp> (all the undefined references are to things that should be in flex' output)
[12:52:25] <-- Kirben has left IRC ()
[13:13:26] <Dominus> more strange then... flex is the same as here.. should work I'd say... maybe some weird correlation between fley and bison...
[14:22:17] --> Dark-Star has joined #exult
[16:24:15] <-- Dark-Star has left IRC (Ping timeout: 272 seconds)
[16:31:44] --> Dark-Star has joined #exult
[16:39:00] <-- Dark-Star has left IRC (Ping timeout: 245 seconds)
[16:44:34] --> Dark-Star has joined #exult
[18:48:17] --> Malignant_Manor has joined #exult
[20:14:04] <Malignant_Manor> Dominus, I should be sending the command line files in a bit.
[20:19:50] <Malignant_Manor> Mail sent
[21:04:48] <-- Dark-Star has left IRC (Ping timeout: 250 seconds)
[21:10:08] --> Dark-Star has joined #exult
[21:19:58] <Dominus> Malignant_Manor: I will have time to test somewhat in an half an hour
[21:21:26] <Malignant_Manor> There's also a patch around the same time that makes alternate config files work again. (broken when we changed to Local AppData\Exult)
[21:23:34] <Dominus> the -c option?
[21:23:57] <Dominus> that would be useful as well to have working
[21:25:32] <Dominus> (with the portable one and the way the OSX app bundle works, I can have a working portable Exult on a stick with "just" the app bundle and everything else (including the Windows version) needed in the bundle itself...
[21:25:41] <Dominus> nice...
[21:25:56] <Dominus> will report back in a few how this version works now
[21:31:45] <Malignant_Manor> I don't understand your "with the portable one" comment. You mean that you are using a Wine or a virtulization of Windows?
[21:32:15] <Malignant_Manor> I don't know how to make anything other than Win32 portable.
[21:34:43] <Dominus> back... no I mean if the portable switch for the windows versions works, the -c switch also works on OS X (got to test that), then I can put all this into a bundle and either double click on the bundle when on OS X or start the windows version in the bundle (app bundles on OS X are actually just folders with appname.app (exult.app for example)) with the --portable switch
[21:40:39] <Dominus> Malignant_Manor: same problem again
[21:41:15] <Dominus> when I first start this exult with the --portable switch it will not start, only write stdout/stderr, that the checksums are wrong
[21:43:43] <Dominus> (also this version had the mingwm10.dll missing but I had this one still from the other one)
[21:44:31] <Malignant_Manor> Yeah, I had a separate test folder from the others. I'm going to check the archive to see if something is different.
[21:45:25] <Dominus> it's really strange, when I start Exult without the portable switch it starts normal, without a complaint about checksums being wrong.
[21:45:35] <Dominus> seemsthe portable switch makes it confuse the files
[21:46:52] <Malignant_Manor> Is this with or without a cfg file?
[21:48:25] <Dominus> without first and if I have one in there it still complains, even when pointing at the correct data folder
[21:51:40] <Dominus> he he and suddenly it works... schrödingers cat...
[21:52:12] <Dominus> I started Process explorer to see what it does exactly and suddenly it worked
[21:52:25] <Dominus> let me see what else I could have been doing
[21:53:37] <Malignant_Manor> Yeah, it doesn't happen here.
[21:53:56] <Malignant_Manor> Saves default to ./blackgate, etc. it seems.
[21:54:34] <Malignant_Manor> That keeps it nice and separate from U7 in DosBox
[21:59:02] <Dominus> hmm, something is going wrong here with an old install of exult.
[22:00:05] <Dominus> I've started Exult from the Total Commander command line and it seems it started an old version of exult with the path set to the portable versions location...
[22:00:51] <Dominus> yup, that'S what is happening
[22:05:02] <Dominus> hell f I know why Total Commander is doing that...
[22:07:37] <Dominus> found it... because of the registry entry HKLM\software\Microsoft\windows\current version\App Paths\Exult.exe
[22:07:56] <Dominus> no idea how that entry got there... but that one made the command line go wrong...
[22:08:10] <Dominus> got that sorted out... let's go testing for real :)
[22:08:43] <-- Malignant_Manor has left IRC (Quit: ChatZilla 0.9.86 [Firefox 3.6.13/20101203075014])
[22:09:06] --> Malignant_Manor has joined #exult
[22:10:47] <Malignant_Manor> That's weird. It shouldn't call another exult if in the same folder as exult.exe.
[22:11:23] <Dominus> did you read my last post?
[22:11:41] <Dominus> it was because of some registry setting which shouldn't be there...
[22:11:54] <Dominus> anyway got that sorted out
[22:12:14] <Malignant_Manor> It shouldn't happen as far as I know.
[22:13:02] <Malignant_Manor> if the command line is in the proper exult folder.
[22:13:42] <Dominus> It shouldn'T happen, but I guess Total Commander honors the App Path setting and thus confuses stuff
[22:23:13] <Dominus> Malignant_Manor: seems to work fine. just on command lines you shouldn't pass -portable to Studio, either just make it -p or if it is possible --portable AND -p (-p for Exult would be nice too) but not -portable
[22:23:41] <Dominus> because if you pass more than one letter it is traditionally that you do a --
[22:25:51] <Malignant_Manor> Ok, see what my lack of coding knowledge does?
[22:25:59] <Dominus> :)
[22:26:07] <Dominus> yours is better than mine :)
[22:26:19] <Dominus> I know just a few details :)
[22:29:12] <Malignant_Manor> It should easily be possible.
[22:31:30] <Dominus> wine does NOT like Exult Studio :)
[22:32:01] <Dominus> at least in XP it is working :)
[22:33:41] <Dominus> (and wine doesn't like ES anyway, no matter whether normal ES or this one with the portable patch)
[22:35:48] <Dominus> let'S see how the other Windows like it
[22:38:19] <-- exultbot has left IRC (Ping timeout: 240 seconds)
[22:38:19] <-- exultbot has left IRC (signing off...)
[22:43:22] --> exultbot has joined #exult
[22:43:22] --- Topic for #exult is: Exult: http://exult.sourceforge.net/ - The open source engine for Ultima 7
[22:43:22] --- Topic for #exult set by Colourless at Fri Sep 12 00:40:42 2008
[22:43:35] <Dominus> ah, there you are... good boy
[22:44:14] <Malignant_Manor> Good thing he wasn't around to hear those naughty things you said.
[22:44:38] <Dominus> yeah, he can be sensitive at times...
[22:47:35] <Dominus> malignant, in the patch for this portable one at line 90 you delete "redirect_output("std");"
[22:47:50] <Dominus> you have it above that in line 70 in the idef win32
[22:48:11] <Dominus> was that redirect_output("std"); ifdef Win32 as well?
[22:48:25] <Dominus> (well, I can look that up myself)
[22:51:24] <Dominus> I don't quite like the command line description you give "Makes the home path the Exult directory (old Windows way)"
[22:51:48] <Malignant_Manor> What's the file? I think redirect_output("std") is only used for Windows atm.
[22:52:16] <Dominus> yes, it's tied to some Windws code
[22:52:37] <Dominus> it's in exult.cc line 507 or so
[22:52:57] <Malignant_Manor> I don't even remember having an output for Linux kernel systems.
[22:53:41] <Dominus> you have in terminal
[22:54:16] <Malignant_Manor> Yeah, but you have to run in terminal and even then, you have to highlight in the crappy terminal
[22:54:46] <Colourless> or you just pipe to a file
[22:54:52] <Dominus> in os x when you doubleclick the binary a terminal opens with just the output of the binary
[22:55:21] <Malignant_Manor> Shh, don't use your logic on me. How do you redirect it to a file?
[22:55:21] <Dominus> if you doubleclick the app bundle the output is viewabel in the Console.App
[22:55:32] <Dominus> > file...
[22:56:26] <Malignant_Manor> For some reason, Pentagram doesn't seem to redirect output in Windows anymore.
[22:57:03] <Dominus> wasn't that fixed already some weeks ago?
[22:58:20] <Malignant_Manor> I don't remember my tracker closing.
[22:58:32] <Dominus> rev 2480 did something there
[23:01:57] <Dominus> though it doesn't seem like it fixed that...
[23:03:00] <Malignant_Manor> Nope, still broken.
[23:06:13] <Malignant_Manor> Have you noticed any more potential problems with the patch?
[23:06:21] --> Kirben has joined #exult
[23:06:21] --- ChanServ gives channel operator status to Kirben
[23:06:51] <Dominus> malignant, no seems good so far. Am trying to get it running on a Windows 9x VM now
[23:17:04] <Dominus> seems to workj fine there as well
[23:17:49] <Dominus> so if no one objects to you adding a possible windows breaking feature... go for it :)
[23:20:58] <Dominus> the only problem i see is with people forgetting that they are using a portable Exult, then starting Exult normally and wondering where their savegames and stuff went...
[23:23:47] <Dominus> hmm, I wonder why Jeff doesn't use a changelog for his android work...
[23:27:06] <Malignant_Manor> Yeah, that's why it should be recommended to compile yourself if you can and use define PORTABLE_EXULT_WIN32.
[23:28:02] <Dominus> huh? so don't use the portable switch?
[23:28:02] <Malignant_Manor> Is there a way to not have the batch file keep the command prompt open?
[23:29:33] <Malignant_Manor> Well, if someone is setup for compiling Exult on Windows, it is better to define.
[23:30:01] <Dominus> hmm, either we go for the command line option or we leave it for people to self compile
[23:30:20] <Malignant_Manor> Well both.
[23:30:37] <Dominus> if we (you) have any doubts on whether the portable command line switch will break things then better not use it
[23:31:26] <Malignant_Manor> It shouldn't break anything, it is just less user friendly than than a precompiled portable version.
[23:31:47] <Dominus> ok, I see what you mean
[23:32:08] <Malignant_Manor> That's why next release Kirben should also compile a portable version.
[23:32:14] <Dominus> but the portable thing is not meant to be user friendly in any way
[23:32:33] <Dominus> if we have the command line option I'm really agianst a special portable version
[23:32:36] <Malignant_Manor> It is mainly mean for people to use the svn without compiling.
[23:33:08] <Malignant_Manor> Why no extra download?
[23:34:00] <Dominus> not many people do REALLY need a portable version, some may think they do, but most don't. Those that need one, should be fine with making a bat or cmd file (cmd file might be closing after starting - but is not compatible to older Windows)
[23:34:29] <Malignant_Manor> Of course, there are issues if an installer is used anyway.
[23:34:49] <Dominus> offering an extra version will only confuse people
[23:35:26] <Dominus> up to now we haven't had anyone of those 3700 windows downloaders complain about a portable version
[23:35:46] <Malignant_Manor> There was 1 on the forums.
[23:35:58] <Malignant_Manor> But that is one person.
[23:36:21] <Colourless> offering a version called portable that is NOT the standard version is a really BAD idea
[23:36:35] <Dominus> some (one or two) have had problems finding their old savegames - but that is for once a problem I need to take on in the FAQ and otoh people are probably better off with new saves anyway
[23:36:59] <Colourless> mabye something like for removeable devices might be better
[23:37:48] <Dominus> we need a Dropbox
[23:37:51] <Dominus> version
[23:37:53] <Dominus> :)
[23:38:26] <Dominus> but yes, offering two exult versions is asking for support problems
[23:38:37] <Malignant_Manor> Are you okay with having a command line option Colourless?
[23:39:22] <Colourless> personally, don't care much. I can cope with whatever way it works :-)
[23:40:53] <Malignant_Manor> Can you look over the code?
[23:41:36] <Malignant_Manor> https://sourceforge.net/tracker/download.php?group_id=2335&atid=302335&file_id=395954&aid=3092742
[23:42:07] <Colourless> can't right now. about to head out
[23:42:24] <Dominus> if you could take a look I'd be grateful. Things seem to work... but who knows maybe you can see some bad stuff right away
[23:42:30] <Dominus> but whenever you got time...
[23:43:37] <Dominus> I have to sleep now... my neck hurts, my head hurts... I'm done for...
[23:43:43] <Dominus> good night
[23:43:49] <-- Dominus has left IRC (Quit: Leaving.)
[23:44:39] --> Dominus has joined #exult
[23:44:51] <-- Dominus has left IRC (Client Quit)
[23:44:52] <Malignant_Manor> Will you have time to look at it in the next few days?
[23:48:05] --> Dominus has joined #exult
[23:48:37] <-- Dominus has left IRC (Client Quit)
[23:48:42] --- Dark-Star is now known as Dark-Star|Zzz
[23:49:22] <Malignant_Manor> If I remember properly, static bool portable;would only work in some areas so I used
[23:49:38] <Malignant_Manor> get_system_path("<HOME>") != "."
[23:53:22] <Malignant_Manor> The get_system_path("<HOME>") != "."
[23:54:11] <Malignant_Manor> checks in Configuration.cc should stay for sure. I think I will commit that now.