#exult@irc.freenode.net logs for 20 Dec 2014 (GMT)

Archive Today Yesterday Tomorrow
Exult homepage

[00:30:59] <-- TheCycoTWO has left IRC (Read error: Connection reset by peer)
[02:14:29] <-- Marzo has left IRC (Remote host closed the connection)
[02:48:04] --> DominusExult has joined #exult
[02:48:04] --- ChanServ gives channel operator status to DominusExult
[02:49:57] <-- Dominus has left IRC (Ping timeout: 240 seconds)
[02:49:57] --- DominusExult is now known as Dominus
[04:16:14] --> Kirben has joined #exult
[04:16:15] --- ChanServ gives channel operator status to Kirben
[06:18:43] <-- Lightkey has left IRC (Ping timeout: 272 seconds)
[06:30:55] --> Lightkey has joined #exult
[07:11:15] <-- amatecha has left IRC (Ping timeout: 258 seconds)
[07:14:19] <-- SugarCube has left IRC (Ping timeout: 258 seconds)
[07:16:53] --> SugarCube has joined #exult
[07:22:22] --> ParuCodex has joined #exult
[07:22:31] --> amatecha has joined #exult
[07:24:17] <-- Parunexus has left IRC (Ping timeout: 258 seconds)
[08:31:46] <Dominus> wjp, https://www.dropbox.com/s/cc1ffwb5ya4e3pc/egg.diff?dl=0
[08:31:59] <Dominus> this *should* work
[08:32:37] <Dominus> meaning it works but shouldn't break anything but fields (if at all)
[08:36:28] <Dominus> since we don't read in criteria for fields but set it ourselves, we should be fine changing the criteria slightly for fields
[10:40:10] <Dominus> oh nice, seemsI make it crash like this
[10:41:41] <Dominus> ok, monsters in firefields is a bad idea for some reason
[10:44:02] <Dominus> actually making campfires firefields is bad for some reason
[10:45:29] --> WebSpirit has joined #exult
[10:59:05] --> vimus has joined #exult
[11:09:33] <-- vimus has left IRC ()
[11:52:46] --> Marzo has joined #exult
[13:11:02] <-- Kirben has left IRC (Ping timeout: 272 seconds)
[13:28:22] <Dominus> Hi Marzo
[13:29:33] <Dominus> Any idea why exult will crash when adding campfire to shape_info.txt as fire field and an npc/monster steps on it?
[13:30:19] <Dominus> This is also with my little egg.cc patch that will make npcs being hurt by fields
[13:30:42] <Dominus> Normal fire fields will hurt npcs now
[13:30:59] <Dominus> T
[13:31:49] <Dominus> I'll investigate more with gdb later. Just wondered if you have a straight away idea
[16:34:52] <-- Lightkey has left IRC (Ping timeout: 265 seconds)
[16:40:10] <Dominus> interesting it crashes on avatar on campfire as well
[16:47:29] --> Lightkey has joined #exult
[18:53:08] <Dominus> ok, the campfire is crashing at egg.cc:1244. perhaps because the campfire animation is not driven by the field_frame_animator?
[18:59:52] <Dominus> hmm, perhaps solved
[19:02:19] <Dominus> wjp can you check my code? https://www.dropbox.com/s/cc1ffwb5ya4e3pc/egg.diff?dl=0
[19:02:42] <Dominus> the first change in egg.cc is to allow any actor to get hurt
[19:29:00] <Marzo> Dominus: are the changes to Field_object::field_effect really needed?
[19:30:00] <Dominus> without that change exult will crash when on a campfire
[19:30:25] <Dominus> could very well be if that should be fixed further up somewhere but I'm not sure
[19:30:33] <Dominus> it's where Exult crashed
[19:30:51] <Dominus> but not a full backtrace
[19:36:26] <Dominus> bt http://pastie.org/9791878
[19:47:12] <Marzo> Right, because the campfire is not animated, so it is not a valid Field_frame_animator
[19:47:41] <Marzo> Hm
[19:47:57] <Marzo> Looking at the campfire shape, it should not damage you on many frames
[19:49:25] <Marzo> Err... on one frame
[19:50:58] <Dominus> https://www.dropbox.com/s/cc1ffwb5ya4e3pc/egg.diff?dl=0
[19:51:25] <Dominus> is the current code excluding the unlit/spent campfire frame check for both games
[19:52:15] <Dominus> I'm not sure about the SI one, I can't find campfire like BG, only with stones around, not able to walk on it
[19:52:32] <Marzo> Instead of adding a check for a shape, I think adding a separate category of fields for campfires would be better
[19:53:19] <Marzo> I can work on this (and other bugs) over the next week
[19:53:20] <Dominus> I found some "Fire", though that are left behind after the banes which are unwalkable in Exult but might be hurting in the original <- need to check
[19:53:32] <Dominus> that would be great
[19:53:39] <Marzo> (today I am killing a bit of time at the moment, but I have a wedding to attend soon)
[19:53:57] <Dominus> oooh, that sounds like fun :)
[19:54:44] <Dominus> Marzo: what about me adding this code for now and you can rewrite it to be better when you have time next week?
[19:55:01] <Marzo> Oh, that SI fire is the same shape as BG's campfire
[19:55:11] <Marzo> I am willing to wager it works the same way
[19:55:17] <Dominus> ah, great
[19:55:29] <Dominus> so only to check on the frame, not the game
[19:56:00] <Marzo> It also has one more frame
[19:56:01] <Dominus> didn't think of looking at that shape in SI
[19:56:44] <Marzo> And is solid, so you probably need to make stairway of crates or bread to be able to walk on it
[19:57:01] <Marzo> (make *a* stairway...)
[19:57:23] <Dominus> ah, so only check for BG :)
[19:58:19] <Marzo> No need for it
[19:58:36] <Marzo> Since you can't walk on it on SI anyway, it makes little difference
[19:58:53] <Dominus> true
[20:00:19] <Marzo> I didn't test the campfire shape on SI; would be interesting to know if it is damaging
[20:01:48] <Dominus> so, uhm, for completeness sake, even though it is solid, should I add the shape 825 to SI's shape_info.txt as fire field?
[20:03:03] <Marzo> I suppose, yes
[20:03:19] <Marzo> And make sure to file a bug report and assign it to me so I don't lose track of it
[20:03:48] <Dominus> ok, will do, the campfire bug report is already done, will fill in the notes
[20:55:20] <Dominus> oh such fun with the original and the item creator
[20:56:34] <Dominus> curiously in the original it seems that they made a mistake. a spent campfire will hurt you (frame 0 of shape 825)
[20:56:51] <Dominus> but shape 8 of a campfire will not hurt you
[20:57:02] <Dominus> frame 8
[20:57:13] <Dominus> well it is a rather small frame, though :)
[20:57:46] <Dominus> my guess is that they somehow at one time looked with a terminal and confused 0 with 8
[21:25:46] <-- WebSpirit has left IRC (Ping timeout: 255 seconds)
[21:58:13] --> Kirben has joined #exult
[21:58:14] --- ChanServ gives channel operator status to Kirben
[21:59:14] <-- Marzo has left IRC (Ping timeout: 272 seconds)