[00:14:54] <Malignant_Manor> Dominus: what isn't working for IOS?
[00:22:35] --> GitHub has joined #exult
[00:22:35] <GitHub> [exult] malignantmanor pushed 1 new commit to master: https://git.io/vaXPH
[00:22:35] <GitHub> exult/master a0a700a Malignant Manor: * exult.*, gumps/ShortcutBar_gump.cc: don't have ShortcutBar_gump intercept...
[00:22:35] <-- GitHub has left #exult
[00:24:05] <-- Malignant_Manor has left IRC (Quit: ChatZilla 0.9.92 [Firefox 45.0.1/20160315153207])
[01:56:29] <-- Lightkey has left IRC (Ping timeout: 268 seconds)
[02:08:50] --> Lightkey has joined #exult
[02:56:30] --> DominusExult has joined #exult
[02:56:30] --- ChanServ gives channel operator status to DominusExult
[03:00:14] <-- Dominus has left IRC (Ping timeout: 248 seconds)
[03:00:15] --- DominusExult is now known as Dominus
[04:51:02] --> frob has joined #exult
[06:50:17] <Dominus> I'll make a patch later to showcase it.
[06:51:16] <Dominus> On iOS the notebook gump is all the way at the top, so it needed the rule to not handle shortcutbar events as well
[06:52:16] <Dominus> But one problem persists:
[06:52:53] <Dominus> The checkmark to close the gump is at the top over the shortcut bar.
[06:53:34] <Dominus> When you press it, the notebook closes correctly as that is still an event on the notebook.
[06:54:38] <Dominus> But when you lift the finger it triggers a mouse_up event on the shortcut bar since the notebook gump is no longer there...
[06:54:57] <Dominus> Thanks for the fixes, btw.
[06:55:26] <Dominus> I didn't realize that the cheat map also had problems ;)
[08:55:54] <-- Kirben has left IRC (Quit: System Meltdown)
[14:27:59] <Dominus> to see what I mean about the notebook gump, see the minimal patch http://pastebin.com/T6MvxcGT
[14:29:00] <Dominus> the full rearranged notbook gump code is at https://github.com/litchie/exult-ios/commit/81dfeaac506f3c49f2987ee4eb80149c3d27a13e
[14:29:24] <Dominus> and https://github.com/litchie/exult-ios/commit/2cd1ee913d6c394060646b3c0fe98ca97a62d8f9
[14:29:50] <Dominus> but the problem can be seen with the minimal patch
[14:31:41] <Dominus> perhaps one of the MOUSEBUTTONUP event breaks for the shortcutbar in exult.cc can go. will test a bit now...
[14:37:51] <Dominus> hmm, if a paperdoll is over the shortcutbar it is of course also behaving bad...
[14:38:25] <Dominus> so maybe it should be if (gumpman->gump_mode() instead of if (gumpman->modal_gump_mode()
[14:39:16] <Dominus> *BUT* the target, feed or jawbone might be good to have accessible while a paperdoll is available...
[19:54:55] <-- frob has left IRC (Read error: Connection reset by peer)
[19:55:33] --> frob has joined #exult
[21:08:50] --> Malignant_Manor has joined #exult
[21:11:43] <Malignant_Manor> Dominus: Would the notebook be alright having the check mark on the bottom?
[21:13:34] <Dominus> heya Malignant_Manor, you caught me right when I was going off :)
[21:13:43] <Dominus> yes, of course it would be allright
[21:14:03] <Dominus> In fact for now I replaced the notebook with the normal book in iOS
[21:14:13] <Dominus> which you can only close by ESC
[21:16:08] <Malignant_Manor> I would want to know other people's opinions on the aesthetics. Of course, Marzo is planning a rewrite so I'm not sure.
[21:18:28] <Dominus> the checkmark on the bottom would actually look a bit better on iOS. Since you can see the green checkmark bar is already looking a bit funny cramped in the top of the screen
[21:18:36] <Malignant_Manor> I never really looked at how the shortcutbar is handling mouse clicks.
[21:19:26] <Dominus> the problem in this case is that the Notebook gump would need to cancel a following mouse_up event
[21:19:56] <Dominus> the shortcutbar intercepts mouse events in exult.cc
[21:20:51] <Dominus> and then decides what to do in its own functions, except for the special cases you added last night
[21:22:11] <Dominus> so in case of the notebook gump it doesn't intercept it because it isn't allowed neither mouse_down or _up
[21:23:38] <Dominus> BUT when I close the notebook gump with a click, it gets instantly closed and there is a lingering mouse_up even when you release the mouse (or finger in iOS
[21:24:12] <Dominus> and that one gets intercepted by the shortcutbar since the notebook gump is no longer there preventing it...
[21:25:58] <Dominus> oh interesting, Malignant_Manor, the "hide missing item" is not being saved with the state "no"
[21:27:05] <Malignant_Manor> sigh
[21:28:18] <Malignant_Manor> The notebook only closes on mouse_up for me and only on mouse_up on the check mark like other gumps
[21:29:08] <Dominus> yeah, I know what you mean.
[21:29:40] <Dominus> I'm not right in how I describe it, still think it's something like that.
[21:29:59] <Malignant_Manor> Nuvie handles gumps/gui differently. I am not used to Exult's gui handling.
[21:35:21] <Dominus> sorry got to go...
[21:42:11] <Malignant_Manor> Man I screwed up writing the outline color in gamewin and wrote it to hide_missing_items
[21:43:26] <Malignant_Manor> I really should stop committing to Exult.
[22:43:32] --> GitHub has joined #exult
[22:43:32] <GitHub> [exult] malignantmanor pushed 1 new commit to master: https://git.io/vaMf7
[22:43:32] <GitHub> exult/master 4cec4f4 Malignant Manor: * gamewin.cc: Fix copy/paste error....
[22:43:32] <-- GitHub has left #exult
[23:22:46] --> Kirben has joined #exult
[23:22:46] --- ChanServ gives channel operator status to Kirben