#exult@irc.freenode.net logs for 21 Aug 2016 (GMT)

Archive Today Yesterday Tomorrow
Exult homepage

[01:53:11] --> DominusExult has joined #exult
[01:53:11] <-- DominusExult has left IRC (Changing host)
[01:53:11] --> DominusExult has joined #exult
[01:53:11] --- ChanServ gives channel operator status to DominusExult
[01:53:14] <-- Dominus has left IRC (Ping timeout: 264 seconds)
[01:53:37] --- DominusExult is now known as Dominus
[03:03:33] <-- Marzo has left IRC (Ping timeout: 240 seconds)
[04:09:33] --- unl_sfo is now known as unlord
[09:06:15] <-- Lightkey has left IRC (Ping timeout: 250 seconds)
[09:19:17] --> Lightkey has joined #exult
[09:38:46] <Dominus> oh, that bug report with non-walking on desert tiles... it's true... with the Windows snapshot
[09:39:03] <Dominus> on OS X it works correctly
[09:49:48] <wjp> broken in linux too
[09:49:57] <Dominus> that's odd
[09:50:28] <Dominus> oh wait, my build might not be up to date...
[09:51:06] <wjp> it does seem fairly recent
[09:51:54] <Dominus> yeah, BUT... I'm using a buildbot to build the snapshots but my local copy might not be up to date... :)
[09:52:09] <Dominus> and yes with the recent OS X snapshot it is broken as well
[09:53:01] <wjp> doing a quick bisect here
[09:53:35] <Dominus> from my snapshots it must be the commits from 9th of August
[09:54:11] <Dominus> actually pinpointed to Marzo's commit :)
[09:54:22] <Dominus> https://github.com/exult/exult/commit/8a0ac79ebece68f5edf08417bf6f6e7b3ed6fab1
[09:54:46] <Dominus> or the one before, sorry
[09:54:54] <wjp> that's a merge
[09:55:41] <Dominus> yeah, it's one of the merge
[09:56:00] <Dominus> so your bisect will be much more useful than my pinpoint
[09:56:06] <wjp> I don't think it's the merge
[09:57:22] <wjp> 79c4f593a3b4b4b4c038cd97c16fc35b722c3217
[09:57:38] <wjp> sadly a mix of several things in that one commit
[10:05:09] <Dominus> it's probably just in /shapes
[10:05:13] <Dominus> *just* :)
[10:19:15] <Dominus> perhaps messing up reading the shape_info.txt and making desert tiles into moutnains or so :)
[10:23:52] * wjp wonders why the build system is pointlessly rebuilding stuff
[10:29:54] <wjp> what _is_ this thing doing??
[10:30:53] <Dominus> ?
[10:33:25] <wjp> the build system seems to be hopelessly confused about what needs rebuilding when
[11:47:25] --> Marzo has joined #exult
[12:31:46] <wjp> Avatar_usecode_parser is at least broken, but that doesn't seem relevant for this bug
[12:31:56] <wjp> (missing 0 offset argument to ReadInt)
[14:41:07] <wjp> the direct cause seems to be that the is_solid flag is true in more places
[14:41:16] <wjp> not quite sure what the relationship with this commit is
[14:46:24] <wjp> (also not 100% sure it's not checking the _wrong_ tiles or something)
[15:29:14] <wjp> aha
[15:41:38] <wjp> right
[15:41:48] <wjp> Shapeinfo_entry_parser::Read_Str is broken
[15:42:06] <wjp> which breaks Multiracial_parser, which copies bogus shape data to random places
[15:43:49] <wjp> (and Avatar_usecode_parser is independently broken in another way)
[15:50:11] <wjp> maybe this: http://www.usecode.org/exult/exult_parser.diff
[16:04:22] <Dominus> wjp, that makes the desert tile walk-on-able again
[19:03:48] <Marzo> <wjp> the build system seems to be hopelessly confused about what needs rebuilding when
[19:04:17] <Marzo> I think that the issue is all the dependencies we have on the flx data, and the dependency they have on flex
[19:06:40] <Marzo> And thanks for looking into that bug
[19:24:47] <-- Marzo has left IRC (Disconnected by services)
[19:24:51] --> monpntcuianfdvrb has joined #exult
[19:24:53] --- monpntcuianfdvrb is now known as ciuhhngzpnwnzgeq
[19:24:57] --- ciuhhngzpnwnzgeq is now known as Marzo
[19:43:57] <wjp> Marzo: the Avatar_usecode_parser bug is potentially ancient. Has that ever worked?
[19:44:23] <-- Marzo has left IRC (Ping timeout: 244 seconds)
[19:44:42] <wjp> ...or not :-)
[20:30:19] <Dominus> So wjp, do you think this fix is ready for git or wait until Marzo gives his input?
[20:38:58] <wjp> The Read_Str part is probably fine
[20:48:55] <Dominus> Will you commit it?
[20:57:04] <wjp> ah, might as well
[20:58:01] <wjp> done
[20:58:13] --> GitHub has joined #exult
[20:58:13] <GitHub> [exult] wjp pushed 1 new commit to master: https://git.io/v6DEh
[20:58:13] <GitHub> exult/master 0a878e3 Willem Jan Palenstijn: Fix text data file reading regression...
[20:58:13] <-- GitHub has left #exult
[21:06:31] <Dominus> Thanks a lot
[21:42:50] --> Marzo has joined #exult
[21:43:17] <Marzo> ... or not