#exult@irc.freenode.net logs for 21 Jun 2016 (GMT)

Archive Today Yesterday Tomorrow
Exult homepage


[01:08:23] <-- frob has left IRC (Remote host closed the connection)
[01:14:17] <-- Lightkey has left IRC (Ping timeout: 258 seconds)
[01:15:02] --> Lightkey has joined #exult
[01:23:50] --> GitHub has joined #exult
[01:23:50] <GitHub> [exult] anyzio opened pull request #3: Fixed an issue with scheduling a chair action… (master...master) https://git.io/vorFA
[01:23:50] <-- GitHub has left #exult
[01:37:11] --> DominusExult has joined #exult
[01:37:11] --- ChanServ gives channel operator status to DominusExult
[01:41:33] <-- Dominus has left IRC (Ping timeout: 276 seconds)
[01:41:34] --- DominusExult is now known as Dominus
[02:40:46] <-- Rottingbeef has left IRC ()
[02:49:10] <-- ParuNexus has left IRC (Remote host closed the connection)
[02:49:28] --> ParuNexus has joined #exult
[03:31:59] --> frob has joined #exult
[04:10:02] <-- frob has left IRC (Remote host closed the connection)
[04:44:44] --> frob has joined #exult
[05:47:36] <-- frob has left IRC (Remote host closed the connection)
[07:07:19] --> ttarrant has joined #exult
[07:42:51] <Dominus> Marzo, could you glance at that pull request?
[07:59:38] --> frob has joined #exult
[08:03:48] <-- frob has left IRC (Ping timeout: 240 seconds)
[09:25:27] <-- Lightkey has left IRC (Ping timeout: 272 seconds)
[09:37:58] --> Lightkey has joined #exult
[10:59:59] --> frob has joined #exult
[11:04:49] <-- frob has left IRC (Ping timeout: 252 seconds)
[11:27:22] --> GitHub has joined #exult
[11:27:22] <GitHub> [exult] marzojr pushed 2 new commits to master: https://git.io/voo6T
[11:27:22] <GitHub> exult/master ea03507 h3x: Fixed an issue with scheduling a chair action where the size of the array passed to find_closest was incorrectly calculated (causing issues with guard that schedules fight in Monitor). Updated finding desk seats to match. Corrected a comparison in ucfun.cc that was reading beyond the end of some strings.
[11:27:22] <GitHub> exult/master d763e6f Marzo Sette Torres Junior: Merge pull request #3 from anyzio/master...
[11:27:23] <-- GitHub has left #exult
[11:28:43] --> Rottingbeef has joined #exult
[12:02:47] --> DominusExult has joined #exult
[12:02:47] --- ChanServ gives channel operator status to DominusExult
[12:06:59] <-- Dominus has left IRC (Ping timeout: 252 seconds)
[12:06:59] --- DominusExult is now known as Dominus
[12:19:41] --- _nyz is now known as anyzio
[13:27:12] --> frob has joined #exult
[13:31:19] <-- frob has left IRC (Ping timeout: 244 seconds)
[13:52:45] <Dominus> Welcome anyzio
[13:53:06] <Dominus> Thanks for your code! What brings you to Exult? ;)
[14:44:30] <anyzio> Hey, thanks. I discovered Ultima 7 when I was about 15, played all the time, then when DOS machines went away, forgot about it. Discovered Exult and over the years tried it out. It was playable but once in a while I would come across a bug that would keep me from progressing. Im a software dev but it never occured to me that I could help out. Github makes it easy to do so and I hope to contribute more.
[14:47:57] <anyzio> I have a use-after-free I am tracking down currently. Anything else I can get from the bug tracker that I can repro Ill be glad to work at.
[15:05:57] <Dominus> That's great! We can use all the help we can get ;)
[15:06:44] <Dominus> I have to confess I didn't think using git would change anything but it attracts help after all
[15:06:49] <Dominus> Mea culpa
[15:08:29] <anyzio> Is the current bug tracker still the one on sourceforge (https://sourceforge.net/p/exult/bugs/)?
[15:10:50] <Dominus> Yes, it is better than guthubs issue tracker (but lacks the github integration of course)
[15:11:09] <Dominus> And we have too many bugs in there with history ;)
[15:11:24] <Dominus> Got to go. See you later
[15:21:51] --> frob has joined #exult
[15:21:56] <-- frob has left IRC (Remote host closed the connection)
[15:22:02] --> frob has joined #exult
[16:07:13] <-- Darrenor64 has left IRC (Remote host closed the connection)
[16:57:58] --> Darrenor64 has joined #exult
[19:25:53] --> frob_bizaro has joined #exult
[19:28:25] <-- frob has left IRC (Ping timeout: 264 seconds)
[20:13:51] <Dominus> Marzo in addition to the mods and game type problem with Exult Studio, I need your help in making autonotes patchable :)
[21:01:22] <-- ttarrant has left IRC (Ping timeout: 244 seconds)
[22:46:45] <anyzio> I was looking into the UAF I encountered the other day and also saw this bug listed: "#1924 Crash in Pickup_actor_action::handle_event". I am curious if they are related. I am still very new to this codebase and its a lot to get used to. I have a feeling these may be related, but have not been able to reproduce the crash in 1924 yet. I do have a question about the call to removed->flush() in gamewind.cc:3035. THe comment above it states "Could cause problems" an
[22:48:14] <anyzio> questionn being: what could the problems the forced call to removed->flush() be exactly? possibly these UAFs?
[22:51:34] <Dominus> it's ages old code... don't know if anyone remembers... :)
[22:52:11] <Dominus> last chnage there was in 08.02.2004 AFAICT
[22:59:22] <anyzio> I may just go after lower hagning fruit and keep an eye out for these particular bugs while playing
[22:59:47] <Dominus> probably best, or... madness :)
[23:54:42] <-- frob_bizaro has left IRC (Ping timeout: 276 seconds)