#exult@irc.freenode.net logs for 22 Nov 2016 (GMT)

Archive Today Yesterday Tomorrow
Exult homepage


[01:04:43] <Marzo> Exult has been approved in Coverity Scan
[01:05:05] <Marzo> I will be checking it out, then will invite you folks over
[01:28:24] <Marzo> Hm
[01:28:45] <Marzo> Both Coverity and Clang make the same mistake with Effects_manager::remove_all_effects
[01:29:09] <Marzo> They both think there are use-after-free when clearing the lists
[01:29:46] <Marzo> I will find a better way to do that; it is likely that compilers may also be confused by it and generate wrong code
[02:13:05] <-- Dominus has left IRC (Ping timeout: 240 seconds)
[02:14:06] --> Dominus has joined #exult
[02:14:06] <-- Dominus has left IRC (Changing host)
[02:14:06] --> Dominus has joined #exult
[02:14:06] --- ChanServ gives channel operator status to Dominus
[02:16:16] <Marzo> Dominus: https://trello.com/c/Ce31YQFb
[03:38:11] <Marzo> Looking at the Coverity log has been illuminating
[03:38:20] <Marzo> Some parts of Exult work by luck
[03:40:09] <Marzo> But a lot of it is noise
[03:56:34] --> Malignant_Manor has joined #exult
[03:57:25] <Malignant_Manor> Marzo: 460 is less than I figured it would be. Of course, there has been a lot of work recently on code fixes.
[04:02:57] <Malignant_Manor> Here is a direct link to the Coverity page. https://scan.coverity.com/projects/exult-exult
[04:05:01] <Malignant_Manor> Unfortunately, it seems to require an account to view the specifics. It does show the type and number of errors and other data. 1.30 defects per 1,000 lines of code.
[04:09:14] <-- Malignant_Manor has left IRC (Quit: ChatZilla 0.9.93 [Firefox 50.0/20161104212021])
[06:52:29] <Dominus> Marzo, we should throw CE out before fixing anything related to it
[06:53:10] <Dominus> I'm sorry that the shortcut bar is that horrible
[06:53:33] <Dominus> And the iOS keyboard can go too
[06:53:58] <Dominus> The iOS port on github does not use it
[06:55:10] <Dominus> we use the native iOS keyboard for text input and have the shortcut bar AND cheat screen for handling anything we need
[08:34:52] <-- Lightkey has left IRC (Ping timeout: 258 seconds)
[08:47:53] --> Lightkey has joined #exult
[10:11:58] <Marzo> Dominus: would it be fair to remove all iOS stuff from main Exult, and in the future we sync up with the iOS port?
[10:27:03] <Dominus> Marzo: that would actually be a good solution.
[10:27:57] <Dominus> The iOS fork does use some of the iphone gump stuff but otoh it's too far away from the initial ifdef iphoneos stuff
[10:28:21] <Dominus> Not to mention the hacky nature of the iOS fork ;)
[10:40:38] <Marzo> Dominus, wjp, Malignant_Manor (when you read the logs): Coverity Scan requires an invite to view the errors. I plan on inviting anyone that wants to be invited; would the 3 of you want that?
[10:42:52] <Dominus> Yes, please
[10:43:10] <Marzo> Your usual e-mail?
[10:43:23] <Dominus> When you gut ce and iOS, please make it seperate commits ;)
[10:43:29] <Dominus> Yes usual pne
[10:44:44] <Dominus> Or I probably have time to rip out both this evening
[10:45:27] <Marzo> I am doing some cleaning on the code, so you can leave that to me
[10:45:40] <Marzo> Going through the Coverity report and fixing stuff
[10:46:27] <Marzo> I already have 11 commits in the queue, and probably will do a lot more
[10:46:37] <Marzo> Invite sent, by the way
[10:46:44] <Marzo> I also sent a message to the mailing list
[10:46:51] <Dominus> What is the ratio of serious vs noise?
[10:47:19] <Marzo> I still have to go through it all
[10:47:28] <Marzo> But even the noise may be useful
[10:47:30] <Dominus> And can you tag git? At least the CE should be tagged before killing it, IMO
[10:47:44] <Marzo> There is some code that trips up both Coverity and Clang in effects manager
[10:48:11] <Marzo> There is a good chance it might trip a compiler at some point too, so it may be wise to "fix" it anyway
[10:48:36] <Marzo> Sure, I will add a tag for CE
[10:49:20] <Marzo> https://trello.com/c/wh1J2iCj
[10:50:07] <Marzo> And after all this, there is still wjp's old usecode debugger code to clean up and commit
[11:47:42] <wjp> Marzo: yes, I would like coverity access
[12:12:03] <Marzo> Invite sent
[12:45:47] --> GitHub has joined #exult
[12:45:47] <GitHub> [exult] marzojr pushed 13 new commits to master: https://git.io/vXpQM
[12:45:47] <GitHub> exult/master cf78a13 Marzo Sette Torres Junior: Allowing independent configurable optimization and debug levels....
[12:45:47] <GitHub> exult/master 4e18578 Marzo Sette Torres Junior: Disabling -Wmaybe-uninitialized warning with low optimization levels...
[12:45:47] <GitHub> exult/master 45bc163 Marzo Sette Torres Junior: Allowing specification of (experimental, buggy, long disabled) usecode...
[12:45:47] <-- GitHub has left #exult
[12:50:08] <Marzo> Holy cow, timidity code is bad
[13:00:58] <Dominus> Hmm, Marzo, I'll need to test some shortcutbar stuff now. I think some of what you just killed was because you could drag objects onto the bar and it would vanish from the world...
[13:01:33] <Dominus> But I'll need to test... ;)
[13:17:46] <Marzo> Oh?
[13:18:13] <Marzo> I can't see how it would make a difference
[13:18:23] <Marzo> The code is basically equivalent to what would happen
[13:18:29] <Marzo> In the old version
[13:22:40] <-- Rottingbeef has left IRC ()
[13:30:14] --> Rottingbeef has joined #exult
[14:38:44] <Dominus> Marzo, the shortcut bar doesn't work now anymore
[14:39:13] <Dominus> it will display and icons will change but no event (clicking on it) will register
[14:47:36] <Marzo> Odd, I tested locally and it worked
[14:47:50] <Marzo> Maybe it has to do with SDL2?
[14:48:22] <Marzo> Oh, I know what went wrong
[14:48:36] <Marzo> Forgot a ./ kn the Ecult command line
[14:48:54] <Marzo> *in the Exult
[14:49:12] <Marzo> Command history is useful :-)
[14:49:42] <Marzo> Will fix later today
[16:43:02] * Dominus wonders what other errors slipped by Marzo as he didn't use the fresh compiled Exult binary ;)
[16:43:32] <Dominus> But seriously, you are a coding machine atm! Impressive
[17:29:22] <-- Rottingbeef has left IRC ()
[17:33:01] --> Rottingbeef has joined #exult
[20:21:08] <Marzo> Dominus: trying to beat wjp ini terms of commits :-p
[20:21:12] <Marzo> *in
[20:21:27] <Marzo> (173 to go)
[20:21:39] <Marzo> *178
[20:23:04] <Marzo> Jeff is nigh unbeatable, having more commits than wjp, me and colourless combined
[20:23:35] <Dominus> you can do it!!!!
[20:24:01] <Dominus> oh, I just noticed that I beat Fingolfin the other day :)
[20:24:33] <Dominus> and only another 30 to beat Colourless
[20:24:36] <Marzo> The list hows you tied with 328 commits
[20:24:49] <Marzo> At least in main Exult repo
[20:25:00] <Dominus> yes but at a tie the ++ and -- count! :)
[20:26:58] <Marzo> I am getting to Jeff in terms of ++, and am the king of -- :-p
[20:32:14] <Dominus> yes :)
[20:36:10] <Dominus> When you rip out CE/PocketPc and iOS you have killed most of Lanicas code except for SDL2 porting...