#exult@irc.freenode.net logs for 26 Jan 2013 (GMT)

Archive Today Yesterday Tomorrow
Exult homepage


[00:00:00] <-- Dominus has left IRC (Read error: Connection reset by peer)
[00:01:37] --> Dominus has joined #exult
[00:01:37] --- ChanServ gives channel operator status to Dominus
[00:13:39] <-- SHODAN has left IRC (Remote host closed the connection)
[00:13:47] --> SHODAN has joined #exult
[00:54:53] <-- Dominus has left IRC (Read error: Connection reset by peer)
[00:55:24] --> Dominus has joined #exult
[00:55:25] --- ChanServ gives channel operator status to Dominus
[01:16:56] <Malignant_Manor> Marzo: are there not supposed to be any warnings?
[01:17:38] <Marzo> Ideally, no; but since I am only compiling on Linux, OS-specific code may have warnings I haven't touched
[01:18:29] <Malignant_Manor> I forgot that the makefile ignores depreciated.
[01:18:52] <Malignant_Manor> make -f makefile.mingw debug -Wall -Wextra -Wcast-qual -Wwrite-strings -Wconv
[01:18:53] <Malignant_Manor> ersion -Wredundant-decls -Winline -Wdisabled-optimization -Wctor-dtor-privacy -
[01:18:55] <Malignant_Manor> Wnon-virtual-dtor -Wold-style-cast -Woverloaded-virtual -Wpedantic -Wpointer-ar
[01:18:56] <Malignant_Manor> ith -Wno-unused-parameter -Wno-unused-but-set-variable -Wno-conversion -Wno-inl
[01:18:58] <Malignant_Manor> ine -Wno-strict-aliasing -Wno-long-long -s
[01:19:28] <Malignant_Manor> didn't show any. Sorry about how that pasted.
[01:19:48] <Malignant_Manor> -Wno-deprecated is also there from the makefile
[01:20:45] <Malignant_Manor> You might want Kirben to check 64 bit windows.
[01:21:00] <Marzo> I don't think parameters passed to make like that end up on CXXFLAGS
[01:21:23] <Malignant_Manor> hmm
[01:21:31] <Malignant_Manor> That would be annoying
[01:21:48] <Marzo> Try editing them into the makefile
[01:22:16] <Marzo> And don't bother with CFLAGS, I don't care about the warnings from the C programs
[01:29:29] <Malignant_Manor> I'm trying now. It's weird I got error: unrecognized command line option '-Wpedantic'. -pedantic works though.
[01:32:56] <-- Marzo has left IRC (Ping timeout: 245 seconds)
[01:49:39] <Kirben> I'm still only running a 32bit versions of Windows.
[02:54:26] <-- Malignant_Manor has left IRC (Quit: ChatZilla 0.9.89 [Firefox 18.0.1/20130116073211])
[03:51:40] <-- Dominus has left IRC (Read error: Connection reset by peer)
[03:52:11] --> Dominus has joined #exult
[03:52:12] --- ChanServ gives channel operator status to Dominus
[05:34:57] <-- Dominus has left IRC (Read error: Connection reset by peer)
[05:35:28] --> Dominus has joined #exult
[05:35:28] --- ChanServ gives channel operator status to Dominus
[08:03:03] <Dominus> Marzo: https://dl.dropbox.com/u/7737184/compilelog.txt all enabled except mods, gimp plugin and that gnome browser plugin :)
[08:03:24] <Dominus> included gcc --version at the top
[09:11:12] <Dominus> I made one for clang as well, as that is often more informative https://dl.dropbox.com/u/7737184/compileclang.txt
[09:11:24] <Dominus> probably look at the clang one first
[09:34:52] <-- Kirben has left IRC ()
[12:38:00] --> Marzo has joined #exult
[13:01:09] <Dominus> Marzo: https://dl.dropbox.com/u/7737184/compileclang.txt
[13:01:21] <Dominus> and https://dl.dropbox.com/u/7737184/compilelog.txt
[13:01:26] <Marzo> Thanks
[13:01:31] <Dominus> clang and llvmgcc
[13:02:01] <Dominus> clang one is probably more helpful as the warnings are more detailed and pointing at solutions
[13:37:06] <-- sh4rm4 has left IRC (Ping timeout: 276 seconds)
[13:40:09] <Marzo> Hm. Deprecated functions being used in CoreAudio Midi Driver
[15:02:05] --> sh4rm4 has joined #exult
[16:14:40] <Dominus> Marzo: I'll look into this coreaudio thing. I'm pretty sure I saw it elsewhere and whatto do. might be that this needs to differentiate between intel and ppc os x
[16:22:47] <Dominus> I normally don't compile against 10.8 SDK hence I haven't seen that deprecated warning before (and am compiling without warnings mostly)
[16:28:30] --> Malignant_Manor has joined #exult
[16:29:19] <Malignant_Manor> Marzo: I have the warnings but they are from r7339.
[16:53:13] <Marzo> Malignant_Manor: no problem
[16:54:19] <Malignant_Manor> Tools didn't completely build.
[16:56:12] <Marzo> Weird that Kirben didn't mention it
[16:56:59] <Malignant_Manor> Well, this is a linking issue I haven't messed with. mingw32/bin/ld.exe: cannot find -lSDL
[17:12:05] <Marzo> Weird is, other programs should have been failing to link if it can't find -lSDL
[17:12:36] <Marzo> Oh, wait
[17:12:52] <Marzo> No, nevermind
[17:14:20] <Malignant_Manor> It's for libsmooth_randomize.dll
[17:15:19] <Marzo> I noticed it
[18:35:54] * Dominus thinks ScummVM has the Coreaudio thing fixed
[18:36:09] * Dominus needs to checkout ScummVM git now
[18:36:19] * Dominus feels abandoned by Fingolfin :(
[18:38:23] <Malignant_Manor> Fingolfin doesn't like the Exult code. He says it is horrible and feels the need to rewrite it every time he looks at it.
[18:39:03] <Dominus> yeah, I remember that conversation
[18:39:43] * Dominus is still checking out scummvm git....
[18:41:52] <wjp> only 1.4M lines of code :-)
[18:42:17] <Dominus> hmm, marzo, interesting stuff added to scummvms fluidsynth driver...
[18:42:42] <Dominus> wjp, if I'd known how to just check out the code without every whatever git downloads... :)
[18:43:03] <Malignant_Manor> Keep that up Dominus and we will never have a release.
[18:43:07] <Dominus> (there is probably a code snapshot, right? :)
[18:43:32] <Dominus> Malignant_Manor: Marzo did steer towards fluidsynth without me anyway :)
[18:43:58] <Dominus> and the state exult is in now, we can release any day (when I have played through the game sometime)
[18:44:07] <Dominus> game*S*
[18:45:47] <Malignant_Manor> I would hope after more than 8 and a half years, there would be time to release something.
[18:46:05] <wjp> Dominus: what do you mean? Do you re-clone every time instead of just pulling/updating?
[18:46:35] <Dominus> wjp, I didn't have scummvm anymore, so I had to do the initial cloning right now
[18:46:37] <Malignant_Manor> Maybe we can release by the 9th anniversary of the last one.
[18:46:57] <Dominus> Malignant_Manor: if everyone else agrees you can be release manager
[18:47:16] <Malignant_Manor> No, that is a job for Dominus.
[18:47:50] <Malignant_Manor> Actually it is less than 8 and a half years. I was seeing 1.1.10rc2.
[18:48:23] <Marzo> (04:38:23 PM) Malignant_Manor: Fingolfin doesn't like the Exult code. He says it is horrible and feels the need to rewrite it every time he looks at it.
[18:48:31] <Marzo> That is a feeling I constantly get also
[18:48:54] <Malignant_Manor> I hate all the mixed indenting.
[18:49:23] <wjp> we can just run astyle over the entire codebase
[18:49:42] <wjp> (but _please_ don't mix such a commit with functional changes ;-) )
[18:49:59] <Malignant_Manor> I also don't understand why functions without parameters get two extra lines for the parenthesis.
[18:50:16] <wjp> just run astyle, really
[18:50:16] <Malignant_Manor> I can see the point when they have parameters that can have comments added.
[18:51:21] <Dominus> whoa, scummvm and exult's coreaudio have drifted fare away from each other
[18:51:58] <Dominus> I'm not sure I will be able to adapt
[18:53:15] <Marzo> (04:49:23 PM) wjp: we can just run astyle over the entire codebase
[18:53:20] <Marzo> I was thinking of doing that
[18:53:53] <Marzo> I just don't know what coding style would be best to "enforce"
[18:54:20] <wjp> scummvm's is fairly sane
[18:54:24] <wjp> http://wiki.scummvm.org/index.php/Code_Formatting_Conventions#Automatically_converting_code_to_our_conventions
[18:54:55] <wjp> but I think at this point you have the largest say
[18:55:00] <Malignant_Manor> Go ahead. We already made a bunch of changes to files that mess up diff with previous and last change dates.
[18:56:55] <Marzo> I disagree about ScummVM's choice for empty loop bodies; I think {} is better
[18:56:55] <wjp> the diff is 265k lines :-)
[18:57:07] <Marzo> The diff for astyle?
[18:57:22] <wjp> yes, I just ran astyle with scummvm's config on exult
[18:57:32] <Marzo> Wow
[18:57:57] <Marzo> If you want to commit, go ahead -- having *any* consistent style is better than none
[18:58:15] <wjp> Marzo: those conventions don't say anything about {} vs ;
[18:58:21] <wjp> just that if you use ;, prefix it with a space
[18:58:29] <Malignant_Manor> It might be best to wait until Marzo is done with compiler warnings.
[18:58:38] <Marzo> I can continue after
[18:58:40] <Dominus> wjp, do you have contact with fingolfin or do you see how he is these days? do you think I'll have any success asking him to look over Exult's coreaudio to apply the scummvm changes?
[18:58:55] <Malignant_Manor> I can always redo the output files of my warnings.
[18:58:58] <Marzo> Hm. I actually have a few uncommitted changes
[18:59:13] <wjp> Dominus: I'm sure he wouldn't mind you asking
[18:59:29] <Dominus> I'll give it a try then :)
[18:59:36] <wjp> I last saw him in Ghent last summer
[19:00:22] <Dominus> I just had my last encounters concerning Exult and his clash (two years ago) with ScummVM in mind when I asked :)
[19:01:26] <Dominus> wow, authors file of ScummVM is very detailed and looooooooong :)
[19:01:52] <Malignant_Manor> I wonder how badly the style changes will screw up the Exult rotate patch?
[19:02:07] <Marzo> Probably will drive the author to madness
[19:02:18] <Marzo> Until he applies astyle with the same settings to his code
[19:03:06] <Malignant_Manor> Is it workable enough that we can include it experimentally?
[19:03:31] <wjp> I really don't like such major things in core exult
[19:03:32] <Marzo> Maybe asking for patch to include preprocessor guards
[19:03:44] * Dominus was about to write an english email to Fingolfin... then I realized he is German and now I'm struggling to find the right German words :)
[19:03:45] <Marzo> But wjp has a point
[19:04:26] <wjp> it has a nice novelty value, but does anyone really want to maintain it?
[19:04:56] <wjp> (just playing the cynic here a bit...)
[19:05:07] <Malignant_Manor> It really depends on how many changes it requires. It probably needs a lot to function properly for all scalers.
[19:06:16] <Dominus> I would like it but it would also need a lot of ifs right now so it doesn't crash whenever someone changes stuff like fill mode or scaler
[19:06:18] <Marzo> And a load of work to decode mouse positions (which he says he is still having trouble with)
[19:06:29] <Malignant_Manor> If it works properly, it would be a nice edition. There isn't a whole lot of Exult development.
[19:06:53] <wjp> but that's why I'm worried it'll end up unmaintained and broken
[19:06:53] <Dominus> very experimental addon... maybe...
[19:07:08] <Malignant_Manor> It should probably be kept out until it at least works properly.
[19:07:34] <Malignant_Manor> That may never happen anyway.
[19:08:41] <Dominus> but then remember how much fun we had with smooth scrolling - breaking things left and right and never fully working....
[19:08:43] <Malignant_Manor> I really doubt it will be before release.
[19:08:57] <Dominus> depends on how long we need for that :)
[19:09:05] <Malignant_Manor> Smoth scrolling has always been awful.
[19:10:26] <Malignant_Manor> I guess after Marzo commits his working copy, wjp could run astyle again and commit.
[19:15:15] <Marzo> I am ready to commit; wjp, how would you prefer to handle this?
[19:15:27] <wjp> just commit
[19:16:25] <Marzo> Done
[19:16:54] <wjp> which files should be excluded from astyle?
[19:17:18] <Marzo> I can't think of any beforehand
[19:17:42] <Marzo> Except maybe those generated by Bison and Flex
[19:18:04] <Malignant_Manor> It only messes with c/c++ files right and not build files?
[19:18:07] <wjp> do we still share file 1:1 with pentagram?
[19:18:10] <wjp> s/file/files/
[19:18:33] <Dominus> no
[19:18:38] <Marzo> There are several similar ones, but unless someone has been keeping them in synch, they have likely drifted appart
[19:18:50] <Marzo> Probably audio code
[19:18:50] <Dominus> drifted apart
[19:19:00] <Marzo> Hm
[19:19:07] <Dominus> that especially, a lot has been fixed and not backported
[19:19:09] <Marzo> Does Pentagram have coding styles?
[19:19:40] <Marzo> Dominus: a lot that has been fixed in Pentagram and not backported to Exult, the other way around, or both?
[19:19:54] <Dominus> most fixes in Exult
[19:19:57] <wjp> bbl, dinner
[19:20:29] <Malignant_Manor> Maybe just exclude the audio folder then.
[19:21:10] <Dominus> because they have drifted apart, no need to exclude it IMO
[19:22:10] <Marzo> audio/midi in Pentagram hasn't changed in 3 years appart from a few changes by Dominus
[19:22:22] <Malignant_Manor> I'm slightly worried astyle will mangle some stuff. (I will hope for the best though.)
[19:23:00] <Marzo> Highly unlikely
[19:23:03] <Malignant_Manor> I don't know how it will handle comments.
[19:23:40] <Dominus> I'm sure astyle will know how to handle those
[19:23:45] <Marzo> The audio folder has more recent changes, which I can go over and see if they are broken in Exult
[19:24:16] <Malignant_Manor> Hopefully if (1) // test becomes if (1) { // test
[19:24:31] <Marzo> That is well handled by astyle
[19:30:42] <-- sh4rm4 has left IRC (Ping timeout: 276 seconds)
[19:31:51] <Marzo> Time range to watch for differences in Pentagram and Exult on the audio folder is 2 years, 9 months -- this is the time when I synched Colourless' no-SDL branch into the trunk
[19:33:21] <Dominus> I don't think it has drifted much apart, since it's mostly fixes that got into Exult and not into Pentagram. After all Pentagram did not have SDL_mixer
[19:33:51] <Marzo> So far, I found only one commit by wjp
[19:38:00] <Marzo> Yep, it is just that one
[19:38:05] <Marzo> http://pentagram.svn.sourceforge.net/viewvc/pentagram/pentagram/trunk/audio/AudioChannel.cpp?r1=1949&r2=2539
[19:38:48] <Malignant_Manor> Ah, that was for speech clipping
[19:45:33] <Marzo> (It is funny that wjp mentioned astyle today -- I had a couple of tabs from their docs that I had been studying, and thinking of using in Exult, since yesterday)
[19:45:52] <Dominus> great minds think alike :)
[19:52:19] <Dominus> god, I can't wrap my mind around coreaudio differences between scummvm and exult
[19:52:51] <Marzo> I can try to take a look, but I will need a guinea pig to test the code I write
[19:54:29] <Dominus> well, I'm here and have an OS X PPC and Intel machine. But don't bother yet, I have written to Fingolfin and begged for his help already
[19:55:14] <wjp> what do you want to do with function argument formatting?
[19:56:08] <wjp> this set of astyle options keeps them relatively unchanged
[19:56:19] <wjp> (except for horizontal whitespace)
[19:56:48] <Marzo> They are relatively inconsistent in Exult, so standardizing them a bit would be nice
[19:57:09] <Marzo> What options do we have?
[19:58:19] <wjp> looks like most changes there would have to be pre-/postprocessing
[19:58:33] <Marzo> Yeah
[19:58:57] <wjp> It stays
[19:58:59] <wjp> function
[19:59:00] <wjp> (
[19:59:11] <wjp> int arg1 // comment
[19:59:13] <wjp> ) {
[19:59:17] <wjp> now
[19:59:34] <wjp> I think I can relatively easily attach the top (
[20:00:36] <Marzo> Awk?
[20:00:58] <wjp> probably sed
[20:02:13] <Marzo> Attaching the top parenthesis has the advantage of aesthetic consistency
[20:02:48] <Marzo> I don't think there are cases of comments after the function name and before the parenthesis
[20:02:59] <Marzo> But it would be good to check
[20:04:59] <Marzo> brb
[20:12:47] <Marzo> Back
[20:18:46] <Dominus> hmm, if I go back through all the diffs of previous commits to scummvm coreaudio, I'll probably be able to adapt it myself... something for later, I guess...
[20:34:13] --> sh4rm4 has joined #exult
[20:37:29] <-- Malignant_Manor has left IRC (Quit: ChatZilla 0.9.89 [Firefox 18.0.1/20130116073211])
[20:37:33] <wjp> ok, http://www.usecode.org/misc/actorio.cc
[20:37:39] <wjp> any opinions?
[20:48:38] <Marzo> Looks good
[20:49:13] <Marzo> But maybe also break up one line ifs and elses?
[20:49:46] <Marzo> (I don't know, just throwing it out there)
[20:50:03] <wjp> example?
[20:50:25] <Marzo> Compare lines 134-141 to lines 145-146
[20:51:04] <Marzo> Not breaking up leads to less vertical space, but forces you to scan to find the code for the if clause
[20:53:37] <wjp> yes, I don't like these either
[20:53:43] <wjp> let's see how that works with astyle
[20:53:58] <wjp> there's an explicit option _not_ to break those, but I don't see the opposite
[20:54:32] <Marzo> Yeah, I think I was misremembering it
[20:54:49] <Marzo> So nevermind
[21:03:01] <wjp> but there are hundreds and hundreds of those according to a quick grep
[21:03:18] <wjp> anyway, commit this and maybe tweak later?
[21:04:33] <Marzo> Yeah
[21:04:51] <Marzo> Anyway, it was just an idea
[21:05:25] <Marzo> And now we will have the biggest commit since we switched from CVS to SVN
[21:05:33] <wjp> here goes...
[21:05:54] <Marzo> Lets see how long it takes
[21:06:32] <wjp> it's going at about a second per file
[21:06:40] <wjp> so don't hold your breath :-)
[21:07:03] <Marzo> The 'sending data' part will be much longer
[21:07:36] <wjp> this is gitsvn, so its output is different
[21:07:41] <wjp> not sure how tha relates
[21:07:48] <wjp> s/tha/that/
[21:08:07] <Marzo> Ah
[21:17:15] <wjp> that should be it
[21:24:52] <Marzo> Thanks
[21:25:27] <Marzo> Now to apply this fix of yours into Exult ( http://pentagram.svn.sourceforge.net/viewvc/pentagram/pentagram/trunk/audio/AudioChannel.cpp?r1=1949&r2=2539 )
[21:25:46] <Marzo> And see if it is needed
[21:26:27] <wjp> ah, that one
[21:34:23] <Marzo> wjp: do you mind writing a changelog entry with the options you used for astyle?
[21:34:43] <Marzo> Just to keep them documented somewhere until Dominus finds a better place for them
[21:35:00] <Marzo> Ah, wait -- you did that already
[22:53:05] --> Malignant_Manor has joined #exult
[22:53:51] <Malignant_Manor> Marzo: I have updated warning outputs.
[22:54:02] <Marzo> Send them in
[22:58:05] <Dominus> wjp, Malignant_Manor, Marzo: where to document coding style?
[22:58:30] <Marzo> That is the question :-)
[22:58:58] <Malignant_Manor> I don't know. We are kind of using ScummVM's now.
[22:59:20] <Marzo> I suggest also documenting the astyle options wjp posted on the changelog
[22:59:25] <Dominus> yeah :)
[22:59:57] <Marzo> We could add a page for it in the site, or add a section for it in the documentation
[23:00:49] <Dominus> or add a README.code
[23:00:51] <Malignant_Manor> It could be titled, "Remind Marzo what coding style to use."
[23:01:02] <Dominus> or something like that
[23:01:18] <Marzo> I usually just used whatever style was used in surroundings
[23:01:27] <Malignant_Manor> Yeah, so do I.
[23:01:30] <Dominus> It'd be better written by someone who *knows* what he is writing about :)
[23:01:34] <Marzo> Even Google's style docs suggest so
[23:01:37] <Malignant_Manor> Now it is consistent.
[23:02:00] <Marzo> You could lift a lot of it from the ScummVM style page :-p
[23:02:39] <Malignant_Manor> Noiw, you just need to find more people who will write code so that the documentation could be of more use.
[23:02:58] <Dominus> har har har har
[23:05:08] <Dominus> anyway, I'm off to bed, tomorrow I'll taggle the coreaudio stuff, working my way forward from Scummvm svn-id: r19835 (7years ago)
[23:05:23] <Dominus> back then our coreaudio driver was pretty much the same :)
[23:36:45] <-- Malignant_Manor has left IRC (Quit: ChatZilla 0.9.89 [Firefox 18.0.1/20130116073211])