#exult@irc.freenode.net logs for 27 Apr 2017 (GMT)

Archive Today Yesterday Tomorrow
Exult homepage


[01:23:34] <-- Dominus has left IRC (Ping timeout: 260 seconds)
[01:24:05] --> Dominus has joined #exult
[01:24:06] --- ChanServ gives channel operator status to Dominus
[06:24:18] <-- Lightkey has left IRC (Ping timeout: 260 seconds)
[06:37:22] --> Lightkey has joined #exult
[08:13:06] --> ttarrant has joined #exult
[13:15:14] <-- ttarrant has left IRC (Ping timeout: 260 seconds)
[14:18:46] --> ttarrant has joined #exult
[14:58:12] <-- ttarrant has left IRC (Quit: Leaving)
[15:31:49] --> ttarrant has joined #exult
[15:46:35] <-- ttarrant has left IRC (Remote host closed the connection)
[15:49:12] --> ttarrant has joined #exult
[16:18:15] <Dominus> hmm, needing to find out when exult broke in between commits from the 24.11.2016 and 27.11.2016
[16:18:22] <Dominus> many coverty scan fixes...
[16:20:44] <Dominus> regression testing later...
[16:22:35] <ttarrant> Dominus, git bisect is your friend
[16:22:58] <ttarrant> has anybody tried to valgrind exult ?
[17:08:32] <Dominus> Ttarrant: yes, I know git bisect and it's one of the reasons it's good to be on git now ;)
[17:09:18] <Dominus> I think marzo valgrinned a bit. But it's hard with Exult... or slooooooooow
[17:30:08] <-- ttarrant has left IRC (Ping timeout: 260 seconds)
[18:13:01] <Dominus> wjp, could you take a look? https://github.com/exult/exult/commit/fd3dbd05f64e80ca1662b32d22326e477b75b544#diff-4a2ebc8d6dab1226b23e7e48ff361890R1164 is causing a crash with an automaton on patrol getting set to street maintenance by a path egg or whatever...
[18:15:54] <Dominus> bug report is at https://sourceforge.net/p/exult/bugs/2016/
[18:37:38] <-- Lightkey has left IRC (Excess Flood)
[18:37:59] --> Lightkey has joined #exult
[18:41:48] <wjp> Dominus: it adds 4 deletes in schedule.cc. Could you check which one triggers the problem?
[18:43:06] <Dominus> commenting the street maintenance delete scr; makes it not crash
[18:44:18] <Dominus> I just observed the original and there the automaton never enters street maintenance.
[18:45:51] <Dominus> but that might be a whole different problem.
[18:49:22] <wjp> yeah, shouldn't crash anyway
[18:52:45] <wjp> I don't know enough about how this Usecode_script works nowadays to judge the effect of that delete scr
[18:55:07] <Dominus> Then I'll comment it for now until Marzo is settled in France and can take better look
[19:15:19] <Dominus> hmm, wjp, in int Schedule::try_street_maintenance( (line 219) - we would need a check for frames in SI. As the Serpent lamps (frames 0,1,4,5 of shapes 526 and 889) can not be toggled. So a patroler should not enter street maintenance if these shapes+frames are the only ones around.
[19:15:51] <Dominus> (doesn't crash with the delete but those shapes commented out in that line)
[19:16:37] <Dominus> but for now probably comment the delete and make a new bug report about those frames
[20:06:12] --> GitHub has joined #exult
[20:06:12] <GitHub> [exult] DominusExult pushed 1 new commit to master: https://git.io/v9Gp7
[20:06:12] <GitHub> exult/master a1a5678 DominusExult: Temporarily reverting part of commit fd3dbd05f as it breaks certain patrols and crashes Exult -> bug 2016
[20:06:12] <-- GitHub has left #exult
[20:51:32] --> GitHub has joined #exult
[20:51:32] <GitHub> [exult] DominusExult pushed 1 new commit to master: https://git.io/v9ZUx
[20:51:32] <GitHub> exult/master 5ea5a91 DominusExult: Allow objects on fire to be put into containers in hack mover or map edit mode
[20:51:32] <-- GitHub has left #exult