#exult@irc.freenode.net logs for 29 Jan 2013 (GMT)

Archive Today Yesterday Tomorrow
Exult homepage

[06:43:21] <-- Marzo has left IRC (Ping timeout: 245 seconds)
[07:15:34] --> Marzo has joined #exult
[08:50:02] <-- Dominus has left IRC (Remote host closed the connection)
[08:50:33] --> Dominus has joined #exult
[08:50:33] --- ChanServ gives channel operator status to Dominus
[10:49:03] <-- Marzo has left IRC (Ping timeout: 252 seconds)
[12:06:59] --> Fingolfin has joined #exult
[12:06:59] --- ChanServ gives channel operator status to Fingolfin
[12:07:27] <Fingolfin> hi all, esp. Dominus
[12:07:38] <Dominus> hi Fingolfin :)
[12:07:54] <Fingolfin> Dominus: if you see a "fingolfin" on this IRC net, then it's probably not me, as I am almost never on IRC these days ;)
[12:08:11] <Fingolfin> but if I am, I hang out in #fink, #sourceforge, #git, sometimes more
[12:08:16] <Dominus> ah, thanks for clarifying
[12:08:49] <Fingolfin> fink and git are among the open source projects I work. And also GAP, which is software for mathematicians: http://www.gap-system.org/
[12:11:27] <wjp> hi Max
[12:11:47] <Dominus> now that I ported the coreaudio stuff to exult I need to port it to pentagram as well :)
[12:12:20] <Dominus> Fingolfin: any ideas on the copyright thingy or should I just leave it as it is?
[12:13:18] <Fingolfin> hi wjp
[12:13:34] <Fingolfin> 2003-2005 The Pentagram Team seems wrong for CoreAudioMidiDriver.cpp on so many levels...
[12:14:17] <Fingolfin> of course any copyright that claims "exult" or "scummvm" or "pentagram" "team" owns the copyright is bogus to start with...
[12:14:28] <Dominus> yes, probably you wrote that :)
[12:14:36] <Fingolfin> it is somewhat less bogus if there is a place where the member of the team are specifically defined
[12:14:58] <Fingolfin> but even then, from a purly legal POV (which of course depends on the jurisdiction...) it is not really valid
[12:15:08] <Fingolfin> the real authors would have to be identified by the commit logs, I guess
[12:15:27] <Fingolfin> a lot of that code is mine, but then I probably took parts from other sources, and also other people in exult, pentagram and scummvm modified parts
[12:15:42] <Dominus> and even then, in this case, I'm not really the author. I'm the one using copy/paste and *slightly* adapting things
[12:19:17] <Fingolfin> I really don't care so much... perhaps... "Originally written by Max Horn, Copyright 2002-2011. Modifications and improvements by multiple other people. Large portions of this code are shared by Exult, Pentagram and ScummVM."
[12:20:16] <Fingolfin> just looked through the logs, I did write most of that code, but then, multiple people made improvements, fixes etc., so I am not sure it's really the best idea to single out my name here... hmpf
[12:22:26] <Dominus> that kind of sums up my problem with the whole copyright header
[12:24:25] <wjp> these headers have very little legal status anyway, from what I understand. Best to make it a good starting point to figure out why contributed, I think
[12:24:31] <wjp> s/why/who/
[12:25:31] <Fingolfin> yeah
[12:25:53] <Fingolfin> part of the problem is that the code is distributed over three disjoint repos
[12:27:14] <-- Kirben has left IRC ()
[12:28:41] <Fingolfin> looking at things, I guess I added this in 2002 to ScummVM, then 2003 to pentagram, and ryan ported this 2005 to exult
[12:29:55] <Dominus> (not to mention coremidi driver as well which has been lifted off scummvm three or four years ago and I couldn't get a good answer on the copyright header back then as well :)
[12:36:36] <Fingolfin> in the end, the whole copyright business tehre is not that important. more important is giving attribution
[12:37:06] <Fingolfin> and even about that you could argue ;)
[12:38:06] <Fingolfin> looking at the commit logs in git, other contributors to the code were/are: Matthew Hoops AKA clone2727, Oystein Eftevaag aka vinterstum
[12:38:14] <Fingolfin> for the CoreAudio driver I mean
[12:39:07] <Fingolfin> there are more committers to scummvm.git/backends/midi/coreaudio.cpp, but they mostly touch the code to adapt it to internal ScummVM interface changes (so they have copyright to the file in ScummVM, but their changes probably did not carry over to exult or pentagram)
[12:39:56] <Fingolfin> (and whitespace / indention change commits are probably not copyrightable either ;-)
[12:40:19] <Fingolfin> I see no other contributors on the ScummVM side, though I may have missed some
[12:41:08] <Fingolfin> clone2727 and vinterstum made changes in 2012, so they should perhaps be mentioned with copyright for that year...
[12:42:02] <Fingolfin> or just don't say copyright, but say something like "Code originally written by Max Horn, later improvements by Matthew Hoops and Oystein Eftevaag, minor tweaks by various other people"
[12:42:16] <Fingolfin> I did not look at the exult & pentagram logs, though, perhaps more contributors hide there
[12:43:15] <Fingolfin> the coremidi code seems to be exclusively me, according to what I see in the logs. it\s not that great to start with, though, I just never felt the need to really make it work great :-(
[12:43:37] <Dominus> he he
[12:44:56] <Dominus> I *do* have the need but the culprit of a good mt32 sound is more our broken sysex stuff to begin with
[12:45:48] <Dominus> except for the initial porting of CoreAudio the code has been yours in Exult
[12:46:28] <Dominus> so I'm gonna nix the "Copyright (C) 2003-2005 The Pentagram Team" and go with what you wrote
[12:47:54] <Dominus> except maybe "by various other people of the ScummVM, Pentagram and Exult Teams"
[12:48:37] <Dominus> Code originally written by Max Horn,
[12:48:37] <Dominus> later improvements by Matthew Hoops and Oystein Eftevaag,
[12:48:37] <Dominus> minor tweaks by various other people of the ScummVM, Pentagram
[12:48:37] <Dominus> and Exult teams.
[12:49:06] <Fingolfin> sure
[12:49:31] <Fingolfin> sounds fine to me, though perhaps matthew and oystein should also be asked if they are OK with it?
[12:49:53] <Dominus> and for Coremidi I'll just write your name and minor tweaks by...
[12:50:05] <Dominus> yes, I'll try to get a hold of them
[12:52:06] <Dominus> Clone2727 is easier to get a hold of than Vinterstum :)
[12:53:02] <Dominus> now it's feeding time of the little one. bbl
[13:04:41] --> TheCycoONE has joined #exult
[13:08:10] --> Marzo has joined #exult
[13:15:52] <Fingolfin> cya
[13:15:53] <-- Fingolfin has left IRC (Quit: Fingolfin)
[13:16:49] <-- SugarCube has left IRC (Ping timeout: 246 seconds)
[13:29:05] --> SugarCube has joined #exult
[13:39:13] <Marzo> Huh. My internet is down most of the day and comes back just in time for me to see Fingolfin going
[14:44:10] --> redwar has joined #exult
[16:40:42] <-- Marzo has left IRC (Ping timeout: 240 seconds)
[16:44:17] --> Marzo has joined #exult
[16:58:12] <-- redwar has left IRC (Ping timeout: 240 seconds)
[17:02:33] <Dominus> yeah, Marzo, he probably won't be here for another two years :)
[17:03:00] <Marzo> So, how is the CoreAudio driver going?
[17:08:49] <Dominus> Marzo: the driver is done, except for a copyright thing (earlier discussion with Fingolfin)
[17:14:07] <Marzo> Dominus: I got something for you to try then
[17:14:25] <Dominus> try with try?
[17:14:53] <Dominus> great, no problem, except it will be a while today before I can actually test
[17:15:04] <Marzo> No problems
[17:15:39] <Marzo> (and yes)
[17:22:01] <Marzo> Hm, I should probably have asked you to test before running astyle on it, though
[17:22:11] <Marzo> But anyway
[17:22:29] <Dominus> he he
[17:22:40] <Dominus> I'm gone for a bit now
[17:23:04] <Marzo> Here is the link for when you get back: http://pastebin.com/MQeXAC4s
[18:44:10] <-- Marzo has left IRC (Ping timeout: 276 seconds)
[19:05:56] <-- Dominus has left IRC (Remote host closed the connection)
[19:06:26] --> Dominus has joined #exult
[19:06:27] --- ChanServ gives channel operator status to Dominus
[21:53:00] <-- TheCycoONE has left IRC (Quit: And then there were n-1)
[22:29:06] --> i30817 has joined #exult
[23:07:50] --> Kirben has joined #exult
[23:07:50] --- ChanServ gives channel operator status to Kirben