#exult@irc.freenode.net logs for 3 Apr 2013 (GMT)

Archive Today Yesterday Tomorrow
Exult homepage

[00:15:18] <Dominus> Marzo, revision 7363 broke the BG keyring mod
[00:31:54] <Dominus> wjp: I added a tracker for this music effects bug https://sourceforge.net/tracker/?func=detail&aid=3609847&group_id=2335&atid=102335
[02:18:14] <-- Matt_O has left IRC (Quit: Leaving)
[03:03:00] --> shazza has joined #exult
[03:19:36] --> Matt_O has joined #exult
[04:54:18] <-- SHODAN has left IRC (Remote host closed the connection)
[04:54:26] --> SHODAN has joined #exult
[06:48:05] --> Matt_O1 has joined #exult
[06:48:24] <-- Matt_O has left IRC (Ping timeout: 276 seconds)
[07:11:53] --> Matt_O has joined #exult
[07:12:09] <-- Matt_O1 has left IRC (Ping timeout: 252 seconds)
[07:33:23] <-- Matt_O has left IRC (Ping timeout: 246 seconds)
[09:34:08] --> Matt_O has joined #exult
[11:31:23] <-- Marzo has left IRC (Ping timeout: 260 seconds)
[11:54:07] --> Fingolfin has joined #exult
[11:54:07] --- ChanServ gives channel operator status to Fingolfin
[12:01:44] --> TheCycoONE has joined #exult
[13:10:40] <-- Fingolfin has left IRC (Quit: Fingolfin)
[13:48:42] <wjp> brr, 7363 is huge
[13:48:56] <wjp> and mixing far too many separate things :-(
[13:49:15] <wjp> but it looks like it breaks opcode 0x56?
[13:49:38] <wjp> changing a peek into a pop in the non-error case while the ChangeLog claims it fixes the error case
[13:53:30] <Dominus> thanks for looking at it. Can you fix it?
[13:53:45] <wjp> well, I can revert it
[13:53:57] <wjp> but I have no idea what Marzo was intending
[13:54:31] <Dominus> hmm
[13:57:30] <Dominus> I wonder if it would help compiling the keyring usecode against these changes
[13:57:41] <wjp> worth a try
[14:01:47] * Dominus is compiling...
[14:09:09] <wjp> if it doesn't help, try replacing the pop() in usecode/ucinternal.cc line 2819 with peek()
[14:09:18] <wjp> (but don't commit that, since it's only a partial revert)
[14:12:52] <Dominus> wjp: the changing of ucinternal.cc helped
[14:13:55] <Dominus> compiling the kexring usecode didn't help (though that gave me warnings of some infinite loops in the spells
[14:14:36] <Dominus> but that has nothing to do with this issue, probably just introduced when marzo disabled npc spells
[14:15:08] <wjp> ok, if you feel like fully reverting that function back to its pre-7373 state, add a line "(void) pop();" right below the THIS_ERROR(); slightly below the previous line
[14:15:16] <wjp> pre-7363
[14:16:04] <Dominus> and keep the peek()?
[14:16:23] <wjp> yes
[14:17:29] <wjp> if it's still fixed after that, I'd be ok with just committing this
[14:17:38] <wjp> and then we can ask Marzo later to take another look
[14:17:59] <Dominus> yes, still works
[14:18:38] <Dominus> should I commit?
[14:19:20] <wjp> fine by me
[14:19:25] <wjp> I can also do it if you prefer
[14:19:37] <Dominus> nah, I can do it
[14:29:08] <wjp> looks good, thanks
[14:29:23] <Dominus> thanks to you :)
[14:35:17] <Dominus> now what is up with the strange bird sounds? :)
[14:37:43] <wjp> I also wonder about 7367's opcode changes
[14:42:01] <Dominus> what about it? I can't make sense of usecode stuff (tried staring at it but that didn't help :))
[14:44:57] <wjp> well, it would mean our understanding of those opcodes would have been wrong since before 2000
[14:45:14] <wjp> specifically how they handle their arguments
[14:45:19] <wjp> which just seems a bit surprising
[14:46:02] <Dominus> can you browse the logs of that commit time? Perhaps Marzo was writing a bit about it
[14:46:07] <wjp> he was
[14:46:27] <-- shazza has left IRC (Ping timeout: 252 seconds)
[16:32:08] <-- ettin has left IRC (Read error: Operation timed out)
[16:36:05] --> ettin has joined #exult
[19:11:31] <Dominus> one more episode of Breaking Bad then off to some Exult playtesting :)
[20:55:32] <-- TheCycoONE has left IRC (Quit: And then there were n-1)
[21:24:32] --> Fing has joined #exult
[21:24:32] --- ChanServ gives channel operator status to Fing
[22:54:21] --> Marzo has joined #exult
[23:50:16] <Dominus> hmm, a lot of things give sound effects I never noticed before... the vortex cube in Britain, the hoe of destruction in the shed...
[23:54:38] <Dominus> hmm and still people sleeping on the floor :(
[23:56:11] <Dominus> https://dl.dropbox.com/u/7737184/badbedsleeperscove.png
[23:56:41] <Dominus> at 3:51 am after wandering to cove from Britain