[01:54:34] <-- Dominus has left IRC (Ping timeout: 244 seconds)
[01:56:51] --> Dominus has joined #exult
[01:56:51] --- ChanServ gives channel operator status to Dominus
[03:03:07] <-- tsoliman_ has left IRC (Quit: ZNC - http://znc.in)
[03:58:39] --> tsoliman has joined #exult
[05:50:49] <-- Lightkey has left IRC (Ping timeout: 268 seconds)
[06:03:16] --> Lightkey has joined #exult
[13:23:04] <-- exultbot has left IRC (signing off...)
[13:24:21] --> exultbot has joined #exult
[13:24:21] --- Topic for #exult is: Exult: http://exult.sourceforge.net/ - The open source engine for Ultima 7
[13:24:21] --- Topic for #exult set by Colourless at Fri Sep 12 00:40:42 2008
[14:23:19] <-- Rottingbeef has left IRC ()
[19:25:59] --> Marzo has joined #exult
[19:55:35] --> Matthew02 has joined #exult
[20:07:04] <Matthew02> Anyone around right now? I'm getting core dumps when loading save games (especially quicksaves). Happens with BG saves, SI saves, and SI:SIFIXES saves. Backtrace says it's happening in Face_button.cc. I checked GitHub and there don't appear to be any changes to that file in a few years, so I must have something configured wrong or similar problem. This is perfectly reproducible with what I have so far and it
[20:07:06] <Matthew02> happens even with new saves.
[20:07:15] <Matthew02> Backtrace at http://pastebin.com/DwmHMVY6.
[20:14:11] <Matthew02> I'll keep an eye out here in case any of you happen to see my message and respond. Thanks in advance.
[20:47:12] <Epitrope> Matthew02: have you filed a bug? they'll likely need a savegame to reproduce: http://exult.sourceforge.net/faq.php#bug_report
[20:48:01] <Epitrope> Matthew02: and does it happen when you start a new game, save, and load it? or only already-existing saved games?
[20:48:27] <Matthew02> Not yet. I'm always averse to file a bug report without doing some searching and asking yet. I guess I'll go ahead, though.
[20:48:36] <Matthew02> Happens in both circumstances.
[20:50:19] <Matthew02> It doesn't happen when I click 'Journey Onward', though.
[20:52:00] <Matthew02> And if I try to load any game other than quicksave, it will segfault, but then next time I 'Journey Onward', it will be from the save game I previously attempted to load.
[20:52:55] <Epitrope> interesting
[20:54:07] <Matthew02> Also, if I quicksave and then later 'Journey Onward', I continue from that previous quicksave with no trouble.
[21:09:45] --> Rottingbeef has joined #exult
[21:15:53] <Epitrope> I am able to reproduce
[21:16:23] <Epitrope> using commit 635fb032f597bdf5b522e4edec67fa17234c0fbe
[21:17:31] <Matthew02> So it's not just me, then? That's nice to know. I'm going to take a quick look at that commit.
[21:20:04] --> Malignant_Manor has joined #exult
[21:20:24] <Epitrope> I'll try building an older commit to see if that works
[21:21:21] <Malignant_Manor> I think this was likely added with the last commit
[21:23:21] <Matthew02> Seems like it. I'm also going to rebuild and see what happens.
[21:28:37] <Malignant_Manor> I mean my last commit and not Marzo's.
[21:29:30] <Matthew02> Ahh... Gotcha.
[21:30:09] <Matthew02> The cheat_screen changes?
[21:30:55] <Malignant_Manor> Well, I changed how the face buttons update.
[21:31:40] <Malignant_Manor> It is adding the button without an actor.
[21:34:11] <Matthew02> I see. Well, I sort of see in the way that someone who is in over his head is able to see. I'm learning, though.
[21:39:25] <Matthew02> I now see that the backtrace points to a couple of lines that were modified in your commit. This is a valuable learning experience for me.
[21:50:34] <Epitrope> yeah, git bisect confirms the problem was introduced in 306c52981888b45b4c4e7daf34973f8fa2c69a59
[21:54:26] <Matthew02> Yes, and I can indeed load saves again.
[21:55:59] <Matthew02> Now if only I was smart enough to contribute in a meaningful way by actually fixing the issue. One of these days...
[22:01:58] <Epitrope> s/was smart enough/had enough context/
[22:02:51] <Matthew02> touché
[22:03:57] <Malignant_Manor> I have a better error log. http://pastebin.com/bkkrFaag
[22:05:44] <Malignant_Manor> It updates while reading the actor data which is really bad. I need to delete face_stats before reading the save data and create it again afterwards.
[22:07:10] <Malignant_Manor> I have forgotten a lot about how Exult works.
[22:09:12] <Matthew02> I'm sure you've forgotten more than I will ever know in the first place. How did you come up with your backtrace? I'm curious what I should have done differently.
[22:10:38] <Malignant_Manor> I have it compiled with -o0 and -ggdb3
[22:11:53] <Matthew02> I figured it was something along those lines. Thanks for the info.
[22:22:40] --> GitHub has joined #exult
[22:22:40] <GitHub> [exult] malignantmanor pushed 1 new commit to master: https://git.io/vVBK9
[22:22:40] <GitHub> exult/master 4181418 Malignant Manor: Fix crash caused by Face_stats updating during actor read....
[22:22:40] <-- GitHub has left #exult
[22:30:40] <Epitrope> that fixes it for me
[22:32:39] <Matthew02> Awesome. I'll re-build in a moment. Thanks for sorting that all out and for the bugfix. You guys rock.
[22:41:31] <Malignant_Manor> Thanks for the report and finding out exactly how to reproduce it. I was the one who broke it.
[22:50:27] <Matthew02> I appreciate the kind words. I'm glad that I was able to contribute in some small measure.
[22:51:10] <Matthew02> I'm curious... Are you a developer by trade, or is it a hobby only?
[22:52:11] <Malignant_Manor> This is a bit of a hobby. I'm not a good coder but can fix some logic bugs or other relatively simple errors.
[22:52:42] <Malignant_Manor> I can also make some modifications based on existing code.
[22:53:46] <Matthew02> Very cool. I look at a project like Exult and the code makes my head swim.
[23:06:40] <-- Malignant_Manor has left IRC (Quit: ChatZilla 0.9.92 [Firefox 45.0.1/20160315153207])