#exult@irc.freenode.net logs for 7 Jan 2018 (GMT)

Archive Today Yesterday Tomorrow
Exult homepage


[02:37:23] <-- Dominus has left IRC (Ping timeout: 260 seconds)
[02:39:18] --> Dominus has joined #exult
[02:39:18] --- ChanServ gives channel operator status to Dominus
[11:34:10] --> michael-kohlhaas has joined #exult
[11:49:06] <-- Lightkey has left IRC (Ping timeout: 246 seconds)
[12:02:40] --> Lightkey has joined #exult
[15:49:49] <Dominus> Odd, either it's a problem of an unclean build or toggle_fullscreen in imagewin is no longer used...
[17:55:26] <-- michael-kohlhaas has left IRC (Ping timeout: 276 seconds)
[18:36:41] <-- Rottingbeef has left IRC ()
[18:49:56] <Dominus> wjp, another rendering problem question: When we switch from fullscreen to windowed mode it goes via gwin->resized (gamewin.cc:938) to Image_window::resized https://github.com/exult/exult/blob/master/imagewin/imagewin.cc#L906 and there the surface is recreated
[18:49:58] <Dominus> with SDL2 the window dimensions will not be set correctly (f fullscreen and windowed uses different settings) unless you set SDL_SetWindowSize(screen_window, neww, newh); after create_surface
[18:50:40] <Dominus> Since this works for SDL 1.2x I guess we are doing something wrong in create_surface
[18:51:02] <Dominus> and setting SDL_SetWindowSize(screen_window, neww, newh); would be more a hack than good code
[18:52:19] --> michael-kohlhaas has joined #exult
[19:07:50] --> Rottingbeef has joined #exult
[19:32:07] <Dominus> I'll have to test Windows first if it happens there as well.
[19:34:06] <Dominus> In create_scaledsurface I need to set rendersetlogicalsize as well for OS X as on HighDPI monitor you can set a very high res but can only use half of it
[19:35:19] <Dominus> So I'll differ between fullscreen and windowed in there (if fullscreen rendersetlogicalsize else setwindowsize)
[19:36:01] <Dominus> If it isn't a problem on Windows I'll do it for OS X only for now
[20:09:53] <-- Dark-Star has left IRC (Remote host closed the connection)
[20:24:06] --> Dark-Star has joined #exult
[20:35:36] <-- michael-kohlhaas has left IRC (Remote host closed the connection)
[21:14:09] <Dominus> hmm, seems to only be wonky on OS X
[21:24:11] <Dominus> ah, it's due to sdl-compat.h definition of SDL_FULLSCREEN. For OS X I've set it to SDL_WINDOW_FULLSCREEN_DESKTOP because without _DESKTOP it wreaks havoc with more than one monitor :(
[22:37:47] --> GitHub has joined #exult
[22:37:47] <GitHub> [exult] DominusExult pushed 2 new commits to master: https://git.io/vNIIX
[22:37:47] <GitHub> exult/master 33eb260 DominusExult: Because in sdl-compat.h SDL_FULLSCREEN is defined to SDL_WINDOW_FULLSCREEN_DESKTOP for OS X it messes up toggling fullscreen on it. The windowed size remains the size of the fullscreen display mode if Exult is configured to use different modes for fullscreen and windowed. SDL_SetWindowSize for windowed mode after creating the renderer fixes that....
[22:37:47] <GitHub> exult/master ca4410b DominusExult: Allow HighDPI on OS X
[22:37:47] <-- GitHub has left #exult