#exult@irc.freenode.net logs for 9 Apr 2016 (GMT)

Archive Today Yesterday Tomorrow
Exult homepage

[00:39:58] <-- frob has left IRC (Ping timeout: 248 seconds)
[01:21:10] <-- Dominus has left IRC (Ping timeout: 276 seconds)
[01:23:01] --> Dominus has joined #exult
[01:23:01] --- ChanServ gives channel operator status to Dominus
[01:45:51] <-- Darrenor64 has left IRC (Ping timeout: 260 seconds)
[01:46:06] --> Darrenor64 has joined #exult
[05:47:57] --> frob has joined #exult
[05:52:24] <-- frob has left IRC (Ping timeout: 248 seconds)
[07:25:23] --> frob has joined #exult
[07:29:47] --> ttarrant has joined #exult
[07:29:48] <-- frob has left IRC (Ping timeout: 260 seconds)
[08:03:01] <-- ttarrant has left IRC (Quit: I'm off)
[09:51:06] <-- Lightkey has left IRC (Ping timeout: 250 seconds)
[10:04:08] --> Lightkey has joined #exult
[17:32:15] <Marzo> Hm
[17:32:29] <Marzo> Thinking of getting rid of all unused variable warnings
[17:33:03] <Marzo> But I am wondering about the best way to go about it
[17:33:26] <Marzo> I am thinking of swiping Boost's ignore_unused_variable_warning function, but I am not sure where to put it
[17:34:21] <Marzo> I think the best option would be to add a new header in headers and include it on the 'headers' dir
[17:34:38] <Marzo> But it could also be placed in another file that gets included frequently
[17:46:25] <Dominus> Heya Marzo
[17:46:34] <Marzo> Hi
[17:47:20] <Dominus> Clang or xcode also has a lot of warnings of conversion of values not being correct or something
[17:47:34] <Dominus> Due to 64bit I think
[17:47:58] <Dominus> Of course I'm not at home and can't give an example right now
[17:48:10] <Dominus> ;)
[17:49:51] <Marzo> Yeah, I am aiming to fix all warnings
[17:50:02] <Marzo> Reduce compilation noise, so to speak
[17:50:31] <Dominus> Nice
[17:51:50] <Marzo> But I will do it one at a time
[17:51:58] <Dominus> While trying to help that guy with build and other problems I realized that our output of installed games is a bit confusing
[17:52:13] <Marzo> The most numerous, but easier to fix, is unused variable warning
[17:52:38] <Dominus> Game blackgate not found, game forge found bla bla
[17:53:55] <Marzo> I am thinking that saying "Pure Black Gate not found" instead would be more informative
[17:55:24] <Dominus> Yes
[17:55:29] <Dominus> Looking for 'blackgate' at '/Library/Application Support/Exult/blackgate'... found game with identity 'FORGE'
[17:55:29] <Dominus> Looking for 'forgeofvirtue' at '/Library/Application Support/Exult/forgeofvirtue'... but it wasn't there.
[17:56:14] <Dominus> etc
[17:57:06] <Dominus> That is actually from studio...
[17:57:28] <Dominus> I think it further confused that guy ;)
[18:01:32] <Marzo> How do these messages sound:
[18:01:33] <Marzo> Looking for Black Gate at '/Library/Application Support/Exult/blackgate'... found Forge of Virtue instead
[18:01:33] <Marzo> Looking for Forge of Virtue at '/Library/Application Support/Exult/forgeofvirtue'... but it wasn't there.
[18:02:20] <Marzo> (Exult also prints those messages, by the way)
[18:05:53] <Dominus> Sounds better. Maybe the message about not finding FOV in the default location could be hidden IF FOV has been found in BG default
[18:06:30] <Dominus> Unless in debug mode
[18:07:30] <Dominus> It adds another if bla bla but people usually only add fov to the bg location and don't need to read the second message
[18:08:55] <Dominus> But only hiding the message if fov was found before, nothing is in fov default and not skipping the check
[18:17:36] <Marzo> Yeah
[18:17:56] <Marzo> On another news, I am thinking of adding a joke NPC to Keyring
[18:18:07] <Marzo> A brown bear named Grylls
[18:36:04] <Marzo> Huh
[18:36:25] <Marzo> imagewin/ibuf16.h:129:70: warning: unused parameter ‘xform’ [-Wunused-parameter]
[18:36:32] <Marzo> Err, wrong message:
[18:36:36] <Marzo> imagewin/ibuf16.h:128:66: warning: unused parameter ‘srch’ [-Wunused-parameter]
[18:36:48] <Marzo> Function has the single line:
[18:36:49] <Marzo> fill8(val, srcw, srcw, destx, desty);
[18:36:58] <Marzo> Note srcw appears twice
[18:37:08] <Marzo> So found a bug by eliminating warnings
[18:42:39] <Dominus> Yeah!
[18:43:48] * Dominus really really should play the BG Keyring...
[20:17:57] <Marzo> Uff, lots of unused parameter warnings
[20:18:14] <Marzo> I found one other that may or may not be a bug
[20:18:20] <Marzo> Need to investigate more
[20:18:32] <Marzo> I am thinking I will split off the bug fixes into separate commits
[20:28:59] <Marzo> ShortcutBar_gump code is awful, judging by the warnings
[20:54:22] --> Malignant_Manor has joined #exult
[20:57:54] <Malignant_Manor> Marzo: how many warnings are there?
[20:58:12] <Marzo> Overall or in shortcutbar?
[20:58:30] <Marzo> But actually, it is the "quality" of the warnings
[20:58:59] <Malignant_Manor> shortcutbar mostly
[21:00:15] <Malignant_Manor> I don't see push initialized
[21:00:36] <Malignant_Manor> translucent seems to not get initialized if false
[21:16:26] <Malignant_Manor> Marzo: -wall (on old gcc) is showing only two issues in ShortcutBar_gump that are specific to it. (there is unused function int SDL_putenv(const char*) in sdl-compat.h
[21:16:46] <Marzo> I compile with a lot more than just -Wall
[21:18:06] <Marzo> Specifically: -Wall -Wextra -Wcast-qual -Wwrite-strings -Wredundant-decls -Wdisabled-optimization -fcheck-new -Wctor-dtor-privacy -Wnon-virtual-dtor -Wold-style-cast -Woverloaded-virtual
[21:19:44] <Malignant_Manor> Yeah, that is a whole lot more
[21:20:35] <Malignant_Manor> I see a bunch of other includes that are spamming the log
[21:26:27] <Marzo> Yeah, I am fixing these
[21:27:38] <Malignant_Manor> I remember you having me print error outputs before but apparently you never went after most of the warnings.
[21:40:34] <Malignant_Manor> Marzo: you had me and Dom give some warnings in 2013. http://log.usecode.org/exultlog.php?log=25Jan2013
[21:41:06] <Marzo> Yeah, I never had the time for it
[21:41:58] <Marzo> Once I am done with these warnings I am handling, I will ask you and Dominus to compile with that crazy level of warnings and send me the logs
[21:43:53] <Marzo> Without all the warnings I am removing, the logs will be a lot more platform-specific
[21:45:26] <Malignant_Manor> I know I am probably guilty of c style casts.
[21:56:22] <Marzo> Most of the c style casts come from GTK code
[22:10:11] <-- Malignant_Manor has left IRC (Quit: ChatZilla 0.9.92 [Firefox 45.0.1/20160315153207])