#exult@irc.freenode.net logs for 9 Jan 2013 (GMT)

Archive Today Yesterday Tomorrow
Exult homepage


[08:28:56] <-- Kirben has left IRC ()
[09:14:53] --> shazza has joined #exult
[09:23:28] --> Kirben has joined #exult
[09:23:28] --- ChanServ gives channel operator status to Kirben
[09:42:47] <-- nutron has left IRC (*.net *.split)
[09:45:28] <-- Kirben has left IRC ()
[09:50:14] --> nutron has joined #exult
[10:18:35] <-- Matt_O has left IRC (Quit: Leaving)
[11:02:11] --> Kirben has joined #exult
[11:02:11] --- ChanServ gives channel operator status to Kirben
[12:50:30] <-- shazza has left IRC (Ping timeout: 264 seconds)
[12:52:23] <-- Kirben has left IRC ()
[12:52:44] --> TheCycoONE has joined #exult
[16:44:19] --> Matt_O has joined #exult
[17:39:19] <Marzo> Ugh
[17:39:31] <Marzo> I knew I should have waited for compilation to finish
[22:01:30] <-- Rottingbeef has left IRC ()
[22:02:05] <-- TheCycoONE has left IRC (Read error: Connection reset by peer)
[22:30:02] --> Kirben has joined #exult
[22:30:03] --- ChanServ gives channel operator status to Kirben
[22:38:21] --> Malignant_Manor has joined #exult
[22:38:48] <Malignant_Manor> Marzo, the logic in bool Actor::ready_ammo seems off. http://pastebin.com/VkU3AGU3
[22:39:01] <Malignant_Manor> winf->get_ammo_consumed()) < 0
[22:39:31] <Malignant_Manor> is checked a second time that seems redundant.
[22:41:07] <Marzo> I will have to check my notes on this
[22:42:21] <Malignant_Manor> I noticed this when static analysis said the ammo variable wasn't being used.
[22:44:38] <Marzo> Well, as is, the ammo variable is indeed redundant and the second check can be removed -- it is not reachable
[22:45:23] <Malignant_Manor> ammo can be used for found = find_best_ammo(winf->get_ammo_consumed());
[22:46:20] <Marzo> You are right, of course
[22:46:52] <Marzo> In terms of style, I think moving the assignment out of the if would be best
[22:46:54] <Malignant_Manor> I'm trying to eliminate some Cppcheck noise.
[22:47:06] <Marzo> You will go nuts
[22:47:27] <Marzo> Really, at first, it is best to put the compiler on maximum warning levels
[22:47:33] <Malignant_Manor> Yeah
[22:47:53] <Malignant_Manor> I'm mainly going for the easy ones.
[22:47:59] <Marzo> And based on the test I did when you suggested, lots of things cppcheck says turn out to be either wrong or noise
[22:53:04] <Malignant_Manor> I know the Windows frontend can toggle categories.
[23:21:42] <-- nutron has left IRC (Ping timeout: 264 seconds)
[23:48:55] <Malignant_Manor> Marzo: Is assert(len = 3*256); supposed to modify len or compare it? http://pastebin.com/qUXFTXYH
[23:49:13] <Marzo> Compare it
[23:49:39] <Marzo> So, something good out of cppcheck :-)
[23:50:58] <Malignant_Manor> It was very useful for finding uninitialized variables in Nuvie.