#gemrb@irc.freenode.net logs for 10 Oct 2010 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage

[00:06:02] <-- duffolonious has left IRC (Ping timeout: 264 seconds)
[00:08:17] --> duffolonious has joined #GemRb
[00:47:29] --> Lightkey has joined #GemRb
[00:51:52] <-- Lightkey has left IRC (Client Quit)
[00:55:02] --> Lightkey has joined #GemRb
[00:57:02] <duffolonious> http://pastebin.com/BcR9SRMu
[00:58:12] --> raevol has joined #GemRb
[01:01:06] <duffolonious> http://pastebin.com/Td2dXfg6
[01:01:23] <duffolonious> that *appears* to have fixed it, but I'm not entirely sure
[01:05:54] <-- duffolonious has left IRC (Ping timeout: 260 seconds)
[01:08:03] --> duffolonious has joined #GemRb
[01:20:54] <-- raevol has left IRC (Quit: Leaving.)
[01:35:02] <-- Maighstir has left IRC (Quit: ~ Trillian Astra - www.trillian.im ~)
[01:50:59] <-- duffolonious has left IRC (Ping timeout: 276 seconds)
[01:52:47] --> duffolonious has joined #GemRb
[03:25:43] --> pupnik_ has joined #GemRb
[03:29:07] <-- pupnik has left IRC (Ping timeout: 240 seconds)
[06:16:00] --> Avenger has joined #GemRb
[06:16:00] --- ChanServ gives channel operator status to Avenger
[06:16:23] <Avenger> hello
[06:20:14] <Avenger> duffolonious: why did you have that print there? The classweapon table is loaded later in the same function, if you need that print, put it after that. No need to load the table again
[06:21:31] <Avenger> the table is loaded only for iwd when type == LUPROFS_TYPE_DUALCLASS or LUPROFS_TYPE_LEVELUP
[07:16:11] --> edheldil_ has joined #GemRb
[08:33:38] <-- edheldil_ has left IRC (Ping timeout: 264 seconds)
[09:01:49] <fuzzie> right, the bug there is just that line 274 (in git) uses ClassWeapTable when it should use ClassWeaponTable?
[09:01:59] <fuzzie> ClassWeaponsTable, even
[09:02:35] <fuzzie> and so the other line which loads clasweap into ClassWeapTable should go?
[09:05:14] <fuzzie> v.confusing
[09:08:22] <pupnik_> mhm
[09:17:57] --> edheldil_ has joined #GemRb
[09:29:57] <Avenger> ah fuzzie, i didn't check the variable names
[09:30:49] <Avenger> it is ClassWeaponsTable for me everywhere
[09:31:55] <Avenger> except his print :)
[09:33:37] <Avenger> ah no
[09:35:53] <fuzzie> you see how there seems to be a missed case there
[09:36:47] <fuzzie> but i wouldn't apply a patch there without asking lynx, myself, because i don't know how it all works
[09:36:51] <fuzzie> maybe you do :)
[09:40:14] <Avenger> well, i actually don't see the missed case, only some redundant table usage
[09:40:51] <Avenger> as far as i see, it loads ClassWeaponsTable in levelup and dualing too
[09:41:37] <fuzzie> but this is 'ClassWeapTable'.
[09:42:29] <fuzzie> which is used for all types
[09:43:08] <Avenger> what do you mean
[09:43:16] <fuzzie> see line 274
[09:43:23] <Avenger> btw, bg1 also has 'clasweap.2da'
[09:43:25] <fuzzie> it uses both ClassWeapTable and ProfsColumn, in iwd1 mode
[09:43:46] <fuzzie> which is what duffolonious's patch is fixing, i assume
[09:44:31] <fuzzie> i didn't know that iwd1 had kits, though
[09:45:19] <Avenger> only mage schools, why?
[09:45:26] <fuzzie> oh, well, i guess that is it
[09:46:06] <fuzzie> this code fails when you have a single-class kitted iwd1 char, i guess
[09:46:26] <Avenger> i don't see how, but i guess that was the case?
[09:46:42] <Avenger> well, not kitted, but schooled
[09:47:31] <Avenger> he wrote: he tried to level up a mage in iwd1
[09:47:34] <fuzzie> it doesn't set 'ClassWeapTable' in that case, and it incorrectly sets 'ProfsColumn'
[09:47:36] <Avenger> could be a specialist
[09:48:10] <Avenger> ok, if i use ClassWeaponsTable everywhere, and instead of IsIWD1 i use if ClassWeaponsTable:, it will work
[09:48:30] <fuzzie> i think iwd1's table is different
[09:48:42] <Avenger> yes, row/column is switched
[09:48:46] <Avenger> but that's fine
[09:48:48] <fuzzie> so you still need the ProfsColumn line from the patch
[09:49:32] <fuzzie> but otherwise yes i think you have the right fix there
[09:49:42] <Avenger> i actually got that
[09:49:52] <fuzzie> ok :)
[10:19:25] <Avenger> clasweap is not used in bg1 ?
[10:20:47] <-- Avenger has left IRC (Quit: ChatZilla 0.9.86 [Firefox 3.6.10/20100914125854])
[10:33:17] --> Avenger has joined #GemRb
[10:33:17] --- ChanServ gives channel operator status to Avenger
[10:33:58] <Avenger> anyone can check bg1? it seems the weapon selection in bg1 level up doesn't work. (no buttons to add a proficiency star)
[10:34:49] <fuzzie> that is quite possible, because i think lynx doesn't have bg1 installed
[10:35:16] <fuzzie> and i don't think i checked proficiencies in level up
[10:35:20] <Avenger> oh well,
[10:35:25] <Avenger> then i commit this
[10:35:34] <fuzzie> but we can fix it anyway
[10:36:27] <Avenger> i just noticed bg1 uses clasweap too, so i added that to the heap
[10:36:36] <fuzzie> the original binary does?
[10:36:37] <CIA-22> GemRB: 03avenger_teambg * rf8fad7764435 10gemrb/gemrb/GUIScripts/LUProfsSelection.py: use clasweap.2da in bg1 too
[10:36:52] <Avenger> well, it has the file, so it should use it :)
[10:37:07] <Avenger> bg2 has it too, but that can be explained by inheritance
[10:37:12] <fuzzie> i seem to remember the file being bad or something, but there is a CLASWEAP string in the exe
[10:37:28] <Avenger> the file is 'bad' for bg2 i guess
[10:38:10] <Avenger> it isn't structurally wrong, because it loaded in dltcep, that's all i know, and the weapon names appeared to be the bg1 weapons
[10:38:32] <Avenger> hopefully the order is correct
[10:39:13] <fuzzie> if i look at forum posts, the modding guides say it is used in both bg1 and bg2 but the format is quite different
[10:39:35] <fuzzie> but i doubt that is true :)
[10:39:37] <Avenger> clasweap is used in bg2? that's surely won't roll
[10:39:47] <Avenger> it has the old weapon names :)
[10:40:00] <Avenger> ok, what to do to fix the selector buttons
[10:40:11] <Avenger> there is already a section of: elif type == LUPROFS_TYPE_LEVELUP and GUICommon.GameIsBG1():
[10:40:22] <Avenger> and there are buttons named there
[10:40:37] <Avenger> maybe OddIds=1 ?
[10:41:05] <Avenger> hmm no, that is iwd
[10:41:29] <fuzzie> yeah, the competent people say that clasweap is not used in bg2 and they have no idea why all the modding guides say to change it
[10:41:37] <Avenger> hehe, yes
[10:41:58] <Avenger> i will look for it in ida
[10:42:05] <Avenger> i switched to look into pst
[10:42:21] <Avenger> its code is very similar in many cases, and it has no multiplayer specific crap
[10:42:35] <edheldil_> Avenger: I have a big part of MFC in ps:t mapped, sadly it's for 2cd version
[10:42:46] <Avenger> though, i'm unsure if it was taken out or never added in
[10:43:37] <fuzzie> the last person to fiddle with bg1 profs was you, Avenger, it seems
[10:43:46] <Avenger> hmm ed, the mfc part is not overly sexy :) i would like to see the vidbitmap struct, or the icon :)
[10:44:23] <Avenger> apparently its size changed from d6 (in bg2) to e4 (in pst)
[10:44:35] <Avenger> i mean the bitmap
[10:45:01] <Avenger> objects are also different, from 30 to 38
[10:45:16] <Avenger> and the object ids are rearranged
[10:45:34] <fuzzie> i'm pretty sure the pst engine code is from *before* bg1
[10:45:39] <fuzzie> from what the developers said
[10:46:05] <fuzzie> which makes a lot of things make more sense, if they hardcoded things before merging engine updates from Bioware
[10:46:20] <Avenger> well, actually... the pst i decoded appears to be aged as totsc
[10:46:48] <fuzzie> i mean, they obviously got updates as they went along
[10:47:00] <Avenger> so it is bg1+upgrades + cut out stuff + pst hacks
[10:47:04] <fuzzie> but the developers were complaining that they couldn't get things fixed because the bioware folks were busy finishing bg1
[10:47:34] <Avenger> a lot of things i thought as bg2 specific has traces in pst :)
[10:47:55] <Avenger> like: the flag that disables overlays
[10:48:16] <fuzzie> but it helps make sense if you think that the pst developers just got engine updates as they went, not just 'one' engine version which they then changed
[10:49:35] <fuzzie> the profs code just confuses me, i guess
[10:49:49] <Avenger> many things differ only because the recompile was done with different compiler options :)
[10:50:07] <Avenger> bg2 has lots of inlining, pst has less or maybe none
[10:50:24] <Avenger> separate functions actually help understanding :)
[10:50:55] <Avenger> what part of the profs code? our script?
[10:51:30] <fuzzie> yes. i just never learnt how any of this works, i'll leave it to you and lynx
[10:51:45] <Avenger> meh
[10:52:39] <Avenger> i wonder which part handles the +-buttons
[10:53:21] <Avenger> ProfsOffsetPress ?
[10:53:23] <fuzzie> that seems to be ProfsOffsetButton1
[10:53:46] <Avenger> ProfsOffsetButton1
[10:53:48] <Avenger> yeah
[10:54:51] <fuzzie> you added that as 'ProfsOffsetButton1 = 1' for bg1 levelup
[10:55:38] --> Maighstir has joined #GemRb
[10:57:15] <Avenger> it is 1 for levelup
[10:57:41] <Avenger> 1/3/5/7 for add, 2/4/6/8 for subtract
[10:58:51] --> SiENcE has joined #GemRb
[10:58:54] <Avenger> so, that's correct
[10:59:12] <Avenger> the problem is that the controls are totally invisible
[10:59:23] <Avenger> so something takes them off, because they are on the chu by default
[10:59:30] <fuzzie> maxprof problems, probably
[10:59:41] <Avenger> if MaxProf == 0:
[10:59:56] <Avenger> that might be my fault then
[11:00:15] <Avenger> MaxProf = ClassWeaponsTable.GetValue (ClassNameSave, ProfsTable.GetRowName(Pos))
[11:00:25] <Avenger> oh
[11:00:48] <Avenger> ok, i print the values out
[11:03:11] <Avenger> rownames are odd: RowName BG1LARGE_SWORD
[11:03:20] <Avenger> this is coming from us
[11:03:53] <Avenger> our weapprof.2da
[11:04:23] <fuzzie> that isn't ok?
[11:04:39] <Avenger> no, bg1 surely didn't have those names
[11:04:49] <Avenger> and it should be the same as in clasweap
[11:05:32] <fuzzie> i mean
[11:05:50] <fuzzie> oh right, you changed things to use clasweap
[11:06:14] <fuzzie> then yes i guess you have to fix our 2da :)
[11:07:16] <Avenger> the 4. column of weapprof in iwd 'cap_ref' is used?
[11:09:27] <Avenger> well, i don't know who uses that column
[11:09:37] <CIA-22> GemRB: 03avenger_teambg * r348694a5094a 10gemrb/gemrb/override/bg1/weapprof.2da: bg1: fixed weapprof to be bg1 compatible
[11:10:33] <-- SiENcE has left IRC (Read error: Connection reset by peer)
[11:24:18] <-- edheldil_ has left IRC (Ping timeout: 240 seconds)
[13:07:16] <pupnik_> http://www.debian.org/ports/kfreebsd-gnu/ Debian+FreeBSD
[13:54:27] --> SiENcE has joined #GemRb
[15:14:57] <duffolonious> Avenger: ignore the print,
[15:15:12] <Avenger> i think i fixed the problem
[15:43:57] --> edheldil_ has joined #GemRb
[15:48:38] --- Maighstir is now known as Maighstir|away
[15:55:06] <-- duffolonious has left IRC (Ping timeout: 240 seconds)
[15:56:32] <-- Avenger has left IRC (Quit: bye!)
[15:57:37] --> duffolonious has joined #GemRb
[16:02:11] <-- duffolonious has left IRC (Ping timeout: 255 seconds)
[16:04:19] --> duffolonious has joined #GemRb
[16:25:58] <-- edheldil_ has left IRC (Ping timeout: 245 seconds)
[17:50:33] --> raevol has joined #GemRb
[18:06:42] --> lynxlynxlynx has joined #GemRb
[18:06:42] --- ChanServ gives channel operator status to lynxlynxlynx
[18:30:14] --- Maighstir|away is now known as Maighstir
[18:38:09] <-- raevol has left IRC (Quit: Leaving.)
[18:56:49] <-- tomprince has left IRC (Ping timeout: 252 seconds)
[18:57:28] --> tomprince has joined #GemRb
[19:03:19] <-- Maighstir has left IRC (Quit: ~ Trillian Astra - www.trillian.im ~)
[19:04:46] --> Maighstir has joined #GemRb
[19:32:46] <-- lynxlynxlynx has left IRC (Remote host closed the connection)
[22:22:14] <-- SiENcE has left IRC (Quit: cya @all)