#gemrb@irc.freenode.net logs for 11 Jun 2011 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage


[00:22:02] <-- Bo_Thomsen has left IRC (Quit: Leaving.)
[00:33:22] <-- brad_a has left IRC (Ping timeout: 255 seconds)
[00:39:24] <-- raevol has left IRC (Quit: Leaving.)
[01:06:30] <-- Cable_ has left IRC (Read error: Operation timed out)
[01:06:45] --> Cable_ has joined #gemrb
[01:46:51] --> raevol has joined #gemrb
[02:24:29] <-- raevol has left IRC (Quit: Leaving.)
[03:58:12] <-- barra_away has left IRC (Read error: Connection reset by peer)
[04:32:33] --> brad_a has joined #gemrb
[05:01:40] <-- brad_a has left IRC (Quit: brad_a)
[07:12:29] --> lynxlynxlynx has joined #gemrb
[07:12:30] <-- lynxlynxlynx has left IRC (Changing host)
[07:12:30] --> lynxlynxlynx has joined #gemrb
[07:12:30] --- ChanServ gives channel operator status to lynxlynxlynx
[07:27:25] --> barra_home has joined #gemrb
[08:07:35] <CIA-39> GemRB: 03lynxlupodian * r5337d66acb0f 10gemrb/gemrb/plugins/IWDOpcodes/IWDOpcodes.cpp: iwdopcodes: use the AI_UPDATE_TIME macro for hardcoded durations
[08:07:45] <CIA-39> GemRB: 03lynxlupodian * rdb552edd8bb1 10gemrb/gemrb/core/ControlAnimation.cpp: silenced a valgrind warning
[08:09:31] --> Bo_Thomsen has joined #gemrb
[08:31:12] --> edheldil_ has joined #gemrb
[09:32:16] <CIA-39> GemRB: 03avenger_teambg * rb6892b20738d 10gemrb/gemrb/core/Scriptable/Actor.cpp: fixed an off by one copy crash
[09:34:08] --> Avenger has joined #gemrb
[09:34:17] --> Maighstir has joined #gemrb
[09:37:55] <Avenger> fuzzie, can you comment on this: http://forums.gibberlings3.net/index.php?s=&showtopic=20872&view=findpost&p=187112
[09:38:13] <Avenger> i think the guy was a bit over eager in changing masks to 0
[10:49:17] <wjp> hm, there are more broken calls to strnuprcpy
[10:50:16] <Avenger> where?
[10:50:58] <wjp> gemrb/plugins/GUIScript/GUIScript.cpp, strnuprcpy(entry->AreaLongName, script, 32);
[10:51:14] <wjp> same file, strnuprcpy(link->DestEntryPoint, ename, 32);
[10:51:31] <Avenger> that is correct
[10:51:40] <wjp> both those vars are char[32]'s
[10:51:41] <Avenger> the target size should be 33
[10:51:42] <Avenger> oh
[10:51:52] <Avenger> really?
[10:51:54] <Avenger> meh
[10:55:00] <Avenger> it should be of type ieVariable
[10:55:05] <Avenger> not simple char[32]
[10:57:21] <wjp> strnlwrcpy(ip->Destination, parameters->string0Parameter, 32); is also fishy since Destination is a ieResRef, but maybe that's intended to overflow into the next field?
[10:58:21] <Avenger> depends
[10:58:28] <Avenger> where is that?
[10:58:41] <CIA-39> GemRB: 03avenger_teambg * r8bba9bd8286d 10gemrb/gemrb/ (core/WorldMap.h plugins/WMPImporter/WMPImporter.cpp): converted some char[32] to ieVariable
[10:59:05] <Avenger> i know only one legally overflown field but that is in effects (resource1/2/3 = variable)
[10:59:07] <wjp> GameScript/Actions.cpp, ChangeDestination
[11:00:32] <Avenger> that is definitely buggy
[11:00:52] <Avenger> ieResRef is zero terminated
[11:01:13] <Avenger> so double fields cannot be merged by a simple copy
[11:01:33] <Avenger> weird, i think i tested this
[11:01:50] <Avenger> i think it should change only the resref, so 32->8
[11:02:34] <wjp> if string0Parameter is in fact a resref, the only side effect of this would be zeroing EntranceName
[11:02:46] <Avenger> but that is wrong
[11:02:58] <wjp> yes, but not sure how noticable it would have been during testing
[11:03:20] <wjp> are you committing these three things, or do you want me to?
[11:03:24] <Avenger> the entrance wouldn't work correctly, i think invalid entrancenames move you to the middle of the target area
[11:03:39] <Avenger> i changed the previous stuff
[11:03:47] <wjp> huh, missed that
[11:03:48] <Avenger> still investigating the latest
[11:04:15] <wjp> but thanks :-)
[11:04:23] <lynxlynxlynx> hey, we do drop parties at wrong places occasionally
[11:04:24] <Avenger> you don't know the forge area, i guess
[11:06:09] <Avenger> ah this is in baldur.bcs supplied by us
[11:07:15] <Avenger> ok, i see it is supposed to change only the area
[11:08:50] <CIA-39> GemRB: 03avenger_teambg * rf83cad4b69a3 10gemrb/gemrb/core/GameScript/Actions.cpp: fixed ChangeDestination copy size
[11:19:21] <-- Bo_Thomsen has left IRC (Quit: Leaving.)
[11:40:31] <lynxlynxlynx> bleh
[12:40:54] <-- edheldil_ has left IRC (Ping timeout: 250 seconds)
[13:07:12] <Avenger> lynx, this action is used only in HoW, and only in the forge area
[13:07:36] <lynxlynxlynx> too bad
[13:08:15] <lynxlynxlynx> and technically that's iwd, not how
[13:11:06] <Avenger> ok, iwd
[13:12:53] <Avenger> when will be the next release?
[13:25:04] <Avenger> hmm the bard song in iwd doesnt' affect everyone as it should
[13:29:09] <Avenger> eep, got this on level up:
[13:29:13] <Avenger> [GUIScript]: Syntax Error:
[13:29:14] <Avenger> Traceback (most recent call last):
[13:29:16] <Avenger> File "./GUIScripts/LevelUp.py", line 375, in OpenLevelUpWindow
[13:29:17] <Avenger> TextAreaControl.SetText(GUIREC.GetStatOverview(pc, LevelDiff))
[13:29:19] <Avenger> File "./GUIScripts/iwd/GUIREC.py", line 345, in GetStatOverview
[13:29:20] <Avenger> GemRB.SetToken ("NEXTLEVEL", LUCommon.GetNextLevelExp (Levels[i]+LevelDiff[i], Class) )
[13:29:22] <Avenger> AttributeError: SetToken(VariableName, Value)
[13:31:48] <Avenger> probably because i added too much xp :)
[13:32:03] <Avenger> evels: [40, 23, 0] Actor NextLevels: [30, 23]
[13:32:05] <Avenger> LevelDiffs: [39, 22, 0] Actor LevelDiffs: [29, 22]
[13:35:14] <lynxlynxlynx> yeah, i'm not sure if we cap it or not
[13:36:15] <lynxlynxlynx> i don't know about the next release, it feels too soon now
[13:36:47] <lynxlynxlynx> and bg2 is broken
[13:36:47] <lynxlynxlynx> so i'd say sometime in july
[13:37:23] --> brad_a has joined #gemrb
[13:41:24] <brad_a> i see that avenger fixed that stnuprcopy bug i reported for walk sound. thank you
[13:41:24] <CIA-39> GemRB: 03avenger_teambg * rc6e583379b3e 10gemrb/gemrb/GUIScripts/ (bg2/GUICommonWindows.py iwd/GUICommonWindows.py): Quick spell customisation in iwd/how
[13:41:44] <Avenger> yep, thanks for reporting
[13:42:28] --> edheldil_ has joined #gemrb
[13:47:04] <CIA-39> GemRB: 03avenger_teambg * r1ee726db77c3 10gemrb/gemrb/GUIScripts/bg1/GUICommonWindows.py: quickspell customisation in bg1
[13:52:46] --> Bo_Thomsen has joined #gemrb
[14:14:22] <-- Avenger has left IRC (Quit: bye!)
[14:51:53] <-- Maighstir has left IRC (Quit: ~ Trillian Astra - www.trillian.im ~)
[14:52:37] <-- edheldil_ has left IRC (Ping timeout: 250 seconds)
[14:56:08] --> Maighstir has joined #gemrb
[15:01:27] --> edheldil_ has joined #gemrb
[15:07:34] <-- edheldil_ has left IRC (Read error: Operation timed out)
[15:09:17] --> test32894789234u has joined #gemrb
[15:43:57] <lynxlynxlynx> -Weffc++ is useless too
[15:45:44] <lynxlynxlynx> http://pastebin.com/aP0g35Vt <-- can't figure this one out
[15:46:11] <lynxlynxlynx> all the members are initialised, yet it still complains
[15:54:22] <Gekz> lol canary
[15:54:26] <Gekz> is that used to check for data corruption?
[15:56:00] <lynxlynxlynx> yes
[15:56:07] <Gekz> Also! If you're considering a path from Python2 to Python3, do not consider it.
[15:56:19] <Gekz> lol at the amount of work even converting simple scripts that use strings is
[15:59:26] <lynxlynxlynx> you do know py3 bundles a conversion script that takes care of the boring bits?
[16:00:07] <Gekz> the boring bits are usually being wrongly converted anyway
[16:00:20] <Gekz> like when it converts your use of somedict.items() into list(somedict.items())
[16:00:28] <Gekz> when in python2 you were meant to be using somedict.iteritems()
[16:00:38] <Gekz> 2to3 is a crutch basically.
[16:00:55] <lynxlynxlynx> still helpful for the silly print change
[16:08:18] <Gekz> so is a regex
[16:08:24] <Gekz> :P
[16:09:06] <Gekz> s/print (.*)/print\(1\)/g
[16:10:09] <lynxlynxlynx> that would work only for singlelined prints (if it did what you wanted to write)
[16:10:39] <Gekz> if you're doing multi-lined prints, you're hurting Python anyway
[16:12:00] --> spike411 has joined #gemrb
[17:13:36] --> barra_away has joined #gemrb
[17:16:52] <-- barra_home has left IRC (Ping timeout: 255 seconds)
[17:53:40] <-- devurandom has left IRC (Remote host closed the connection)
[17:57:24] <-- spike411 has left IRC (Quit: Manga & anime pokec na Jabberu: manga.cz@conf.netlab.cz)
[17:57:55] --> devurandom has joined #gemrb
[18:52:06] <-- test32894789234u has left #gemrb
[19:42:40] --> phuus has joined #gemrb
[19:55:08] <-- phuus has left IRC (Quit: So long and thanks for all the fish!)
[20:47:23] <-- Maighstir has left IRC (Quit: ~ Trillian Astra - www.trillian.im ~)
[21:30:07] --> raevol has joined #gemrb
[22:21:01] <brad_a> I have a hopefully easy question
[22:21:23] <brad_a> how would i go about spacing out the dialgue choices to be more touch screen friendly?
[22:21:40] <brad_a> perhaps increase the font size a tick as well
[22:41:30] <lynxlynxlynx> get the font mod
[22:41:34] <lynxlynxlynx> it increases the size
[22:41:38] <brad_a> ah
[22:41:56] <brad_a> what about the spacing? font->print in textedit.cpp?
[22:42:02] <lynxlynxlynx> spacing them manually probably wouldn't help much or worse, inducing scrollbars
[22:42:59] <brad_a> right now they are so close that there will be so rage inducing playing going on with a touchscreen
[22:43:00] <-- lynxlynxlynx has left IRC (Read error: Connection reset by peer)