#gemrb@irc.freenode.net logs for 11 May 2010 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage


[00:38:10] --> Gekz has joined #GemRb
[01:17:44] <-- tombhadAC has left IRC (Quit: Verlassend)
[01:29:08] <-- Gekz has left IRC (Quit: This computer has gone to sleep)
[03:02:15] <-- fuzzie has left IRC (Ping timeout: 240 seconds)
[03:03:11] --> fuzzie has joined #GemRb
[04:26:23] <-- Nomad010 has left IRC (Ping timeout: 265 seconds)
[04:32:26] --> raevol has joined #GemRb
[05:45:02] --> Gekz has joined #GemRb
[06:03:56] --> cubathy has joined #GemRb
[06:23:10] <-- Gekz has left IRC (Quit: This computer has gone to sleep)
[06:39:02] --> Gekz has joined #GemRb
[06:43:13] <-- Gekz has left IRC (Client Quit)
[06:53:19] <-- raevol has left IRC (Quit: Leaving.)
[08:48:18] <-- cubathy has left IRC (Ping timeout: 258 seconds)
[08:49:52] <-- |Cable| has left IRC (Remote host closed the connection)
[08:53:08] --> lynxlynxlynx has joined #GemRb
[08:53:08] --- ChanServ gives channel operator status to lynxlynxlynx
[09:02:03] --> cubathy has joined #GemRb
[10:12:37] --> Gekz has joined #GemRb
[10:58:17] <-- Gekz has left IRC (Quit: This computer has gone to sleep)
[11:17:33] --> Gekz has joined #GemRb
[11:18:11] <-- cubathy has left IRC (Ping timeout: 258 seconds)
[11:18:32] --> Gekz_ has joined #GemRb
[11:31:33] --> cubathy has joined #GemRb
[12:30:09] --> Nomad010 has joined #GemRb
[12:31:01] <-- cubathy has left IRC (Ping timeout: 258 seconds)
[12:58:14] <-- Gekz_ has left IRC (Ping timeout: 265 seconds)
[12:58:59] --> Gekz_ has joined #GemRb
[14:15:41] --> kettuz has joined #GemRb
[14:45:44] --> tomprince_loki has joined #GemRb
[14:48:58] <-- tomprince_loki has left IRC (Client Quit)
[14:49:21] --> tomprince_loki has joined #GemRb
[14:51:33] <-- tomprince_loki has left IRC (Client Quit)
[15:04:00] --> tomprince_loki has joined #GemRb
[15:43:22] <-- tomprince_loki has left IRC (Ping timeout: 246 seconds)
[16:03:34] --> tomprince_loki has joined #GemRb
[16:16:59] <-- tomprince_loki has left IRC (Read error: No route to host)
[16:56:14] --> tomprince_loki has joined #GemRb
[17:14:32] <CIA-13> GemRB: 03lynxlupodian * r2a9414757401 10gemrb/gemrb/core/Actor.cpp:
[17:14:32] <CIA-13> GemRB: Actor::SetModal now toggles the state to MS_NONE when the new state is the
[17:14:32] <CIA-13> GemRB: same as the old one, resulting also in proper action bar refreshing.
[17:16:59] <fuzzie> that breaks scripts, no?
[17:19:20] <fuzzie> most of those SetModal calls aren't toggles
[17:19:41] <fuzzie> i thought
[17:20:02] <lynxlynxlynx> with that code only if they get called with the same value twice and only for party members
[17:20:26] <fuzzie> which is going to break AI scripts, no?
[17:20:51] <fuzzie> i mean, we could fix the relevant callers to check the modal state first
[17:20:58] <fuzzie> and i'm not sure which are which
[17:21:29] <fuzzie> i'm just curious why it would be better to do it this way
[17:21:56] <lynxlynxlynx> ai scripts keep setting the state in some kind of loop?
[17:22:34] <fuzzie> "if <situation where we should be in state> { set state }" type things
[17:22:36] <lynxlynxlynx> this way things are centralised, since we'll also be displaying messages, not just updating the state
[17:23:09] <lynxlynxlynx> sounds easier to update the callers with a "force" parameter
[17:23:31] <fuzzie> ok.
[17:23:40] <fuzzie> rename the function to ToggleModal, then?
[17:23:58] <fuzzie> i mean, that's not a request, a question
[17:24:52] <lynxlynxlynx> to me both names are bad for the new functionality
[17:29:29] <fuzzie> yes. hm :)
[17:29:43] <fuzzie> oh well. you'll add the messages?
[17:29:50] <lynxlynxlynx> but of those two, i prefer the current
[17:29:54] <lynxlynxlynx> yes
[17:30:07] <lynxlynxlynx> all the callers from actions should do no toggling then, right?
[17:30:36] <lynxlynxlynx> most of them are such, so i'll default the thing to off
[17:35:34] <fuzzie> i think almost all of them are calling with NONE anyway, so it's not that important
[17:37:22] <lynxlynxlynx> yep, there's a surprising little number of changes to be made
[17:38:00] <fuzzie> i just think the guiscript side will be confusing
[17:38:22] <fuzzie> but maybe i am easily confused today
[17:38:38] <lynxlynxlynx> imho it is clearer this way than exposing the state to them
[17:40:46] --> |Cable| has joined #GemRb
[17:42:37] <-- Gekz_ has left IRC (Quit: This computer has gone to sleep)
[18:05:26] <-- Nomad010 has left IRC (Ping timeout: 246 seconds)
[18:05:38] --> Nomad010 has joined #GemRb
[18:26:55] <CIA-13> GemRB: 03lynxlupodian * r485023288d4b 10gemrb/gemrb/ (4 files in 2 dirs):
[18:26:55] <CIA-13> GemRB: added a "force" parameter to SetModal, since actions don't expect toggling
[18:26:55] <CIA-13> GemRB: and updated the few callers that explicitly want it
[18:33:37] <fuzzie> thanks. bit busy tonight, sorry
[18:34:00] <fuzzie> almost free of lectures now..
[18:35:52] <lynxlynxlynx> cool
[18:36:29] <lynxlynxlynx> no need to feel sorry either
[18:39:17] <fuzzie> well, i am complaining but not really paying attention :) but thanks
[18:40:56] <lynxlynxlynx> complaining/peer review :)
[18:41:48] <lynxlynxlynx> we all know how torn you are when doing stuff you have to instead of stuff you want to
[18:42:27] <lynxlynxlynx> luckily there's also procrastination besides the two extreme solutions :)
[18:55:54] <-- tomprince_loki has left IRC (Read error: Connection reset by peer)
[18:58:38] --> tomprince_loki has joined #GemRb
[19:13:57] <-- tomprince_loki has left IRC (Read error: Connection reset by peer)
[19:39:22] <lynxlynxlynx> hmm, iwd2 appears to have hidden kits
[19:39:42] <lynxlynxlynx> there are strings for at least some bard kits, maybe more
[20:03:43] <-- Nomad010 has left IRC (Ping timeout: 240 seconds)
[21:46:38] <-- kettuz has left IRC (Quit: Leaving)
[22:12:44] <CIA-13> GemRB: 03lynxlupodian * r983bab4aa4c8 10gemrb/gemrb/docs/en/GUIScript/SetModalState.txt: SetModalState.txt: documented the third parameter
[22:12:47] <CIA-13> GemRB: 03lynxlupodian * re086c89b7898 10gemrb/gemrb/includes/strrefs.h: strrefs.h: fixed entering/leaving shadows order
[22:20:01] <lynxlynxlynx> i've got the printing working too, but it needs a bit off cleaning first
[22:20:40] <fuzzie> neat
[22:21:32] <lynxlynxlynx> it's silly how big a change was needed for that
[22:21:59] <lynxlynxlynx> http://pastebin.com/qhj3yBLj
[22:22:43] <lynxlynxlynx> i need to figure out if the string will be useful in the core at all - maybe it makes no sense to have them there
[22:23:52] <lynxlynxlynx> modifying strings.2da is easier on potential modders, but not that much (vs. knowing to modify modal.2da)
[22:24:46] <fuzzie> isn't the coming-out-of-shadows going to need to be in the core, at least?
[22:25:52] <fuzzie> (why not just make ModalSpells a vector?)
[22:32:32] <lynxlynxlynx> i think it can all be in that table, also the one for the failed attempt if need be (but it is only needed for hiding)
[22:33:00] <lynxlynxlynx> what would be the benefit of storing it as a vector?
[22:34:45] <lynxlynxlynx> ah, it is faster
[22:35:16] <lynxlynxlynx> linear vs. logarithmic for searching
[22:36:11] <fuzzie> well, it would also make for simpler code :) i don't think the performance will be a problem at all
[22:37:31] <lynxlynxlynx> not at this scale, sure, but it is a matter of principle and good design, no?
[22:38:59] <fuzzie> well, i would argue that the code you're happier with is the better design
[22:40:36] <lynxlynxlynx> i don't know the internals of the two and with current use, there is no difference, but there may be small side effects
[22:40:58] <lynxlynxlynx> like maybe map pulls in more headers than vector (ok, we already include both)
[23:03:45] <-- lynxlynxlynx has left IRC (Remote host closed the connection)