[00:28:18] <-- edheldil_ has left IRC (Ping timeout: 264 seconds)
[01:11:00] <-- rocket_hamster has left IRC ()
[03:26:33] <-- CIA-44 has left IRC (Ping timeout: 272 seconds)
[06:45:56] --- DrMcCoy is now known as MrSpock
[06:46:07] --- MrSpock is now known as DrMcCoy
[06:50:19] --> edheldil has joined #gemrb
[06:50:25] --- ChanServ gives channel operator status to edheldil
[06:51:04] --> lynxlynxlynx has joined #gemrb
[06:51:05] <-- lynxlynxlynx has left IRC (Changing host)
[06:51:05] --> lynxlynxlynx has joined #gemrb
[06:51:05] --- ChanServ gives channel operator status to lynxlynxlynx
[06:51:09] <fuzzie> morning
[06:58:06] <edheldil> Hi, fuzzie
[07:00:27] <fuzzie> so about last night, I don't see how the PlayMovie works
[07:00:44] <fuzzie> as documented, the check in it should be 'if (!flag)'
[07:01:53] <lynxlynxlynx> gmornin
[07:02:10] <fuzzie> but of course if you do that it breaks all the other uses, so .. in what situation should PlayMovie not play a movie if it was already set in the ini?
[07:02:18] <lynxlynxlynx> when in doubt, don't touch it if it works :)
[07:02:32] <fuzzie> well it doesn't work in iwd2 because you can't play movies more than once, so it's bugging me :-p
[07:02:50] <lynxlynxlynx> there is no ini storage limit
[07:02:53] <fuzzie> but because PlayMovie in the iwd2 GUIScript is passing 0 as the flag
[07:03:07] <lynxlynxlynx> movies are stored there just as a list of which you can then replay through the movies menu
[07:03:20] <lynxlynxlynx> to avoid spoilers they are added as you play
[07:03:27] <fuzzie> which is the only GUIScript which passes a flag!=1 which isn't "CREDITS"
[07:03:33] <fuzzie> right, but the list is handled on the GUIScript side :)
[07:03:48] <fuzzie> and this is the inverse logic: it *doesn't* play the movie if it's already listed
[07:04:50] <fuzzie> but the documentation is clearly wrong, and so is the iwd2 guiscript I guess
[07:05:22] <fuzzie> leaving me still wondering why this should ever be used
[07:06:33] <lynxlynxlynx> i don't have any movies section in the ini; i can play the intros , one chapter and the final movie :s
[07:06:43] <fuzzie> try playing them more than once
[07:07:00] <fuzzie> after gemrb helpfully adds them to the internal ini
[07:07:20] <fuzzie> well, try playing the intro specifically I guess
[07:07:58] <lynxlynxlynx> yeah, doesn't repeat
[07:08:21] <edheldil> iirc start script juct checked the flags itself and either played the movies or not - there were not check in the engine itself, that's stupid
[07:08:44] <fuzzie> well, I can't think of any reason why we need the PlayMovie core code to check this, ever
[07:09:31] <fuzzie> 04fdb29d1063eaa69eaae5b91d53bc2eddbf0a7c dates back to 2005 though
[07:10:14] <fuzzie> and that's right after 5a2993dd9442c6895461aa2cd5b5e2be3514772c which does the checks in the start script :)
[07:13:02] <fuzzie> will have to put it on the list to ask Avenger.
[07:13:26] <edheldil> hmm, github can't show specific commits??
[07:13:34] <fuzzie> it can
[07:13:53] <edheldil> other than by manually editing url?
[07:13:59] <fuzzie> oh, well, probably not
[07:14:26] <fuzzie> I think manually editing the url is expected. :P You can also e.g. add .patch to the end to get a git-am style patch, or .diff for a plain diff.
[07:14:43] <wose_> oh is there a official copy of the gemrb repo on github?
[07:15:00] <fuzzie> yes, mirrored to https://github.com/gemrb
[07:16:24] <wose_> thx
[07:17:46] <edheldil> fuzzie: looks like a bug, the flag is clearly ignored :)
[07:18:23] <fuzzie> well, predictably he fixed that later on
[07:18:32] <fuzzie> in the opposite way to as documented
[07:18:38] <fuzzie> so my head explodes at that point, really
[07:20:39] <edheldil> should be if (!flag or !ind) PlayMovie(...)
[07:21:38] <edheldil> if (!flag || !ind) of course
[07:22:26] <lynxlynxlynx> or would actually work, just not for avenger
[07:22:46] <fuzzie> edheldil: but of course almost all GUIScript calls set flag==1 now :-p
[07:24:20] <edheldil> eh :)
[07:24:27] <edheldil> st. to fix, then :)
[07:25:11] <edheldil> they should use it only when playing in-game movies
[07:25:48] <fuzzie> well, if you have some idea of when that should happen .. is it a pst thing?
[07:25:50] <edheldil> why do they use flag if it was ignored? Strange ...
[07:26:09] <fuzzie> Later it was fixed to check if (flag).
[07:26:12] <fuzzie> 'fixed' I should say.
[07:26:18] <edheldil> to be frank, I am not sure when it happens
[07:26:26] <edheldil> ah
[07:26:35] <fuzzie> ok, so I guess none of us are quite sure :-)
[07:26:39] <fuzzie> pst seems like possibility though
[07:27:21] <edheldil> well, I have a feeling that the intro plays always
[07:27:31] <edheldil> iirc
[07:27:36] <fuzzie> yes, I think the intro+outro always play
[07:27:39] <fuzzie> so I am left wondering what doesn't
[07:28:31] <edheldil> exactly - I wanted to say that's easy and then I realized I do not remember any such opportunity :)
[07:29:11] <edheldil> so, my gut feeling is to fix the check and then remove most/all usages of the flag
[07:32:09] <edheldil> specifically, I think that it should not have anything to do with the INI var, but should check some game var, if there's any (and not a GameScript for it already)
[07:32:35] <edheldil> e.g. the shadows movie is probbaly played just once
[07:32:59] <edheldil> but imo it should play again if you start a new game
[07:33:07] <fuzzie> seems that it should really be in python
[07:33:19] <fuzzie> if not in gamescript
[07:33:40] <fuzzie> but this is in GUIScript code anyway so hopefully it should only be for python calls, right..? I am feeling lost
[07:34:13] <edheldil> unless the guiscript is called from gamescript as a quick hack :)
[07:35:15] <edheldil> so ... if you can, fix the check and remove the flag usage from regular movie playing
[07:36:06] <edheldil> I would think the check should be in GameScript ...
[07:36:12] <fuzzie> yes
[07:36:46] --> edheldil_ has joined #gemrb
[07:38:08] <edheldil> hehe, there're indeed Play_Throne_Movie, Played_Shadow_Movie and Played_Sigil_Movie vars
[08:09:25] <-- wrotek has left IRC (Ping timeout: 246 seconds)
[08:50:25] --> wrotek has joined #gemrb
[09:48:38] <-- wrotek has left IRC (Read error: Connection reset by peer)
[09:50:29] --> Husar1 has joined #gemrb
[09:51:03] <lynxlynxlynx> ok, done with regurgitating that series
[09:51:21] <lynxlynxlynx> ctrl-c is now working again, just use it twice
[11:08:49] --> rocket_hamster has joined #gemrb
[11:09:36] <edheldil> lynxlynxlynx: if you haven't done it already, maybe you could write to console st. like "Press Ctrl-C again to quit"
[11:10:46] <lynxlynxlynx> could be helpful, yes
[12:49:18] --> barra_home has joined #gemrb
[12:52:49] --> barra_away has joined #gemrb
[12:56:14] <-- barra_home has left IRC (Ping timeout: 240 seconds)
[13:44:41] <lynxlynxlynx> grrr, how i got trolled
[13:45:00] <lynxlynxlynx> bg2 has a separate bunch of scripts for guiopt while outside the game
[13:45:14] <lynxlynxlynx> no wonder my changes had no effect
[13:45:49] <fuzzie> :/
[13:51:44] <edheldil> hehe
[14:01:05] <-- kida_laptop has left IRC (Quit: 전 이만 갑니다.)
[14:01:21] --> kida_laptop has joined #gemrb
[15:00:18] <-- rocket_hamster has left IRC (Read error: No route to host)
[16:06:39] <-- Husar1 has left IRC (Quit: Husar1)
[16:07:10] <-- edheldil_ has left IRC (Ping timeout: 272 seconds)
[16:40:13] --- barra_away is now known as barra_home
[17:03:31] --> rocket_hamster has joined #gemrb
[17:06:27] --> gembot has joined #gemrb
[17:13:27] <lynxlynxlynx> is it just me or is sf not sending mail today
[17:46:26] --- barra_home is now known as barra_away
[17:57:15] <-- duckpunch has left IRC (Ping timeout: 244 seconds)
[17:58:22] --> duckpunch has joined #gemrb
[18:22:25] <tomprince> brada: Your slave should be able to connect now.
[18:22:39] --> Yoshimo has joined #gemrb
[18:53:15] --> edheldil_ has joined #gemrb
[18:59:43] <-- rocket_hamster has left IRC ()
[19:10:22] <-- gembot has left IRC (Remote host closed the connection)
[19:10:45] --> gembot has joined #gemrb
[20:11:13] <lynxlynxlynx> gembot: unmute
[20:11:13] <gembot> You hadn't told me to be quiet, but it's the thought that counts, right?
[20:11:21] <lynxlynxlynx> heh
[20:14:33] <lynxlynxlynx> everything looks fine :)
[20:19:28] <tomprince> Except osx isn't working.
[20:23:37] <lynxlynxlynx> but it's all in brad's hands
[20:24:07] <lynxlynxlynx> from the build perspective just an include directive is missing
[20:24:16] <lynxlynxlynx> thanks for bringing it back up
[21:00:26] <-- Yoshimo has left IRC (Quit: Yoshimo)
[21:22:50] <-- barra_away has left IRC (Quit: Verlassend)
[22:39:09] <-- lynxlynxlynx has left IRC (Remote host closed the connection)
[22:47:19] --> CIA-45 has joined #gemrb