#gemrb@irc.freenode.net logs for 14 Jan 2012 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage


[00:08:19] <Baldurer> ok
[00:09:54] <Baldurer> my thought was that it might have something to do with the bug that makes some items disappear when put into the bag of holding, and some scrolls disappear when put in scroll cases
[00:10:24] <tomprince> Baldurer: Maybe it does. I think avenger said that the item was getting a temporary flag.
[00:36:56] <-- Drakkar has left IRC (Ping timeout: 260 seconds)
[00:38:03] <-- kettuz has left IRC (Quit: Leaving)
[00:39:25] --> Drakkar has joined #gemrb
[00:54:43] --> PixelScum has joined #gemrb
[00:57:15] <-- Drakkar has left IRC (Ping timeout: 248 seconds)
[01:00:35] <-- brad_a has left IRC (Quit: brad_a)
[01:01:09] --> brad_a has joined #gemrb
[01:01:23] <-- brad_a has left IRC (Client Quit)
[01:07:24] --> Drakkar has joined #gemrb
[01:10:09] <-- PixelScum has left IRC (Ping timeout: 245 seconds)
[01:19:19] --> PixelScum has joined #gemrb
[01:20:55] --> scriptedfate has joined #gemrb
[01:21:49] <-- Drakkar has left IRC (Ping timeout: 245 seconds)
[01:22:02] <scriptedfate> So, tomprince, as I mentioned on the forum, I think I've found something that may take care of it
[01:22:14] <scriptedfate> it == the std:: vs :: problem
[01:24:26] --> brad_a has joined #gemrb
[01:24:36] <scriptedfate> brad_a, you may be interested as well
[01:24:43] <brad_a> sure
[01:24:52] <brad_a> lets hear
[01:24:59] <scriptedfate> Basically, if I change the preprocessor from cpp to gpp, std:: is in ::
[01:25:10] <scriptedfate> as well as std::
[01:25:22] <brad_a> what is gpp?
[01:25:32] <scriptedfate> general purpose preprocessor
[01:26:11] <scriptedfate> ( I think )
[01:27:27] <scriptedfate> Unfortunately I don't know if I can do this in the IDE or if it will finally force me into the arms of Make
[01:27:50] <brad_a> seems odd. i wasnt aware the preprocessor did any of that
[01:28:09] <scriptedfate> (which I thought I was going to have to do anyway in order to build the plugins as dynamic libraries without giving them each their own project
[01:28:15] <scriptedfate> Indeed it's odd
[01:28:45] <scriptedfate> The only thing I can think of is that the qcc conf file is using a naming convention that evokes preprocessor namings, but in fact has some other side-effect
[01:29:26] <scriptedfate> (basically, qcc is a family of preprocessors, compilers, assemblers, and linkers. To figure out which one goes where and does what, it relies on .conf files that are evoked by the -V argument
[01:29:47] <scriptedfate> For the IDE, this is hardcoded as -V4.4.2,gcc_nto<arch>_cpp
[01:30:10] <scriptedfate> At work, we use -V4.6.2,gcc_nto<arch>_gpp
[01:30:31] <scriptedfate> (mostly because 4.4.2 wouldn't compile the large assembler jumps needed for latest libs
[01:30:34] <scriptedfate> But I digress
[01:31:15] <scriptedfate> The point is, we can ignore the flagrant violations of 17.6.1.1 paragraph 2 statement 167
[01:31:20] <scriptedfate> or was that 176...
[01:31:21] <scriptedfate> anyhoo
[01:32:15] <scriptedfate> This means I'll instead be making changes to the external build and relying on cross-configure to get things right
[01:37:12] <brad_a> sounds good
[01:37:52] <scriptedfate> brad_a, do you know if any of the other platform builds use toolchain files for configuring cmake to cross-compile?
[01:38:37] <brad_a> im pretty sure cmake can build for ios so yes i think so
[01:38:50] <brad_a> or are you talking gemrb specifically
[01:38:59] <scriptedfate> I'm talking gemrb specifically :)
[01:39:25] <brad_a> im not familiar with any builds not using xcode or cmake
[01:39:33] <brad_a> im sure there are many tho
[01:39:42] <scriptedfate> dangity
[01:39:47] <brad_a> since our cmake scripts are basically nix/win/mac
[01:40:05] <scriptedfate> Well, that's 90% right there
[01:40:51] <brad_a> im not sure how beholder builds android
[01:42:27] <scriptedfate> If he builds on nix for android, he might just get away with clever aliases
[01:43:10] <brad_a> no. he uses windows iirc
[01:45:25] <scriptedfate> Hmm... if he uses their IDE, he might have project files kicking around... but otherwise I'm lost
[01:48:05] <tomprince> scriptedfate: Everything can be linked statically.
[01:48:30] <scriptedfate> tomprince, but they still need to be built separately
[01:48:59] <scriptedfate> Right now the IDE thinks that the plugins folder is just a source folder for the same deliverable
[01:49:09] <scriptedfate> and I haven't been able to dissuade it of that notion
[01:49:28] <scriptedfate> So either I need to find or fabricate SDL_mixer SDL_ttf and vorbis so that _every_ plugin can build
[01:49:33] <scriptedfate> Or I need to rethink
[01:50:43] <tomprince> Can you not tell it which files to build?
[01:50:58] <tomprince> If you don't care about SDL_mixer SDL_ttf and vorbis, just don't build them.
[01:51:29] <tomprince> Are you sure gpp isn't picking up host includes (I am guessing you are cross-compiling.
[01:56:33] <scriptedfate> I'm reasonably certain that gpp isn't picking up the host includes as I specifically only include target includes in the include path
[01:56:42] <scriptedfate> tomprince, fair enough
[01:57:17] <scriptedfate> Regardless, I need to switch the -V flag. And if the IDE will not let me, then I'll have to change toolchain, and cmake looks like a good place to land
[01:57:54] <tomprince> We'll take patches, to support cross builds out of the box ...
[01:59:08] <scriptedfate> Awesome :)
[01:59:26] <scriptedfate> What's even nicer is that qcc takes the last -V flag as gospel... I've got it mostly building :)
[02:03:06] <scriptedfate> Uhh... is this a bug?
[02:03:24] <scriptedfate> SDLVideo.cpp:2514 dest->XPos = dest->XPos; ?
[02:03:37] <scriptedfate> shouldn't that be dest->XPos = sprite->Xpos?
[02:03:47] <scriptedfate> s/Xpos/XPos/
[02:06:57] <brad_a> ha ha yeah
[02:07:05] <brad_a> where is that used i wonder..
[02:07:32] <brad_a> well its used in plenty of places...
[02:09:36] <brad_a> well it looks like it doesnt actually matter
[02:11:07] <scriptedfate> considering it duplicates the sprite first?
[02:11:13] <brad_a> yes
[02:11:29] <brad_a> so the else part probably doesnt matter for the same reason
[02:11:31] <scriptedfate> Would a patch fixing it (removing it) be accepted?
[02:11:31] <-- Maighstir has left IRC (Quit: .)
[02:11:39] <brad_a> i dont see why not
[02:11:55] <scriptedfate> Alrighty... which brings me to the question: how is that done?
[02:12:11] <brad_a> git format-patch
[02:12:13] <scriptedfate> I know the github model of develop on a fork, submit pull request, merge
[02:12:22] <brad_a> we do that too
[02:12:26] <brad_a> i think
[02:12:38] <scriptedfate> And I know the webkit model of git format-patch, upload to tracker, r+
[02:12:41] <brad_a> i always use format-patch
[02:12:50] <scriptedfate> Do we have dedicated committers?
[02:12:57] <brad_a> but tomprince i think prefers to merge remotes
[02:13:26] <brad_a> oh i always just uploaded to dropbox and pasted a link here
[02:13:32] <scriptedfate> How do you resolve the sf and github mirrors? Are they automagically bidirectionally mirrored?
[02:13:36] <brad_a> lynx is our dedicated everything
[02:13:49] <scriptedfate> lynx is GMT ~ 0, though, yes?
[02:13:54] <brad_a> no
[02:13:54] <tomprince> Nah, github is only occaisonally synced.
[02:14:00] <brad_a> he is gmt+ somesuch
[02:14:11] <tomprince> probably ~+2/3 or so
[02:14:16] <scriptedfate> Iceland?
[02:14:18] <brad_a> and is currently on holiday i believe
[02:14:20] <scriptedfate> Portugal?
[02:14:40] <brad_a> no slovenia (hope i spelled that right so i dont embarass myself)
[02:14:48] <scriptedfate> Ah, GMT - 2/3
[02:14:53] <brad_a> embarrass >_<
[02:15:05] <scriptedfate> And you got Slovenia right except the caps
[02:15:18] <scriptedfate> Wait, no
[02:15:28] <scriptedfate> I embarrassed myself.
[02:15:31] <brad_a> lol
[02:15:46] <scriptedfate> UTC+1
[02:15:55] <scriptedfate> I'm on the minus side. Always get those backwards
[02:15:59] <brad_a> that sounds right
[02:16:13] <scriptedfate> (For my brother it doesn't matter, he's +/- 12 from me in Taiwan :)
[02:16:39] <scriptedfate> So... someone develops a patch, formats it, hosts it someplace, then posts the link to #gemrb
[02:16:56] <brad_a> that is one way
[02:17:00] <scriptedfate> Then presumably someone goes over it for r+/-. If r- GOTO 10
[02:17:05] <scriptedfate> If r+, then...
[02:17:16] <scriptedfate> Another way?
[02:17:33] <brad_a> well doing the commits in your on github fork :-P
[02:17:44] <brad_a> then we can look and pull them in
[02:18:53] <scriptedfate> To the out-of-date repo
[02:19:08] <brad_a> ?
[02:19:20] <scriptedfate> tomprince said that github is only occasionally synced
[02:19:29] <brad_a> you should fork fuzzies repo then add sf as a master and pull from it to bring it upto date
[02:19:51] <brad_a> or just clone sf then push to github
[02:20:19] <tomprince> Well, I tend to push a copy of what is on sf to my github fork, when I push something to github.
[02:24:38] <brad_a> tomprince: instead of that asset how about this: MouseFlags = (core->MouseFeedback & 0x03);
[02:25:20] <brad_a> assert
[02:25:23] <brad_a> bah
[02:25:59] <scriptedfate> brad_a, tomprince, r? https://github.com/fuzzie/gemrb/pull/1
[02:27:05] <scriptedfate> Oops, man, I should've read here before the request
[02:27:13] <scriptedfate> Let me make a pull request to sync fuzzie up first
[02:27:25] <brad_a> what about the unnecessary else?
[02:27:38] <brad_a> yes fuzzies fork is terribly out of date
[02:28:43] <tomprince> and the analagous code in MirrorHorizontal.
[02:28:52] <brad_a> ah that too
[02:28:56] <brad_a> may as well get it all
[02:29:29] <scriptedfate> brad_a, that else appears to actually do something (flipping the flip_ver (whatever that is))
[02:30:00] <tomprince> scriptedfate: We don't really use github pull requests.
[02:30:12] <brad_a> the bottom else
[02:30:26] <brad_a> the one that does dest->YPos = sprite->YPos
[02:30:39] <brad_a> dest->Ypos will already be = to sprite-<ypos
[02:30:51] <scriptedfate> tomprince, brad_a r? https://github.com/fuzzie/gemrb/pull/2
[02:31:07] <scriptedfate> So... now I'm confused. What is the preferred workflow?
[02:31:18] <scriptedfate> brad_a, *facepalm* of course. Le duh.
[02:31:44] <brad_a> workflow is a good question
[02:31:50] <brad_a> nobody has told me preference
[02:32:11] <tomprince> Most people have commit access to sf, so people just push there.
[02:32:13] <brad_a> sometime people ask to see a branc sometimes its format-patch
[02:32:24] <tomprince> And sometimes ask for comments on patches here.
[02:32:39] <scriptedfate> push no review?
[02:32:41] <scriptedfate> Ouch.
[02:32:49] * scriptedfate is welcomed to the Wild West
[02:32:52] <scriptedfate> :)
[02:32:54] <brad_a> :)
[02:32:55] <tomprince> For people that don't, post branches or patch series here, and convince somebody to push.
[02:33:13] <tomprince> Well, at least we have a buildbot. Not that it tests much.
[02:33:15] <brad_a> even tho i have write access i still ask for peer review
[02:33:20] <brad_a> for good reason too ;-)
[02:33:27] <scriptedfate> brad_a, good on ya
[02:33:57] <tomprince> scriptedfate: We don't have the resource to do peer-review.
[02:34:49] <brad_a> despite gemrb being very large and very complete (compared to most similar projects) there arent a lot of developer
[02:34:50] <brad_a> s
[02:34:57] <tomprince> There are about 7 developers, 3 of whom are active, and 2 how just kibbitz occasionally.
[02:36:09] <scriptedfate> Well, with such numbers at least it's not likely that you'll have groups working at cross purposes
[02:36:16] <tomprince> It'd be great if we had enough people with enough time and knowledge of the inner workings of IE, to have thorough peer review.
[02:36:34] <brad_a> also i think it best to move dest = duplicate … to the top
[02:36:34] <brad_a> since it is currently in both the if and the else
[02:36:53] <brad_a> thats the other problem
[02:37:02] <brad_a> not many have super deep knowledge
[02:38:17] <brad_a> tomprince: is there a reason for the times i see x = 0; instead of x = NULL; when x is a pointer?
[02:38:26] <tomprince> no.
[02:38:33] <tomprince> Not that I am aware.
[02:38:33] <brad_a> then change that as well :)
[02:39:09] <brad_a> i have certainly never seen a pointer initialized that way outside gemrb...
[02:39:34] <scriptedfate> brad_a, never look at webkit.
[02:39:44] <scriptedfate> Not sure why, but they prefer 0 to NULL
[02:39:45] <brad_a> aw but i love webkit
[02:39:52] <brad_a> o_O
[02:40:01] <brad_a> now im curious if there is a reason
[02:40:11] <brad_a> time to google
[02:40:15] <scriptedfate> They also prefer using namespace X to using X::name
[02:40:39] <scriptedfate> And prefer two-line ifs to three-line, despite the real danger of dangling else
[02:40:54] * scriptedfate has ranted on this before, at length, and will stop now
[02:41:53] <brad_a> for the null vs 0 thing i guess some older compilers blah blah blah
[02:42:33] <brad_a> apparently null is not always defined as 0
[02:42:37] <tomprince> NULL documents intent.
[02:42:57] <tomprince> If we were all fancy and c++11, it'd be nullptr.
[02:43:07] <brad_a> yes i saw that in my reading
[02:43:14] <tomprince> (Although NULL is still defined as 0).
[02:43:30] <scriptedfate> (in some compilers)
[02:43:37] <scriptedfate> (on some platforms)
[02:43:46] <scriptedfate> Okay, some = most if not all the ones you'll run across
[02:43:50] <brad_a> i actually always thought NULL was special and would evaluate to false no matter waht
[02:44:07] <scriptedfate> The only magical one is nullptr
[02:44:20] <brad_a> i learn something new everyday
[02:44:22] <tomprince> and the constant 0
[02:44:36] <scriptedfate> And it's not even really nifty magic like Argument-Dependent Name Lookup
[02:44:42] <tomprince> 0 is more magical that nullptr.
[02:44:57] <tomprince> But not in a good way. Just a backwards compatible one.
[02:45:01] <scriptedfate> It's how nullptr is less magical that makes it magical :)
[02:45:10] <tomprince> Yes.
[02:46:19] <scriptedfate> r? https://github.com/scriptedfate/gemrb/commits/mirror
[02:46:37] <scriptedfate> top three
[02:48:07] <brad_a> i would have just rolled them all into 1 patch but the changes look fine to me
[02:50:00] <tomprince> Looks good. But each commit message should stand on its own.
[02:50:28] <scriptedfate> I can squish 'em
[02:51:39] <tomprince> That'd probably make the most sense.
[02:53:13] <scriptedfate> Done and done. Same link, top
[02:55:13] <tomprince> scriptedfate: Is that the name and email you want to show up?
[02:57:56] <scriptedfate> Chris and scriptedfate@gmail.com? Sure
[02:58:12] <scriptedfate> ...unless there's more than one Chris?
[02:58:26] <brad_a> if htere is he isnt using his real name ;-)
[02:58:37] <scriptedfate> better make it Chris H-C
[02:58:43] <scriptedfate> Just to be on the safe side :)
[03:02:48] <tomprince> Do you want to update it?
[03:09:27] <scriptedfate> tomprince, it has been so updated
[03:09:32] <scriptedfate> *now
[03:13:12] --> Drakkar has joined #gemrb
[03:15:42] <CIA-36> GemRB: 03scriptedfate * rd0c645498f16 10gemrb/gemrb/plugins/SDLVideo/SDLVideo.cpp: Remove misleading statements and useless code, and factor out some common code.
[03:16:19] <brad_a> tomprince: i believe this addresses everything that was brought up: http://dl.dropbox.com/u/13866402/cursors.patch
[03:16:23] <scriptedfate> Wowza. My first real honest-to-goodness push
[03:16:26] <brad_a> tho i still need to test it
[03:16:29] <scriptedfate> to gemrb
[03:16:37] <-- PixelScum has left IRC (Ping timeout: 276 seconds)
[03:18:49] <tomprince> brad_a: You don't need the !!! warning in the config anymore. And it might be sensible to say that it is a bitfield, with the rest of the bits reserved.
[03:19:02] <brad_a> yes
[03:19:22] <brad_a> so the bitshift should work the way i expect?
[03:20:17] <tomprince> Also, thinking about it, I wonder if it makes sense to reverse the sense, so that the default is 0?
[03:20:54] <brad_a> you mean because the other flags disable?
[03:20:59] <brad_a> yes that is logical
[03:21:26] <tomprince> No, in case we add new flags, to be backwards compatible, the defaults for them will have to be 0.
[03:21:46] <brad_a> that too :-P
[03:21:57] <tomprince> You should also mask away everything we don't care about right now.
[03:21:57] <brad_a> ok i will inverse them
[03:22:11] <brad_a> ?
[03:22:49] <scriptedfate> And with that, I'm going to go be boring and get some sleep. G'night, all
[03:22:54] <-- scriptedfate has left IRC (Quit: Leaving)
[03:23:03] <tomprince> & 0x3
[03:23:09] <brad_a> oh
[03:23:43] <-- Baldurer has left IRC (Ping timeout: 244 seconds)
[03:23:50] <brad_a> yes theres no reason not to
[03:24:02] <brad_a> but then if we add new flags we have to remember
[03:24:13] <tomprince> Yes.
[03:24:44] <tomprince> Also, you should use > with a bitfield. (You do in PollEvents)
[03:25:21] <brad_a> yes i see
[03:25:55] <tomprince> s/should/shouldn't/ of course
[03:26:00] <brad_a> originally that workde but ive gon and switched flags around
[03:26:20] <brad_a> so i broke it
[03:26:38] <brad_a> i shall fix that and the other 2 things in the morning
[03:26:56] <brad_a> im not going to squander my entire friday night sober
[03:27:01] <brad_a> :) goodnigh
[03:27:06] <brad_a> thanks for the input
[03:27:16] <-- brad_a has left IRC (Quit: brad_a)
[03:30:28] <tomprince> I was also going to say 'MouseFlags & MOUSE_TOOLTIPS' instead of 'MouseFlags&MOUSE_TOOLTIPS', but it is about 1100 to 900 in favor of the later.
[03:32:29] <gembot> build #7 of autotools g++-4.5 is complete: Failure [failed minimal test] Build details are at http://buildbot.gemrb.org/builders/autotools%20g%2B%2B-4.5/builds/7 blamelist: scriptedfate@gmail.com
[03:51:09] <gembot> build #8 of autotools g++-4.5 is complete: Success [build successful] Build details are at http://buildbot.gemrb.org/builders/autotools%20g%2B%2B-4.5/builds/8
[05:58:26] --> PixelScum has joined #gemrb
[06:00:09] <-- Drakkar has left IRC (Ping timeout: 245 seconds)
[07:58:15] --> Drakkar has joined #gemrb
[08:01:19] <-- PixelScum has left IRC (Ping timeout: 276 seconds)
[08:23:24] --> PixelScum has joined #gemrb
[08:26:01] <-- Drakkar has left IRC (Ping timeout: 276 seconds)
[08:37:19] --> Drakkar has joined #gemrb
[08:40:08] <-- PixelScum has left IRC (Ping timeout: 240 seconds)
[08:43:14] --> Yoshimo has joined #gemrb
[09:43:04] --> PixelScum has joined #gemrb
[09:46:00] <-- Drakkar has left IRC (Ping timeout: 260 seconds)
[09:55:38] --> Drakkar has joined #gemrb
[09:58:50] <-- PixelScum has left IRC (Ping timeout: 260 seconds)
[10:07:24] --> PixelScum has joined #gemrb
[10:10:40] <-- Drakkar has left IRC (Ping timeout: 276 seconds)
[10:26:13] --> kettuz has joined #gemrb
[10:37:30] --> Drakkar has joined #gemrb
[10:40:20] <-- PixelScum has left IRC (Ping timeout: 252 seconds)
[11:00:06] --> PixelScum has joined #gemrb
[11:02:13] <-- Drakkar has left IRC (Ping timeout: 248 seconds)
[11:11:34] --> Drakkar has joined #gemrb
[11:14:11] <-- PixelScum has left IRC (Ping timeout: 252 seconds)
[11:50:07] --> Maighstir has joined #gemrb
[12:24:37] <CIA-36> GemRB: 03avenger_teambg * r612e93fd3363 10gemrb/gemrb/core/GameScript/GSUtils.cpp: properly initialize the expiration field in CreateItem, fixes the cause of bug #3473067
[12:24:37] <CIA-36> GemRB: 03avenger_teambg * r84487cf06998 10gemrb/gemrb/plugins/SDLVideo/SDLVideo.cpp: Merge branch 'master' of ssh://gemrb.git.sourceforge.net/gitroot/gemrb/gemrb
[12:33:41] <gembot> build #9 of autotools g++-4.5 is complete: Failure [failed minimal test] Build details are at http://buildbot.gemrb.org/builders/autotools%20g%2B%2B-4.5/builds/9 blamelist: avenger_teambg@sourceforge.net
[12:39:10] --> Baldurer has joined #gemrb
[13:01:07] <gembot> build #97 of nmake-msvc++10 is complete: Success [build successful] Build details are at http://buildbot.gemrb.org/builders/nmake-msvc%2B%2B10/builds/97
[13:16:16] <gembot> build #389 of mingw32 is complete: Exception [exception upload] Build details are at http://buildbot.gemrb.org/builders/mingw32/builds/389 blamelist: avenger_teambg@sourceforge.net
[14:50:35] <-- Yoshimo has left IRC (Quit: Yoshimo)
[15:29:45] <CIA-36> GemRB: 03avenger_teambg * r720095e38af5 10gemrb/gemrb/core/ (Game.cpp Game.h): meh, msvc6 doesn't like const char
[15:29:57] --> PixelScum has joined #gemrb
[15:32:08] <-- Drakkar has left IRC (Ping timeout: 252 seconds)
[15:46:30] <gembot> build #10 of autotools g++-4.5 is complete: Success [build successful] Build details are at http://buildbot.gemrb.org/builders/autotools%20g%2B%2B-4.5/builds/10
[16:01:40] --> Yoshimo has joined #gemrb
[16:16:41] --> Drakkar has joined #gemrb
[16:19:14] <-- PixelScum has left IRC (Ping timeout: 244 seconds)
[16:32:36] <-- demitar has left IRC (Ping timeout: 240 seconds)
[16:33:05] <gembot> build #397 of msvc++6 is complete: Success [build successful] Build details are at http://buildbot.gemrb.org/builders/msvc%2B%2B6/builds/397
[16:37:23] --> demitar has joined #gemrb
[16:38:58] --> PixelScum has joined #gemrb
[16:41:52] --> brad_a has joined #gemrb
[16:41:57] <-- Drakkar has left IRC (Ping timeout: 248 seconds)
[16:48:16] <-- demitar has left IRC (Ping timeout: 240 seconds)
[16:49:44] --> SiENcE has joined #gemrb
[16:50:04] --> demitar has joined #gemrb
[16:58:56] <-- demitar has left IRC (Ping timeout: 240 seconds)
[17:01:24] --> Drakkar has joined #gemrb
[17:03:59] <-- PixelScum has left IRC (Ping timeout: 260 seconds)
[17:41:51] --> lachlans has joined #gemrb
[17:50:30] <-- gembot has left IRC (Ping timeout: 248 seconds)
[18:06:32] <-- brad_a has left IRC (Read error: Connection reset by peer)
[18:08:50] --> brad_a has joined #gemrb
[18:14:07] --> demitar has joined #gemrb
[18:16:43] <CIA-36> GemRB: 03bradallred * r2e9354402d9c 10gemrb/gemrb/ (7 files in 3 dirs): Cursors: abstract cursor management from SDLVideo to Video and consolidate setCursor methods.
[18:16:53] <CIA-36> GemRB: 03bradallred * rd575fd57f1aa 10gemrb/gemrb/plugins/SDLVideo/SDLVideo.cpp: SDLVideo: only render tooltips if MOUSE_TOOLTIPS is set.
[18:16:53] <CIA-36> GemRB: 03bradallred * r3d0063bc6a50 10gemrb/gemrb/ (7 files in 3 dirs): Video/SDLVideo: move and rename "DisableMouse" from SDLVideo to Video as "MouseFlags". Add new flags for mouse and tooltip visibility accessible via config.
[18:16:53] <CIA-36> GemRB: 03bradallred * r1e71324137d3 10gemrb/gemrb/ (6 files in 5 dirs): Merge branch 'master' of ssh://gemrb.git.sourceforge.net/gitroot/gemrb/gemrb
[18:30:42] <-- brad_a has left IRC (Quit: brad_a)
[18:32:31] --> PixelScum has joined #gemrb
[18:33:56] <-- Drakkar has left IRC (Ping timeout: 240 seconds)
[18:46:40] --> Drakkar has joined #gemrb
[18:48:04] <-- PixelScum has left IRC (Ping timeout: 240 seconds)
[18:54:24] <-- SiENcE has left IRC (Quit: cya)
[18:57:36] --> PixelScum has joined #gemrb
[19:00:44] <-- Drakkar has left IRC (Ping timeout: 260 seconds)
[19:12:26] <-- PixelScum has left IRC (Ping timeout: 255 seconds)
[19:14:53] --> Drakkar has joined #gemrb
[19:25:19] --> gembot has joined #gemrb
[19:30:24] <gembot> build #10 of autotools g++-4.6 is complete: Failure [failed compile] Build details are at http://buildbot.gemrb.org/builders/autotools%20g%2B%2B-4.6/builds/10 blamelist: bradallred@me.com
[19:30:25] <gembot> build #11 of autotools g++-4.5 is complete: Failure [failed compile] Build details are at http://buildbot.gemrb.org/builders/autotools%20g%2B%2B-4.5/builds/11 blamelist: bradallred@me.com
[19:34:00] <gembot> build #9 of autotools g++-4.2 is complete: Failure [failed compile] Build details are at http://buildbot.gemrb.org/builders/autotools%20g%2B%2B-4.2/builds/9 blamelist: bradallred@me.com
[19:34:27] <gembot> build #9 of cmake g++-4.2 is complete: Failure [failed compile] Build details are at http://buildbot.gemrb.org/builders/cmake%20g%2B%2B-4.2/builds/9 blamelist: bradallred@me.com
[19:35:23] <gembot> build #9 of cmake g++-4.4 is complete: Failure [failed compile] Build details are at http://buildbot.gemrb.org/builders/cmake%20g%2B%2B-4.4/builds/9 blamelist: bradallred@me.com
[19:35:41] <gembot> build #9 of cmake g++-4.6 is complete: Failure [failed compile] Build details are at http://buildbot.gemrb.org/builders/cmake%20g%2B%2B-4.6/builds/9 blamelist: bradallred@me.com
[19:38:41] <gembot> build #9 of autotools g++-4.4 is complete: Failure [failed compile] Build details are at http://buildbot.gemrb.org/builders/autotools%20g%2B%2B-4.4/builds/9 blamelist: bradallred@me.com
[19:38:56] --> PixelScum has joined #gemrb
[19:39:52] <gembot> build #9 of cmake g++-4.5 is complete: Failure [failed compile] Build details are at http://buildbot.gemrb.org/builders/cmake%20g%2B%2B-4.5/builds/9 blamelist: bradallred@me.com
[19:40:03] <gembot> build #62 of osx-test is complete: Failure [failed compile] Build details are at http://buildbot.gemrb.org/builders/osx-test/builds/62 blamelist: bradallred@me.com
[19:41:05] <-- Drakkar has left IRC (Ping timeout: 268 seconds)
[19:41:41] --> brad_a has joined #gemrb
[19:41:48] <brad_a> >_<
[19:47:15] <brad_a> what am i missing?
[19:47:31] <fuzzie> oh
[19:48:21] <brad_a> do i just need enum in fromt of cursor index??? (obviously this builds without error/warning for me)
[19:48:23] <fuzzie> 'CursorIndex CursorIndex' sure sounds like a really bad idea
[19:48:30] <brad_a> oh
[19:48:32] <brad_a> ha
[19:48:34] <fuzzie> just don't do that?
[19:48:34] <brad_a> ok
[19:48:36] <brad_a> yes
[19:48:38] <fuzzie> give the enum a different name please? :P
[19:48:38] <brad_a> :-P
[19:48:42] <brad_a> will do
[19:48:50] <brad_a> suggestion?
[19:49:01] <fuzzie> i'd just use CursorType
[19:49:05] <brad_a> ok
[19:49:15] <fuzzie> but you could change the name of the variable to ActiveCursor..
[19:49:20] <fuzzie> or various other things
[19:49:47] <brad_a> strange that i get no error or warning...
[19:50:04] <fuzzie> you're a bit spectacularly inconsistent with the formatting of 'if' statements btw :p
[19:50:12] <brad_a> i am?
[19:50:37] <fuzzie> e.g. "if(cur)" followed two lines later by "if (curIdx == VID_CUR_DRAG)"
[19:50:39] <brad_a> sometimes i absorb what is in the surrounding code :-P
[19:51:10] <fuzzie> your brand-new code in both cases :-p
[19:51:17] <fuzzie> i mean it doesn't matter ;p
[19:51:39] <fuzzie> would be really nice to have consistent policy but we're such a mess
[19:51:40] --> Drakkar has joined #gemrb
[19:51:44] <brad_a> well i have no excuses then :)
[19:54:24] <-- PixelScum has left IRC (Ping timeout: 260 seconds)
[19:55:21] <gembot> build #391 of mingw32 is complete: Failure [failed compile] Build details are at http://buildbot.gemrb.org/builders/mingw32/builds/391 blamelist: bradallred@me.com
[20:01:32] <CIA-36> GemRB: 03bradallred * r5dcc9dd26558 10gemrb/gemrb/core/ (Video.cpp Video.h): Video: rename CursorIndex enum to CursorType. currently both a variable and the enum share the same name and that causes errors on most compilers.
[20:02:47] <brad_a> apparently it is just clang that will let you do that
[20:03:13] <brad_a> i guess msvc++ completed sucessfully too
[20:03:31] <brad_a> but gcc and mingw dont like that at all
[20:07:04] <-- brad_a has left IRC (Quit: brad_a)
[20:14:32] <gembot> build #178 of nmake-msvc++6 is complete: Success [build successful] Build details are at http://buildbot.gemrb.org/builders/nmake-msvc%2B%2B6/builds/178
[20:16:00] <gembot> build #11 of autotools g++-4.6 is complete: Success [build successful] Build details are at http://buildbot.gemrb.org/builders/autotools%20g%2B%2B-4.6/builds/11
[20:16:47] <gembot> build #12 of autotools g++-4.5 is complete: Success [build successful] Build details are at http://buildbot.gemrb.org/builders/autotools%20g%2B%2B-4.5/builds/12
[20:18:47] <fuzzie> I was going to say that I was surprised it didn't warn you that you were doing crazy things, but I'd forgotten we don't enable warnings for clang.
[20:19:16] <tomprince> 'if(' 631 vs 'if (' 11770
[20:22:01] <gembot> build #10 of autotools g++-4.2 is complete: Success [build successful] Build details are at http://buildbot.gemrb.org/builders/autotools%20g%2B%2B-4.2/builds/10
[20:24:03] <gembot> build #10 of cmake g++-4.2 is complete: Success [build successful] Build details are at http://buildbot.gemrb.org/builders/cmake%20g%2B%2B-4.2/builds/10
[20:25:35] <gembot> build #10 of cmake g++-4.4 is complete: Success [build successful] Build details are at http://buildbot.gemrb.org/builders/cmake%20g%2B%2B-4.4/builds/10
[20:27:14] <gembot> build #10 of cmake g++-4.6 is complete: Success [build successful] Build details are at http://buildbot.gemrb.org/builders/cmake%20g%2B%2B-4.6/builds/10
[20:31:07] <gembot> build #10 of autotools g++-4.4 is complete: Success [build successful] Build details are at http://buildbot.gemrb.org/builders/autotools%20g%2B%2B-4.4/builds/10
[20:34:42] <gembot> build #10 of cmake g++-4.5 is complete: Success [build successful] Build details are at http://buildbot.gemrb.org/builders/cmake%20g%2B%2B-4.5/builds/10
[20:44:50] <CIA-36> GemRB: 03tom.prince * r8ba334031788 10gemrb/CMakeLists.txt:
[20:44:50] <CIA-36> GemRB: clang is g++ compatible, so treat it the same way.
[20:44:50] <CIA-36> GemRB: CMAKE_CXX_COMPILER_ID is documented at http://www.cmake.org/cmake/help/cmake2.6docs.html
[20:44:51] <CIA-36> GemRB: 03tom.prince * r787b7c3b6637 10gemrb/CMakeLists.txt:
[20:44:51] <CIA-36> GemRB: Require CMake 2.6.0+.
[20:44:51] <CIA-36> GemRB: We don't actually test anything before 2.8.*, so bump the version we require somewhat.
[20:44:51] <CIA-36> GemRB: CentOS 6.2 has cmake 2.6.4 ....
[20:57:22] --> PixelScum has joined #gemrb
[20:59:38] <-- Drakkar has left IRC (Ping timeout: 240 seconds)
[21:13:14] <gembot> build #392 of mingw32 is complete: Success [build successful] Build details are at http://buildbot.gemrb.org/builders/mingw32/builds/392
[21:13:29] --> Drakkar has joined #gemrb
[21:15:45] <-- PixelScum has left IRC (Ping timeout: 252 seconds)
[21:54:30] --> PixelScum has joined #gemrb
[21:56:21] <-- Drakkar has left IRC (Ping timeout: 248 seconds)
[21:56:42] <gembot> build #102 of nmake-msvc++10 is complete: Success [build successful] Build details are at http://buildbot.gemrb.org/builders/nmake-msvc%2B%2B10/builds/102
[22:15:47] <gembot> build #63 of osx-test is complete: Success [build successful] Build details are at http://buildbot.gemrb.org/builders/osx-test/builds/63
[22:31:33] <-- PixelScum has left IRC (Read error: Connection reset by peer)
[22:46:59] --> Drakkar has joined #gemrb
[23:13:56] <-- Yoshimo has left IRC (Quit: Yoshimo)
[23:33:55] --> PixelScum has joined #gemrb
[23:33:59] <-- edheldil has left IRC (Remote host closed the connection)
[23:34:48] <-- Drakkar has left IRC (Read error: Connection reset by peer)