#gemrb@irc.freenode.net logs for 14 Jun 2010 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage


[01:23:02] <-- Maighstir_laptop has left IRC (Quit: Maighstir_laptop)
[02:06:02] --> Gekz has joined #GemRb
[04:57:10] <CIA-23> GemRB: 03tom.prince * r2a1b77fd7095 10gemrb/gemrb/core/Actor.cpp:
[04:57:10] <CIA-23> GemRB: Actor: Don't segfault on invalid level accesing monkbon.
[04:57:10] <CIA-23> GemRB: Signed-off-by: Tom Prince <tom.prince@ualberta.net>
[05:07:57] <-- raevol has left IRC (Quit: Leaving.)
[05:39:15] <-- pupnik has left IRC (Ping timeout: 240 seconds)
[05:43:06] <-- budlust has left IRC (Remote host closed the connection)
[05:43:22] --> budlust has joined #GemRb
[05:44:35] --> lynxlynxlynx has joined #GemRb
[05:44:35] --- ChanServ gives channel operator status to lynxlynxlynx
[06:46:22] <-- |Cable| has left IRC (Remote host closed the connection)
[07:23:21] --> barra_library has joined #GemRb
[09:09:12] --> Maighstir_laptop has joined #GemRb
[09:23:54] <-- barra_library has left IRC (Quit: Verlassend)
[09:34:34] <-- Maighstir_laptop has left #GemRb
[10:48:29] <-- Gekz has left IRC (Read error: Connection reset by peer)
[10:53:02] --> Gekz has joined #GemRb
[10:57:49] <-- Gekz has left IRC (Read error: Connection reset by peer)
[10:58:39] --> Gekz has joined #GemRb
[11:38:40] --> Gekz_ has joined #GemRb
[12:25:22] --> Napfton has joined #GemRb
[12:41:04] <Napfton> Failed to open /media/BG2_CD2/data3.cab as an InstallShield Cabinet File
[12:41:12] <Napfton> hi, what can i do against that?
[12:42:33] <lynxlynxlynx> is the file corrupt?
[12:43:30] <Napfton> dunno, under win the installation runs trough
[12:43:31] <Napfton> :/
[12:43:46] <Napfton> at least it did some years ago :P
[12:43:51] <lynxlynxlynx> run it through file
[12:43:56] <lynxlynxlynx> ie/tob/data2.cab: InstallShield Cabinet archive data version 6, 1207473557 files
[12:44:17] <Napfton> file /media/BG2_CD2/data3.cab
[12:44:19] <Napfton> /media/BG2_CD2/data3.cab: InstallShield CAB
[12:44:56] <lynxlynxlynx> ok, so atleast the header is good
[12:45:51] <Napfton> hm
[12:45:58] <Napfton> maybe its nothing there to extract
[12:45:58] <lynxlynxlynx> c78f41ff4cb47ea04fdf25ea6f55eb8b is the md5 sum of mine
[12:46:07] <Napfton> its 512byte big
[12:46:21] <Napfton> 3cb62f70f82b1fa9220eeec80d68b8d8
[12:46:24] <Napfton> is mine
[12:46:34] <lynxlynxlynx> mine is also 512 small
[12:46:43] <Napfton> i got the german version
[12:47:25] <Napfton> oh yours if from the tob cd
[12:47:32] <Napfton> im using bg2 disc 2
[12:47:41] <lynxlynxlynx> no, it isn't
[12:47:57] <Napfton> hmm
[12:48:07] <lynxlynxlynx> tob only has data{1,2}
[12:48:11] <Napfton> ill go on with the next cd, maybe it'll still work
[12:49:04] <Napfton> hm no
[12:49:15] <Napfton> data4 doesnt work either
[12:49:27] <Napfton> but this cd is definitly not broken
[12:50:27] <Napfton> data1 and 2 ran trough smooth
[12:51:29] <wjp> aren't these files part of the same archive?
[12:51:44] <Napfton> what files? what archive?
[12:51:53] <wjp> so you shouldn't have to explicitly unpack the higher-numbered ones
[12:52:10] <wjp> maybe
[12:52:13] <Napfton> well they are all on different disks
[12:53:01] <lynxlynxlynx> you can check if the files are ok by trying to install through wine
[12:53:01] <Napfton> i could copy them into one dir, but i doubt thats the problem
[12:53:38] <Napfton> lynxlynxlynx: i wanted to avoid using wine :(
[12:53:51] <Napfton> i was glad to have found that unshield thingy
[12:56:13] <Napfton> hm my wine seems to be broken
[12:58:03] <Napfton> it wasnt broken but the Setup.exe exits with multiple errors and without finishing the installation :/
[12:59:08] <lynxlynxlynx> are you running it from the same dir?
[12:59:25] <Napfton> you mean where i wanted it to be installed?
[12:59:55] <lynxlynxlynx> no, pwd
[13:00:01] <Napfton> no
[13:00:17] <Napfton> i created a bg2 dir, and called setup.exe via wine from there
[13:01:28] <lynxlynxlynx> run it from its cwd
[13:01:50] <lynxlynxlynx> http://gemrb.sourceforge.net/wiki/doku.php?id=unshield <-- i wrote this and it worked, but it was with an english set
[13:02:20] <Napfton> run the setup or the unshield?
[13:05:13] <lynxlynxlynx> both worked for me, i have many installs
[13:05:19] <Napfton> running wine setup.exe from the mountpoint of the cd doesnt change a thing
[13:06:33] <Napfton> well i cant even compile gemrb, so it doesnt really matter
[13:06:38] <Napfton> thanks anyway
[13:07:18] <-- Napfton has left #GemRb
[13:12:33] <lynxlynxlynx> bleh
[13:18:23] <edheldil> hehe
[13:49:52] --> pupnik has joined #GemRb
[14:02:07] --> |Cable| has joined #GemRb
[14:31:18] --> Maighstir_laptop has joined #GemRb
[15:13:16] <-- pupnik has left IRC (Quit: leaving)
[15:34:26] --> Guest40195 has joined #GemRb
[15:38:50] <-- Gekz_ has left IRC (Changing host)
[15:38:50] --> Gekz_ has joined #GemRb
[17:26:41] --> raevol has joined #GemRb
[17:35:15] <-- Gekz_ has left IRC (Read error: Connection reset by peer)
[17:35:56] --> Gekz_ has joined #GemRb
[18:01:34] --> cubathy has joined #GemRb
[18:13:53] <lynxlynxlynx> http://pastebin.com/C6PYM77P <-- can't figure out where this goes wrong
[18:14:39] <lynxlynxlynx> we should start using complete imports
[18:17:33] <fuzzie> the tables get loaded somewhere sufficiently early?
[18:18:03] <Guest40195> Does it work if you change it to GUICommon.ClassTable ?
[18:18:04] <lynxlynxlynx> start.py
[18:18:26] <-- raevol has left IRC (Quit: Leaving.)
[18:18:30] <lynxlynxlynx> it works in all other gametypes, that's why it is odd
[18:18:50] <-- Gekz has left IRC (Read error: Connection reset by peer)
[18:18:57] <fuzzie> pst's Start.py imports GUICommonWindows
[18:19:03] <fuzzie> which imports LUCommon
[18:19:03] --> Gekz has joined #GemRb
[18:19:08] <fuzzie> so clearly not going to work
[18:19:08] <-- Gekz_ has left IRC (Read error: Connection reset by peer)
[18:19:30] --- Guest40195 is now known as tomprince_loki
[18:19:32] <fuzzie> doesn't look like it needs the GUICommonWindows import
[18:19:52] <lynxlynxlynx> that's workinprogress stuff
[18:19:53] <fuzzie> but i agree that complete imports are prbly best, if you mean importing the module rather than copying symbols
[18:20:05] --> raevol has joined #GemRb
[18:20:10] --> Gekz_ has joined #GemRb
[18:20:13] <lynxlynxlynx> yes, import mod instead of from mod import
[18:21:30] <lynxlynxlynx> this table stuff will be easy to fix, the functions are more problematic
[18:21:43] <lynxlynxlynx> but maybe this event handler refactoring will help there
[18:22:14] <fuzzie> well, some of the code relies on copying default implementations of functions
[18:22:43] <fuzzie> otherwise, yes, i would wait for the refactoring
[18:23:12] <tomprince_loki> Well, woud it be better to change that to an explicit from blah import foo?
[18:23:14] <fuzzie> i imagine tomprince can also automatically patch up all the imports, too
[18:23:24] <fuzzie> tomprince_loki: that is what it is right now, and that copies the variable
[18:23:49] <fuzzie> which means you have to be sure that the module already got initialised
[18:24:03] <fuzzie> not sure why we don't just initialise the tables on load of that module, though?
[18:24:09] <tomprince_loki> Yes, but if you are wanting to rely on copy default impls?
[18:24:29] <fuzzie> i mean: this code is already doing 'from blah import foo'
[18:24:46] <fuzzie> so i don't see your point?
[18:25:09] <lynxlynxlynx> fuzzie: you mean guicommon just running the function after defining it instead?
[18:25:13] <fuzzie> lynxlynxlynx: yes
[18:25:23] <fuzzie> problems with load order?
[18:25:29] <lynxlynxlynx> will see
[18:25:53] <tomprince_loki> Or even just having that code at the module level?
[18:26:07] <fuzzie> well, it is tidier in a function, but you could make the function private :)
[18:27:39] <lynxlynxlynx> pst doesn't mind :)
[18:27:40] <fuzzie> or maybe not, that doesn't work for module functions?
[18:28:06] <fuzzie> hmm, documentation says it should work, i am doing something stupid maybe
[18:28:53] <lynxlynxlynx> iwd too
[18:30:33] <fuzzie> well, i can't make that work
[18:30:45] <lynxlynxlynx> what are you trying?
[18:30:53] <tomprince_loki> This seems perfectly tidy: http://pastebin.com/U5xsaP8i
[18:31:14] <fuzzie> tomprince_loki: yes, but you just stripped out all the tests, no?
[18:31:37] <lynxlynxlynx> yep, it will print needless errors in some games
[18:32:07] <tomprince_loki> Well, I missed the HasResource checks.
[18:32:17] <fuzzie> well, those are what i thought would make it untidy
[18:32:22] <fuzzie> but if there are only two, no big deal
[18:32:33] <fuzzie> i thought there were more
[18:32:52] <fuzzie> are there more tables that we should share and don't, or am i just mad?
[18:32:56] <lynxlynxlynx> ideally all should be checked, so it is easier to mod or something
[18:33:24] <fuzzie> well, then you could make it a helper function
[18:33:29] <lynxlynxlynx> fuzzie: perhaps, now only those loaded very often are
[18:33:34] <fuzzie> do what tomprince did, but call the helper function on each line rather than LoadTable
[18:34:04] <fuzzie> make sense?
[18:34:27] <lynxlynxlynx> i'm in the middle of a change, the move can be done later
[18:34:45] <fuzzie> ok. just thoughts, still in no position to code
[18:39:02] <CIA-23> GemRB: 03lynxlupodian * rad2b1a8f2c8a 10gemrb/gemrb/GUIScripts/ (6 files in 6 dirs): run LoadCommonTables in GUICommon instead of the callers
[18:40:23] <tomprince_loki> lynxlynxlynx: Once the C++ side of the event handler stuff goes in, some of the imports will need to change at the same time as the SetEvent calls.
[18:41:16] <tomprince_loki> In particular, GUICommonWindows.SetupMenuWindowControls will need GUIMA.OpenMapWindow etc.
[18:42:57] <lynxlynxlynx> sounds good
[18:43:06] <fuzzie> yes
[18:44:38] <tomprince_loki> ... and the trick is, that will probably cause recursive imports. Which is fine when we switch to 'import blah'.
[18:45:36] <lynxlynxlynx> let me know when you plan to merge this in and get thing rolling
[18:45:41] <lynxlynxlynx> i want to do the release first ;)
[18:46:40] <fuzzie> does 'import blah' fix recursive imports?
[18:46:52] <lynxlynxlynx> no
[18:48:06] <tomprince_loki> Well, depends on what is broken with them.
[18:49:00] <lynxlynxlynx> do you guys have any simple unfinished business? i'm thinking about doing the release on wednesday
[18:49:01] <fuzzie> i mean, what you intend is to remove the 'from' imports entirely and to prefix everything?
[18:49:14] <fuzzie> i have no time to commit anything until thurs
[18:49:23] <lynxlynxlynx> but you have work done?
[18:49:28] <fuzzie> that comment about trigger being uninitialised still stands, though
[18:50:25] <fuzzie> and if it's a valid point, then i guess commits are not being valgrinded and that would worry me
[18:50:27] <lynxlynxlynx> and yes, all the from imports can go, but it doesn't make much sense for GUIDefines and other only-constant containing files
[18:52:40] <fuzzie> i think i have no relevant commits. tidying and PS:T stuff.
[18:52:57] <fuzzie> which is to say, i don't think they'd fix anything
[18:55:04] <tomprince_loki> I don't have anything that wants to go in a release.
[18:55:08] <lynxlynxlynx> maybe the date will move up to then, i'll see how motivated i'll be
[18:55:26] <lynxlynxlynx> now what is this trigger regression you're talking about?
[18:56:00] <fuzzie> tomprince changed some of the store stuff the other day, and i couldn't see where the 'trigger' variable he added was initialised
[18:56:40] <lynxlynxlynx> and what do you say about that tomprince_loki?
[18:56:55] <fuzzie> but other than that, i think everything i found in reviews is fixed
[18:57:54] <lynxlynxlynx> basic gameplay still works here, but we'll need more suckers to try longer games
[18:58:04] <fuzzie> well, the release might help for that
[18:58:12] <lynxlynxlynx> yep
[18:58:13] <fuzzie> but the bugs reported on the forum seem kinda showstoppers
[18:58:30] <lynxlynxlynx> same old bugs, but atleast the saving got fixed
[18:58:42] <lynxlynxlynx> or fixed a bit, not sure if all the dir creation is now handled
[18:58:42] <fuzzie> yes, that is a great fix
[18:59:02] <lynxlynxlynx> i also noticed iwd2 has two quicksaves - one is a backup
[18:59:05] <fuzzie> afaik tomprince fixed it perfectly, i think it worked fine for everything i tested
[18:59:19] <lynxlynxlynx> great
[19:03:13] <fuzzie> i'm sure there will be horrible regressions, but no value in blocking release
[19:03:36] <lynxlynxlynx> why so sure?
[19:04:30] <tomprince_loki> Re: I missed thinking about intialization of trigger, but it turns out that it is new intialized by 'new STOItem()' in Interface::DoTheStoreHack. Note the ().
[19:06:16] <tomprince_loki> And also, I plead innoncence, since the code that reads trigger is never ever called, since stores aren't supported in PsT.
[19:10:25] <fuzzie> can we really depend on adherance to zero value-initialization?
[19:11:16] <fuzzie> i guess for a plain struct it should work everywhere
[19:11:28] <tomprince_loki> I wasn't suggesting we do, although the standard is pretty clear.
[19:11:55] <tomprince_loki> That was just part of my plea of innoncence. :)
[19:12:06] <fuzzie> i look at http://svn.boost.org/svn/boost/trunk/libs/config/test/boost_no_com_value_init.ipp
[19:12:17] <fuzzie> which someone linked me to, upon asking
[19:15:10] <fuzzie> so that looks hopeful for not bothering
[19:15:38] <fuzzie> and are stores not supported, or are they just broken?
[19:15:45] <fuzzie> i thought you concluded it was the latter
[19:16:31] <fuzzie> (sorry, not nitpicking, honest question, ca'n't remember!)
[19:17:38] <tomprince_loki> The basic stuff to show it, and look at the different pages are there, and the documentation of the control ids, but nothing for interacting with the store.
[19:18:23] <fuzzie> but enough that the triggers should be checked?
[19:19:37] <fuzzie> well, i guess i'll look at it in future
[19:20:39] <fuzzie> so, ok, i have no pending review issues ten :)
[19:20:46] <fuzzie> so wednesday sounds fine, lynx
[19:22:11] <lynxlynxlynx> :)
[19:39:30] --> edheldil_ has joined #GemRb
[19:39:58] <edheldil_> Hi
[19:40:32] <lynxlynxlynx> oj
[19:45:34] <-- budlust has left IRC (Remote host closed the connection)
[19:45:48] --> budlust has joined #GemRb
[20:00:29] <tomprince_loki> The pst store is actually worse than unimplemented, since the close button doesn't work properly.
[20:10:03] <fuzzie> sounds familiar from my struggles in iwd2
[20:11:02] <-- edheldil_ has left IRC (Ping timeout: 245 seconds)
[20:42:26] <-- lynxlynxlynx has left IRC (Remote host closed the connection)
[21:01:26] <-- cubathy has left IRC (Ping timeout: 258 seconds)
[21:16:12] --> cubathy has joined #GemRb
[21:24:19] --> lynxlynxlynx has joined #GemRb
[21:24:19] --- ChanServ gives channel operator status to lynxlynxlynx
[21:44:47] <-- budlust has left IRC (Ping timeout: 245 seconds)
[21:47:44] <-- lynxlynxlynx has left IRC (Remote host closed the connection)
[21:50:17] <-- Gekz_ has left IRC (Read error: Connection reset by peer)
[21:50:29] --> Gekz_ has joined #GemRb
[21:50:36] <-- Gekz has left IRC (Read error: Connection reset by peer)
[21:52:32] --> Gekz has joined #GemRb
[21:58:26] <-- Gekz_ has left IRC (Read error: Connection reset by peer)
[22:00:55] <-- tomprince_loki has left IRC (Quit: tomprince_loki)
[22:01:03] <-- Gekz has left IRC (Read error: Connection reset by peer)
[22:01:25] --> Guest40195 has joined #GemRb
[22:02:56] <-- Guest40195 has left IRC (Client Quit)
[22:03:09] --> Guest40195 has joined #GemRb
[22:03:51] <-- Guest40195 has left IRC (Client Quit)
[22:04:12] --> Guest40195 has joined #GemRb
[22:06:24] --> Gekz has joined #GemRb
[22:08:54] <-- Gekz has left IRC (Read error: Connection reset by peer)
[22:09:00] <-- Guest40195 has left IRC (Ping timeout: 265 seconds)
[22:09:42] --> Gekz has joined #GemRb
[22:09:47] --> lynxlynxlynx has joined #GemRb
[22:09:47] --- ChanServ gives channel operator status to lynxlynxlynx
[22:15:31] <-- lynxlynxlynx has left IRC (Remote host closed the connection)
[22:26:13] --> budlust has joined #GemRb
[22:40:34] --> Guest40195 has joined #GemRb
[22:54:31] --- Guest40195 is now known as tomprince_loki
[22:57:32] <-- cubathy has left IRC (Ping timeout: 265 seconds)
[23:31:45] <-- Maighstir_laptop has left #GemRb
[23:40:27] <-- Gekz has left IRC (Read error: Connection reset by peer)
[23:40:44] --> Gekz has joined #GemRb
[23:56:18] --> Gekz_ has joined #GemRb