#gemrb@irc.freenode.net logs for 14 Jun 2011 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage


[00:15:01] <-- edheldil_ has left IRC (Ping timeout: 250 seconds)
[00:28:20] --> edheldil_ has joined #gemrb
[00:33:43] <-- edheldil_ has left IRC (Read error: Connection reset by peer)
[00:34:25] --> edheldil_ has joined #gemrb
[00:46:56] <brad_a> is there a reason that delete and backspace are implemented differently in textedit.cpp?
[00:53:38] <brad_a> i ask because the delete key on the ipad keyboard doesnt work because it is delete and not backspace and i want to kknow if i ought to just make the backspace and delete the same or if i just want to make them the same for ios.
[00:54:03] <brad_a> it may seem like a stupid question but im a mac user and have no delete key
[00:57:40] --> raevol has joined #gemrb
[00:59:40] <-- edheldil_ has left IRC (Ping timeout: 240 seconds)
[01:33:47] <-- brad_a has left IRC (Ping timeout: 276 seconds)
[01:39:15] <-- PixelScum has left IRC (Read error: Connection reset by peer)
[01:39:46] --> PixelScum has joined #gemrb
[01:45:27] --> brad_a has joined #gemrb
[02:11:11] <-- PixelScum has left IRC (Read error: Connection reset by peer)
[02:11:43] --> PixelScum has joined #gemrb
[02:48:01] <-- raevol has left IRC (Quit: Leaving.)
[04:07:28] <-- dhewg has left IRC (Read error: Operation timed out)
[04:07:34] --> dhewg has joined #gemrb
[04:43:20] <-- brad_a has left IRC (Quit: brad_a)
[05:21:13] --> edheldil_ has joined #gemrb
[05:36:44] --> Bo_Thomsen has joined #gemrb
[05:46:53] <edheldil_> btw I think you do NOT need developer license to install apps on iPhone (even somebody else's), but maybe you need it to get xcode. But if there's a need I can check with our iPhone dev here
[05:51:42] <-- edheldil_ has left IRC (Ping timeout: 240 seconds)
[06:03:20] --> edheldil_ has joined #gemrb
[06:10:08] --> barra_home has joined #gemrb
[06:51:46] <-- edheldil_ has left IRC (Ping timeout: 244 seconds)
[07:01:33] <-- Bo_Thomsen has left IRC (Quit: Leaving.)
[07:24:55] --> raevol has joined #gemrb
[07:32:38] --> edheldil_ has joined #gemrb
[07:44:31] <-- edheldil_ has left IRC (Ping timeout: 268 seconds)
[08:32:14] --> lubos has joined #gemrb
[08:37:45] --> lynxlynxlynx has joined #gemrb
[08:37:45] <-- lynxlynxlynx has left IRC (Changing host)
[08:37:45] --> lynxlynxlynx has joined #gemrb
[08:37:45] --- ChanServ gives channel operator status to lynxlynxlynx
[09:00:31] <-- |Cable| has left IRC (Remote host closed the connection)
[09:12:39] <-- raevol has left IRC (Quit: Leaving.)
[09:46:06] --- _dev_urandom is now known as devurandom
[09:59:07] --> edheldil_ has joined #gemrb
[10:02:37] <-- lynxlynxlynx has left IRC (Ping timeout: 255 seconds)
[10:19:55] <-- edheldil_ has left IRC (Ping timeout: 268 seconds)
[10:23:43] --> lynxlynxlynx has joined #gemrb
[10:23:43] <-- lynxlynxlynx has left IRC (Changing host)
[10:23:43] --> lynxlynxlynx has joined #gemrb
[10:23:43] --- ChanServ gives channel operator status to lynxlynxlynx
[10:32:39] --> edheldil_ has joined #gemrb
[10:44:54] <CIA-39> GemRB: 03lynxlupodian * r26ad4fbd7624 10gemrb/gemrb/core/EffectQueue.cpp: check_resistance: do a signed check against magic resistance
[14:13:46] <-- lynxlynxlynx has left IRC (Read error: Operation timed out)
[14:27:37] --> lynxlynxlynx has joined #gemrb
[14:27:37] <-- lynxlynxlynx has left IRC (Changing host)
[14:27:37] --> lynxlynxlynx has joined #gemrb
[14:27:37] --- ChanServ gives channel operator status to lynxlynxlynx
[15:01:21] --> Maighstir has joined #gemrb
[15:24:22] --> brad_a has joined #gemrb
[15:40:22] <-- edheldil_ has left IRC (Ping timeout: 260 seconds)
[15:50:31] --> Avenger has joined #gemrb
[15:50:43] <Avenger> lynx the last commit broke build
[15:52:22] <lynxlynxlynx> not for me
[15:54:42] <lynxlynxlynx> maybe casting it at assignment is better
[16:17:28] <brad_a> speaking of commits. did i muckup with the one i tried to do last night?
[16:23:48] <lynxlynxlynx> no, the last commit is from the middle of today
[16:23:57] <lynxlynxlynx> yours was ifdefed out anyway
[16:24:34] <brad_a> my commit was the ifndef stuff
[16:26:06] <brad_a> i just dont see it on source forge but it shows on my computer so im confused
[16:26:37] <brad_a> probably dont know what im doing :|
[16:29:18] <lynxlynxlynx> you can commit all you want and it will stay local
[16:29:27] <brad_a> i see
[16:29:37] <lynxlynxlynx> you'd have to push the changes for them to get upstream
[16:29:47] <lynxlynxlynx> but you don't have the permissions for that anyway
[16:29:50] <brad_a> ah so i do need an account then
[16:29:51] <brad_a> yeah
[16:30:29] <lynxlynxlynx> since you don't run a git server and probably don't use any git mirroring service, it is easiest if you send patches
[16:30:35] <brad_a> os how do i get permissions? or how would you prefer me to do this?
[16:30:43] <lynxlynxlynx> git show commithash
[16:31:04] <lynxlynxlynx> or git's create patchset command (i forgot the name)
[16:31:28] <lynxlynxlynx> you can get permission once you've proven your worth ;)
[16:31:40] <brad_a> oh boy
[16:33:19] <lynxlynxlynx> Avenger is the end boss, while the others will just pester you if you try to get something ugly in
[16:33:36] <brad_a> im fine with that :)
[16:33:44] <lynxlynxlynx> protip: break your changes into smaller commits, sensible bits
[16:33:55] <lynxlynxlynx> makes regression finding so much easier
[16:34:07] <brad_a> all this one is is an ifndef to not include the delete key code on ios so that del and backspace are the same.
[16:34:20] <brad_a> will do
[16:34:21] <lynxlynxlynx> you can use git commit --interactive or git add -p (and then git commit without extra args)
[16:35:09] <lynxlynxlynx> you'll have an easy job, since you'll mostly be adding new files
[16:36:11] <brad_a> eventually i want to tackle something on the todo
[16:37:14] <lynxlynxlynx> yay
[16:37:33] <lynxlynxlynx> please be of the sequential type :)
[16:38:09] <lynxlynxlynx> parallelisation can easily lead to less progress
[16:38:15] <brad_a> sequential? you mean start at the top of the list?
[16:38:28] <lynxlynxlynx> not at all
[16:38:45] <brad_a> explain?
[16:38:50] <lynxlynxlynx> it was more of a rant
[16:38:55] <brad_a> oh
[16:39:05] <brad_a> oh isee
[16:39:10] <brad_a> do one thing at a time till its done
[16:39:27] <lynxlynxlynx> kinda
[16:43:35] <lynxlynxlynx> no pressure :)
[16:46:34] <brad_a> ha ha none take. ive enjoyed working on this so far
[16:47:50] <brad_a> seeing how old this poject is im suprised it hasent died. that just seems to be the way things go. loss of intrest or whatnot
[16:51:59] <lynxlynxlynx> for a very long period of time, Avenger was the sole contributor
[16:53:10] <lynxlynxlynx> his persistance payed off, since others like me weren't happy with the pace and realised there's only one way of making it go faster
[16:54:15] <brad_a> indeed
[16:54:17] <brad_a> http://dl.dropbox.com/u/13866402/iosdeletecommit.txt
[16:54:21] <brad_a> that is my commit
[16:55:18] <brad_a> if its not too much of a pain the email should be bradallred@me.com. i would have changed it but i dont know if that would invalidate the commit hash or anything. (remember i know nothing :P )
[16:55:46] <brad_a> i changed my git congig so it will be correct from now on
[16:57:00] <lynxlynxlynx> no, you can edit all you want
[16:57:52] <lynxlynxlynx> next protip: don't mix whitespace cleanup into other work
[17:01:07] <wjp> shouldn't we change GEM_DELETE to GEM_BACKSP at a higher level than this?
[17:02:38] <wjp> or do you really mean to change it in TextEdit but not in TextArea or Console?
[17:02:42] <-- PixelScum has left IRC (Ping timeout: 240 seconds)
[17:03:24] --> Drakkar has joined #gemrb
[17:05:28] <brad_a> ios has no console access so that doesnt matter, but i suppose you are right about text area. i didnt even realize.
[17:05:47] <brad_a> i didnt mean to do whitespace cleanup :P
[17:06:51] <wjp> I'm not sure what the exact reason for this change is, but if it's necessary, it probably fits better in SDLVideo.cpp where it's set
[17:07:31] <brad_a> you mean sdlvideodriver.cpp?
[17:07:43] <brad_a> i aggree to taht
[17:08:20] <brad_a> the reason is because ios doesnt have a backspace and so i want delete to behave as such
[17:09:01] <brad_a> go ahead and thow that out and ill do it where is proper :D
[17:13:44] --> barra_away has joined #gemrb
[17:16:23] --> PixelScum has joined #gemrb
[17:16:52] <-- barra_home has left IRC (Ping timeout: 255 seconds)
[17:19:35] <-- Drakkar has left IRC (Ping timeout: 246 seconds)
[17:24:13] --> |Cable| has joined #gemrb
[17:25:30] --> Bo_Thomsen has joined #gemrb
[17:27:20] <brad_a> http://dl.dropbox.com/u/13866402/iosdeletecommit.txt
[17:28:04] <brad_a> i believe that is much more satisfactory
[17:34:45] <lynxlynxlynx> mhm
[17:34:53] --> BaldimerBrandybo has joined #gemrb
[17:35:49] <brad_a> no accidental whitespace clean up ;)
[17:36:22] <Avenger> brad, i don't know what you mean by IOS has no console access. Console in gemrb is just a special editbox for 'cheat' codes.
[17:36:27] <lynxlynxlynx> git diff will color it red, so it is easy to spot too
[17:36:38] <Avenger> it is really useful for development
[17:37:12] <Avenger> so, i'm pretty sure you want keyboard for it too :)
[17:37:13] <lynxlynxlynx> it's like the quake console, but the new patch is fine wrt that
[17:37:15] <fuzzie> Avenger: there's no way to get output though
[17:37:33] <fuzzie> i was wondering about writing a quake-style-one unless someone wrote one without me noticing
[17:37:41] <Avenger> well, you can still do stuff like SetPlayerStat(0,IE_XP,100000) :D
[17:37:46] <brad_a> oh that. i thought you meant something else
[17:38:17] <brad_a> yeah i changed it in sdlvideo.cpp instead so it covers everything
[17:38:22] <Avenger> cool
[17:38:50] <brad_a> thanks for pointing that out
[17:38:51] <-- PixelScum has left IRC (Ping timeout: 276 seconds)
[17:38:58] <Avenger> that is the right place, because it is using sdl
[17:39:14] <Avenger> all sdl calls should be confined to sdlvideo :)
[17:39:15] --- barra_away is now known as barra_home
[17:39:52] <brad_a> ill remember that
[17:40:41] <Avenger> i'm unfamiliar with androids, but wouldn't they also miss a keyboard like this?
[17:40:55] <brad_a> well except for that iphone keyboard bit that i commited yesterday. i did that in textedit.cpp i dont know where else it could go since i need the keyboard to appear when a textfield gains focus
[17:41:15] <Avenger> i meant that commit
[17:41:43] <fuzzie> yes, but a lot of android devices have hardware keyboards
[17:42:02] <Avenger> if you need something like that, maybe just add a new method in video.h/video.cpp/sdlvideo.cpp
[17:42:03] <brad_a> android ought to have a compile flag to use virtual keyboard or not if it has a physical one then do something like i have doe. 
[17:42:09] <fuzzie> so it's a bit trickier
[17:42:20] <fuzzie> but a new method sounds nice
[17:42:50] <Maighstir> My non-hardware-keyboard android phone gets a barely visible button that opens up the virtual keyboard
[17:43:50] <brad_a> is that code in the repo? i should modify it do have that on ios and link it to the code for the iphone keyboard
[17:44:28] <brad_a> or is that part of SDL on android?
[17:44:45] <Maighstir> I don't know where it comes from
[17:45:27] <brad_a> probably SDL. ill have a peek in there and see if they have something similar for iOS
[17:46:23] <brad_a> except if it were SDL then it could interfere with game controls so maybe thats not where
[17:46:36] <Maighstir> it does interfere
[17:46:40] <brad_a> oh lol
[17:46:45] <brad_a> i dont want that then
[17:46:49] <Maighstir> yeah
[17:47:01] <brad_a> ill stick with auto display on focus
[17:53:42] <brad_a> avenger, about this new method. are you suggesting replacing my SDL calls in textedit with something like core->GetVideoDriver()->showVirtualKeyboard()
[17:54:06] <brad_a> then of course implementing that methodin the required classes
[18:05:58] <lynxlynxlynx> yes
[18:09:41] <brad_a> ok ill take care of doing that
[18:11:49] <brad_a> somebody can undo my commit from yesterday. the textedit.cpp one
[18:12:06] <brad_a> or just wait till i do this. doesnt matter to me
[18:21:41] <Avenger> i can wait till the weekend :)
[18:22:34] <brad_a> im sure ill find time to do this tomorrow. working on homework right now.
[18:26:46] <brad_a> would you prefer this method only be compiled when a flag is set or have it just be empty when the virtual keyboard flas isnt set?
[18:28:31] <brad_a> option 2 is easier if you have no prefrence :D
[18:31:15] <Avenger> do what is easier to you
[18:32:51] <brad_a> option 2 it is
[18:33:27] <Avenger> if i understood you correctly, you can do it either by compile time flag or a runtime flag. It is totally up to you.
[18:35:40] <Avenger> or... you meant always a compile time flag, but you prefer the fewer ifdefs, more stubs? I guess, we can always add more ifdefs :)
[18:38:18] <brad_a> yeah i meant always compile time but fewer ifdefs
[18:38:37] <brad_a> but if you prefer i can do option one with more ifdef i really dont mind
[18:39:09] <brad_a> i just wanted to follow whatever convention is already in place if any
[18:40:27] <brad_a> ill see if there is an sdl function that will tell me if a virtual keyboard and then i can do runtime or even both
[18:41:05] <brad_a> i was even going to put in the android equivalent but there doesnt appear to be one in android sdl for some strange reason
[18:41:39] <fuzzie> you're looking at android's sdl-lib?
[18:42:07] <brad_a> yes
[18:46:56] <fuzzie> SDL_ANDROID_SetScreenKeyboardShown in SDL_screenkeyboard.h, then
[18:48:22] <brad_a> im searching the SDL clone i made just this week and that isnt in here...
[18:49:11] <fuzzie> the android sdl-lib one, not the libsdl.org one?
[18:49:16] --> edheldil_ has joined #gemrb
[18:50:03] <brad_a> i didnt download anything specifi for android but this SDL clone has plenty of android specifics in it
[18:50:13] <brad_a> but i trust you
[18:50:36] <fuzzie> well
[18:50:47] <fuzzie> i don't ever use SDL on android myself
[18:51:30] <fuzzie> but i know that all the ports I know of (including the gemrb one) are using the android sdl-lib by pelya
[18:52:42] <brad_a> well ill throw that in there and if it fails to link or compile then just delete it
[18:56:17] <brad_a> it would be swell if the SDL people would replace these proprietary methods for ios/android into a single showkeyboard type of thing so we didnt have to pollute gemrb code with a bunch of ifdefs
[19:29:35] <-- |Cable| has left IRC (Read error: Connection reset by peer)
[19:29:54] --> |Cable| has joined #gemrb
[19:29:55] <fuzzie> there was some discussion on the mailing list
[19:30:08] <fuzzie> but SDL 1.3 isn't useful to a lot of people anyway
[19:50:25] <-- Avenger has left IRC (Quit: bye!)
[20:00:51] <-- brad_a has left IRC (Ping timeout: 252 seconds)
[20:06:57] --> brad_a has joined #gemrb
[20:08:01] <CIA-39> GemRB: 03avenger_teambg * racea382ad36e 10gemrb/gemrb/core/EffectQueue.cpp: fixed compilation problem
[21:52:26] <lynxlynxlynx> for some reason it doesn't want to apply your patch
[21:52:32] <lynxlynxlynx> and it's not an eol issue
[21:54:26] <lynxlynxlynx> eh, nevermind
[21:57:23] <brad_a> talking to me?
[21:59:25] <lynxlynxlynx> mhm
[21:59:34] <lynxlynxlynx> it was truncated and the spaces munged
[21:59:44] <brad_a> hmmm
[22:00:03] <lynxlynxlynx> use git format-patch next time and just upload what it creates
[22:00:43] <brad_a> that was from git but i copied it from terminal into text edit. i suppose i ought to just pipe it directly to a file from now on
[22:01:17] <brad_a> hell thats easier too i dont know whay i didnt do that :O
[22:01:49] <CIA-39> GemRB: 03bradallred * r88a3c20c501a 10gemrb/gemrb/plugins/SDLVideo/SDLVideo.cpp: treat delete and backspace the same when compiling for iOS
[22:01:59] <brad_a> thank you sir
[22:02:30] <lynxlynxlynx> hand copying will kill tabs
[22:02:56] <lynxlynxlynx> git format-patch
[22:03:10] <brad_a> i assume piping to a file is fine
[22:03:41] <lynxlynxlynx> but then you have to name it yourself
[22:04:10] <lynxlynxlynx> zzz
[22:04:35] <brad_a> the file name matters?
[22:04:43] <-- lynxlynxlynx has left IRC (Read error: Connection reset by peer)
[22:11:17] <-- brad_a has left IRC (Ping timeout: 252 seconds)
[22:28:59] <-- Bo_Thomsen has left IRC (Quit: Leaving.)
[23:01:07] <-- edheldil_ has left IRC (Read error: Connection reset by peer)
[23:01:43] --> edheldil_ has joined #gemrb
[23:06:42] <-- edheldil_ has left IRC (Ping timeout: 240 seconds)
[23:25:34] <-- Maighstir has left IRC (Quit: ~ Trillian Astra - www.trillian.im ~)
[23:37:51] --> edheldil_ has joined #gemrb
[23:43:32] <-- edheldil_ has left IRC (Ping timeout: 246 seconds)