[03:36:06] <-- phao has left IRC (Ping timeout: 265 seconds)
[04:14:26] --> edheldil_ has joined #gemrb
[05:37:37] <-- edheldil_ has left IRC (Ping timeout: 250 seconds)
[05:56:31] --> decker^ has joined #gemrb
[05:59:14] <decker^> hello
[05:59:49] <decker^> came to report a game breaking bug i found with party reforming. Had 6 people in party, went to trade jaheira and khalid for ajantis
[05:59:53] <decker^> here is the output:
[05:59:56] <decker^> http://pastebin.com/cEtSURBg
[05:59:57] <Pepelka> [Python] GemRB - Party Reform bug output - Pastebin.com
[06:00:08] <decker^> Python script GUIWORLD.py
[06:01:11] <decker^> i did a temp fix for myself to bypass it by changing UpdatePortriatWindows by breaking in the loop if portid >= 6 but I have no idea how to really fix the problem.
[06:01:14] <decker^> So just reporting.
[06:03:27] <decker^> anyway off to zzz...
[06:03:33] <-- decker^ has left IRC (Quit: Leaving)
[06:54:48] --> edheldil_ has joined #gemrb
[06:58:53] <-- Lightkey has left IRC (Ping timeout: 246 seconds)
[06:59:26] <-- edheldil_ has left IRC (Ping timeout: 240 seconds)
[07:11:35] --> edheldil_ has joined #gemrb
[07:11:45] --> Lightkey has joined #gemrb
[07:12:10] <edheldil> decker^: don't forget, that with lynx's patches, youy can have party up to 10 PCs
[07:48:23] <lynxlynxlynx> maybe it was something to do with the fact that khalid and jaheira are a pair
[07:53:10] <fuzzie> hm
[07:53:35] <fuzzie> leaving conversation GUI conflicting with reform GUI?
[08:20:05] --> Eli2_ has joined #gemrb
[08:23:08] <-- Eli2 has left IRC (Ping timeout: 264 seconds)
[09:58:59] --> GeneralDuke has joined #gemrb
[10:07:06] --> decker^ has joined #gemrb
[10:07:59] <decker^> hello
[10:10:20] <decker^> so i broke it up into 2 bugs and did a report and test different cases. I am not interpreting anything about what the cause might be or suggesting solutions, just reporting information.
[10:10:26] <decker^> anyway here is my testing:
[10:10:29] <decker^> http://pastebin.com/rd037c1d
[10:10:29] <Pepelka> GemRB - Party Reformation - Pastebin.com
[10:11:45] <decker^> i have no idea why it happens, i just know it does. I did 11 tests total, some different cases/conditions and some repeats.
[10:13:53] <decker^> Anyway I don't plan on looking into it any further mostly because there are a few other things I am looking at, but if any of you want me to do further testing let me know I'll see what I can do.
[10:17:29] <decker^> also, redownloading the ad&d anthology from gamersgate so i would be willing to do a pst playthrough (have never played it) in response to your post.
[10:18:33] <decker^> sorry if it seems i am spamming, just bringing info and assuming you'll check logs :)
[10:18:57] <decker^> so a few things i have checked on todo list for BG:
[10:19:18] <lynxlynxlynx> hey
[10:19:19] <decker^> dead party members shouldn't be visible after area transitions -> checked, party members corpses are visible.
[10:19:41] <decker^> oh hey
[10:20:13] <decker^> Alaundo choir should chant on their own. -> checked, does not happen. clicking on them will start their chanting, but doesn't happen automatically.
[10:20:19] <lynxlynxlynx> did you set MaxPartySize manually?
[10:20:30] <decker^> I don't even know how to do that.
[10:20:34] <decker^> or where.
[10:20:40] <lynxlynxlynx> the main cfg
[10:20:41] <decker^> I can though.
[10:20:43] <lynxlynxlynx> probably not
[10:20:45] <decker^> k hold on
[10:20:54] <lynxlynxlynx> pretty sure you'd remember
[10:21:24] <decker^> it is commented out.
[10:21:30] <decker^> do i need to uncomment it?
[10:21:38] <decker^> to keep at 6 members then?
[10:21:52] <lynxlynxlynx> no
[10:22:03] <lynxlynxlynx> i think #1 and #2 may be the same thing
[10:22:20] <lynxlynxlynx> iirc we don't refetch the button pairs in a few places
[10:22:20] <decker^> #1 and #2 referring to what, bg1 and bg2?
[10:22:26] <lynxlynxlynx> your list
[10:22:36] <decker^> i can uncomment it and retest if yo ulike
[10:22:44] <decker^> oh right yeah i thought so too
[10:23:02] <decker^> It was strange i found those two in kagain's shop, i went there to recruit him and those two were there instead.
[10:23:13] <decker^> bg never fails to surprise me :) i figured mine as well try.
[10:23:25] <decker^> kind of nice since they were a pair.
[10:24:23] <lynxlynxlynx> hmm, actually uncommenting may help
[10:24:40] <decker^> yeah just did it
[10:24:53] <lynxlynxlynx> gemrb/core/Interface.cpp:1300 <-- or remove the int here
[10:25:24] <lynxlynxlynx> i don't understand how it compiled this way
[10:25:32] <decker^> worked fine on situation #3 but situation #1 still the same, probably cause of the pair
[10:25:57] <decker^> want me to do more testing with just the maxpartysize=6 or go ahead and edit that?
[10:26:11] <decker^> i mean before i do
[10:27:35] <decker^> situation with safana worked first time then broke second
[10:27:51] <decker^> going to remove int now
[10:28:39] <decker^> okay commented out
[10:29:43] <Pepelka> [commit] lynxlynxlynx: LUSpellSelection.OpenSpellsWindow expects the level to be the new level https://github.com/gemrb/gemrb/commit/58481aebaae9c65b51a9bfc7054bc0dfa8cc2532
[10:29:44] <Pepelka> [commit] lynxlynxlynx: CREImporter::FindSpellType: be more lax https://github.com/gemrb/gemrb/commit/335ba0b1bd587bd882fa7b4693f91db34aefdf50
[10:29:45] <Pepelka> [commit] lynxlynxlynx: OpenPortraitWindow: update PortraitButtons here too https://github.com/gemrb/gemrb/commit/8f64439d22bbae0dfe01ae1eb48fa1ca6db37e51
[10:29:46] <Pepelka> [commit] lynxlynxlynx: core: update the member party size max, not a new one https://github.com/gemrb/gemrb/commit/f27a67836b3d04105b8ceafb2620fdb55e583f24
[10:30:32] <lynxlynxlynx> you can just update to the latest version and uncommenting won't be necessary
[10:30:56] <decker^> ok
[10:31:05] <lynxlynxlynx> do a git diff > saveme
[10:31:06] <lynxlynxlynx> first
[10:31:08] <decker^> gotta do some stashing then
[10:31:12] <lynxlynxlynx> i think you'll have some conflicts
[10:31:24] <decker^> okay good idea
[10:31:25] <lynxlynxlynx> i fixed a few spacing issues in your commit
[10:31:33] <decker^> what commit
[10:31:43] <lynxlynxlynx> uhh, the one from the other day
[10:31:51] <decker^> oh right
[10:31:55] <lynxlynxlynx> you can revert the whole file if you don't have any other changes in it
[10:32:00] <lynxlynxlynx> much easier
[10:32:06] <decker^> did you see my thing about the gui store?
[10:32:16] <lynxlynxlynx> yeah, but several questions
[10:32:19] <lynxlynxlynx> not for nwo
[10:32:35] <decker^> nwo?
[10:32:36] <decker^> now?
[10:33:00] <decker^> meaning one thing at a time?
[10:33:47] <decker^> crap i got conflicts
[10:33:56] <decker^> shouldn't a stash handle those
[10:34:33] <decker^> what does needs merge and unmerged mean
[10:34:42] <decker^> oh nm
[10:34:48] <decker^> just never done it without the gui
[10:35:34] <decker^> oh i see, the ) ) instead of ))
[10:36:54] <decker^> ugh
[10:41:16] <decker^> just going to reclone with my fork
[10:50:02] <decker^> there
[10:50:47] <decker^> better anyway now i can just do pull requests rather than doing a patch, though since i am still inexperienced i'll seek help on that matter :)
[10:54:12] <lynxlynxlynx> cool
[10:54:31] <lynxlynxlynx> yeah, that was supposed to be a now
[10:54:36] <lynxlynxlynx> got a phone call
[10:54:41] <lynxlynxlynx> today's gonna be a tough
[10:54:44] <decker^> k
[10:54:49] <decker^> yikes
[10:54:56] <lynxlynxlynx> ... day
[10:55:12] <decker^> sorry man :(
[10:55:16] <lynxlynxlynx> so yeah, didn't forget abuot guistore, still have a tab with it open
[10:55:32] <lynxlynxlynx> just deadlines and some drama, nothing extraordinary
[10:55:47] <decker^> well we can worry about it some other time if you'd rather, when it is a better time
[10:56:09] <lynxlynxlynx> you can recheck if things are better now wrt portraits
[10:56:17] <lynxlynxlynx> comment your maxpartsize back
[10:56:23] <decker^> ok
[10:56:28] <lynxlynxlynx> bbl
[10:56:33] <lynxlynxlynx> & thanks
[10:56:34] <decker^> will do
[10:56:36] <decker^> np
[10:57:14] <decker^> probably leave myself here soon but will do a few tests first and spam some more lol
[11:02:54] <decker^> 81%
[11:04:39] <decker^> hey i would be willing to contribute to this: Add Doxygen doc comments to more objects.
[11:05:09] <decker^> that way i can learn more doxygen stuff for personal reasons and help out too while i browse the code and learn it.
[11:05:42] <decker^> but that is a maybe...
[11:14:57] <decker^> man... noober makes me want to play an evil party just to kill him lol
[11:15:02] <decker^> maybe i can lure him into the woods
[11:16:18] <decker^> no witnesses
[11:17:33] <decker^> well nothing seems too different other than recruiting without the pair companions seems to result in the gui breaking less often.
[11:17:46] <decker^> strange that it "seems" random as to whether it will break or not...
[11:18:10] <decker^> if i can maybe i will see if i can figure out why it breaks one instance and not the next ... comparing logs or something.
[11:18:34] <decker^> one thing for sure, the python errors do happen every time though from what i can see but i will recheck
[11:18:41] <decker^> anyway i am out of here now
[11:19:05] <decker^> thanks again lynxlynxlynx :) hope things go well for you today .. or went well for you if you read this after the matter
[11:19:20] <-- decker^ has left IRC (Quit: Leaving)
[11:37:55] <edheldil> heh, he reminds me of my daughters :)
[15:00:50] <-- edheldil_ has left IRC (Ping timeout: 246 seconds)
[15:31:23] <-- GeneralDuke has left IRC (Quit: GeneralDuke)
[16:48:16] --> edheldil_ has joined #gemrb
[18:48:52] <lynxlynxlynx> phew
[18:49:17] <lynxlynxlynx> back to wierd control issues
[18:49:49] <lynxlynxlynx> can't seem to reduce my uncommitted pile, things just get swapped in a whack-a-mole fashion
[18:58:57] <Pepelka> [commit] lynxlynxlynx: iwd2 uses listspll.2da instead of spells.2da and filenames for learning https://github.com/gemrb/gemrb/commit/804882a8811c82ae90a25df3195d3ad1e2ccbe47
[18:58:59] <Pepelka> [commit] lynxlynxlynx: SetupSpellsWindow: fixed level param for cg https://github.com/gemrb/gemrb/commit/21a37e71d7de69d176fe96ab82e2e4a53a5dbb91
[18:59:00] <Pepelka> [commit] lynxlynxlynx: GetLearnablePriestSpells: only look at listspll.2da for iwd2 https://github.com/gemrb/gemrb/commit/7c6f626585bd5a853586ef2b604975db834168ec
[18:59:01] <Pepelka> [commit] lynxlynxlynx: iwd2: nuke domain spells earlier, so it also works for non-casters https://github.com/gemrb/gemrb/commit/cbf2cfc6cde31222d226cc991d202f07c1ec6c58
[18:59:02] <Pepelka> [commit] lynxlynxlynx: LearnAnySpells: don't learn the same spells twice (non-clerics) https://github.com/gemrb/gemrb/commit/54f6929e574496468299b65f3dcffd86ac68db4d
[18:59:03] <Pepelka> [commit] lynxlynxlynx: GetLearnableDomainSpells: handle domain spells on level-up too https://github.com/gemrb/gemrb/commit/1475006c1d6d91a06786f91723cca999ca8f59b7
[19:13:22] --> phao has joined #gemrb
[19:58:43] <-- phao has left IRC (Ping timeout: 265 seconds)
[20:25:38] <-- edheldil_ has left IRC (Ping timeout: 246 seconds)
[20:37:08] <Pepelka> [commit] lynxlynxlynx: LUSpellSelection: fixed up for iwd2 level-up https://github.com/gemrb/gemrb/commit/f7772a0c42ba741d1fe95e01331eca9875a11db5
[20:37:09] <Pepelka> [commit] lynxlynxlynx: DisplayWeapons: removed extraneus delimiter https://github.com/gemrb/gemrb/commit/a94fdbc9a4fb8a607e8008ccaaeddd460fdb6b08
[20:37:10] <Pepelka> [commit] lynxlynxlynx: GUIREC: implemented level-up kit selection https://github.com/gemrb/gemrb/commit/1e652161ee8d44d76d1bbfd2dd96e34cc93f4908
[20:37:11] <Pepelka> [commit] lynxlynxlynx: SetupSpellsWindow: added kit support https://github.com/gemrb/gemrb/commit/23c29337dbbbd4b7c23f0468a8144460ad6475a1
[20:37:12] <Pepelka> [commit] lynxlynxlynx: FinishLevelUp: take kits into account https://github.com/gemrb/gemrb/commit/7c8afb89e1e09d2a042ab9366410fc926759b159
[20:37:13] <Pepelka> [commit] lynxlynxlynx: FinishLevelUp: don't reapply the kit if it didn't change https://github.com/gemrb/gemrb/commit/3ea791b0d23575472891daf65e42b1a9c64fe1b8
[21:59:52] --> edheldil_ has joined #gemrb
[21:59:53] --> phao has joined #gemrb
[22:09:03] <-- lynxlynxlynx has left IRC (Ping timeout: 244 seconds)
[22:33:42] <-- edheldil_ has left IRC (Ping timeout: 260 seconds)
[22:36:36] <Pepelka> [commit] lynxlynxlynx: guirec: eh, just save the kit immediately https://github.com/gemrb/gemrb/commit/a728055375d2322c073deaacd62fd2e669b43034
[22:36:37] <Pepelka> [commit] lynxlynxlynx: Feats: added kit support to the level-up path https://github.com/gemrb/gemrb/commit/513ab6ae5c8a7c2526d35ccf95c633c316551cdc
[22:36:38] <Pepelka> [commit] lynxlynxlynx: Skills: the skill points table has no kits https://github.com/gemrb/gemrb/commit/42498f0a672b881ab9ab010ed72152153625af20
[22:36:39] <Pepelka> [commit] lynxlynxlynx: PCStatsStruct: split out an Init method for reinit purposes https://github.com/gemrb/gemrb/commit/474b39d83f2d1d229ab386c187ada54c29f97e20
[22:36:41] <Pepelka> [commit] lynxlynxlynx: FillPlayerInfo: clean PCStatsStruct in iwd2 https://github.com/gemrb/gemrb/commit/3f3d8b1b45e628376e1a7a356f4d834a6610060e
[22:40:03] --> lynxlynxlynx has joined #gemrb
[22:40:03] --- ChanServ gives channel operator status to lynxlynxlynx
[22:54:20] <-- phao has left IRC (Ping timeout: 264 seconds)
[23:04:02] --> phao has joined #gemrb
[23:20:45] <-- phao has left IRC (Ping timeout: 256 seconds)