#gemrb@irc.freenode.net logs for 17 Dec 2011 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage


[00:03:53] --> brad_a_ has joined #gemrb
[00:07:05] <-- brad_a has left IRC (Ping timeout: 255 seconds)
[00:08:19] <-- brad_a_ has left IRC (Ping timeout: 252 seconds)
[00:21:10] --> brad_a has joined #gemrb
[00:21:16] <-- brad_a has left IRC (Remote host closed the connection)
[00:21:25] --> brad_a has joined #gemrb
[00:25:23] --> brad_a_ has joined #gemrb
[00:25:56] <-- brad_a_ has left IRC (Client Quit)
[00:27:26] <-- brad_a has left IRC (Ping timeout: 240 seconds)
[00:36:46] <-- PixelScum has left IRC (Ping timeout: 240 seconds)
[00:38:38] --> Drakkar has joined #gemrb
[01:10:27] <-- Yoshimo has left IRC (Ping timeout: 240 seconds)
[02:13:21] --> joneirik has joined #gemrb
[03:19:47] --> PixelScum has joined #gemrb
[03:22:17] <-- Drakkar has left IRC (Ping timeout: 252 seconds)
[03:34:54] --> Drakkar has joined #gemrb
[03:35:06] <-- PixelScum has left IRC (Ping timeout: 240 seconds)
[03:35:37] --> PixelScum has joined #gemrb
[03:35:49] <-- PixelScum has left IRC (Read error: Connection reset by peer)
[04:44:03] --> PixelScum has joined #gemrb
[04:47:27] <-- Drakkar has left IRC (Ping timeout: 276 seconds)
[05:26:19] <-- PixelScum has left IRC (Read error: Connection reset by peer)
[05:55:03] <-- joneirik has left IRC (Remote host closed the connection)
[08:46:17] --> lynxlynxlynx has joined #gemrb
[08:46:18] <-- lynxlynxlynx has left IRC (Changing host)
[08:46:18] --> lynxlynxlynx has joined #gemrb
[08:46:18] --- ChanServ gives channel operator status to lynxlynxlynx
[10:53:08] <lynxlynxlynx> fuzzie: the malloc fix you made now crashes
[10:53:21] <lynxlynxlynx> http://forums.gibberlings3.net/index.php?showtopic=23661&pid=194480&st=0&#entry194480
[10:53:41] <lynxlynxlynx> i thought it was a setup issue, since when i was playing, i didn't have the problem, but it turns out, i can reproduce it
[10:54:32] <lynxlynxlynx> maybe strlen crashes, since it gets fed a null from GetName
[10:54:35] <fuzzie> ah, whose fault is that?
[10:54:40] <fuzzie> yes, that is the only possible culprit
[10:55:29] <lynxlynxlynx> just make it fallback to spell as before?
[10:55:39] <fuzzie> before?
[10:56:10] <fuzzie> git says it's been using GetName since you added the code
[10:57:36] <lynxlynxlynx> - tmp = (char *) malloc(strlen(msg)+strlen(spell)+4);
[10:57:36] <lynxlynxlynx> + tmp = (char *) malloc(strlen(spell)+strlen(GetName(-1))+4);
[10:57:45] <fuzzie> yes, that was a bug
[10:58:05] <lynxlynxlynx> in this case, spell does contain good info
[10:58:19] <fuzzie> i mean, my patch was 100% correct
[10:58:36] <lynxlynxlynx> yes
[10:58:50] <lynxlynxlynx> but we'll need to change the print too to avoid empty messages
[10:58:52] <fuzzie> if GetName(-1) is returning NULL in some cases then it should be checked further up, right?
[10:59:53] <fuzzie> or should there still be a print when a trap is casting?
[11:00:06] <fuzzie> i can't remember ever seeing messages when a trap casted in original
[11:00:11] <lynxlynxlynx> we used to have a hardcoded "trap" in there somewhere
[11:00:21] <lynxlynxlynx> me neither
[11:00:36] --> duckpunch has joined #gemrb
[11:01:17] <fuzzie> i think just adding a '&& Type == ST_ACTOR' to the 'stricmp(spell, "")' check would be my fix
[11:01:25] <fuzzie> but you're much more of an expert in this area then i am
[11:02:18] <lynxlynxlynx> i'm wondering whether it should cause the triggers too (SeeSpellCast)
[11:03:20] <fuzzie> i think yes
[11:04:41] <lynxlynxlynx> ok
[11:04:51] <fuzzie> i'm not sure, i remember one specific special case
[11:05:18] <fuzzie> oh, i am thinking of TrapTriggered
[11:05:24] <fuzzie> so, i think i have no idea
[11:06:18] <fuzzie> although: since the SpellCast triggers all have matching, probably spell casts by non-actors are ignored anyway?
[11:06:59] <fuzzie> so probably it doesn't matter and wrapping it higher up is fine too
[11:08:19] <lynxlynxlynx> too late
[11:08:27] <fuzzie> hehe, ok
[11:09:33] <CIA-41> GemRB: 03lynxlupodian * rf86147fd0f10 10gemrb/gemrb/core/Scriptable/Scriptable.cpp:
[11:09:33] <CIA-41> GemRB: CreateProjectile: avoid crash by only printing spellcasting messages for actors
[11:09:33] <CIA-41> GemRB: fixes crash in the lightning room of ci
[11:32:50] --> Yoshimo has joined #gemrb
[12:50:51] <-- DrMcCoy has left IRC (Ping timeout: 240 seconds)
[13:15:29] --> DrMcCoy has joined #gemrb
[13:35:59] <-- DrMcCoy has left IRC (Quit: He's dead, Jim)
[13:37:05] --> DrMcCoy has joined #gemrb
[14:27:53] --> fffffffff11111 has joined #gemrb
[14:42:44] <-- fffffffff11111 has left #gemrb
[14:43:08] --> fffffffff11111 has joined #gemrb
[14:57:05] --> Beholder has joined #gemrb
[14:57:56] <-- fffffffff11111 has left #gemrb
[14:58:14] --> fffffffff11111 has joined #gemrb
[15:07:46] <-- fffffffff11111 has left #gemrb
[15:08:10] --> fffffffff11111 has joined #gemrb
[15:18:54] <-- duckpunch has left IRC (Quit: leaving)
[15:26:59] <-- fffffffff11111 has left #gemrb
[15:27:23] --> fffffffff11111 has joined #gemrb
[15:50:28] --> Demitar has joined #gemrb
[16:06:21] --> Drakkar has joined #gemrb
[16:16:35] <-- Yoshimo has left IRC (Quit: Yoshimo)
[16:34:43] <-- fffffffff11111 has left IRC (Quit: fffffffff11111)
[16:46:34] --> hanicka has joined #gemrb
[16:48:12] <-- hanicka has left IRC (Remote host closed the connection)
[17:09:07] --> PixelScum has joined #gemrb
[17:11:35] <-- Drakkar has left IRC (Ping timeout: 240 seconds)
[17:59:01] <-- Demitar has left IRC (Ping timeout: 252 seconds)
[18:12:57] --> SiENcE has joined #gemrb
[18:25:12] <lynxlynxlynx> eeh, annoying actions
[18:27:30] <lynxlynxlynx> cut225b destroys mellisan intentionally
[18:28:05] <lynxlynxlynx> no condition either
[18:28:50] <lynxlynxlynx> now, it is expected, since the guards take her to the stair exit, but she isn't respawned to start the dialog after the battle
[18:29:15] <-- Beholder has left #gemrb
[18:34:27] <lynxlynxlynx> her saradush ref is mentioned only in another area
[18:49:28] <lynxlynxlynx> i wonder how it worked before :)
[18:50:54] <lynxlynxlynx> from the lp videos it seems there's an almost instant cutscene after the battle ends
[18:50:59] <lynxlynxlynx> i guess that should spawn her
[18:53:44] <lynxlynxlynx> found it, part of baldur.bcs
[18:54:40] <lynxlynxlynx> fuzzie: http://pastebin.com/NDwrQeiP <-- could this also be a victim of the instants problem?
[18:55:53] <lynxlynxlynx> that ClearAllActions could mess everything up if it is run at the wrong time
[19:07:38] --> Yoshimo has joined #gemrb
[22:48:08] <-- lynxlynxlynx has left IRC (Read error: Connection reset by peer)
[23:50:49] <-- SiENcE has left IRC (Quit: cya)