[00:38:30] <-- kida has left IRC (Ping timeout: 264 seconds)
[04:01:06] <-- Drakkar has left IRC (Read error: Connection reset by peer)
[04:02:47] --> Drakkar has joined #gemrb
[04:43:05] --> kida has joined #gemrb
[04:43:49] <-- kida has left IRC (Remote host closed the connection)
[06:45:04] <-- brada has left IRC (Quit: brada)
[09:34:59] --> lynxlynxlynx has joined #gemrb
[09:35:00] <-- lynxlynxlynx has left IRC (Changing host)
[09:35:00] --> lynxlynxlynx has joined #gemrb
[09:35:00] --- ChanServ gives channel operator status to lynxlynxlynx
[09:46:06] --> fizzle has joined #gemrb
[10:42:24] --> Yoshimo has joined #gemrb
[12:54:08] --> traveler__ has joined #gemrb
[14:23:48] <-- traveler__ has left IRC (Ping timeout: 245 seconds)
[15:06:31] <-- Yoshimo has left IRC (Read error: Connection reset by peer)
[15:34:00] --> kingron has joined #gemrb
[16:01:07] --> brada has joined #gemrb
[17:03:03] <gembot> build #323 of osx-xcode-binary is complete: Success [3build successful] Build details are at http://buildbot.gemrb.org/builders/osx-xcode-binary/builds/323
[17:09:38] --> rocket_hamster has joined #gemrb
[17:19:46] <lynxlynxlynx> rocket_hamster: do you have time today to finish that coop?
[17:42:30] --> ronsen has joined #gemrb
[17:45:08] <-- kingron has left IRC (Ping timeout: 245 seconds)
[17:58:53] <-- Cable_ has left IRC (Ping timeout: 240 seconds)
[18:05:44] <fizzle> lynxlynxlynx: http://paste.debian.net/hidden/a5ec93e5/
[18:05:51] <Seniorita> Debian Pastezone
[18:05:51] <fizzle> does that look right to you?
[18:06:44] <fizzle> I think we're applying AC and Thac0 effects twice otherwise
[18:12:25] --> Cable_ has joined #gemrb
[18:24:29] <lynxlynxlynx> you think? do you have an actual bug somewhere?
[18:25:02] <lynxlynxlynx> it was fine with everything i tested, but it maybe did not involve extra effect queues, which is partly why that TODO was left there
[18:29:50] <fizzle> nothing tangible, tbh
[18:30:23] <fizzle> but I had a couple of situations where I seemed to not hit anything at all
[18:30:41] <fizzle> I can't prove that's the cause, though
[18:31:09] <fizzle> but it seems logical that with another effect queue you'd apply stuff twice there
[18:56:58] <-- rocket_hamster has left IRC (Read error: Connection reset by peer)
[19:13:49] <lynxlynxlynx> mhm
[19:15:12] <lynxlynxlynx> but it is better to just uncomment the two inner calls then, so the other queue doesn't inherit the whole previous values
[19:15:46] <lynxlynxlynx> AddAllEffects also executes them
[20:08:00] <-- brada has left IRC (Quit: brada)
[20:32:52] <fizzle> the queue doesn't keep any values though, does it?
[21:12:23] <lynxlynxlynx> which queue?
[21:22:22] --> brada has joined #gemrb
[21:31:34] <fizzle> the extra one (fx)
[21:32:17] <lynxlynxlynx> the effects could modify ToHitStats and AC
[21:32:51] <fizzle> shouldn't it be enough to reset them afterwards?
[21:33:18] <fizzle> ie. why before *and* after?
[21:33:40] <lynxlynxlynx> percentage increases for example
[21:34:01] <lynxlynxlynx> it has to be done before, so it starts at the basestats or similar
[21:34:22] <lynxlynxlynx> otherwise it would work on the full values from the previous tick
[21:35:00] <fizzle> but as I understand it what fx->AddAllEffects applies is entirely irrelevant
[21:35:09] <fizzle> because it will be reapplied later on
[21:36:16] <lynxlynxlynx> not sure if it could have any side effects
[21:37:09] <-- ronsen has left IRC (Quit: Leaving)
[21:38:28] <lynxlynxlynx> probably doesn't matter
[21:39:31] <lynxlynxlynx> nice fixes btw
[21:41:38] <fizzle> thanks, I think it was my third attempt at getting the polymorph stuff to work today :P
[21:41:50] <fizzle> didn't let me sleep at night...
[21:42:49] <lynxlynxlynx> hehe
[21:43:02] <fizzle> it's still not quite perfect, though, because the other effects of the polymorph spell linger if it isn't stopped using the "normal form" polymorph spell
[21:43:25] <fizzle> no idea how to fix that
[21:43:46] <lynxlynxlynx> you mean only the polymorph has a duration set?
[21:43:58] <fizzle> no
[21:44:04] <lynxlynxlynx> or the multiple form change
[21:44:32] <fizzle> the spell has polymorph, spell hit, create item etc.
[21:45:02] <fizzle> they all have duration set
[21:45:08] <fizzle> but if you polymorph again, you add all the same effects again
[21:45:17] <fizzle> and we only kill the fx_polymorph
[21:45:42] <lynxlynxlynx> you could improve that bit in the effect
[21:45:42] <fizzle> "polymorph to normal" explicitly undoes those
[21:45:55] <lynxlynxlynx> we have code to look up effects by resource too
[21:46:15] <fizzle> you don't know the resource
[21:46:39] <lynxlynxlynx> you look it up from the past effect
[21:46:57] <lynxlynxlynx> you can have only one polymorph at a time, so you can grab the group there
[21:47:31] <fizzle> how do you know which remove item belonged to the previous polymorph?
[21:47:41] <fizzle> effect source?
[21:50:59] <lynxlynxlynx> yes
[21:51:31] <lynxlynxlynx> there's also a SourceType iirc that tells you if it is from an item or a spell, but it shouldn't matter here
[22:17:42] <-- brada has left IRC (Quit: brada)
[22:38:07] <fizzle> hm, RemoveAllEffects(source) currently only removes live effects
[22:38:31] <fizzle> is that limitation necessary?
[22:41:58] <fizzle> (or even desirable)
[22:52:06] <lynxlynxlynx> no idea, would have to check the users
[22:52:18] <fizzle> there aren't many
[23:03:17] <lynxlynxlynx> i'm at work :s
[23:04:21] <fizzle> that's no time to be at work
[23:05:15] <fizzle> but anyway, I suspect the live check can be removed
[23:05:27] <fizzle> if you can confirm or deny let me know
[23:05:34] <fizzle> I'm off to bed
[23:05:45] <fizzle> sounds better than work to me... ;)
[23:08:32] <-- fizzle has left #gemrb
[23:25:12] <lynxlynxlynx> fake sense of urgency and all that crap