[00:55:03] <-- Gekz has left IRC (Quit: This computer has gone to sleep)
[01:30:28] --> Gekz has joined #GemRb
[02:56:14] <-- Gekz has left IRC (Quit: This computer has gone to sleep)
[04:16:57] --> Gekz has joined #GemRb
[04:32:21] <-- Nomad010 has left IRC (Ping timeout: 276 seconds)
[04:47:22] --> raevol has joined #GemRb
[05:18:43] <tomprince> What is the point of the true branch of if(type) in GameScript::SaveGame (in Actions.cpp)? It seems that all the savegame.2da tables have default value 0, so the else branch is the only branch ever taken.
[05:39:36] <-- raevol has left IRC (Quit: Leaving.)
[06:26:49] <-- Gekz has left IRC (Quit: This computer has gone to sleep)
[07:07:28] --> Gekz has joined #GemRb
[07:15:00] <-- Gekz has left IRC (Read error: Connection reset by peer)
[07:18:15] --> Gekz has joined #GemRb
[07:32:43] <tomprince> or.cz/python: Very very HACKISH start at exposing SaveGame objects to python. I think the C++ side is mostly done (modulo cleanup), but only bg2/GUILoad is updated.
[08:21:24] --> stefano-k has joined #GemRb
[08:22:16] --> lynxlynxlynx has joined #GemRb
[08:22:17] --- ChanServ gives channel operator status to lynxlynxlynx
[08:37:53] <fuzzie> tomprince: to support localisation, i guess?
[08:38:25] <fuzzie> hm, that doesn't make much sense either
[09:13:21] <-- Gekz has left IRC (Read error: Connection reset by peer)
[09:18:37] --> Gekz has joined #GemRb
[09:29:35] <-- Gekz has left IRC (Read error: Connection reset by peer)
[09:30:38] --> Gekz has joined #GemRb
[10:14:56] --> kettuz has joined #GemRb
[10:55:19] <-- lynxlynxlynx has left IRC (*.net *.split)
[10:57:37] --> lynxlynxlynx has joined #GemRb
[10:57:37] --- ChanServ gives channel operator status to lynxlynxlynx
[12:03:57] <tomprince> fuzzie: Do you see any reason not to drop that bit, and move the table lookup to SaveGameIterator?
[12:04:25] <fuzzie> well, yes.
[12:04:34] <fuzzie> because the code was added for some reason.
[12:05:09] <fuzzie> perhaps someone should maintain a "list of things to ask Avenger" wiki page
[12:05:50] <lynxlynxlynx> heh
[12:06:08] <lynxlynxlynx> checking the history reveals nothing?
[12:06:33] <fuzzie> it was added in one of those commits which touches a whole bunch of things, and there's never been a savegame.2da with a non-0 default.
[12:12:12] <tomprince> Well. But if there is a reason to have use it always, hence having the code in one place?
[12:12:28] <fuzzie> i don't understand what you're saying
[12:13:03] <tomprince> There is also code to get the information from the table in GameControl, but it does do that check.
[12:14:12] <fuzzie> i mean, *none* of those code is correct as-is, right?
[12:14:16] <fuzzie> erm, none of this code.
[12:15:51] <fuzzie> but you want to put all the quicksave/autosave logic into SaveGameIterator, including the slot calculation?
[12:16:04] <tomprince> This code? The table reading stuff. Given what is in the tables, it all works right now. If tables were changed, then no.
[12:16:54] <fuzzie> it doesn't work properly right now, afaics
[12:18:08] <fuzzie> i don't have disassemblies of anything except ToB, but i imagine this code is meant to handle another game.
[12:18:47] <fuzzie> maybe the relevant point for you is, as discussed before: "this code isn't used by any data I have" is a terrible reason to break code.
[12:19:01] <fuzzie> my point is more that the other path doesn't work *anyway*.
[12:19:27] <fuzzie> the ToB mapping is missing entirely, and that's just for the one game I have disasm of the action for.
[12:19:50] <fuzzie> (0-2 should be mapped to 3-5 in ToB mode)
[12:21:34] <fuzzie> the original game does that mapping in the action, but i assume the GUI should obey that too, if so doing that in a central place makes sense, but i'm not sure about consequences for the other games.
[12:23:19] <fuzzie> ok, yes, that other path is for iwd2.
[12:23:51] <fuzzie> the savegame.2da is just wrong.
[12:24:37] <fuzzie> iwd2/ar1000.baf: SaveGame(16202) // ~Prologue~
[12:24:39] <fuzzie> iwd2/ar1201.baf: SaveGame(39843) // ~Visiting Shawford at the Palisade~
[12:24:42] <fuzzie> iwd2/ar5200.baf: SaveGame(16206) // ~Chapter Four~
[12:24:44] <fuzzie> iwd2/ar6050.baf: SaveGame(39588) // ~Guardian Slain, Portal Collapsing~
[12:24:47] <fuzzie> iwd2/61pfexit.baf: SaveGame(39725) // ~Prevent Izbelah from casting Temporal Stasis~
[12:24:50] <fuzzie> ^- eg
[12:27:46] <fuzzie> i don't see any strref uses in the other games, so i assume it's iwd2-only
[12:30:15] <lynxlynxlynx> i don't remember chapter autosaves from elsewhere either
[12:30:25] <tomprince> I'll fix that up then.
[12:30:47] <-- Gekz has left IRC (Quit: This computer has gone to sleep)
[12:31:23] <lynxlynxlynx> not in my scripts either
[12:31:35] <fuzzie> tomprince: ok, great :)
[12:32:54] <CIA-13> GemRB: 03lynxlupodian * re05662ca3124 10gemrb/gemrb/override/shared/dmgtypes.2da: treat soul eater damage as magic damage when deciding what message to display
[12:33:30] <fuzzie> i really doubt that action code is correct, though
[12:33:40] <fuzzie> it does CreateSaveGame with int0parameter as the slot?
[12:34:15] <fuzzie> so that is presumably another problem, but i don't have a runnable copy of iwd2 handy
[12:44:56] <fuzzie> and google is unhelpful
[12:53:02] <tomprince> Do you know how to trigger the buggy save slot code? or.cz/python seems to be working, but I'd like to test that the fix actually fixes the case I sent out to fix.
[12:59:22] <lynxlynxlynx> + if (int cansave = CanSave()) <-- yuck
[12:59:25] <fuzzie> sure, just take an empty savegame directory and try quicksaving
[13:00:38] <tomprince> Yeah, I know. It needs a bunch of cleanup.
[13:01:59] <tomprince> I'd be more interested in the comments on the python side.
[13:02:52] <fuzzie> well, you shouldn't be doing 'Games = 0
[13:02:53] <fuzzie> '
[13:03:26] <fuzzie> and you replaced a comment which makes sense with one that doesn't..
[13:03:58] <fuzzie> and the Holder commit should be seperate
[13:04:33] <tomprince> Yes. I was more interested in getting something that worked. I do plan to split it up and clean it up.
[13:05:02] <fuzzie> but it doesn't seem to work as-is
[13:05:26] <fuzzie> did i miss a commit with things like MakePyList in it?
[13:07:12] <tomprince> I did.
[13:07:22] <fuzzie> ok. well, helpful to have.
[13:07:42] <tomprince> Should be up now.
[13:07:47] <fuzzie> i already said that i thought passing (index,name) tuples back to python is what i'd do
[13:08:39] <fuzzie> if you insist on passing pointers into pythonland, the api seems fine
[13:10:21] <fuzzie> but i would suggest you get wjp or edheldil to look at it
[13:11:34] <fuzzie> but i think most of the problems seem to be non-design-stuff, like the comments, so if you haven't tidied it yet..
[13:12:35] --> Gekz has joined #GemRb
[13:12:46] <fuzzie> oh, and of course you broke the SaveGame action, but you know that
[13:13:26] <tomprince> :)
[13:14:35] <fuzzie> and obviously there are unrelated changes in here, i always hate it when that happens
[13:14:54] <fuzzie> git add -i only saves me for so long..
[13:16:21] <tomprince> I don't think there is anything entirely unrelated, but a bunch of stuff that should be in sepeate commits.
[13:16:36] <tomprince> And now that I want to trigger it, I can seem to trigger it, with trunk.
[13:17:24] <lynxlynxlynx> with an empty (mp)save?
[13:17:56] <fuzzie> i would keep the sanity check somewhere, in the (!save) branch..
[13:19:23] <fuzzie> in fact i guess maybe i should put some sanity checking myself before the DelTree call once you commit this, making sure the directory is actually a sane one, etc
[13:21:30] <fuzzie> but, time :|
[13:22:06] <tomprince> IT seems to trigger when you have >=2 saves, but no 000001 save, and you try to quicksave.
[13:22:30] <fuzzie> or in various other situations
[13:22:48] <fuzzie> i mean, you understand the problem? the code tries treating slot numbers as indexes into the directory entries, so any time you have gaps of any kind, it breaks
[13:23:15] <fuzzie> as far as i can tell, your code doesn't do that, so it seems like it should fix it all
[13:23:35] <tomprince> Yes.
[13:23:54] <tomprince> And I found a case where trunk triggers it, and my patch works.
[13:26:17] <fuzzie> so, ^.^ victory ^.^ ? :)
[13:26:44] <tomprince> Seems so. :)
[13:27:07] <lynxlynxlynx> btw, i think we should do a new release in a few weeks, depending on the speed of our progress
[13:27:30] <lynxlynxlynx> not before the end of may
[13:27:34] <tomprince> I'll see about cleaning it tonight.
[13:27:51] <tomprince> In the mean time, I should go and do some real work. :)
[13:29:25] <lynxlynxlynx> :)
[13:30:59] <edheldil> is there something easy I could do?
[13:31:05] <edheldil> for the release
[13:32:00] <lynxlynxlynx> probably
[13:33:53] <lynxlynxlynx> maybe add support for npclevel.2da (probably shared), npclvl25.2da (tob) handling
[13:34:57] <fuzzie> fix the silly gui list sort order? :)
[13:35:31] <lynxlynxlynx> http://gemrb.sourceforge.net/wiki/doku.php?id=todo <-- plenty of todos
[13:36:32] <-- kettuz has left IRC (Quit: Leaving)
[13:37:12] <edheldil> heh
[13:37:58] <fuzzie> i think the only stuff i have pending here is annoying messy messaging stuff..
[13:42:15] <lynxlynxlynx> i'll be working on modal actions, but time will become more and more scarce for a while
[15:01:23] <CIA-13> GemRB: 03lynxlupodian * rbddcf4248dff 10gemrb/gemrb/ (106 files in 21 dirs): Merge branch 'master' of ssh://gemrb.git.sourceforge.net/gitroot/gemrb/gemrb
[15:16:41] <wjp> CIA doesn't seem to give the most useful messages here
[15:21:32] <-- stefano-k has left IRC (Quit: Sto andando via)
[15:25:58] <tomprince> Perhaps if you merge the other way.
[15:34:44] --> budlust has joined #GemRb
[16:19:30] <tomprince> By the way, cmake generates working MSVC6 project files.
[16:20:01] <fuzzie> ooh, neat.
[16:20:32] <tomprince> Except that it includes snprintf.c, and a couple of minor breakages.
[16:36:52] <wjp> I guess here at work we should evaluate cmake too... different platform configurations getting out of sync is driving me insane
[16:39:36] <fuzzie> it's pretty good as long as you're not cross-compiling
[17:47:31] --> kettuz has joined #GemRb
[18:05:18] <-- budlust has left IRC (Remote host closed the connection)
[18:05:37] --> budlust has joined #GemRb
[19:58:15] <-- budlust has left IRC (Ping timeout: 240 seconds)
[19:58:58] --> budlust has joined #GemRb
[20:36:50] <-- budlust has left IRC (Ping timeout: 240 seconds)
[21:41:21] <-- kettuz has left IRC (Quit: Leaving)
[21:48:09] --> cubathy has joined #GemRb
[22:14:23] <-- cubathy has left IRC (Quit: Leaving)
[23:43:13] <-- Gekz has left IRC (Quit: This computer has gone to sleep)