#gemrb@irc.freenode.net logs for 18 Jan 2015 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage

[02:14:17] --> turtleman_ has joined #gemrb
[03:09:08] <-- erdic has left IRC (Ping timeout: 245 seconds)
[03:10:48] --> erdic has joined #gemrb
[06:10:10] <-- Lightkey has left IRC (Ping timeout: 265 seconds)
[06:22:39] --> Lightkey has joined #gemrb
[07:18:52] <-- turtleman_ has left IRC (Ping timeout: 255 seconds)
[09:10:02] <-- Eli2_ has left IRC (Quit: Ex-Chat)
[09:22:22] --> raevol has joined #gemrb
[10:25:35] <Pepelka> [commit] lynxlynxlynx: GUIREC: clarified comment https://github.com/gemrb/gemrb/commit/ba1185a8d4a95a08bfd7d022c7687e76a19f33f3
[10:25:36] <Pepelka> [commit] lynxlynxlynx: GUIREC: fixed extraneus newlines after levels https://github.com/gemrb/gemrb/commit/405f30b0a3be5254ee410cfd56ef9e05ec438eb2
[10:25:37] <Pepelka> [commit] lynxlynxlynx: iwd2: removed temporary hack from DisplaySkills https://github.com/gemrb/gemrb/commit/0edcf53ea27600ec0b4145c7368de16ce4581106
[10:25:39] <Pepelka> [commit] lynxlynxlynx: LoadScreen: keep the hint lookup within table bounds https://github.com/gemrb/gemrb/commit/0c55618a5652b4b10de767f3317c806c3c43c083
[11:40:49] <-- raevol has left IRC (Quit: Leaving)
[12:36:31] <Pepelka> [commit] lynxlynxlynx: Interface::InitializeVarsWithINI: fixed silly leak fix https://github.com/gemrb/gemrb/commit/09c132bb87b14bdd21ee6e3655fb9d676722c99c
[12:36:32] <Pepelka> [commit] lynxlynxlynx: GetCString: handle invalid seeks gracefully https://github.com/gemrb/gemrb/commit/d6c4e0af0564e13e37d02fcb1af6fc3b41a573a8
[12:36:33] <Pepelka> [commit] lynxlynxlynx: Font::GetGlyph: avoid reading random memory https://github.com/gemrb/gemrb/commit/5dca1b8f25f18f4fcb6855049dc4e77403ea072e
[12:36:34] <Pepelka> [commit] lynxlynxlynx: InitializeVarsWithINI: always set overrides, so we can't crash https://github.com/gemrb/gemrb/commit/a85ca78c89a178a361df54f1f727735fa8b8c40b
[13:10:04] --> Eli2 has joined #gemrb
[13:57:01] --> Driim has joined #gemrb
[14:18:29] <-- Driim has left IRC (Ping timeout: 246 seconds)
[14:54:21] --> Driim has joined #gemrb
[15:25:57] --> turtleman_ has joined #gemrb
[15:31:11] <-- Driim has left IRC (Ping timeout: 256 seconds)
[15:34:46] --> Driim has joined #gemrb
[16:51:33] <-- Eli2 has left IRC (Ping timeout: 265 seconds)
[17:18:39] <-- turtleman_ has left IRC (Ping timeout: 264 seconds)
[17:20:18] <-- gembot has left IRC (Remote host closed the connection)
[17:20:42] --> gembot has joined #gemrb
[17:39:33] <-- Driim has left IRC (Ping timeout: 276 seconds)
[17:47:02] <lynxlynxlynx> edheldil: if you feel bored, I'd appreciate cre2.2 support in iesh
[18:04:17] <-- Mechanimal has left #gemrb
[18:05:11] --> Mechanimal has joined #gemrb
[18:06:27] --> Driim has joined #gemrb
[18:08:23] <-- Driim has left IRC (Remote host closed the connection)
[18:43:15] --> brada has joined #gemrb
[18:46:30] <brada> lynx: its pretty easy to see when/why the ttf importer broke
[18:47:32] --> Eli2 has joined #gemrb
[18:47:38] <brada> should be easy to fix
[18:48:02] <lynxlynxlynx> coo
[18:53:23] --> Driim has joined #gemrb
[18:54:39] <Driim> Anything to fix before a pull request? https://github.com/DriimGit/gemrb/blob/master/gemrb/core/Game.cpp#L1742-1824
[18:54:42] <Pepelka> gemrb/Game.cpp at master · DriimGit/gemrb · GitHub
[18:54:43] <Pepelka> »gemrb - Engine Made with preRendered Background«
[18:56:22] <brada> Driim: I believe we prefer logging messages in english
[18:57:04] <Driim> Oh sorry, forgot that from testing. Fixing.
[18:59:17] <Driim> done.
[19:13:31] --> turtleman_ has joined #gemrb
[19:36:15] <brada> lynx: only ixed part of the problem :/ still get junk its just longer now ha ha
[19:38:01] <lynxlynxlynx> it's supposed to be DEMO*150, so long is good
[19:39:28] <brada> yeah it just was part of the problem and there is something else wrong too
[19:41:00] <brada> Driim: you can do a pull request at anytime and any additional changes will be reflected there. its easier to comment on a pull request so i can add comments about specific lines etc
[19:41:04] <lynxlynxlynx> Driim: the second specialCount != -1 check looks redundant
[19:42:14] <lynxlynxlynx> flags & SP_HEAL_ALL should be flags & (SP_HEAL_ALL|SP_REST)
[19:43:26] <lynxlynxlynx> consistent use of spaces would be good too
[19:44:16] <lynxlynxlynx> and if nobody is injured, SP_REST spells won't be cast
[19:44:26] <lynxlynxlynx> that's not good, it's not meant only for healing
[19:46:36] <lynxlynxlynx> it was bad before, but now the nesting is even deeper, so some helper functions would be good, also for readability
[19:54:26] <brada> agreed. there should probably be a atandalone function for getting a list of injured PCs or somethinging
[19:55:03] <brada> or possibly even better a function for returning a list of PCs that you can pass some kind of filtering/flags to
[19:55:26] <brada> that would probably be usefull in a few other places we are doing similar things
[19:56:22] <brada> tho if that is too much work for driim we can probably clean it up for him after
[20:31:38] <brada> lynx: probelm is the font size is now in pixels
[20:31:47] <brada> so 14 is too small or something
[20:32:03] <brada> not exactly sure what error it causes, but switching to 24 fixes it
[20:33:37] <brada> ok
[20:33:54] <brada> somehow we are getting a px size of 0 so thats pretty obviously wrong
[20:34:03] <brada> probably just need to update the fonts.2da file then
[20:34:32] <brada> looks like it probably didnt get updated with the rest of them is all
[20:38:40] <brada> fixed now, but we should maybe add some guard against that…
[20:38:56] <Pepelka> [commit] bradallred: Demo: update fonts.2da PT_SIZE -> PX_SIZE https://github.com/gemrb/gemrb/commit/ccf1e348356e17c992e20fbbc5b9d74cb1782571
[20:40:54] <brada> I had assumed when i was looking at it and getting 0,0 sizes that it was due to the refactor that made the empty placeholders to fill in the gaps between characters. i even checked the size in the fonts.2da file and missed that the column name was just wrong :D
[20:48:15] <lynxlynxlynx> in the end, it was over pretty fast
[21:47:25] <Driim> Thanks for the feedback. I will look into what you said and submit a pull request after for easier commenting.
[21:56:17] <Driim> so SP_REST is not just for healing spells. I left a comment at the end for the non-healing rest spells, but that was with the aforementioned assumption. What spells would these be though? Cure Disease and such perhaps?
[21:57:16] <-- turtleman_ has left IRC (Ping timeout: 255 seconds)
[21:58:23] <lynxlynxlynx> anything you want
[21:58:44] <lynxlynxlynx> i'll be playing with stoneskin there for example, as it lasts longer than 8h
[21:58:49] <lynxlynxlynx> similarly some buffs in iwd2
[21:59:04] <lynxlynxlynx> brada: the newlines are still driving me crazy
[21:59:28] <lynxlynxlynx> the last guirec case is very simple to look at if you want a more concrete start
[22:00:07] <brada> im not exactly sure what you mean
[22:04:25] <lynxlynxlynx> 405f30b0a3be
[22:04:56] <lynxlynxlynx> can't pretty print properly for single-classed pcs
[22:05:49] <brada> oh i see. i will look at that soon
[22:05:50] <lynxlynxlynx> ... and the iwd2 xp stuff is just crazy
[22:11:22] <-- Driim has left IRC (Quit: Leaving)
[23:01:17] <-- Eli2 has left IRC (Ping timeout: 265 seconds)
[23:03:21] --> Eli2 has joined #gemrb
[23:19:19] --> turtleman_ has joined #gemrb
[23:34:31] --> Eli2_ has joined #gemrb
[23:37:33] <-- Eli2 has left IRC (Ping timeout: 265 seconds)