#gemrb@irc.freenode.net logs for 19 Jan 2012 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage


[00:28:48] <-- kettuz has left IRC (Remote host closed the connection)
[01:45:12] --> joneirik has joined #gemrb
[01:59:16] <-- demitar has left IRC (Ping timeout: 240 seconds)
[02:04:16] --> brad_a has joined #gemrb
[02:04:39] <brad_a> do we really even need the quiet flaf for pause? is therre like a game preferenc for it or something?
[02:42:57] --> gembot has joined #gemrb
[03:49:09] <brad_a> tomprince,fuzzie,lynx: http://dl.dropbox.com/u/13866402/pausing.patch
[03:49:36] <brad_a> as always untested and going to bed :)
[03:51:46] <tomprince> this 'int strref = STR_PAUSED;' seems useless.
[03:52:45] <tomprince> I guess not useless, just confusing. ;)
[03:55:32] <brad_a> yes i should probably init to 0?
[03:56:39] <tomprince> Don't init it.
[03:57:52] <tomprince> Also, how about TogglePause() { SetPause(~gc->GetDialogueFlags() & DF_FREEZE_SCRIPTS); }
[03:58:32] <tomprince> (with an if(gc)) to avoid crashes ..
[03:59:35] <brad_a> sure
[04:00:12] <brad_a> tho is it necessary?
[04:01:05] <tomprince> Seems like a nicer interface, to me.
[04:02:25] <brad_a> ok
[04:19:17] <-- brad_a has left IRC (Quit: brad_a)
[05:01:08] <-- joneirik has left IRC (Remote host closed the connection)
[07:07:44] --> lynxlynxlynx has joined #gemrb
[07:07:45] <-- lynxlynxlynx has left IRC (Changing host)
[07:07:45] --> lynxlynxlynx has joined #gemrb
[07:07:45] --- ChanServ gives channel operator status to lynxlynxlynx
[09:01:10] <edheldil> fuzzie: re SOPA, allegedly Google originally considered blacking out too, in the end they only added a tiny statement which took us some time to find at all. Apparently the shareholders did not want to threaten their Ad revenue :/
[09:01:47] <fuzzie> Google's stuff was a lot more obvious from US IP addresses
[09:02:11] <fuzzie> a lot of the adsense ads replaced with anti-SOPA message, the logo blacked out, etc
[09:03:36] <fuzzie> but I can understand them not wanting their shareholders to turn up with pitchforks and torches
[09:04:25] <edheldil> ah, ok, that makes sense. We saw google.cz without any mention, so when "engish version of Google.com" gave us a normal page that tiny statement, we thought that's all
[09:04:54] <edheldil> with that tiny ...
[11:44:24] --> demitar has joined #gemrb
[12:39:38] <-- edheldil has left IRC (Remote host closed the connection)
[13:26:36] <-- demitar has left IRC (Ping timeout: 240 seconds)
[18:21:19] --> Yoshimo has joined #gemrb
[18:42:00] <-- Yoshimo has left IRC (Quit: Yoshimo)
[18:44:30] --> kettuz has joined #gemrb
[19:49:28] --> SiENcE has joined #gemrb
[20:28:23] <-- lynxlynxlynx has left IRC (Remote host closed the connection)
[20:29:29] --> lynxlynxlynx has joined #gemrb
[20:29:30] <-- lynxlynxlynx has left IRC (Changing host)
[20:29:30] --> lynxlynxlynx has joined #gemrb
[20:29:30] --- ChanServ gives channel operator status to lynxlynxlynx
[20:32:15] --> Yoshimo has joined #gemrb
[20:53:44] --> brad_a has joined #gemrb
[21:12:25] --> demitar has joined #gemrb
[22:20:36] <brad_a> fuzzie,lynx,tomprince: http://dl.dropbox.com/u/13866402/pause3.patch
[22:20:46] <brad_a> still needs testing of course :-P
[22:21:16] <fuzzie> um
[22:21:20] <fuzzie> why the >> 3?
[22:22:07] <fuzzie> if you really have some good reason for not e.g. casting to bool then do put a big big warning sign next to the define of the constant
[22:22:37] <fuzzie> and for that matter why the PauseSetting rather than a bool?
[22:23:55] <fuzzie> also I would give quiet a default value of false..
[22:25:11] <brad_a> hm lol no i was jsut to dense to cast to bool
[22:26:26] <fuzzie> also you have changed the code so that it no longer displays two autopauses if you get two in a frame, which is not so nice I think
[22:26:45] <fuzzie> no?
[22:26:49] <fuzzie> oh, you did something weirder
[22:26:50] <brad_a> i did give quite a default val of false originally tomprince said it was silly! :)
[22:27:28] <fuzzie> but yes, i guess all of that
[22:27:35] <brad_a> oh i didnt realize the 2 at once thing
[22:27:45] <brad_a> didnt occur to me
[22:27:56] <fuzzie> well, I am not particuarly wedded to the default
[22:28:11] <fuzzie> but I really don't like the PauseSetting thing if it's just two values
[22:28:25] <brad_a> well i had on off and toggle too but
[22:28:41] <fuzzie> i do like the TogglePause() instead of that
[22:29:17] <brad_a> well just read the log from early this morning i guess
[22:29:23] <brad_a> right
[22:29:36] <fuzzie> oh right, his idea :)
[22:29:47] <brad_a> im not sure why tomprince suggested an enum then
[22:29:48] <fuzzie> the refactoring is nice though.
[22:31:43] <tomprince> Given ->SetPause(false, true), what do the two arguments mean?
[22:31:47] <fuzzie> minor things: "}else {" -> "} else {"
[22:31:56] <fuzzie> tomprince: well, that would be why I'd just leave it as SetPause(false) with a default argument
[22:32:36] <fuzzie> then it needs one comment, in the Autopause function which has SetPause directly above it for reference
[22:32:44] <fuzzie> s/in the/with the/
[22:33:40] <fuzzie> not wedded to the idea, just seems very overcomplicated atm
[22:34:03] <tomprince> Neither am I.
[22:34:26] <tomprince> The first patch seemed to have a more complicated interface than this one. But maybe I am imagining things.
[22:35:08] <fuzzie> well actually, I suppose SetPause(PAUSE_OFF, true) doesn't make any more sense to me in terms of arguments anyway
[22:35:47] <fuzzie> but this is perhaps because I've spent the entire day staring at computation theory rather than an actual thing.
[22:36:09] <tomprince> Certainly having a single enum and then a bool isn't much better.
[22:36:39] <fuzzie> oh right, could put quiet in the enum. maybe good.
[22:38:05] <brad_a> ?
[22:43:56] <tomprince> 'int strref = STR_UNPAUSED-pause;' is too magical.
[22:44:26] <brad_a> as magical as tis: displaymsg->DisplayConstantString(STR_AP_UNUSABLE+flag, DMC_RED);
[22:45:17] <tomprince> Well, that is magical too.
[22:45:22] <tomprince> not quite as magical.
[22:46:14] <tomprince> And I'd be tempted to switch on pause, instead of if, if you use an enum.
[22:46:20] <brad_a> ok ill go back to how it was in the last revision
[22:46:50] <brad_a> i dont follow your last statement
[22:47:02] <brad_a> oh switch(pause)
[22:47:05] <brad_a> gottcha
[22:47:15] <tomprince> I'd do 'int strref; switch (pause) { case PAUSE_OFF: strref = STR_UNPAUSED; ...; break; ....}'
[22:47:41] <brad_a> yeah i just didnt read switch as a programming keyword originally :)
[22:49:20] <-- Yoshimo has left IRC (Quit: Yoshimo)
[22:57:55] <brad_a> im still unclear what we are going to do about the parameters
[22:58:19] <brad_a> other than wish c++ ethods could be as verbose as objective-c ;-)
[22:58:37] --> Baldurerd has joined #gemrb
[22:58:49] <tomprince> I think that makes 3 of us.
[23:00:25] <-- Baldurerd has left IRC (Remote host closed the connection)
[23:07:50] <-- lynxlynxlynx has left IRC (Remote host closed the connection)
[23:14:55] <CIA-36> GemRB: 03avenger_teambg * rbaaf2ffdbcc8 10gemrb/gemrb/ (core/Effect.h plugins/EFFImporter/EFFImporter.cpp): added effect Parameter5/6 they are used in some IWD2 effects
[23:16:59] <CIA-36> GemRB: 03avenger_teambg * rc99709536b10 10gemrb/gemrb/core/ (Interface.cpp Inventory.cpp Inventory.h): Inventory will be able to return the currently equipped armor's itemtype
[23:19:11] <CIA-36> GemRB: 03avenger_teambg * r251702901576 10gemrb/gemrb/ (4 files in 2 dirs): IWD2:implemented armored arcana feat, spell failure based on itemtype
[23:20:42] <CIA-36> GemRB: 03avenger_teambg * ra9a37881edd4 10gemrb/gemrb/core/Scriptable/Actor.h: fixed a messed up file
[23:21:09] <brad_a> im lovin all the IWD2 work avenger has been doing
[23:25:58] --> Hupp has joined #gemrb
[23:28:20] <CIA-36> GemRB: 03avenger_teambg * rc848ddf79143 10gemrb/gemrb/plugins/FXOpcodes/FXOpcodes.cpp: improved opcodes: disease, charm (domination), deafness
[23:28:30] <CIA-36> GemRB: 03avenger_teambg * ra96ca19e8b86 10gemrb/gemrb/plugins/IWDOpcodes/IWDOpcodes.cpp: iwd opcodes: tenser's transformation, control undead, lower resistance
[23:32:22] <-- SiENcE has left IRC (Read error: Connection reset by peer)
[23:38:10] --> Drakkar has joined #gemrb
[23:47:04] --- Hupp is now known as Stuganbars
[23:52:59] <-- Gekz has left IRC (Remote host closed the connection)
[23:54:16] <-- demitar has left IRC (Ping timeout: 240 seconds)
[23:59:08] <-- Stuganbars has left IRC (Ping timeout: 240 seconds)