[00:02:42] --> turtleman_ has joined #gemrb
[04:02:29] <-- turtleman_ has left IRC (Ping timeout: 256 seconds)
[06:03:15] <Pepelka> [commit] bradallred: Font: refactoring StringSize for force breaking https://github.com/gemrb/gemrb/commit/2982fa85526c149a447ba34759056508326dcc91
[06:03:16] <Pepelka> [commit] bradallred: Font::StringSize: keep a running count of characters instead of attempting to rewind https://github.com/gemrb/gemrb/commit/0a4a3c69571c08b31991cf1a65a4a9125a38ca38
[06:03:18] <Pepelka> [commit] bradallred: TextContainer: these conditions aren't mutually exclusive https://github.com/gemrb/gemrb/commit/8934a3f08e618770adc9c9d74cd374e1ddb65ad5
[06:09:52] <-- Lightkey has left IRC (Ping timeout: 265 seconds)
[06:22:25] --> Lightkey has joined #gemrb
[07:34:00] --> Eli2 has joined #gemrb
[11:39:21] --> Eli2_ has joined #gemrb
[11:40:52] <-- Eli2 has left IRC (Ping timeout: 240 seconds)
[13:54:22] --> Eli2 has joined #gemrb
[13:55:52] <-- Eli2_ has left IRC (Ping timeout: 240 seconds)
[13:59:20] --> turtleman_ has joined #gemrb
[15:44:44] --> brada has joined #gemrb
[15:46:26] <brada> lynx: let me know of any new asserts or text problems you notice since those last commits. the infinite loop shouldnt be possible anymore, however, the work is only partially complete so “bad” data can still result in an assert. dont think “good” data should be aflicted, but maybe.
[15:50:36] <brada> oh “bad data” in this context is something that would force a non natural line break (single word too long for a line)
[16:08:47] <lynxlynxlynx> only those?
[16:10:31] <brada> afik :D its a bit complicated for me to say with 100% certainty. thats why it would be helpful to report any such asserts or visual bugs.
[16:11:10] <brada> I’ll try to find time this week to work on the other half of that problem
[16:14:13] <brada> oh and do you happen to have a quick answer for this: https://github.com/gemrb/gemrb/commit/0d42ea476be9d8b371ff934e3e059f4198ea8213
[16:14:33] <Pepelka> GUIREC: fixing double "\n" bug · 0d42ea4 · gemrb/gemrb · GitHub
[16:14:34] <Pepelka> »gemrb - Engine Made with preRendered Background«
[16:15:26] <brada> I dont know if that string varies by game (i kinda doubt it)
[16:16:09] <brada> but at the same time if it were just a newline then why are we bothering with this complexity?
[16:33:07] <lynxlynxlynx> yeah, a quick grep shows it's different for all games
[16:34:04] <lynxlynxlynx> it's a literal "None"
[16:35:08] <lynxlynxlynx> not available in bg1, otherwise they all resolve to the same value
[16:42:35] <brada> hmmm i probably messed something up then. or maybe that has been broken for a while.
[16:43:49] <brada> i dont think the original outputs “None” for some of those cases we are inserting nones for
[16:45:05] <lynxlynxlynx> i'm not sure where it was needed though, only ai script comes to mind
[16:45:31] <lynxlynxlynx> pst still uses it btw
[16:46:17] <brada> ok ill try to find time to fix that today
[18:11:53] <-- Eli2 has left IRC (Ping timeout: 240 seconds)
[18:15:31] <-- strycore has left #gemrb ("Leaving")
[21:22:59] <-- turtleman_ has left IRC (Ping timeout: 272 seconds)
[21:35:02] --> turtleman_ has joined #gemrb