#gemrb@irc.freenode.net logs for 21 Apr 2016 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage

[04:32:44] <-- SinisterRectus has left IRC (Ping timeout: 244 seconds)
[07:36:52] --> GeneralDuke has joined #gemrb
[08:00:03] <-- GeneralDuke has left IRC (Quit: GeneralDuke)
[08:01:18] --> GeneralDuke has joined #gemrb
[08:37:29] <-- Drakkar has left IRC (Read error: Connection reset by peer)
[08:37:33] --> PixelScum has joined #gemrb
[09:55:39] <-- PixelScum has left IRC (Ping timeout: 260 seconds)
[15:06:59] --> Eli2| has joined #gemrb
[15:09:46] <-- Eli2_ has left IRC (Ping timeout: 244 seconds)
[16:13:38] <-- GeneralDuke has left IRC (Quit: GeneralDuke)
[18:19:51] --> phao has joined #gemrb
[18:22:27] <-- phao has left IRC (Client Quit)
[19:21:01] <kujeger> huzzah! got the double-space bug in SDL2 fixed, along with a "shift-press-is-display-as-strange-text-in-input" bug
[19:40:16] --> Drakkar has joined #gemrb
[21:01:01] <kujeger> did a pr
[21:01:53] <kujeger> but I think it would be a good thing to eventually get rid of SDL1 completely, and rewrite stuff with SDL2.. the SDL1+2 combination right now is weird
[21:10:25] <fuzzie> might be nicer to use 0x400000e5 (this is SDL_SCANCODE_RSHIFT | 0x40000000) for the constant there
[21:12:15] <fuzzie> oh you change it in the second commit :p I guess everything with 0x40000000 set isn't a valid text-generating character
[21:12:34] <fuzzie> but I'm a bit confused about your logic here, since the comment says that it's for ignoring keys that generate text, which this isn't
[21:12:51] <fuzzie> is the actual problem that the SDL 1 driver doesn't understand the keycode?
[21:56:09] <kujeger> I believe the root problem is probably that the SDL2 driver does things in a way that the shim/dispatcher in SDLVideo does not work well with
[21:57:06] <kujeger> so whenever one hit ctrl/shift, it generated a key_down event, which gemrb tried to "print"
[21:57:13] <kujeger> giving some garbage text
[21:58:41] <kujeger> however I really don't want to touch things outside SDL20Video just in case I unintentionally break something in SDL1
[21:59:25] <kujeger> and for now it seems to work fine -- text inputs are OK, and ingame use of ctrl/shift does not seem to be affected from what I have tested
[22:17:08] <kujeger> and now, bed..
[22:41:57] --> SinisterRectus has joined #gemrb