#gemrb@irc.freenode.net logs for 26 Nov 2014 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage

[04:12:27] --> Eli2_ has joined #gemrb
[04:15:50] <-- Eli2 has left IRC (Ping timeout: 265 seconds)
[06:25:24] <-- Lightkey has left IRC (Ping timeout: 265 seconds)
[06:37:55] --> Lightkey has joined #gemrb
[08:35:48] --> edheldil_ has joined #gemrb
[08:44:01] <-- edheldil_ has left IRC (Ping timeout: 272 seconds)
[09:21:58] <-- raevol has left IRC (Quit: Leaving)
[13:16:10] <-- DrMcCoy has left IRC (Ping timeout: 255 seconds)
[13:21:29] --> DrMcCoy has joined #gemrb
[17:17:47] --> kpedersen has joined #gemrb
[17:20:56] <-- kpederse1 has left IRC (Ping timeout: 250 seconds)
[17:56:02] --> fizzle has joined #gemrb
[18:10:50] <fizzle> lynxlynxlynx: wouldn't the IF_VISIBLE check be better off in ValidTarget?
[18:11:16] <fizzle> we likely have all the problems with deactivated actors now that we had we unscheduled ones
[18:11:54] <lynxlynxlynx> perhaps
[18:12:07] <lynxlynxlynx> it was just a minimal fix
[18:12:30] <lynxlynxlynx> would need to dig up more test cases for anything larger
[18:14:51] --> kpederse1 has joined #gemrb
[18:15:18] <fizzle> naively, it would make sense to treat them just like unscheduled actors
[18:16:57] <-- kpedersen has left IRC (Ping timeout: 240 seconds)
[18:19:19] <lynxlynxlynx> i guess
[18:19:55] <lynxlynxlynx> but i really don't know any other uses, except for one in iwd/how or totl, which was keeping the game from being finishable for a while
[18:20:35] <lynxlynxlynx> it was mostly real visibility stuff
[18:21:46] <fizzle> I haven't seen many scripts using Deactivate, either
[18:22:11] <fizzle> I'm sure we would have seen more problems if there were more users
[18:23:16] <fizzle> most code simply ignores the flag
[18:23:34] <lynxlynxlynx> ah yes, also garren windspear
[18:24:44] <lynxlynxlynx> most uses are in the iwds, but a surprising amount also in bg2
[18:25:09] <lynxlynxlynx> bg1 just 6 cases, five of which are area scripts
[18:27:24] <lynxlynxlynx> iwd2 seems to use it mostly to disable sounds
[18:28:10] <lynxlynxlynx> looking at dialogs, also pst crops up
[18:29:25] <lynxlynxlynx> so plenty of places to check, but it seems the problems aren't noticeable or there; other scripting stuff could be hiding them though
[18:30:18] <fizzle> the most noticable of the unscheduled issues was party members attacking invisible foes
[18:30:57] <fizzle> most of these targets don't seem hostile, though
[18:32:10] <lynxlynxlynx> cutspy and similar, i guess
[18:33:15] <lynxlynxlynx> the bg1 ones are for npc daily timing of appearance
[18:33:45] <lynxlynxlynx> that may actually be a good test case, i think i had similar problems with tyris
[18:33:55] <lynxlynxlynx> she's also there just part of the day
[18:36:11] <lynxlynxlynx> in bg1 that's alora and faldorn (checking the chapter instead of time)
[19:01:42] <fizzle> hm, yes alora is broken at least
[19:02:08] <fizzle> do deactivated actors still run their scripts?
[19:02:18] <lynxlynxlynx> yes
[19:02:51] <fizzle> hm, so she can initiate dialog even if she's not there?
[19:04:31] <lynxlynxlynx> that should be disabled if it is possible
[19:05:20] <fizzle> I guess See() should always return false if the actor's disabled, then
[19:05:41] <lynxlynxlynx> but it's clear the scripts need to run, as some of the personal ones handle (de)activation
[19:05:50] <fizzle> true
[19:06:08] <lynxlynxlynx> see should already be fine for disabled ones
[19:06:24] <lynxlynxlynx> that was the problem for iwd and garren
[19:06:39] <fizzle> oh, eh, alora.bcs seems, um, ... creative
[19:07:13] <lynxlynxlynx> ... yep 6949e83826
[19:07:50] <fizzle> well, not just the target, also the source
[19:07:51] <lynxlynxlynx> the last block of alora can't ever run, right? no continue anywhere
[19:08:19] <fizzle> I suppose so, yes
[19:24:30] <fizzle> also, you reverted that commit...
[19:24:50] <lynxlynxlynx> hehe
[19:31:23] --> edheldil_ has joined #gemrb
[19:32:29] <lynxlynxlynx> actually you did
[19:32:39] <lynxlynxlynx> during the unscheduled work
[19:33:31] <lynxlynxlynx> and it was actually a change by avenger
[19:34:53] <fizzle> I guess now it's my turn to say hehe...
[19:49:53] <fizzle> great, the scripts constantly activate and deactivate her
[19:50:08] <fizzle> she's a-blinkin'
[19:53:51] <lynxlynxlynx> 50% etherealness
[19:54:26] <lynxlynxlynx> also one of the things i have to figure out for iwd2
[20:14:31] <fizzle> hm, is there a proper description of the GetTimeOfDay trigger anywhere?
[20:14:50] <fizzle> iesdp is unhelpful and the thing looks ... not quite right
[20:16:12] <lynxlynxlynx> it's not just checking which of the constants we're in?
[20:16:31] <fizzle> the question is, what do those constants mean?
[20:16:32] <lynxlynxlynx> some ids has DAY NOON and so on
[20:16:36] <lynxlynxlynx> ah
[20:16:50] <lynxlynxlynx> that should be well understood by now, modders use it
[20:17:02] <lynxlynxlynx> i wouldn't expect it to match rl
[20:20:07] <fizzle> well, DAY is 0, and from what our code does it would match from 0:00 to 6:00
[20:20:37] <fizzle> that doesn't seem right
[20:22:37] <fizzle> hm
[20:22:57] <fizzle> 0 time is 6:00, apparently
[20:24:15] <fizzle> so it should actually match from 6:00 to 12:00
[20:24:21] <fizzle> which is still odd
[20:33:22] <fizzle> well, in any case, I guess with those scripting snafus, alora isn't the best test case
[20:50:53] <-- fizzle has left #gemrb
[23:34:19] <-- edheldil_ has left IRC (Ping timeout: 265 seconds)