#gemrb@irc.freenode.net logs for 28 Mar 2010 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage


[00:02:01] <tomprince> The fixed stuff is up.
[00:02:25] <tomprince> You should be able to cherry-pick the OpenAL commit if you want.
[00:07:19] <fuzzie> /opt/maemo/usr/lib/gemrb/plugins/libBIFImporter.so.0.0.0 <- i wonder how they managed this..
[00:08:19] <tomprince> The 0.0.0?
[00:08:42] <tomprince> Or, the /usr/lib?
[00:08:48] <fuzzie> well, yes, only the 0.0.0 :)
[00:09:05] <fuzzie> I guess the maemo build system is likely responsible.
[00:11:42] <tomprince> No, we are. Or were. That was one of the things I cleaned up.
[00:12:23] <fuzzie> Well, I mean, we also have the plain .so form, no?
[00:12:24] <tomprince> Changing -version-info 0:0:0 to -avoid-version.
[00:12:39] <tomprince> libtool automatically creates it.
[00:12:49] <tomprince> You just never noticed it, since you never install.
[00:13:03] <tomprince> Yes, we do.
[00:13:03] <fuzzie> They turn out to have a set of symlinks elsewhere in the filesystem.
[00:14:15] <tomprince> If you grab 3e8749defd61c8526b8ebc17614d6cebd82ee1ec and do a make install, the .so.0.0.0 will show up. And I think probably the .so will be a link to that.
[00:14:51] <fuzzie> Yes; it seems that in another directory they have a libWMPImporter.so -> libWMPImporter.so.0.0.0, then a libWMPImporter.so.0.0.0 -> /opt/maemo/usr/lib/gemrb/plugins/libWMPImporter.so.0.0.0.
[00:15:37] <tomprince> That just seems crazy.
[00:25:22] <tomprince> I have an alternative version of the KEYImporter hashtable patch at or.cz/2map. I don't know which is better. I just realized that the new one leaks the keys of the second map, but that is fixable.
[03:11:08] --> Genrazn has joined #GemRb
[03:13:23] <-- Maighstir_laptop has left #GemRb
[03:13:38] <-- Genraznx has left IRC (Ping timeout: 248 seconds)
[04:14:27] <-- ratpor has left IRC (Quit: Get used to disappointment.)
[06:05:50] <-- Gekz has left IRC (Quit: Leaving)
[06:36:22] <-- Nomad010 has left IRC (Ping timeout: 264 seconds)
[07:56:07] --> Gekz has joined #GemRb
[08:29:44] <-- raevol has left IRC (Ping timeout: 258 seconds)
[08:30:21] --> raevol has joined #GemRb
[09:54:08] --> Nomad010 has joined #GemRb
[09:54:25] <-- Nomad010 has left IRC (Remote host closed the connection)
[09:56:25] --> Nomad010 has joined #GemRb
[10:33:47] <fuzzie> i just spent several minutes trying to work out why none of my spell buttons did anything, before realising i had armour on
[10:34:48] <fuzzie> did the original engine provide some kind of feedback for that? i was a bit misled by the fact that the disabled buttons still 'pressed in' when i clicked them
[10:57:05] <-- Nomad010 has left IRC (Remote host closed the connection)
[10:57:16] --> Nomad010 has joined #GemRb
[10:57:29] <-- Nomad010 has left IRC (Remote host closed the connection)
[10:57:37] --> Nomad010 has joined #GemRb
[10:58:24] <-- Nomad010 has left IRC (Remote host closed the connection)
[10:58:34] --> Nomad010 has joined #GemRb
[10:58:45] <-- Nomad010 has left IRC (Remote host closed the connection)
[10:59:53] --> Nomad010 has joined #GemRb
[13:11:52] <-- raevol has left IRC (Quit: Leaving.)
[14:05:48] --> Maighstir_laptop has joined #GemRb
[14:08:13] <-- Nomad010 has left IRC (Ping timeout: 258 seconds)
[14:24:32] --> lynxlynxlynx has joined #GemRb
[14:24:32] --- ChanServ gives channel operator status to lynxlynxlynx
[14:50:26] --> Genraznx has joined #GemRb
[14:52:41] <-- Genrazn has left IRC (Ping timeout: 258 seconds)
[14:55:11] --> Nomad010 has joined #GemRb
[14:55:19] <Nomad010> gar
[15:09:32] <Nomad010> ok so after on and off working on that sweepline algorithm optimisation i have come to the conclusion that it won't make any difference
[15:10:13] <-- Gekz has left IRC (Read error: Connection reset by peer)
[15:10:35] --> Gekz has joined #GemRb
[15:11:00] --> kettuz has joined #GemRb
[15:13:58] <wjp> hm, pity :/
[15:15:50] <Nomad010> i think in the docs it says that polygons can self-intersect
[15:16:09] <Nomad010> or they don't say they are simple
[15:32:15] <lynxlynxlynx> so the git repo is all complete? If so, I'd like to publish this on the forum and change the dl location on our main page
[15:33:34] <fuzzie> i think that is a good idea
[15:34:17] <fuzzie> maybe also update NEWS a bit, if you have time?
[15:35:58] <lynxlynxlynx> yes, i think we're over 100 again :)
[15:41:17] <lynxlynxlynx> hmm, it will be hard to count them from now on
[15:50:55] <wjp> git-rev-list v0.6.0..HEAD | wc -l
[15:51:54] --> Enverex has joined #GemRb
[15:52:21] <CIA-43> GemRB: 03lynxlynxlynx * r9c44095d59ab 10gemrb/NEWS: NEWS: recent news
[15:52:39] <lynxlynxlynx> ;)
[15:55:03] <lynxlynxlynx> need to fix up my id
[15:59:35] <fuzzie> wiki main page exploded a bit?
[15:59:44] <lynxlynxlynx> url?
[16:00:01] <lynxlynxlynx> indeed, on it
[16:05:41] <CIA-43> GemRB: 03lynxlupodian * r1a7be39694a2 10gemrb/.mailmap: added .mailmap (see git-shortlog) to fix my previous address
[16:06:57] <lynxlynxlynx> wiki fixed
[16:07:26] <fuzzie> wjp: http://repo.or.cz/w/gemrb.git/commitdiff/3c46e0f472aa13a539494bd855a9c20583b20fa8 good?
[16:10:29] <wjp> yes, looks good
[16:12:40] <CIA-43> GemRB: 03tom.prince * rc39ef5579693 10gemrb/gemrb/plugins/OpenALAudio/OpenALAudio.cpp: OpenALAudio: Properly cleanup on error in loadSound and StreamFile.
[16:16:22] <lynxlynxlynx> forum notified
[16:17:02] <fuzzie> lynxlynxlynx: do you know if there's meant to be more feedback trying to cast spells with armour on?
[16:17:24] <lynxlynxlynx> i don't think so
[16:17:54] <lynxlynxlynx> in most games it is prohibited if we're talking about arcane magic and in iwd2 there's just a chance-of-success penalty
[16:18:10] <Maighstir_laptop> BG1 only greys-out the spell button, it's still presable, and no text feedback is given
[16:19:34] <fuzzie> ok.
[16:21:15] <lynxlynxlynx> we already do that too
[16:21:29] <fuzzie> yes :)
[16:21:59] <fuzzie> it confused me for a bit when trying to test earlier! but if that is how it's meant to work, all is good
[16:22:37] <lynxlynxlynx> btw, who's for gpg-signing of our releases?
[16:22:50] <lynxlynxlynx> with git we can also sign tags, not just the tarballs
[16:25:11] --> tomprince_loki has joined #GemRb
[16:32:04] <tomprince_loki> fuzzie: I think the best solution to the SaveGameIterator issue is to expose (slot,name) pairs, rather than an index in to a random (even sorted) list.
[16:32:52] <fuzzie> well, that could work, as long as you can provide a new name.
[16:33:14] <fuzzie> there's certainly no way to make it work with only slot numbers or only indexes.
[16:35:33] <tomprince_loki> I'll admit I'm not sure the right way to handle the python interface.
[16:37:10] <fuzzie> Well, tuples would work fine for pairs. I'd be happy to write that bit, if needed.
[16:37:48] <tomprince_loki> The issue is how to get the list of all existing pairs to the python side.
[16:40:46] <fuzzie> Would you need to handle it differently?
[16:40:46] <fuzzie> They'd be uniquely ordered, presumably.
[16:41:19] <fuzzie> I can't think of any problems with passing a python list back either.
[16:41:19] <-- CIA-43 has left IRC (*.net *.split)
[16:41:20] <-- tomprince_loki has left IRC (*.net *.split)
[16:41:20] <-- Genraznx has left IRC (*.net *.split)
[16:41:21] <-- wjp has left IRC (*.net *.split)
[16:41:21] <-- kettuz has left IRC (*.net *.split)
[16:41:22] <-- |Cable| has left IRC (*.net *.split)
[16:41:22] <-- lynxlynxlynx has left IRC (*.net *.split)
[16:41:23] <-- anji has left IRC (*.net *.split)
[16:41:25] <-- cfchris6 has left IRC (*.net *.split)
[16:41:28] <-- tomprince has left IRC (*.net *.split)
[16:41:29] <-- Nomad010 has left IRC (*.net *.split)
[16:41:33] <-- Enverex has left IRC (*.net *.split)
[16:41:35] <-- xrogaan has left IRC (*.net *.split)
[16:44:56] <fuzzie> hm, lonely :)
[16:45:10] --> tomprince_loki has joined #GemRb
[16:45:10] --> Enverex has joined #GemRb
[16:45:10] --> kettuz has joined #GemRb
[16:45:10] --> Nomad010 has joined #GemRb
[16:45:10] --> Genraznx has joined #GemRb
[16:45:10] --> lynxlynxlynx has joined #GemRb
[16:45:10] --> cfchris6 has joined #GemRb
[16:45:10] --> CIA-43 has joined #GemRb
[16:45:10] --> |Cable| has joined #GemRb
[16:45:10] --> wjp has joined #GemRb
[16:45:10] --> anji has joined #GemRb
[16:45:10] --> tomprince has joined #GemRb
[16:45:10] --> xrogaan has joined #GemRb
[16:50:59] <tomprince_loki> For net spliters: lynxlynxlynx: any opposition to removing the $Id$ leftovers?
[16:51:01] <fuzzie> I can't think of why you wouldn't be able to just make minimal changes to the existing python interface. The only new functionality you'd need is some more information when saving a game, I think?
[16:51:30] <fuzzie> In the spirit of minimal changes.
[16:54:10] <tomprince_loki> Well, looking at bg1/GUILoad.py, python just grabs the count of save games, and just uses that to index into save game iterator.
[16:54:13] <fuzzie> and i find that repeat a bit ambigious :) are you asking lynx?
[16:54:42] <-- Nomad010 has left IRC (Ping timeout: 246 seconds)
[16:55:26] <tomprince_loki> No. As far as I could tell, most people missed lynx asking that.
[16:55:30] --> nomad__ has joined #GemRb
[16:55:50] <CIA-43> GemRB: 03lynxlupodian * r8a8aba66d9f1 10gemrb/ (540 files in 57 dirs):
[16:55:50] <CIA-43> GemRB: removed the obsolete $Id(entifiers$)
[16:55:50] <CIA-43> GemRB: utterly boring diff follows
[16:56:20] <fuzzie> maybe use <nick> :) but lynx already mentioned looking forward to it and no-one objected, i'm sure
[16:56:30] <-- lynxlynxlynx has left IRC (*.net *.split)
[16:56:31] <-- anji has left IRC (*.net *.split)
[16:58:38] <CIA-43> GemRB: 03lynxlupodian * r9bad07351869 10gemrb/gemrb/docs/en/CVS.txt: CVS.txt: removed long obsolete doc
[16:58:51] --> anji has joined #GemRb
[16:59:24] --> lynxlynxlynx has joined #GemRb
[16:59:29] <-- lynxlynxlynx has left IRC (Read error: Operation timed out)
[16:59:38] --> lynxlynxlynx has joined #GemRb
[16:59:38] --- ChanServ gives channel operator status to lynxlynxlynx
[16:59:52] --> Gekz_ has joined #GemRb
[17:00:35] <lynxlynxlynx> sf held that spammy commit mail due to its size
[17:01:31] <-- Gekz has left IRC (Ping timeout: 264 seconds)
[17:07:36] --> Nomad010 has joined #GemRb
[17:08:41] <-- nomad__ has left IRC (Write error: Broken pipe)
[17:08:48] --> cfchris6_ has joined #GemRb
[17:09:16] <-- cfchris6 has left IRC (Read error: Connection reset by peer)
[17:14:51] --> anji_ has joined #GemRb
[17:15:16] <-- anji has left IRC (*.net *.split)
[17:15:16] <-- tomprince_loki has left IRC (*.net *.split)
[17:15:17] <-- Genraznx has left IRC (*.net *.split)
[17:15:18] <-- wjp has left IRC (*.net *.split)
[17:18:13] --> wjp has joined #GemRb
[17:22:15] --> tomprince_loki has joined #GemRb
[17:22:15] --> Genraznx has joined #GemRb
[17:24:45] --- ChanServ gives channel operator status to wjp
[17:30:53] <-- exultbot has left IRC (Ping timeout: 386 seconds)
[17:30:53] <-- exultbot has left IRC (signing off...)
[17:32:09] --> exultbot has joined #GemRb
[17:32:09] --- Topic for #GemRb is: GemRB 0.6.0 | http://gemrb.sf.net | Be wary of your words for there are Modron sensors in this channel: http://log.usecode.org/gemrblog.php | Hey <CHARNAME>, we need some awesome screenshots!
[17:32:09] --- Topic for #GemRb set by lynxlynxlynx at Tue Nov 3 16:51:03 2009
[17:43:53] --> lynxlynx has joined #GemRb
[17:43:53] <-- lynxlynxlynx has left IRC (Read error: Connection reset by peer)
[17:43:56] <-- lynxlynx has left IRC (Changing host)
[17:43:56] --> lynxlynx has joined #GemRb
[17:43:56] --- ChanServ gives channel operator status to lynxlynx
[17:44:01] --- lynxlynx is now known as lynxlynxlynx
[17:44:08] <lynxlynxlynx> geez
[18:06:47] <Genraznx> Did you drop a f bomb?
[18:18:49] --> Enverex has joined #GemRb
[18:46:09] <CIA-43> GemRB: 03lynxlupodian * rd00691bdb6b5 10gemrb/gemrb/plugins-prepare.sh: plugins-prepare.sh: exit early if something goes wrong
[18:55:03] <tomprince_loki> Does it make sense to move Core out of plugins, and pass proper -I options, so we don't need to specify directories for include files?
[18:56:54] <lynxlynxlynx> i agree that it's odd the way it is now
[18:56:59] <lynxlynxlynx> packagers get confused too
[18:57:34] <fuzzie> it makes sense to move Core out of plugins.
[19:03:48] <CIA-43> GemRB: 03lynxlupodian * rd1be4d2343fb 10gemrb/gemrb/GUIScripts/pst/ (GUIINV.py GUIREC.py): pst: load classes.2da only once
[19:03:57] <CIA-43> GemRB: 03lynxlupodian * r0530aa2132eb 10gemrb/gemrb/GUIScripts/pst/GUIREC.py: pst: load races.2da only once
[19:04:02] <CIA-43> GemRB: 03lynxlupodian * rc5cb7259b361 10gemrb/gemrb/GUIScripts/pst/ (FloatMenuWindow.py GUIMG.py GUIPR.py): pst: load clskills.2da only once
[19:04:08] <CIA-43> GemRB: 03lynxlupodian * r60c8567fbe33 10gemrb/gemrb/GUIScripts/pst/GUIREC.py: pst: load xplevel.2da only once
[19:14:30] <Lightkey> I have a deja vu
[19:22:23] * fuzzie sighs
[19:23:30] <fuzzie> i found the reason pst zombies were disappearing on death.. another longstanding bug interacting badly with newer semi-fixes.
[19:55:12] <-- tomprince_loki has left IRC (Ping timeout: 265 seconds)
[19:55:31] <-- tomprince has left IRC (Ping timeout: 245 seconds)
[19:57:41] --> tomprince has joined #GemRb
[19:58:20] <CIA-43> GemRB: 03lynxlupodian * r3421011ba984 10gemrb/gemrb/GUIScripts/iwd/CharGen.py: iwd: load classes.2da only once
[19:58:21] <CIA-43> GemRB: 03lynxlupodian * r49876bd4bbab 10gemrb/gemrb/GUIScripts/bg1/ (GUICG10.py GUICG2.py GUICG22.py GUICG8.py): bg1: load races.2da only once
[19:58:22] <CIA-43> GemRB: 03lynxlupodian * r746ba202b4b4 10gemrb/gemrb/GUIScripts/iwd/CharGen.py: iwd: removed extra table loading from CharGen.py
[19:58:23] <CIA-43> GemRB: 03lynxlupodian * r5ea10a6886a1 10gemrb/gemrb/GUIScripts/iwd/ (GUIMG.py GUIPR.py): iwd: load clskills.2da only once
[19:58:26] <CIA-43> GemRB: 03lynxlupodian * r16eea7a4a4c3 10gemrb/gemrb/GUIScripts/bg1/ (CharGenGui.py GUICG22.py): bg1: load kitlist.2da only once
[19:58:27] <CIA-43> GemRB: 03lynxlupodian * r014e8f04bbbf 10gemrb/gemrb/GUIScripts/bg1/ (CharGenGui.py GUICG15.py GUIMG.py GUIPR.py): bg1: load clskills.2da only once
[19:58:31] <CIA-43> GemRB: 03lynxlupodian * r6ecdab496b05 10gemrb/gemrb/GUIScripts/bg1/ (GUICG10.py GUICG15.py GUICG2.py GUICG22.py GUICG3.py): bg1: load classes.2da only once
[19:59:57] <lynxlynxlynx> i'd appreciate if someone tried bg1 to see if chargen still works
[20:00:30] <lynxlynxlynx> and the mage and priest spellbooks
[20:02:34] <wjp> chargen seems ok
[20:02:42] <wjp> (but only tried a single char)
[20:03:15] <lynxlynxlynx> thanks
[20:03:27] <wjp> hm
[20:03:36] <wjp> a paladin looks like a wizard though
[20:03:39] <wjp> robe, staff
[20:05:08] <wjp> and there are some other with starting a game: the message window shows 'Paused for chapter text'
[20:05:39] <wjp> and double clicking on portraits throws an exception that indicates a missing window
[20:08:29] <Nomad010> i managed to buy bg2 today
[20:08:41] <Nomad010> it was like R60 lol
[20:09:14] <wjp> R?
[20:09:23] <Nomad010> oh like 5 pounds
[20:11:22] <lynxlynxlynx> only the first could be caused by my changes, but I doubt it
[20:11:41] <lynxlynxlynx> i was expecting runtime exceptions if anything
[20:13:31] <wjp> just checked, and it was the same before your 'load ... only once' commits
[20:16:09] <lynxlynxlynx> :)
[20:18:58] <fuzzie> missing window errors?
[20:20:11] <wjp> after opening and closing the priest scroll, double clicking a char portrait seems to call a function from GUIPR.py
[20:20:52] <wjp> from RunSelectionChangeHandler
[20:21:01] <fuzzie> :nod:
[20:22:00] <fuzzie> it's missing a SetSelectionChangeHandler(None), ofc
[20:24:10] <fuzzie> i wonder why only bg1 GUIPR/GUIMG?
[20:25:53] <fuzzie> lynx removed it in 32a41951?
[20:26:10] <fuzzie> (applying a patch from zefklop)
[20:27:24] <lynxlynxlynx> no clue how much testing that got
[20:27:43] <fuzzie> i just wanted to know to make sure nothing else is missing
[20:28:16] <wjp> hm, that patch is ancient
[20:28:30] <fuzzie> unfortunately it is difficult to tell, that patch mangled quite a few files; zefklop added the GUIREC one back in 969ceb4e
[20:29:34] <fuzzie> but if you could add the obvious two lines back and check that fixes it?
[20:30:29] <fuzzie> it does look like they're the only lasting fallout.
[20:32:21] <wjp> yes, that fixes it; I'll commit it
[20:32:29] <fuzzie> lynxlynxlynx: an errant s/KitListTable/KitListTableTable/ in bg1/CharGenGui.py?
[20:33:24] <fuzzie> Otherwise the bg1 changes look fine.
[20:35:45] <CIA-43> GemRB: 03wjpalenstijn * r7c36a2789095 10gemrb/gemrb/GUIScripts/bg1/ (GUIREC.py GUIWORLD.py): Fix whitespace
[20:35:48] <CIA-43> GemRB: 03wjpalenstijn * rf496c79023bc 10gemrb/gemrb/GUIScripts/bg1/ (GUIMG.py GUIPR.py): Clear selection change handler after closing mage/priest window
[20:38:44] <wjp> hm, strange. When opening the mage window for a paladin it isn't greyed out, but when clicking on the paladin portrait (while the window is open) does grey it out
[20:39:19] <wjp> which confuses me since UpdateMageWindow is called in both cases as far as I can tell
[20:40:04] <fuzzie> SetVisible(1) is called afterwards, in the first case.
[20:40:26] <wjp> ah, I'm blind
[20:41:19] <wjp> guess which commit introduced that :-)
[20:42:32] <fuzzie> change it to 3, I guess? it would be nicer if we used the named constants.
[20:43:40] <lynxlynxlynx> thanks
[20:43:57] <fuzzie> (why is it disabled for GUIPR? same patch again, it seems..)
[20:45:19] <CIA-43> GemRB: 03lynxlupodian * ra9cf02ed47c5 10gemrb/gemrb/GUIScripts/bg1/CharGenGui.py: CharGenGui.py: fixed a typotypo
[20:45:47] <wjp> which are the named constants for SetVisible?
[20:46:39] <lynxlynxlynx> gemrb/GUIScripts/GUIDefines.py:185
[20:47:07] <lynxlynxlynx> let's see if they're the same at all
[20:47:19] <wjp> shadow color for ShowModal?
[20:47:41] <fuzzie> not those..
[20:47:56] <fuzzie> WINDOW_FRONT etc, see Window.h
[20:48:02] <fuzzie> erm, Interface.h.
[20:48:35] <fuzzie> Despite the sync comment, I don't see them in the .py.
[20:48:44] <lynxlynxlynx> they're unexposed
[20:48:51] <lynxlynxlynx> :)
[20:49:16] <lynxlynxlynx> well, if something isn't used, there's no point in adding it to the python counterpart
[20:49:18] <fuzzie> so add them at the same time, i suggest
[20:49:27] <fuzzie> they're used all over the python side
[20:49:42] <lynxlynxlynx> Control.h isn't in sync either, but we don't need the new stuff
[20:50:39] <lynxlynxlynx> some regex and it can be all replaced :)
[20:52:00] <CIA-43> GemRB: 03wjpalenstijn * r42a41a2ab661 10gemrb/gemrb/GUIScripts/bg1/ (GUIMG.py GUIPR.py): Grey out mage/priest windows properly
[20:52:43] <lynxlynxlynx> wjp: if you want, I can decrypt the constants
[20:53:02] <wjp> go for it :-)
[20:53:05] <fuzzie> i would appreciate it
[20:53:11] * wjp too
[20:53:16] <fuzzie> i didn't realise they *were* constants.
[20:53:18] <Lightkey> I don't care
[20:55:27] <lynxlynxlynx> maybe DarkLock cares
[20:57:08] <Lightkey> there is no DarkLock and no LightKey either
[20:57:20] <lynxlynxlynx> ok ok, Darklock
[20:57:47] <Lightkey> and you would not say that if you knew what I use the nick Darklock for elsewhere ;-)
[20:58:48] <lynxlynxlynx> well, you used it here too, but I really don't want to know about the rest
[20:59:03] <Lightkey> haha
[21:03:20] <Lightkey> btw what happened to Tron?
[21:03:31] <lynxlynxlynx> i would like to know too
[21:05:31] <Lightkey> I hope he does not turn up like a certain other Tron from the CCC
[21:07:50] --> tomprince_loki has joined #GemRb
[21:08:26] <lynxlynxlynx> conflictfoo
[21:14:53] --> cfchris6 has joined #GemRb
[21:15:30] <-- cfchris6_ has left IRC (Read error: Operation timed out)
[21:17:37] <CIA-43> GemRB: 03lynxlupodian * r767d7d1166c7 10gemrb/gemrb/ (128 files in 7 dirs): use named constants when calling SetVisible
[21:19:57] <lynxlynxlynx> hmpf, missed a few
[21:31:56] <CIA-43> GemRB: 03lynxlupodian * r9fc6b470d659 10gemrb/gemrb/GUIScripts/ (40 files in 5 dirs): made the rest of the calls to SetVisible use named constants
[21:32:29] <tomprince_loki> or.cz/core: Patch to move Core out of plugins. Also, uses include paths.
[21:32:59] <tomprince_loki> Builds with autotools/cmake.
[21:36:57] --> Edheldil_ has joined #GemRb
[21:38:54] <-- kettuz has left IRC (Quit: Leaving)
[21:39:03] <lynxlynxlynx> looks good to me, but please get input from others too
[21:40:00] <fuzzie> I don't think putting both in one patch is a good idea.
[21:41:26] <fuzzie> But if others do, I don't object.
[21:43:35] <wjp> tomprince_loki: re. your strnlen patch (69186e5f784fff): in Core/Variables.cpp we supply our own version of strnlen, so I'm wondering if it's not available somewhere
[21:43:56] <tomprince_loki> That is what I am doing: we have it, but weren't using it.
[21:44:22] <tomprince_loki> The message could perhaps be clearer.
[21:45:03] <lynxlynxlynx> splitting it can't hurt
[21:45:35] <fuzzie> re QueryField patch: it seems it would be *far* clearer to have two different names.
[21:47:18] <fuzzie> the strnlen and gitignore commits seem good to apply.
[21:48:24] <tomprince_loki> We would need 4 names.
[21:48:45] <tomprince_loki> aa, a0, 0a, 00
[21:49:18] <fuzzie> the existing ones are unambigious, no?
[21:50:59] <fuzzie> but, again, maybe someone else has an opinion..
[21:51:30] <tomprince_loki> QueryField(0,0) would be ambiguous, I think.
[21:52:26] <fuzzie> That is rather horrible.
[21:54:40] <lynxlynxlynx> indeed
[22:01:47] <-- lynxlynxlynx has left IRC (Remote host closed the connection)
[22:03:06] <fuzzie> I am still fighting this death animation mess.
[22:10:24] <tomprince_loki> fuzzie: I pushed a split core patch.
[22:11:40] <tomprince_loki> It was fairly easy, it just matters what order you do it in. I originally started moving plugins/Core to core. But that depends on the other, and I didn't think to do the other first.
[22:12:31] <fuzzie> I should make sure to either catch Avenger and see if he can update the VC++ files, or install VC++ somewhere and try doing it myself.
[22:18:42] <fuzzie> The strnlen in core is not exported or defined anywhere, it seems?
[22:18:55] <fuzzie> So I can't merge that patch after all.
[22:25:25] <fuzzie> Looks like we're doing crazy things with dropping animations. Worries for another day.
[22:29:49] <CIA-43> GemRB: 03fuzzie * rb0c1b479081e 10gemrb/gemrb/plugins/Core/ (Actor.cpp Actor.h):
[22:29:49] <CIA-43> GemRB: always draw dead actors in Actor::Draw and some related hibernation changes
[22:29:49] <CIA-43> GemRB: (needs more thought, this is just a bugfix.)
[22:31:40] <CIA-43> GemRB: 03tom.prince * r1894d9b42c63 10gemrb/.gitignore: gitignore: Add generated cmake files.
[22:32:16] --> Gekz has joined #GemRb
[22:32:34] <-- Gekz_ has left IRC (Read error: Connection reset by peer)
[22:34:32] --> Gekz_ has joined #GemRb
[22:34:33] <tomprince_loki> I just pushed a fix to the strnlen patch that *should* work, but I don't have a machine w/o strnlen to test against.
[22:36:19] <fuzzie> typo in GEM_EXPROT.
[22:36:31] <fuzzie> and it needs a semicolon, i guess.
[22:37:08] <tomprince_loki> Yes.
[22:37:42] <fuzzie> Sorry, quite happy to fix that myself.
[22:37:54] <tomprince_loki> I assumed that. :)
[22:38:19] <fuzzie> But it's bedtime, so testing will have to wait until tomorrow. Ninight. :)
[22:38:48] <tomprince_loki> night.
[22:43:02] <Edheldil_> night
[22:43:23] <Edheldil_> looks like the git repo is churning happily
[22:44:25] <-- Nomad010 has left IRC (Ping timeout: 248 seconds)
[22:47:09] <tomprince_loki> Edheldil_: Woud it be possible to get that LuaScript patch (with the plugin itself?)
[23:00:57] <Edheldil_> tomprince_loki, I will do it, but tonight I am too fuzzy from DST change and today's performance
[23:01:03] <Edheldil_> good night
[23:01:12] <-- Edheldil_ has left IRC (Quit: Really?)