#gemrb@irc.freenode.net logs for 30 Nov 2013 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage


[03:22:47] <-- edheldil__ has left IRC (Read error: Operation timed out)
[05:18:06] <-- Eli2_ has left IRC (Ping timeout: 245 seconds)
[05:18:48] --> Eli2 has joined #gemrb
[06:30:26] <-- |Cable| has left IRC (Ping timeout: 246 seconds)
[06:43:22] --> |Cable| has joined #gemrb
[07:01:35] --> edheldil_ has joined #gemrb
[07:12:03] <-- edheldil_ has left IRC (Ping timeout: 260 seconds)
[07:30:32] --> edheldil_ has joined #gemrb
[09:36:32] --> Yoshimo has joined #gemrb
[09:45:33] --> edheldil__ has joined #gemrb
[10:16:35] <-- edheldil__ has left IRC (Remote host closed the connection)
[10:50:45] <-- edheldil_ has left IRC (Read error: Operation timed out)
[12:08:45] <-- Yoshimo has left IRC (Quit: Yoshimo)
[14:09:25] --> lynxlynxlynx has joined #gemrb
[14:09:25] <-- lynxlynxlynx has left IRC (Changing host)
[14:09:25] --> lynxlynxlynx has joined #gemrb
[14:09:26] --- ChanServ gives channel operator status to lynxlynxlynx
[16:59:59] <Seniorita> [commit] bradallred: CocoaWrapper: fix attempt to mutate an immutable dictionary https://github.com/gemrb/gemrb/commit/ae053a6f82d8f8992a1fee20f12f046e34e1bb38
[18:37:58] <-- lynxlynxlynx has left IRC (Ping timeout: 272 seconds)
[19:09:07] --> brada has joined #gemrb
[19:09:15] <brada> does this look ok: http://pastebin.com/9RYMhY8x
[19:09:16] <Seniorita> [Diff] utf8 refactor - Pastebin.com
[19:09:24] <brada> I don't have a data set to test with
[19:09:41] <brada> so I'll probably push it and make somebody else fix it if its not :p
[19:18:11] <brada> should prolly const-ify that static array...
[19:44:06] <-- brada has left IRC (Quit: brada)
[20:13:04] --> brada has joined #gemrb
[20:18:38] <Seniorita> [commit] bradallred: aliviate some of the nastiness of the UTF-8 support patch. https://github.com/gemrb/gemrb/commit/4a18616f899580ade7807e2150afcd06a8b1de4d
[20:19:48] <brada> looking closer at that static array this can be simplified even more...
[20:20:27] <brada> the same 0x7f rule applies to utf 8 as well
[20:21:07] <brada> I don't know why whoever wrote this in the first place didn't bother using the logic that was already in place...
[20:23:29] <brada> instead of short circuiting it into a half-copy of the existing logic
[20:26:37] --> berenm has joined #gemrb
[20:27:26] <brada> I also question using this static lookup table over a short series of if statements... guess its subjective
[20:39:01] <-- brada has left IRC (Quit: brada)
[20:47:13] <-- |Cable| has left IRC (Ping timeout: 246 seconds)
[20:55:24] --> brada has joined #gemrb
[21:13:55] <brada> well i do see an error i need to fix
[21:16:14] <brada> i imagine this would crash quite spectacularly on utf8 :D
[21:21:20] <-- berenm has left #gemrb
[21:54:57] <Seniorita> [commit] bradallred: Font: more cleanup from messy UTF-8 patch https://github.com/gemrb/gemrb/commit/f4d156bd1044014f8d1262a1c72ca4cdf9bc0bae
[21:56:19] <brada> yay. overall reduced LOC by 39 and (I think) made things easier to understand :D
[22:08:11] <Seniorita> [commit] bradallred: Font: skip current character if it isn’t valid. https://github.com/gemrb/gemrb/commit/17da78a78ee398e0c14a367c6d2003bb72e6a76f
[22:25:52] <brada> I'm tempted to really break something in in the codebase to spur somebody into working on GemRB again :p
[23:15:17] --> |Cable| has joined #gemrb
[23:16:45] <-- brada has left IRC (Quit: brada)
[23:54:55] --> brada has joined #gemrb