#gemrb@irc.freenode.net logs for 31 Jul 2011 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage

[07:08:19] <-- harijan2 has left IRC (Remote host closed the connection)
[07:26:22] --> lynxlynxlynx has joined #gemrb
[07:26:22] <-- lynxlynxlynx has left IRC (Changing host)
[07:26:22] --> lynxlynxlynx has joined #gemrb
[07:26:22] --- ChanServ gives channel operator status to lynxlynxlynx
[08:53:58] --> test32894789234u has joined #gemrb
[08:58:40] --> PixelScum has joined #gemrb
[09:00:57] <-- Drakkar has left IRC (Ping timeout: 255 seconds)
[09:50:37] --> Maighstir has joined #gemrb
[11:26:16] --> barra_home has joined #gemrb
[11:34:31] --> barra_away has joined #gemrb
[11:37:33] <-- barra_home has left IRC (Ping timeout: 255 seconds)
[13:25:02] <-- test32894789234u has left IRC (Read error: Connection reset by peer)
[13:37:20] <-- Maighstir has left IRC (Quit: .)
[13:41:33] <CIA-26> GemRB: 03avenger_teambg * r99dff00d4562 10ielister/ielister.cpp: updated vvc fields in ielister
[13:46:27] <CIA-26> GemRB: 03avenger_teambg * r27a115bc69d0 10gemrb/gemrb/override/pst/ (s061glwb.vvc s061shll.vvc): flag hacks for the antimagic shell vvc's (freeze on last frame/orbiting)
[13:48:21] --- barra_away is now known as barra_home
[13:53:51] <CIA-26> GemRB: 03avenger_teambg * r46a4f346b831 10gemrb/gemrb/plugins/PSTOpcodes/PSTOpcodes.cpp: started implementing hardcoded PST overlays
[14:04:59] <lynxlynxlynx> 5 is the round size in pst
[14:05:21] <CIA-26> GemRB: 03lynxlupodian * r05a2d1b4cae5 10gemrb/gemrb/core/Interface.cpp: Interface::ResolveStatBonus: fixed remaining indentation errors
[14:05:22] <CIA-26> GemRB: 03lynxlupodian * r01555ffbe9a9 10gemrb/gemrb/ (core/Interface.cpp core/Interface.h override/bg2/dstable.2da):
[14:05:22] <CIA-26> GemRB: Interface::ResolveStatBonus: extended so it can return negative boni,
[14:05:22] <CIA-26> GemRB: get the value from other columns and use a different stat value
[14:05:22] <CIA-26> GemRB: 03lynxlupodian * r1633dc299582 10gemrb/gemrb/ (3 files in 3 dirs): implemented the fatigue malus to luck
[14:12:59] --> Avenger has joined #gemrb
[14:13:04] <Avenger> hey lynx, why did you go with this complicated solution?
[14:13:10] --- ChanServ gives channel operator status to Avenger
[14:13:23] <Avenger> do you expect some games to be different?
[14:13:39] <lynxlynxlynx> not really, but i don't see it as complicated
[14:13:57] <lynxlynxlynx> this way there has to be no hardcoded table for it in the core
[14:14:08] <lynxlynxlynx> err, there doesn't have to be any ...
[14:14:34] <Avenger> it is just a bit slower, but nevermind ;)
[14:14:56] <lynxlynxlynx> it is, but this will not be called so often like the main stat changes
[14:19:26] <Avenger> pst overlays == the ugliest hacks in the IE
[14:20:33] <-- Avenger has left IRC (Quit: bye!)
[14:47:45] <CIA-26> GemRB: 03lynxlupodian * rf458f1b7ddee 10gemrb/gemrb/core/Scriptable/Actor.cpp: pcf_fatigue: take constitution bonus/malus into account
[14:47:56] <CIA-26> GemRB: 03lynxlupodian * r05a05d920b66 10gemrb/gemrb/core/Scriptable/Actor.cpp: add a point of fatigue every 4 hours
[14:48:53] <fuzzie> 4*5*60*15?
[14:52:47] <fuzzie> hm, no, you lack the *15 multiplier
[14:54:02] <fuzzie> the original does all the work when checking timing (con bonus modifier, verbal constants, luck modifier, portrait icons, string)
[14:55:04] <fuzzie> don't know if we do that elsewhere, if not i could dump some notes on pastebin or something
[14:56:20] <CIA-26> GemRB: 03lynxlupodian * rb7514694d4fc 10gemrb/gemrb/core/Scriptable/Actor.cpp: regenerate actors with high enough constitution
[14:57:01] <lynxlynxlynx> hmm
[14:57:33] <lynxlynxlynx> you're right
[14:59:07] <lynxlynxlynx> i think we already do all of what you mention, except for "string" which i don't know what it means
[15:00:39] <CIA-26> GemRB: 03lynxlupodian * r35d978563a26 10gemrb/gemrb/core/Scriptable/Actor.cpp: fixed fatigue timing
[15:09:20] --> SiENcE has joined #gemrb
[16:55:09] <fuzzie> lynxlynxlynx: i mean, all the fatigue-specific stuff, so i guess this would be some string about being fatigued?
[17:00:23] <lynxlynxlynx> right, there's probably a vb constant
[17:00:33] <lynxlynxlynx> and the portrait icon
[17:06:14] <fuzzie> i hadn't realised there was a con bonus involves, so
[17:18:45] <lynxlynxlynx> there's another modifier for luck - intoxication
[17:19:40] <lynxlynxlynx> the original didn't check gametime, but the elapsed time since load (or similar), since you could fool it by saving and reloading
[17:19:52] <lynxlynxlynx> the mali are brutal
[17:41:11] <-- Demitar has left IRC (Ping timeout: 260 seconds)
[17:43:47] --> Maighstir has joined #gemrb
[18:15:14] <lynxlynxlynx> eh, i should test more, another mistake
[19:13:22] <CIA-26> GemRB: 03lynxlupodian * rdb42163da0be 10gemrb/gemrb/core/Scriptable/Actor.cpp: give the fatigue mod on rest, so we don't get into a pcf loop
[19:14:05] --> Avenger has joined #gemrb
[19:14:06] --- ChanServ gives channel operator status to Avenger
[19:14:27] <Avenger> meh, it looks like pst has a different location for the hostile spell flag
[19:17:33] <Avenger> we know that byte as 'unknown1' in the spell extended header. if it's bit 4 is set, it is a hostile spell. (unknown1 & 4)
[19:18:33] <lynxlynxlynx> another hack for the importer
[19:18:49] <lynxlynxlynx> if it is really the same thing
[19:19:52] <Avenger> it sends the hit triggers
[19:20:01] <Avenger> so i guess, yeah
[19:21:42] <Avenger> actually, if it is set, it is friendly. So... extra sucky :)
[19:26:13] <Avenger> luckily i don't have to modify too much in dltcep :) i just change the 0x1 to some more meaningful name
[19:31:05] <CIA-26> GemRB: 03lynxlupodian * r217b8218e921 10gemrb/gemrb/GUIScripts/include.py: include.py: added some shorthand forms for easier debugging
[19:31:05] <CIA-26> GemRB: 03lynxlupodian * rf22b822542d7 10gemrb/gemrb/core/Scriptable/Actor.cpp: display the portrait icon and verbal constant for fatigue
[19:39:02] <Avenger> this is the third hostile related bit in items/spells. All in a different location
[19:56:17] <-- Avenger has left IRC (Quit: ChatZilla 0.9.87 [Firefox 5.0/20110615151330])
[19:56:57] --> Demitar has joined #gemrb
[20:03:45] <-- DrMcCoy has left IRC (Disconnected by services)
[20:03:49] <-- xrogaan_ has left IRC (Ping timeout: 250 seconds)
[20:03:58] --> DrMcCoy has joined #gemrb
[20:05:42] --> xrogaan_ has joined #gemrb
[20:05:43] <-- xrogaan_ has left IRC (Changing host)
[20:05:43] --> xrogaan_ has joined #gemrb
[20:37:32] --> Avenger has joined #gemrb
[20:37:50] <Avenger> i forgot how to commit changes gradually :(
[20:39:53] --- ChanServ gives channel operator status to Avenger
[20:49:38] <CIA-26> GemRB: 03avenger_teambg * rce7670777ea2 10gemrb/gemrb/ (4 files in 2 dirs):
[20:49:38] <CIA-26> GemRB: load the hostile flag
[20:49:38] <CIA-26> GemRB: added a new effect filter to EffectQueue (for cloak of warding)
[20:52:29] <lynxlynxlynx> git add -p
[20:52:37] <lynxlynxlynx> or git commit --interactive
[20:53:27] <CIA-26> GemRB: 03avenger_teambg * r5b83f1b55da0 10gemrb/gemrb/core/ (Interface.cpp Spell.cpp):
[20:53:27] <CIA-26> GemRB: pst hostile flag finished
[20:53:27] <CIA-26> GemRB: fixed a parameter problem with GetProjectile
[20:53:30] <Avenger> yeah, i found it... but i already messed up the previous commit :)
[20:53:37] <Avenger> it should be atomic with this one, though :)
[20:54:14] <Avenger> can you check that?
[20:54:21] <lynxlynxlynx> GetProjectile is missing
[20:54:29] <Avenger> even with the second commit?
[20:54:33] <Avenger> O_o
[20:54:38] <lynxlynxlynx> oh, i'm too slow :)
[20:54:47] <Avenger> phew
[20:55:00] <Avenger> i really try to add this gradually, because i changed too many things
[20:56:14] <lynxlynxlynx> if you're really bothered by it, you can revert the commits and then do them as you please
[20:57:13] <CIA-26> GemRB: 03avenger_teambg * rb734965b3d97 10gemrb/gemrb/core/ (Map.cpp Map.h): a few more consts
[20:58:00] <lynxlynxlynx> git revert 5b83f1b55da0; git revert ce7670777ea2; git cherry-pick -n ce7670777ea2; git stash; git cherry-pick -n 5b83f1b55da0; git stash pop; something like this
[20:59:02] <lynxlynxlynx> i'm not sure if the files wouldn't still be staged; in that case you'd just git reset --soft HEAD
[21:01:43] <CIA-26> GemRB: 03avenger_teambg * r56d3f34148a0 10gemrb/gemrb/core/ (ScriptedAnimation.cpp ScriptedAnimation.h): a fix for bam based twin animations (pst has them instead of vvcs)
[21:03:54] <CIA-26> GemRB: 03avenger_teambg * r8bdbefb69d3f 10gemrb/gemrb/plugins/ (FXOpcodes/FXOpcodes.cpp PSTOpcodes/PSTOpcodes.cpp): more pst overlays
[21:04:58] <-- SiENcE has left IRC (Quit: cya)
[21:06:54] <Avenger> most of the ugliness is in :)
[21:07:34] <Avenger> oops, i think i forgot to add a dependency
[21:09:10] <CIA-26> GemRB: 03avenger_teambg * r7ed4e7d00dbb 10gemrb/gemrb/core/Scriptable/ (Actor.cpp Actor.h): more stuff for overlays
[21:10:56] <CIA-26> GemRB: 03avenger_teambg * r5d210ab827c5 10gemrb/gemrb/core/Scriptable/Scriptable.cpp: more GetProjectile parameter fixes
[21:13:56] <CIA-26> GemRB: 03avenger_teambg * rc35a69357fd6 10gemrb/gemrb/core/Scriptable/Scriptable.cpp: don't do special stuff with Sanctuary and Invisibility, the original is much simpler
[21:16:49] <CIA-26> GemRB: 03avenger_teambg * r1f31f22916f7 10gemrb/gemrb/core/EffectQueue.cpp: fix? FirstApply (not sure)
[21:16:50] <CIA-26> GemRB: 03avenger_teambg * r1cc6a942ffc3 10gemrb/gemrb/core/EffectQueue.cpp:
[21:16:50] <CIA-26> GemRB: fix the removal of more than one counter
[21:16:50] <CIA-26> GemRB: (stoneskin, spelltrap, mirror image use only 1, but still...)
[21:17:14] <Avenger> ok, i'm done. and managed to not commit any floattext related stuff :)
[21:17:45] <Avenger> i hope it still works
[21:25:37] <lynxlynxlynx> that sanctuary one looks fishy
[21:26:31] <lynxlynxlynx> as an example, the bg sanctuary spell allows the cleric to cast any nonhostile spell without breaking the sanctuary
[21:26:50] <lynxlynxlynx> it's a good way to heal up if there's nobody clairvoyant around
[21:27:22] <lynxlynxlynx> we already handle this and the invisibility removal in there
[21:29:46] <Avenger> but it is not like in the original
[21:29:58] <Avenger> i'll get the real conditions from the original
[21:30:20] <Avenger> you can add the hostile spell stuff to sanctuary
[21:30:57] <Avenger> you started hacking because the removal effects were AFTER the spell casting. In the original, they are before spell casting
[21:31:13] <Avenger> they are at the start of casting
[21:34:22] <lynxlynxlynx> ok, but the replacement is currently worse, even if it is more in line with the original
[21:35:02] <-- barra_home has left IRC (Quit: Verlassend)
[21:37:57] <Avenger> the hostile flag is easy. But why did you add target self don't disable invisibility?
[21:39:37] <CIA-26> GemRB: 03avenger_teambg * rde657dac4f76 10gemrb/gemrb/core/Scriptable/Scriptable.cpp: don't remove sanctuary if target is self
[21:39:42] <Avenger> oops
[21:39:50] <Avenger> well, i meant, spell is not hostile :)
[21:40:04] <Avenger> the problem with this is pst spells are not hostile :)
[21:40:15] <Avenger> they have a separate flag
[21:42:52] <CIA-26> GemRB: 03avenger_teambg * rdf448d2d5894 10gemrb/gemrb/ (4 files in 2 dirs): implemented IsInGuardianMantle
[21:43:00] <CIA-26> GemRB: 03avenger_teambg * r78baae14a46f 10gemrb/gemrb/core/EffectQueue.h: missing from guardian mantle
[21:45:29] <lynxlynxlynx> the complicated part was for one bg2 spell
[21:45:34] <lynxlynxlynx> i thought i documented it
[21:45:59] <lynxlynxlynx> shadow door maybe? something that makes you invisible, but would fail that check and be immediately dispelled
[21:46:55] <CIA-26> GemRB: 03lynxlupodian * r8594fe5b70b6 10gemrb/gemrb/core/DisplayMessage.h: both in bg1 and bg2 the dialog text is white, only when one of the pcs talks it is different
[21:46:55] <CIA-26> GemRB: 03lynxlupodian * re1c1e605e991 10gemrb/gemrb/ (7 files in 5 dirs):
[21:46:56] <CIA-26> GemRB: Don't use white,
[21:46:56] <CIA-26> GemRB: as it's too bright!
[21:46:56] <CIA-26> GemRB: Let color grey
[21:46:56] <CIA-26> GemRB: save the day
[21:46:56] <CIA-26> GemRB: with lesser light!
[21:46:56] <CIA-26> GemRB: 03lynxlupodian * rd9a90e829ddb 10gemrb/gemrb/ (19 files in 7 dirs): added constants for colors used with DisplayMessage set of functions
[21:49:27] <Avenger> huh, a monster commit
[21:51:02] <lynxlynxlynx> just hex to constants
[21:51:25] <Avenger> DMC_BG2XPGREEN is just CYAN? :D
[21:51:34] <lynxlynxlynx> it's green :P
[21:51:46] <Avenger> it is green+blue
[21:51:59] <Avenger> full green+blue == cyan
[21:52:06] <lynxlynxlynx> greener than cyan
[21:52:22] <Avenger> well, then your display is wrong :D
[21:54:00] <Avenger> see http://rabbit.eng.miami.edu/class/library/v10/library.cpp
[21:54:22] <lynxlynxlynx> http://hexday.com/color/bcefbc vs http://hexday.com/color/00ffff
[21:55:09] <Avenger> bcefbc is not cyan for sure
[21:55:13] <Avenger> 0xffff00 is the one
[21:55:22] <lynxlynxlynx> bcefbc is DMC_BG2XPGREEN
[21:55:35] <lynxlynxlynx> so q.e.d.
[21:56:04] <Avenger> ok, i just saw this:
[21:56:07] <Avenger> - displaymsg->DisplayConstantString(STR_JOURNALCHANGE,0xffff00);
[21:56:08] <Avenger> + displaymsg->DisplayConstantString(STR_JOURNALCHANGE, DMC_BG2XPGREEN);
[21:56:44] <Avenger> so, the journal change is lightgreen?
[21:56:53] <lynxlynxlynx> yeah, i checked that on screenshots
[21:58:35] <lynxlynxlynx> zzz
[21:59:34] <-- lynxlynxlynx has left IRC (Remote host closed the connection)
[22:04:00] <CIA-26> GemRB: 03avenger_teambg * r2ead2dee7118 10gemrb/gemrb/core/Scriptable/Actor.cpp: Damage now actually honours the guardian mantle bit
[22:15:49] <-- Maighstir has left IRC (Quit: .)
[22:21:43] <Avenger> zzz
[22:21:44] <-- Avenger has left IRC (Quit: bye!)
[23:20:21] <CIA-26> GemRB: 03avenger_teambg * rcf8984503031 10dltcep/ (5 files): small update (a previously unknown pst spell flag)