[00:00:11] <tomprince> And Inventory::GetItem is misnamed an unused.
[00:06:08] <tomprince> And it looks like CREItem could reasonably have a non-default constructor (and only non-default constructors?
[00:21:16] <tomprince> Also, is there any reason that GameScript::TakeItemReplace reuses the CREItem, or is that just a premature optimziation.
[02:34:22] <tomprince> Related question: Should Map::GetPile be modifying its argument? That seems like it would make alot of things move unexpectedly (granted, only a half tile)
[03:30:28] <tomprince> or.cz/const
[03:53:05] --> budlust has joined #GemRb
[04:18:53] <-- budlust has left IRC (Ping timeout: 240 seconds)
[04:54:17] <-- cubathy has left IRC (Ping timeout: 245 seconds)
[05:06:26] --> cubathy has joined #GemRb
[05:16:31] --> raevol has joined #GemRb
[06:00:01] <-- raevol has left IRC (Quit: Leaving.)
[06:13:19] --> raevol has joined #GemRb
[06:22:46] --> puphome has joined #GemRb
[06:25:47] <-- puphome_ has left IRC (Ping timeout: 265 seconds)
[06:28:23] --> Gekz has joined #GemRb
[06:41:47] <-- raevol has left IRC (Quit: Leaving.)
[06:42:25] --> raevol has joined #GemRb
[06:48:17] <-- raevol has left IRC (Quit: Leaving.)
[06:50:08] <-- |Cable| has left IRC (Remote host closed the connection)
[07:03:56] --> lynxlynxlynx has joined #GemRb
[07:04:02] <-- lynxlynxlynx has left IRC (Changing host)
[07:04:02] --> lynxlynxlynx has joined #GemRb
[07:04:02] --- ChanServ gives channel operator status to lynxlynxlynx
[07:11:23] <-- Gekz has left IRC (Quit: This computer has gone to sleep)
[07:43:19] --> Gekz has joined #GemRb
[08:13:57] <fuzzie> tomprince: move?
[08:14:36] <fuzzie> i mean, it converts the argument to the correct coordinates
[08:15:57] <fuzzie> not quite understanding how it would make anything move, though, rather than just be created in the right place
[08:17:19] <fuzzie> and the doxygen comment in the RemoveItem commit is bad
[08:20:21] <fuzzie> and how closely did you look at the rest? CreateItemCore really overwrites all elements of CREItem?
[08:21:24] <fuzzie> claiming "every use of this was passed a new CREItem" when you just made that the case in the previous commit is kinda misleading for my reviewing this, too :(
[08:26:07] <fuzzie> otherwise it looks fine assuming your const commit really does just add 'const'
[08:27:27] <fuzzie> which does seem to be the case :)
[08:27:33] <fuzzie> also good morning all
[08:32:01] <Lightkey> morning already ~.~
[08:34:51] <Gekz> moop
[08:34:54] <-- Gekz has left IRC (Quit: Leaving)
[08:35:14] --> Gekz has joined #GemRb
[09:00:34] <tomprince> Position is passed as reference to GetPile.
[09:01:46] <fuzzie> ah!
[09:02:35] <fuzzie> i imagine the reference needs removing, but clearly i need more coffee
[09:02:55] <fuzzie> you're right, that is terrible
[09:05:07] <fuzzie> especially the way CopyGroundPiles is the same
[09:05:31] <fuzzie> i guess all the Actions/Triggers need a const parameter for 'parameter' too, to make sure this doesn't happen
[09:06:41] <fuzzie> sound reasonable?
[09:07:11] <tomprince> Yes.
[09:07:56] <tomprince> I didn't look to closely at the CreateItemCore thing.
[09:08:16] <fuzzie> me neither
[09:09:12] <tomprince> Although, looking at it more this morning, I am curious if the current code does the right thing. It looks like the current code doesn't set the weight to -1, which means the weight is for the wrong item.
[09:10:15] <fuzzie> well, hence why CalculateWeight() stomps over the slot weights
[09:10:19] <fuzzie> i think
[09:11:01] <fuzzie> oh, i see, as you say, only if it's -1.
[09:11:44] <tomprince> I am curious what the effect in the original engine is for TakeItemReplace when used with a stack.
[09:12:16] <fuzzie> i imagine the same as us
[09:12:38] <fuzzie> well, ok, i didn't look what gemrb is doing: but i imagine the correct behaviour is to replace the whole stack, since the inventory works on slots
[09:13:07] <tomprince> But do we keep the same stack size, or do we use the stack size from the item we load?
[09:13:29] <tomprince> The current code does the former, but if we just set weight to -1, we will do the later.
[09:14:51] <fuzzie> maybe a question best discovered from experimenting
[09:15:04] <fuzzie> you would thinkthe latter
[09:15:39] <tomprince> The only other field that CreateItemCore doesn't stomp on is Expired.
[09:16:26] <fuzzie> hmm, maybe not the latter
[09:16:55] <fuzzie> it is used when replacing Drow Bolts and the such, if you have any convenient bg2 saves
[09:17:26] <tomprince> No.
[09:17:28] <fuzzie> i don't have a bg2 i can run, and probably won't today
[09:18:32] <fuzzie> but it seems to be bg2-only, so hopefully simple to find out..
[09:23:34] <CIA-24> GemRB: 03tom.prince * re3692092126e 10gemrb/gemrb/ (83 files in 7 dirs):
[09:23:35] <CIA-24> GemRB: Constificiation.
[09:23:35] <CIA-24> GemRB: Signed-off-by: Tom Prince <firstname.lastname@example.org>
[10:24:14] --> Gekz_ has joined #GemRb
[10:53:22] <tomprince> We do try to change the actions/triggers in a few places:
[10:53:26] <tomprince> http://localhost:8010/builders/cmake%20g%2B%2B-4.4.3/builds/62/steps/compile/logs/stdio
[10:53:57] <tomprince> Although I suspect we don't need to for any of them.
[10:54:45] * wjp suspects that URL will not work here :-)
[10:54:52] <wjp> hi
[10:55:42] <tomprince> Yes, s/localhost:8010/hermes.hocat.ca:4010/ :)
[10:55:46] <tomprince> Hello.
[10:57:55] <fuzzie> slihtly less trivial than i'd hoped
[10:58:22] <fuzzie> "we hack this to death" is probably a sign that we should fix though :-)
[10:59:03] <fuzzie> but, ok, none of those are bugs, which is reassuring
[10:59:58] <wjp> how annoying. Outgoing traffic to that port is actually filtered here
[11:00:32] * wjp re-routes
[11:01:26] <-- Gekz has left IRC (Changing host)
[11:01:26] --> Gekz has joined #GemRb
[11:05:08] <tomprince> It is also on 80 now.
[11:16:55] --> Maighstir_laptop has joined #GemRb
[11:36:55] <edheldil> heh, my mobile carrier used to helpfully compress transferred images, screwing .tar.bz2 files during the process. I spent sometime with subvertir looking for a culprit when we were implementing autotools in GemRB
[11:37:29] <edheldil> I hate all kinds of 'almost full internet access'
[14:35:55] <-- Gekz_ has left IRC (Quit: Leaving)
[17:38:32] <-- cubathy has left IRC (Ping timeout: 272 seconds)
[17:56:04] <tomprince> Anybody know an easy to test trigger in a store in pst?
[18:01:20] <lynxlynxlynx> something is missing from that sentence
[18:01:58] <tomprince> Not necesarily.
[18:01:59] <lynxlynxlynx> you want to test a trigger? you want to test stores? you want to test a store related trigger?
[18:02:32] <tomprince> PST has triggers for store availability. I want to test one.
[18:02:37] <lynxlynxlynx> it was not the lack of "way" that bothered me
[18:03:08] <tomprince> Since I want to change to compiling on load rather than execute.
[18:03:35] <lynxlynxlynx> shouldn't be hard
[18:06:08] <tomprince> No, I just thought somebody might happend to know an easy place to test.
[18:08:15] <tomprince> If not, I'll track something down later.
[18:08:52] <lynxlynxlynx> stores are run from the dialog, right?
[18:09:16] <tomprince> Yes, I think so.
[18:12:19] <fuzzie> well, i assume this is for the curiosity shop place
[18:12:38] <lynxlynxlynx> AR0402 has one
[18:12:41] <lynxlynxlynx> barkis
[18:12:52] <lynxlynxlynx> just need to recheck
[18:16:27] <lynxlynxlynx> doesn't look like a real barkeep, i'll find you another one
[18:17:48] --> kingron has joined #GemRb
[18:18:12] <lynxlynxlynx> AR0600 goncalves
[18:21:00] <lynxlynxlynx> hah
[18:22:24] <lynxlynxlynx> Vrischika looks like a better choice
[18:25:08] <lynxlynxlynx> the store is called Vris
[18:25:41] <lynxlynxlynx> the npc is in the Curiosity Shoppe at the lower part of the area
[18:26:03] <lynxlynxlynx> whew
[18:26:31] <lynxlynxlynx> what a loop, i didn't see your line fuzzie
[18:30:27] <lynxlynxlynx> i didn't see dltcep has a store button either >>
[18:31:38] --> tomprince_loki has joined #GemRb
[19:20:12] <fuzzie> well, i didn't *look*, i just know you'd need triggers there :)
[19:42:05] --> |Cable| has joined #GemRb
[19:42:25] <-- |Cable| has left IRC (Remote host closed the connection)
[19:43:00] --> |Cable| has joined #GemRb
[20:24:28] <-- Gekz has left IRC (Ping timeout: 260 seconds)
[21:32:06] <-- lynxlynxlynx has left IRC (Remote host closed the connection)
[21:49:25] --> cubathy has joined #GemRb
[22:03:58] <-- cubathy has left IRC (Ping timeout: 258 seconds)
[22:08:24] <-- tomprince has left IRC (Ping timeout: 265 seconds)
[22:08:41] --> tomprince has joined #GemRb
[22:17:32] --> cubathy has joined #GemRb
[22:19:18] <-- tomprince_loki has left IRC (Ping timeout: 258 seconds)
[22:19:35] --> tomprince_loki has joined #GemRb
[22:55:08] <-- kingron has left IRC (Quit: Leaving)
[23:25:47] --> _pickle has joined #GemRb