#gemrb@irc.freenode.net logs for 8 Jan 2015 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage

[03:54:19] <-- nutron has left IRC (Remote host closed the connection)
[04:11:34] --> brada has joined #gemrb
[04:12:00] <brada> lynx: i think we are ready to merge
[04:12:17] <brada> the mapenotes problem wasnt what it seemed
[04:12:24] <brada> they were getting saved and loaded fine
[04:12:35] --> Eli2_ has joined #gemrb
[04:12:39] <brada> just the position was getting set to 0,0 for most of them
[04:15:19] <gembot> build #900 of cmake clang++ is complete: Success [3build successful] Build details are at http://buildbot.gemrb.org/builders/cmake%20clang%2B%2B/builds/900
[04:15:39] <-- Eli2 has left IRC (Ping timeout: 265 seconds)
[04:20:01] <gembot> build #895 of cmake g++-4.2 is complete: Success [3build successful] Build details are at http://buildbot.gemrb.org/builders/cmake%20g%2B%2B-4.2/builds/895
[04:24:18] <gembot> build #890 of cmake g++-4.4 is complete: Success [3build successful] Build details are at http://buildbot.gemrb.org/builders/cmake%20g%2B%2B-4.4/builds/890
[04:51:08] <gembot> build #701 of nmake-msvc++10 is complete: Success [3build successful] Build details are at http://buildbot.gemrb.org/builders/nmake-msvc%2B%2B10/builds/701
[05:02:12] <gembot> build #647 of mingw32 is complete: Success [3build successful] Build details are at http://buildbot.gemrb.org/builders/mingw32/builds/647
[05:47:04] <-- brada has left IRC (Quit: brada)
[06:13:07] <-- Lightkey has left IRC (Ping timeout: 265 seconds)
[06:25:55] --> Lightkey has joined #gemrb
[10:40:12] --> Driim has joined #gemrb
[10:57:27] <Driim> Do I need some authorization to push the party AI button fix I made to github?
[10:59:26] <wjp> the usual approach is to create a github account, fork our repository, make the change in a branch, and submit a pull request
[11:01:01] <Driim> Ok, so all else is done except submitting a pull request.
[11:01:27] <wjp> in that case, you don't need any special authorization or permissions for submitting a pull request
[11:08:13] <Driim> Ah, I haven't forked the repo either, not with my account at least. Ah well, some more steps then.
[11:09:36] <lynxlynxlynx> how did you get the code then?
[11:12:09] <wjp> just clone the repo, I presume
[11:13:24] <Driim> Yes
[11:13:58] <Driim> As per the wiki page.
[11:17:35] <lynxlynxlynx> hmm, i think you can still fork without redownloading
[11:17:48] <lynxlynxlynx> just make the web fork and add the new remote
[11:18:06] <lynxlynxlynx> but it's easier to just redownload and reapply the patch
[11:19:14] <Driim> Probably, I'll still try the first method first and see what goes wrong.
[11:23:50] <Seniorita> [wiki] lynxlynxlynx: download - [Main development repository] added forking instructions http://www.gemrb.org/wiki/doku.php?id=download&rev=1420716028&do=diff
[11:25:45] <Driim> done, only had to 'git remote set-url origin' and at least no complaints.
[11:27:13] <lynxlynxlynx> you'll need both remotes to be able to sync up with the main repo
[11:30:45] <Driim> right you are, I set up separate fetch and push urls now.
[11:34:12] <lynxlynxlynx> this looks odd
[11:37:40] <lynxlynxlynx> AI the python var always holds the current state, so it looks like the "AI" vars are the wrong way round
[11:38:29] <lynxlynxlynx> plus, GS_PARTYAI is always 1, so the hotkey line at the end should also be using AI/"AI"
[11:40:59] <-- Driim has left IRC (Ping timeout: 256 seconds)
[11:43:03] <wjp> is it the check in ExecuteScript that's inverted then?
[12:04:57] <lynxlynxlynx> looks like it
[12:05:05] --> Kaze88 has joined #gemrb
[12:05:21] <lynxlynxlynx> probably all need to change at once and it all started with silly naming
[12:07:14] <Kaze88> Yo
[12:08:13] <lynxlynxlynx> oj
[12:08:47] <Kaze88> Im making an presentation about opensource projects and i was wondering that how many devs do you got in gemrb?
[12:11:27] <lynxlynxlynx> how do you count that?
[12:13:36] <Kaze88> yeah thats the tricky one sinceopen source projects usually have the core + voluntary ppl...lets say the core + most dedicated.
[12:17:24] <Kaze88> and the project started back in 09?
[12:18:30] --> Driim has joined #gemrb
[12:19:08] <lynxlynxlynx> uhh, i'll just say that from dec 7 to today (last month) there have been 5 code changers
[12:20:13] <lynxlynxlynx> gemrb started around 2000
[12:20:26] <Kaze88> yeah noticed the registeration
[12:20:34] <Kaze88> first review 09
[12:20:47] <Kaze88> how many members were there in 2000?
[12:23:15] <Kaze88> just say if you dont want to answer to these or if im bothering you guys.
[12:23:23] <lynxlynxlynx> it started with one guy
[12:23:44] <lynxlynxlynx> by the time it hit sourceforge there were at least 4 in the mailing lists
[12:23:51] <lynxlynxlynx> i can't find the old archives anymore
[12:28:07] <Kaze88> How has the community and new supporters responded to your game engine (atleast on reviews were great mostly) and if someone wanted to join, what would be the best way to do it?
[12:29:47] <lynxlynxlynx> i haven't been there from the start, but in general i guess the response is good
[12:30:06] <lynxlynxlynx> we're not flooded with developers, so it could be better
[12:30:58] <lynxlynxlynx> it could always be better :)
[12:31:18] <lynxlynxlynx> if someone wants to help, the best way is to talk to us
[12:31:36] <Kaze88> also who are the core members of the team? avenger, brad, edheldil, fuzzie, wjp, you etc? atleast those names showed up on the sitemap. you dont have president etc on the team?
[12:32:00] <lynxlynxlynx> we don't have a president, no :D
[12:32:18] <lynxlynxlynx> as with most floss project, it's a loose meritocracy
[12:32:55] <Kaze88> so you are mostly looking for coders or?
[12:33:12] <Kaze88> User interface devs?
[12:34:04] <lynxlynxlynx> everyone
[12:34:19] <lynxlynxlynx> skillset is only limiting what you can do
[12:34:35] <lynxlynxlynx> but that's not taking willingness to learn into consideration
[12:35:00] <lynxlynxlynx> you definitely don't have to be a programmer to contribute
[12:37:06] <Kaze88> maybe a short list what kind of devs you are looking for. i have no clue of game development, but i guess you would need coders, ui designers, 3d modellers, artists etc
[12:40:37] <lynxlynxlynx> http://www.gemrb.org/wiki/doku.php?id=contribute
[12:40:38] <Seniorita> contribute [GemRB wiki]
[12:41:36] <edheldil> Kaze88: 1) modder that creates some short demo game in gemrb 2) c++ or python coder 3) tester 4) doc writer
[12:42:33] <Kaze88> okay almost there. who was the "father" of gemrb? where are you from? around the world? anyone from Finland?
[12:43:15] <Driim> If I find the time I'll take a stab at improving the heal on rest-script. At least providing a skeleton
[12:44:45] <edheldil> Kaze88: founding fathers were balrog and avenger, I think
[12:45:32] <edheldil> we are mostly from Europe, but none from Finland, I think
[12:46:04] <Kaze88> Okay
[12:46:09] <Kaze88> Thank you very much
[12:46:45] <Kaze88> I think that i can compile my presentation now based on these answers. thank you again all!
[12:46:52] <kujeger> speaking of contributing, I built a small script for myself that records a start of gemrb with BG2, creating characters and so on, and then goes through the introduction cinematic of BG2. Would it be of use if I set it to do this automatically on e.g. commits and then uploads the video somewhere? I could probably set it up with BG, IWD1/2 and PST as well
[12:49:10] <-- Kaze88 has left IRC (Quit: Page closed)
[12:49:52] <-- Driim has left IRC (Ping timeout: 245 seconds)
[12:51:06] <lynxlynxlynx> hmm, not sure
[12:51:35] <lynxlynxlynx> some of our timings differ, but i doubt they could be easily extracted from video
[12:52:17] <kujeger> was thinking also of things like when a fix for game a is committed but inadvertently breaks game b that the comitter didn't have access to
[12:53:00] <lynxlynxlynx> video is a really poor way to test for that
[12:53:04] <kujeger> then again actually watching a video to look for stuff like that might be a poor way
[12:53:07] <kujeger> ha, yes
[12:54:00] <lynxlynxlynx> our buildbot runs the minimal test which ensures the core infra is ok
[12:54:43] <lynxlynxlynx> if you set a var, it also does a blank game test, which covers yet more
[12:55:03] <kujeger> the reason I did it was just to easily see what was different from BG2 and gemrb BG2 during the introduction, but figured since I had done it I might as well hear if it could be of use to anyone else
[12:55:53] <lynxlynxlynx> did you find anything else besides the diagonal stuff?
[12:56:15] <lynxlynxlynx> i think the scream trap animation is misplaced, but nothing else comes to mind
[12:56:40] <lynxlynxlynx> could also just be a timing issue, since it's probably scripted and not an actual trap
[12:57:51] <kujeger> some effects are wrong, and I think character animations are a litle off
[12:58:14] <kujeger> (I'd have to recheck the video)
[13:01:04] <edheldil> so it IS useful ...
[13:01:59] <kujeger> http://kumini.kujeger.net/dump/autobg2_clean.mkv this is an old one from july, I should record a new one with latest changes
[13:03:25] <kujeger> tempting to set it up to record a selection of cutscenes, to see which ones run visually correct
[13:20:34] <-- DrMcCoy has left IRC (Remote host closed the connection)
[13:27:34] --> DrMcCoy has joined #gemrb
[13:44:37] <edheldil> That would be great to see even slight differences in timing, if it would be possible to compare the videos frame-by-frame with the original. But is it?
[13:45:17] <lynxlynxlynx> sure, dump the frames with ffmpeg or similar
[13:46:12] <lynxlynxlynx> actor speed is a serious problem for this
[13:52:37] --> Driim has joined #gemrb
[13:56:03] <Driim> is there any clean way to get the knowledge how much a spell can heal?
[13:58:10] <lynxlynxlynx> no, since it uses dice
[13:58:24] <lynxlynxlynx> so not without running
[13:59:18] <Driim> So it not possible even to find out the min and/or max what it possibly can be?
[13:59:29] <lynxlynxlynx> your thought of letting it run for an extra tick and be reentrant sounds good, but also complicated and potentially full of traps
[13:59:42] <lynxlynxlynx> that's why i suggested what i did
[13:59:47] <lynxlynxlynx> sure it is, check their descriptions
[14:00:13] <Driim> I know, it started to feel like too much work, to run the time
[14:00:47] <Driim> I thought I might just check the minimum each spell can heal and then just use Heal()
[14:09:05] <lynxlynxlynx> nah, you still want to apply the spells
[14:09:23] <lynxlynxlynx> just use the estimate to distribute their application throughout the party better
[14:09:42] <lynxlynxlynx> also the mean will be a better choice than the minimum
[14:11:26] <Driim> With Heal I could get hp instantly modified, so party's end result would not be an estimation
[14:12:04] <Driim> Even though it is wrong, since it is skipping the rules.
[14:17:05] <lynxlynxlynx> the emphasis being on "it is wrong"
[14:20:04] <Driim> If it were easier understanding how the engine does things, I'd have more motivation on getting it done right =) Sigh, more reading and head scratching to do then.
[14:30:39] <lynxlynxlynx> it's already using data from splspec.2da, that's why i said it's a good place to store the values
[14:31:02] <lynxlynxlynx> i think we already start with the most injured pc
[14:31:41] <lynxlynxlynx> the loop would need to be encased in another one and perhaps the spell effectivity sorted too
[14:32:17] <lynxlynxlynx> 1st most injured gets 1st most potent healing spell, 2nd most injured gets 2nd most and so on
[14:32:41] <lynxlynxlynx> since there may be multiple memorisations, the spells will be the same in some cases
[14:32:59] <lynxlynxlynx> and you'd have to treat heal, mass heal and the like specially too
[14:33:11] <lynxlynxlynx> hope that helps
[14:33:18] <lynxlynxlynx> reread what i wrote the other day
[14:33:27] <Driim> Not most injured, just the first. Also, natural healing only happens on the fist party member before spell healing, the rest heal afterwards.
[14:48:46] <Driim> Sorry, just a bit frustrated for a lack of, or inability to find, good examples or documentation.
[15:59:58] <lynxlynxlynx> it would be good to know what docs you are missing, so they can be added
[16:00:23] <lynxlynxlynx> you're straight in the game and actor objects though
[16:21:35] <Driim> How come my commands to console are accepted but produce no output(unless there are errors)? For example Roll or GetPlayerStat
[16:23:08] <Driim> At first I got the maximum hp of a character, now just... nothing
[16:25:41] <wjp> I haven't tried our console in a while, but try prefixing the call with "print " ?
[16:26:08] <Driim> that's it.
[16:32:42] <Driim> Any idea why one exportable character requirement is, that the character is _not_ dual-classed?
[16:33:36] <Driim> Limitation on the implementation of exporting maybe?
[16:39:00] <Driim> Using SaveCharacter on a dual-classed character works and importing it revealed no issues.
[16:44:31] <-- DrMcCoy has left IRC (Quit: He's dead, Jim)
[16:45:04] --> DrMcCoy has joined #gemrb
[17:00:50] --> brada has joined #gemrb
[17:00:56] <brada> hello
[17:14:03] <Driim> re-reading the healing spell descriptions they seem to have a fixed amount of healing after all.
[17:37:50] <lynxlynxlynx> Driim: exportability is determined by a presence of a mc flag bit
[17:38:27] <lynxlynxlynx> could be we mistakenly reset it during dualclassing, since the same bitfield holds the mapping for the previous class
[17:43:45] <Driim> Ok. On the healing matter: are the spells written out anywhere, or is there any quick&simple method to link spell descriptions and resrefs?
[17:44:20] <lynxlynxlynx> a from splspec.2da, th
[17:45:09] <lynxlynxlynx> the ones with bit 8 are cast on this ocassion
[17:45:12] <lynxlynxlynx> occasion
[17:49:55] <lynxlynxlynx> but there's no need for spell description linking
[17:50:09] <lynxlynxlynx> the hp data should just be put in the table (extra column)
[17:51:17] <Driim> Yes, and in order to do that, I have to find out which handle is which spell =)
[17:53:27] <lynxlynxlynx> nearinfinity or dltcep
[17:53:43] <lynxlynxlynx> some websites may have the page names as the refs
[17:55:08] <lynxlynxlynx> http://www.gamebanshee.com/showshot.php?/icewinddaleii/spells/images/cureseriouswounds.jpg <-- not the case
[17:55:09] <Seniorita> Screenshots @ GameBanshee
[17:55:10] <Seniorita> »Daily news, reviews, interviews, previews, screenshots, walkthroughs, databases, cheats, and more for PC, Xbox, GameCube, Playstation, and Game Boy Advance.«
[17:55:16] <lynxlynxlynx> and ugh, forgot about the caster level
[17:55:18] <lynxlynxlynx> even more fuzz
[17:55:27] <lynxlynxlynx> brada: i confirm that map notes are fine now :)
[17:55:37] <brada> sweet
[17:55:42] <brada> merge?
[17:56:00] <lynxlynxlynx> guirec :P
[17:56:07] <brada> still?
[17:56:08] <lynxlynxlynx> that's the last thing
[17:56:18] <lynxlynxlynx> still the same commit too
[17:56:22] <brada> that last fix wasnt everything?
[17:56:34] <lynxlynxlynx> i didn't even catch that one
[17:56:48] <lynxlynxlynx> you broke the favourites displays
[17:57:07] <brada> ok
[17:58:16] <Driim> How come iwd in-game descriptions give fixed amount of healing? 8 for cure light wounds, 11 for cmw etc
[17:58:31] <Driim> and no caster level modification
[17:59:16] <lynxlynxlynx> it's just different
[17:59:28] <lynxlynxlynx> fixed means that the heuristic will do perfectly
[18:43:05] <brada> lynx: that should be fixed now…
[18:46:17] <lynxlynxlynx> it doesn't have problems with missing data, yes
[18:46:30] <lynxlynxlynx> not sure why it's doubly spaced though
[18:46:44] <lynxlynxlynx> weren't you mostly removing them?
[18:55:32] <brada> i didnt notice anything wrong. is the original not also double spaced?
[18:55:40] <brada> or is it jsut certain lines that shouldnt be?
[18:56:24] <lynxlynxlynx> none, just before the second heading
[18:56:41] <lynxlynxlynx> master should have it right, but i'm checked out now
[18:56:53] <lynxlynxlynx> there should be a screenshot url comment above the section function
[18:57:19] <brada> anyway i can fix the doulbe spacing later
[18:57:24] <brada> im a bit busy atm
[18:57:44] <brada> i dont think double spacing should prevent merging tho :)
[19:05:00] <lynxlynxlynx> no, you're fine
[19:05:09] <lynxlynxlynx> just remember to do a pull, not a rebase
[19:14:57] <-- DrMcCoy has left IRC (Disconnected by services)
[19:15:05] --> DrMcCoy has joined #gemrb
[19:15:58] <-- DrMcCoy has left IRC (Client Quit)
[19:17:07] --> DrMcCoy has joined #gemrb
[19:18:03] --> kpederse1 has joined #gemrb
[19:21:34] <-- kpedersen has left IRC (Ping timeout: 255 seconds)
[19:39:07] <brada> i was just going to checkout masert and to a git merge… is that not what we want?
[19:39:52] <brada> im also unsure of what is going to happen to channel traffic when that is merged… im scared of the wall of text that i imagine flooding in
[19:51:43] <lynxlynxlynx> i guess that works, i just usually do it via git pull branch .
[19:51:55] <lynxlynxlynx> no need for the fetch step here
[19:52:07] <lynxlynxlynx> let's see about Seniorita
[19:52:34] <brada> ok here we go
[19:53:18] <lynxlynxlynx> miha's not online
[19:53:30] <brada> thats probably for the best
[19:53:32] <Seniorita> [commit] lynxlynxlynx: Font: isspace is available only in c++ std, so include the correct header https://github.com/gemrb/gemrb/commit/acd700eae45e01125f485ceed127150483a32c2d
[19:53:34] <Seniorita> [commit] lynxlynxlynx: AREImporter: another winfix https://github.com/gemrb/gemrb/commit/ebc014d81c480a9de4da21f162667a79dd841278
[19:53:35] <Seniorita> [commit] bradallred: Merge branch 'master' into font-rewrite https://github.com/gemrb/gemrb/commit/78c2ecbeb672865fda353357ec78e0a53530c533
[19:53:36] <Seniorita> [commit] bradallred: StringBlock: removing obsolete comment and possible null dereference https://github.com/gemrb/gemrb/commit/88f1b5a06e45d4b6a899face4fc1324fdaf2b6be
[19:53:37] <brada> oh ha ha
[19:53:37] <Seniorita> [commit] bradallred: GUIScript: fix an error in SubstituteForControl https://github.com/gemrb/gemrb/commit/52c8ead7e1fcfef11ca20f1853196e3a49f6ac50
[19:53:38] <brada> yeah
[19:53:38] <Seniorita> [commit] bradallred: Control: this is exactly what MarkDirty() does https://github.com/gemrb/gemrb/commit/86aeb84c28668248969e53120ed6b3d24d374c86
[19:53:40] <Seniorita> [commit] lynxlynxlynx: only pst has the harmless* set of triggers https://github.com/gemrb/gemrb/commit/5f1c3e34bd5634285fd531ae32795a4ff1aa8b2b
[19:53:41] <Seniorita> [commit] bradallred: no need to store the strdup result for this operation https://github.com/gemrb/gemrb/commit/8d93a45dd68f8ac91b53307f276003431a036ff3
[19:53:42] <Seniorita> [commit] bradallred: fix a string leak https://github.com/gemrb/gemrb/commit/cb468341a68836767ee3c5b4d1ee13d913e10120
[19:53:43] <Seniorita> [commit] bradallred: Scrollbar: consolidating stepPx/GetStep/CalculateStep https://github.com/gemrb/gemrb/commit/f06dbb46182db315d402ee372abb7711d7cdab1d
[19:53:44] <Seniorita> [commit] bradallred: TextArea: fix a 1px rounding error https://github.com/gemrb/gemrb/commit/f4f2c92e66dd15cce2dd1a6b0056f4a43783af21
[19:53:46] <Seniorita> [commit] lynxlynxlynx: GetActorClassTitle: reinstated safety check from master https://github.com/gemrb/gemrb/commit/85c88521f08b4f6a34111d6af2877c0570ebcf12
[19:53:47] <Seniorita> [commit] lynxlynxlynx: added missing moviefont definitions https://github.com/gemrb/gemrb/commit/822040e83d9c0d69fb7bf26c2ba3e42ab8566ed4
[19:53:48] <Seniorita> [commit] lynxlynxlynx: MakeSpellCount: fixed wrong constant being used https://github.com/gemrb/gemrb/commit/c890d2cf5ebdf9f183a61e0bfbd6e631f330748b
[19:53:49] <Seniorita> [commit] bradallred: iw2 GUIREC: fix missing variable https://github.com/gemrb/gemrb/commit/0fbc59b47217b925aefa71f25c2bb4c4f779bb3d
[19:53:50] <Seniorita> [commit] bradallred: MapNotes: simplify map note creation https://github.com/gemrb/gemrb/commit/38c6a8320fcae02cca2d209eee41a3fa32a8fd39
[19:53:52] <Seniorita> [commit] bradallred: mapnotes: fix position getting set to (0,0) on copy https://github.com/gemrb/gemrb/commit/2f82c1e93299f83fc2c23face4690dd24da46806
[19:53:53] <Seniorita> [commit] bradallred: MapNotes: cleanup https://github.com/gemrb/gemrb/commit/abeacc8cdea2fcb2e7509124efc8fbcd82a31e9d
[19:53:54] <Seniorita> [commit] bradallred: iwd2 GUIRec: fix another typo https://github.com/gemrb/gemrb/commit/1f0ad80519b86759611721cfa9cc0cf9c1f068cc
[19:53:55] <Seniorita> [commit] bradallred: GemRB_GetPCStats: return a consistant type https://github.com/gemrb/gemrb/commit/e473b39295c048a706020c056c3fec5423885979
[19:54:21] <fuzzie> \o/
[19:54:39] <lynxlynxlynx> anti-climactic
[19:55:04] <brada> i wonder if it got blocked for spamming
[19:55:24] <brada> or crashed :D
[19:57:28] <lynxlynxlynx> no, just went up till the last merge
[19:58:22] <brada> ah i see. makes sense
[19:58:38] <lynxlynxlynx> gitk shows the same
[19:58:54] <lynxlynxlynx> well, wohooo!
[20:01:19] <brada> finally :)
[20:01:41] <brada> still some things to be done there of course
[20:05:47] <lynxlynxlynx> i'll copy part of the pull request info into the header
[20:06:02] <lynxlynxlynx> nice bit of doc
[20:08:16] <brada> indeed
[20:08:27] <lynxlynxlynx> how would you summarize that branch in NEWS?
[20:09:06] <lynxlynxlynx> text handling rewrite for better perfomance and unicode support?
[20:09:29] <fuzzie> also extra awesome.
[20:09:41] <fuzzie> and fewer lurking gnome horrors.
[20:09:58] <brada> the pull request should have some tidbits
[20:10:30] <lynxlynxlynx> yeah, but this needs to be exec exec exec summary short and user readable
[20:11:04] <lynxlynxlynx> so, added maintainability?
[20:12:04] <brada> yes maintainability was a key reason i did it so throw that in there :)
[20:12:44] <lynxlynxlynx> Malformed scripting action: StartCutscene(#53cKulda#) <-- silly iwd2 (it remains a mistery how the engine coders didn't murder the scripters at some point)
[20:12:48] <brada> fixed a ton of minor bugs especially when compared to the original. may werent obvious without doing a comparrison.
[20:13:19] <brada> what if the engine coders were the scripters? what then? :D
[20:13:49] <brada> I have those screen shot comparisons that might be fun to post somewhere to give an idea of how the text layout changed
[20:14:04] <lynxlynxlynx> yea! visual changelogs ftw
[20:16:47] <lynxlynxlynx> running coverity on it
[20:16:55] <Seniorita> [commit] lynxlynxlynx: Font.h: added architecture note to the intro doc https://github.com/gemrb/gemrb/commit/a98415d2eb340f5d39d8047868c1a4ab4d4bf21c
[20:18:54] <brada> here was what gemrb looked like compared to original prior to merging: https://www.dropbox.com/s/cwtukctguqg8xlg/gemrb-current.png?dl=0
[20:18:57] <Seniorita> Dropbox - gemrb-current.png
[20:19:14] <brada> and this is how it looks now: https://www.dropbox.com/s/9f3vm75n8sr3p6g/gemrb-new.png?dl=0
[20:19:16] <Seniorita> Dropbox - gemrb-new.png
[20:20:13] <brada> diffrence is subtle if you dont have a comparison like that.
[20:20:24] <brada> but we were chopping off a few labels here and there due to it
[20:33:18] <lynxlynxlynx> Analysis Summary:
[20:33:18] <lynxlynxlynx> New defects found: 6
[20:33:18] <lynxlynxlynx> Defects eliminated: 11
[20:33:21] <lynxlynxlynx> not bad :)
[20:34:36] <brada> nice an overall reduction then :p
[20:36:42] <brada> that one memory error in GemMarkup.cpp looks bogus to me…
[20:37:06] <brada> finit would have to be deleted between those calls
[20:38:03] <brada> the only other things in my code i see are some dead store warnings (placeholder code for text editing actually)
[20:39:34] <brada> that classnames thing is throwing a warning again too
[20:39:55] <brada> as i said on github tho, it shoud only leak if input is bad (still should fix it i guess)
[20:40:28] <brada> could roll back to what i had done to fix it too
[20:41:14] <lynxlynxlynx> are we looking at the same report? :s
[20:41:48] <brada> im looking at clangs report
[20:41:54] <lynxlynxlynx> oh
[20:42:11] <lynxlynxlynx> well, none of the new stuff mentions finit or gemmarkup
[20:42:46] <lynxlynxlynx> 2x dead code, 2x palette null deref, 2x no initialisation
[20:45:31] <brada> the palette nul deref is in GemMarkup :p
[20:52:29] <brada> oh, it occured to me that something else needs to be put on the todo
[20:52:36] <lynxlynxlynx> DrawOverheadText which is in scriptable
[20:52:36] <brada> tooltips are still using cstrings
[20:52:41] <brada> so they dont get translated
[20:53:08] <brada> i guess that means i was right about it being bogus :p
[20:53:49] <brada> so tooltips will only work with asciiish encodings
[21:08:55] <brada> hmmm i must be mistaken about tooltips. at somepoint they are getting turned into Strings so that should be fine
[21:09:09] <brada> still would like to go back and make the rest of the tooltip code use string etc
[21:29:08] <brada> we still need to find somebody to finish the opengl stuff
[21:29:18] <brada> or at least improve/fix it
[21:29:27] <brada> im afraid i broke it a bit
[21:29:56] <wjp> oh, I still had some font colouring things on my TODO list, didn't I?
[21:31:13] <lynxlynxlynx> i noticed something else that may be for you; i think it was discussed before, but not sure; iwd2 movies get wrecked if you have subtitles on (i suspect the custom subtitle color palette, but haven't checked yet)
[21:34:05] <lynxlynxlynx> grr, infinite loops
[21:35:51] <wjp> remind me how I turn on subtitles?
[21:36:07] <lynxlynxlynx> Display Movie Subtitles=1
[21:36:31] <wjp> oh, is this gem-*.ini new?
[21:36:41] <lynxlynxlynx> they won't actually be displayed, but the frames will be garbled up
[21:36:47] <lynxlynxlynx> newish
[21:37:01] <wjp> wow, nice effect
[21:37:07] <lynxlynxlynx> it's completely possible that we have to wrong subtitle font set for iwd2 too
[21:37:17] <lynxlynxlynx> to/the
[21:38:34] <lynxlynxlynx> brada: i can reproduce the infinite loop
[21:38:42] <lynxlynxlynx> just try creating a druid in tob
[21:38:49] <lynxlynxlynx> seems the spell list does him in
[21:39:03] <lynxlynxlynx> GemRB::Font::StringSize (this=0x8996b0,
[21:39:03] <lynxlynxlynx> string=L"EvilEntangleShillelaghArmor of FaithDoomBarkskinCharm Person or MammalFind TrapsFlame BladeGood BerriesKnow AlignmentResist Fire/ColdSlow PoisonCall LightningDispel MagicHold AnimalProtection From Fir"..., stop=0x7fffffffd000, numChars=0x7fffffffd008)
[21:39:12] <lynxlynxlynx> more newline crap
[21:41:25] <lynxlynxlynx> yeah
[21:42:04] <brada> ill check out the subtitles
[21:42:15] <brada> er maybe you were talking to wjp
[21:42:29] <brada> that sounds possibly related to that alpha blending thing he was playing with
[21:43:28] <brada> unfortunately i dont have IWD :(
[21:43:51] <wjp> oh, the speech in the IWD2 introduction is also at double speed
[21:43:56] <brada> ill have to pick that game up on the cheap next time gog ahs a sale
[21:44:07] <brada> wjp: is that new?
[21:44:13] <wjp> you've missed about 5 of those the past half year :-)
[21:44:26] <brada> ha ha well ive been busy
[21:44:54] <fuzzie> it is easy to miss them when you're busy
[21:44:58] <brada> of course now there is that shiny EE version
[21:45:02] <fuzzie> I trust you all grabbed Cosmo's Cosmic Adventure while it was on sale
[21:45:14] <brada> so maybe i should make gemrb work with those next
[21:45:21] <brada> fuzzie: i did not
[21:45:23] <fuzzie> it is reassuringly 13 on their bestsellers list right now, above these silly games like Duke Nukem
[21:45:27] <brada> never heard of it either :p
[21:45:47] <lynxlynxlynx> the subtitle thing has nothing to do with the font rewrite btw
[21:46:01] <brada> ok good :)
[21:46:10] <brada> sounds like a wjp thing
[21:46:28] <lynxlynxlynx> newlines are grrr though
[21:46:34] <brada> yes
[21:46:36] <lynxlynxlynx> seems like sometimes append just ignores them
[21:48:18] <Seniorita> [commit] lynxlynxlynx: NEWS: font-rewrite got merged! https://github.com/gemrb/gemrb/commit/3d8c0ea877e545eaa719a30658958f86a59465d4
[21:48:19] <Seniorita> [commit] lynxlynxlynx: first round (search) of extra conversions to named GetValue constants https://github.com/gemrb/gemrb/commit/fd9e69293cadb41c85772347f8eb1fcdc23bf04f
[21:48:20] <Seniorita> [commit] lynxlynxlynx: second round (search) of extra conversions to named GetValue constants https://github.com/gemrb/gemrb/commit/10f8e75c975d17f27c6c384d0e00d18052a535b8
[21:48:21] <Seniorita> [commit] lynxlynxlynx: third round (search) of extra conversions to named GetValue constants https://github.com/gemrb/gemrb/commit/61a2ab8cc94e9c9c7db49f8fae82668190b06e3f
[21:48:22] <Seniorita> [commit] lynxlynxlynx: use GTV_REF to get resolved strings instead of manual lookup https://github.com/gemrb/gemrb/commit/8b9ac964a0c3d050d73426111f56b65e89d30733
[21:48:24] <Seniorita> [commit] lynxlynxlynx: bg2::cg: fix some infinite loops https://github.com/gemrb/gemrb/commit/d7179035879de1926f6006fdb43360ac433ec9d7
[21:49:48] <brada> glad you fixed that, but it still shouldnt cause an infinite loop...
[21:49:54] <brada> so there is still a bug lurking
[21:50:07] <lynxlynxlynx> Font::StringSize should be smarter
[21:50:30] <lynxlynxlynx> i'm sure there are other ways to trigger it
[21:53:06] <-- Driim has left IRC (Quit: Leaving)
[21:58:39] <brada> of course it should be. do you have any specific insight for how it should behave?
[21:59:11] --> cj_schnell has joined #gemrb
[22:02:06] <lynxlynxlynx> didn't even look at why it happens
[22:02:20] <lynxlynxlynx> same thing as for pst journal?
[22:02:34] <lynxlynxlynx> surely we can check for overflows and stuff like that
[22:08:55] <wjp> oh, the IWD2 subtitle and audio bugs are linked.
[22:09:08] <wjp> subtitle code is breaking the frame counter and confusing the rest of the movie player
[22:12:14] <brada> oh lynx, that infinite loop looks probably expected actually
[22:12:31] <brada> i mean we should detect that situation and avoid it by clipping the text instead
[22:12:42] <brada> but that line as it was couldnt possibly fit in that text area
[22:12:59] <brada> ill look at it deeper
[22:13:01] <brada> later
[22:13:38] <brada> even putting spaces between the spells would work
[22:14:23] <brada> regardless, in this case StringSize isnt to blame since it is a string 10 kilometers long
[22:14:34] <lynxlynxlynx> newlines go between them and that works
[22:14:40] <brada> yes
[22:14:43] <brada> sapces would too
[22:14:54] <brada> but without that it doenst knwo where to break the “word"
[22:15:00] <lynxlynxlynx> yeah but that's wrong in this case
[22:15:06] <brada> how?
[22:15:19] <lynxlynxlynx> just in this particular case, i mean
[22:17:38] <brada> its probably trivial to just compare the string length to the container width and realize it will never fit and just clip it off
[22:18:13] <brada> or force wrap it, wheverver we prefer
[22:23:34] <Lightkey> http://www.pcgamer.com/beamdog-confirms-that-a-new-baldurs-gate-game-is-in-the-works/
[22:23:37] <Seniorita> Beamdog confirms that a new Baldur's Gate game is in the works - PC Gamer
[22:23:38] <Seniorita> »Rumors about the game known as Adventure Y have been swirling since 2012.«
[22:25:05] <lynxlynxlynx> just cut it short and shorter, manually adding "WTF!?"
[22:29:17] <brada> ha ha im totally tempted to do that
[22:30:11] <wjp> lazy question: how do I quickly print the output of core->GetString() to the terminal?
[22:31:42] <brada> GemRB.GetString?
[22:31:54] <brada> you mean in game console i assume
[22:33:02] <wjp> no, from C++, on terminal
[22:33:31] <brada> oh its jsut like std::string
[22:33:47] <brada> so %ls
[22:33:54] <brada> for the format specifier
[22:34:00] <brada> then string.c_str()
[22:35:41] <wjp> ah, I see
[22:39:42] <wjp> ok, subtitle timing seems fine
[22:39:52] <wjp> just not displaying them somehow; maybe due to font or palette
[22:40:11] <Seniorita> [commit] : Fix IWD2 movies when subtitles are enabled. https://github.com/gemrb/gemrb/commit/9f4184df918c7bfbbbcd54ae83c259ecfcac4945
[22:40:31] <wjp> but this fixes the videos themselves
[22:40:44] <lynxlynxlynx> thanks
[22:41:07] <lynxlynxlynx> i'll just randomly try some other fonts, it has stonesml now
[22:41:55] <wjp> could also be due to how it tries to paint them in the SDL backend,
[22:42:00] <wjp> with this ugly backBuf hack
[22:43:01] <wjp> anyway, bedtime; 'night
[22:43:06] <lynxlynxlynx> nn
[22:47:30] <lynxlynxlynx> this ai switching looks even odder when you try it
[23:12:40] <Seniorita> [commit] lynxlynxlynx: Scriptable::DrawOverheadText: simplify call, since palette is already resolved to either https://github.com/gemrb/gemrb/commit/a234de3ab5184c77f9a6280a00ef885dc998f927
[23:12:41] <Seniorita> [commit] lynxlynxlynx: AREImporter::GetMap: init color for coverity https://github.com/gemrb/gemrb/commit/efcf7717038f3a574e51683049d3d74b0506e83d
[23:12:42] <Seniorita> [commit] lynxlynxlynx: Scriptable::ExecuteScript: correctly check if party ai is on https://github.com/gemrb/gemrb/commit/20c32178629ac0bb89405f14a2691066e86b56c9
[23:16:58] <lynxlynxlynx> found the dualclass bit mash too
[23:28:34] <brada> nice
[23:35:54] --> edheldil_ has joined #gemrb