#gemrb@irc.freenode.net logs for 8 Mar 2012 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage

[00:21:54] <-- Yoshimo has left IRC (Quit: Yoshimo)
[00:23:56] <-- edheldil_ has left IRC (Ping timeout: 272 seconds)
[00:34:07] <-- haad has left IRC (Quit: Leaving.)
[00:42:35] --> brad_a has joined #gemrb
[01:10:07] --> joneirik has joined #gemrb
[03:07:36] --> alx3apps has joined #gemrb
[04:24:10] <-- DrMcCoy has left IRC (Ping timeout: 244 seconds)
[04:27:16] --> DrMcCoy has joined #gemrb
[04:38:07] <-- DrMcCoy has left IRC (Ping timeout: 244 seconds)
[04:50:24] --> DrMcCoy has joined #gemrb
[05:07:01] <brad_a> what is "RK"?
[05:07:40] <brad_a> i see its related to the mouse but thats it
[05:47:04] --> nutron has joined #gemrb
[06:24:51] <-- brad_a has left IRC (Quit: brad_a)
[06:48:56] --> brad_a has joined #gemrb
[07:10:29] <-- brad_a has left IRC (Quit: brad_a)
[07:30:04] --> Avenger has joined #gemrb
[07:31:42] <Avenger> brad_d: RK is short for Repeat Key. It is to repeat clicks when a button is pressed. (for example at thieving skill point distribution)
[07:31:57] <-- Avenger has left IRC (Client Quit)
[07:41:14] --> brad_a has joined #gemrb
[07:43:29] <brad_a> ah thanks for the explanation :). in retrospect it was obvious as is often the case.
[07:52:08] --> kettuz has joined #gemrb
[08:03:41] --> lynxlynxlynx has joined #gemrb
[08:03:42] <-- lynxlynxlynx has left IRC (Changing host)
[08:03:42] --> lynxlynxlynx has joined #gemrb
[08:03:42] --- ChanServ gives channel operator status to lynxlynxlynx
[08:04:39] <-- brad_a has left IRC (Quit: brad_a)
[08:28:55] <-- kettuz has left IRC (Quit: Leaving)
[08:42:33] <-- joneirik has left IRC (Remote host closed the connection)
[10:12:53] <edheldil> Have you guys got the github mail already?
[10:14:11] <edheldil> because for some of my colleagues it ended in Spam folder, apparently it too much looks like another "Verify you bank account" phishing
[10:23:17] --- edheldil has changed the topic to: GemRB 0.7.0 | http://gemrb.org | Verify your GitHub keys | Something wrong? CHECK THE GEMRB LOG | Be wary of your thoughts for there are Illithid present: http://log.usecode.org/gemrblog.php | import pdb; pdb.set_trace()
[10:34:04] <lynxlynxlynx> yep
[10:36:45] --> edheldil_ has joined #gemrb
[11:17:00] <-- alx3apps has left IRC (Quit: Leaving.)
[12:46:14] --> haad has joined #gemrb
[13:35:36] <-- kida_laptop has left IRC (Ping timeout: 272 seconds)
[13:35:51] --> kida_laptop has joined #gemrb
[14:47:02] <-- haad has left IRC (Quit: Leaving.)
[17:16:55] <-- Cable_ has left IRC (Remote host closed the connection)
[17:18:28] --> |Cable| has joined #gemrb
[17:20:39] <-- |Cable| has left IRC (Remote host closed the connection)
[17:22:10] --> |Cable| has joined #gemrb
[17:24:33] <-- |Cable| has left IRC (Remote host closed the connection)
[17:26:02] --> |Cable| has joined #gemrb
[17:48:19] <CIA-28> GemRB: 03avenger_teambg * rf7990c751b2a 10gemrb/gemrb/plugins/GUIScript/GUIScript.cpp: fixed another regression
[17:48:22] <CIA-28> GemRB: 03avenger_teambg * r1332d404dac5 10gemrb/gemrb/ (GUIScripts/GUICommonWindows.py core/Interface.cpp): Merge branch 'master' of ssh://gemrb.git.sourceforge.net/gitroot/gemrb/gemrb
[18:15:32] <-- edheldil_ has left IRC (Ping timeout: 272 seconds)
[18:27:20] --> qubodup has joined #gemrb
[18:27:25] <qubodup> hi
[18:36:16] --> brad_a has joined #gemrb
[18:39:36] <lynxlynxlynx> oj
[18:51:52] <gembot> build #244 of osx-test is complete: Success [3build successful] Build details are at http://buildbot.gemrb.org/builders/osx-test/builds/244
[18:55:07] <CIA-28> GemRB: 03lynxlupodian * r15f57f65b5b5 10gemrb/gemrb/plugins/GUIScript/GUIScript.cpp: some more regression fixes
[19:11:54] --> Yoshimo has joined #gemrb
[19:12:54] <-- brad_a has left IRC (Quit: brad_a)
[19:47:21] --> brad_a has joined #gemrb
[20:06:16] --> kettuz has joined #gemrb
[20:19:54] <CIA-28> GemRB: 03avenger_teambg * r8b297d806305 10gemrb/gemrb/ (6 files in 3 dirs): fixed learning of spells in iwd2 (always select the correct booktypes)
[20:21:30] <-- kettuz has left IRC (Quit: Leaving)
[20:23:15] <CIA-28> GemRB: 03avenger_teambg * r80781efd4018 10gemrb/gemrb/core/Spellbook.cpp: spaces!!!
[20:23:56] --> Avenger has joined #gemrb
[20:23:57] --- ChanServ gives channel operator status to Avenger
[20:25:25] <lynxlynxlynx> what's with your spaces recently, changed the editor?
[20:26:26] <-- qubodup has left IRC (Read error: Connection reset by peer)
[20:27:00] <Avenger> you convinced me to commit from windows
[20:27:21] <Avenger> msvc's editor is silly, replaces tabs with spaces
[20:27:48] <lynxlynxlynx> i'm sure it's not so silly to not be able to switch it off
[20:27:56] <Avenger> so i have to go through it with pspad
[20:28:00] <lynxlynxlynx> also, as of one of the last commits, creimporter doesn't build
[20:28:04] <Avenger> meh
[20:28:36] <Avenger> did i sommit actormgr?
[20:28:40] <Avenger> commti
[20:28:45] <Avenger> O_o
[20:29:02] <lynxlynxlynx> http://paste.debian.net/159054/
[20:29:19] <lynxlynxlynx> so yes, looks like something is missing
[20:29:54] <CIA-28> GemRB: 03avenger_teambg * r3320094de8f3 10gemrb/gemrb/plugins/CREImporter/CREImporter.h: missing file
[20:29:55] <Avenger> maybe this one
[20:30:50] --> qubodup has joined #gemrb
[20:31:18] <lynxlynxlynx> much better, only the two return type errors remain
[20:31:47] <Avenger> hmm, those consts?
[20:32:07] <lynxlynxlynx> exactly
[20:32:09] <lynxlynxlynx> mismatch
[20:32:52] <Avenger> i wonder what's wrong
[20:33:07] <lynxlynxlynx> there's no const in the header
[20:33:21] <lynxlynxlynx> this is findspell
[20:33:50] <Avenger> but there is no findspell in any header?
[20:35:28] <Avenger> too many const :)
[20:37:39] <CIA-28> GemRB: 03avenger_teambg * r96979ddb640a 10gemrb/gemrb/ (3 files in 2 dirs): hopefully better
[20:37:58] <Avenger> if this isn't better, then i gotta reboot to linux and try there ;)
[20:45:08] <lynxlynxlynx> works
[20:53:13] --> edsrzf has joined #gemrb
[20:54:52] <Avenger> iwd2 spellbook marshalling is still not done. Do you want to fix that? :)
[20:55:40] <Avenger> it is a bit tricky, one gotta count the spells and convert the resrefs back to indices.
[20:55:53] <Avenger> but the loader is there for reference
[20:55:54] <lynxlynxlynx> sorry, no time whatsoever until april
[20:56:32] <Avenger> ok, i'm kinda busy too, gotta work in saturday :(
[20:57:23] <edsrzf> Hi, I've just started BG1 and it seems like the Command Sounds and Selection Sounds options do nothing, so my characters are annoyingly vocal.
[20:57:39] <edsrzf> I was thinking this might be a good thing to work on for a first patch. Can anyone give me some guidance?
[20:58:06] <Avenger> did you try to edit the original game ini?
[20:58:23] <lynxlynxlynx> shhh, he wants to fix it permanently
[20:58:46] <Avenger> well, it is a guiscript value problem, i guess
[20:59:01] <edsrzf> Yeah, I think I found the Python where the option is
[20:59:15] <lynxlynxlynx> Avenger: well, one weekday is nothing, i did more than a month's worth of overtime the last two months and it won't get any better -.-
[20:59:16] <Avenger> well, simply the associated values are wrong
[20:59:53] <Avenger> OptRadio ('SelectionSounds', Window, 58, 57, 'Selection Sounds Frequency', 1)
[20:59:54] <Avenger> OptRadio ('SelectionSounds', Window, 59, 57, 'Selection Sounds Frequency', 2)
[20:59:56] <Avenger> OptRadio ('SelectionSounds', Window, 60, 57, 'Selection Sounds Frequency', 3)
[20:59:57] <Avenger> lower the values by one :)
[21:00:05] <edsrzf> Oh, that's it?
[21:00:11] <Avenger> most likely, yes
[21:00:21] <edsrzf> I thought it would be more involved, but I'll try that :)
[21:00:39] <Avenger> well, it could be more difficult, if the original engine uses 1-3 values
[21:00:42] <-- qubodup has left IRC (Ping timeout: 244 seconds)
[21:00:51] <Avenger> then you need to modify core engine code too
[21:01:04] <Avenger> and then, you need to investigate ALL five games
[21:01:08] <Avenger> ...
[21:01:10] <fuzzie> there were various odd issues with the options not sticking
[21:01:28] --> qubodup has joined #gemrb
[21:01:37] <fuzzie> would be nice if it were all just bad values
[21:02:01] <Avenger> i made some change to update the core variables based on the gui settings
[21:02:13] <Avenger> that's when i noticed the number discrepancy
[21:02:24] <Avenger> 0 means no feedback, in core
[21:02:37] <fuzzie> ah :)
[21:02:40] <Avenger> but i think in the gui it is 3
[21:03:01] <Avenger> and then i checked other games, and it seems they might have different values
[21:03:26] <Avenger> so i gave up on this, the iwd2 spellbook is much more interesting :)
[21:03:39] <edsrzf> Ok, that change made it better, but it's still not like the regular game
[21:04:21] <Avenger> well, i think they should be 2,1,0 not 1,2,3?
[21:04:36] <Avenger> check how these values are used in core
[21:04:44] <edsrzf> Ah, yeah, that'd make sense based on what I'm seeing
[21:05:03] <edsrzf> I have 0, 1, 2 but the options seem reversed (although 1 doesn't behave quite like I'd expect)
[21:05:37] <Avenger> in core, 0 - no sound, 1 - 25% sound, 2 - always sound
[21:06:12] <Avenger> See actor.cpp::SelectActor / CommandActor
[21:06:43] <edsrzf> Ok, thanks
[21:11:17] <edsrzf> I see, when command frequency is 1, CommandActor plays a sound 20% of the time, but I think it's supposed to only play a sound the first time you issue a command after selecting
[21:11:24] <edsrzf> 25%, I mean
[21:11:47] <-- edsrzf has left IRC (Remote host closed the connection)
[21:12:48] --> edsrzf has joined #gemrb
[21:29:24] <-- Avenger has left IRC (Quit: bye!)
[21:37:31] <edsrzf> I have a patch ready. How do I get someone to look at it?
[21:37:50] <lynxlynxlynx> paste/upload it somewhere
[21:39:40] <edsrzf> https://gist.github.com/2003634
[21:41:53] <edsrzf> I wasn't sure what to do with Planescape's Python (if anything) since it seems to work differently
[21:44:02] <lynxlynxlynx> looks fine
[21:44:21] <lynxlynxlynx> maybe expand the var name
[21:44:34] <edsrzf> playedCommandSound?
[21:44:37] <lynxlynxlynx> then git format-patch
[21:45:39] <lynxlynxlynx> something else would be better, since it also affects selection sounds
[21:46:10] <edsrzf> No, only command sounds.
[21:46:33] <edsrzf> Select resets it, but it only affects whether or not the4 command sound is played
[21:46:49] <edsrzf> And even then only when the option is a certain value
[21:48:13] <-- qubodup has left IRC (Quit: leaving)
[21:51:12] <edsrzf> Updated the gist with a patch generated by git format-patch, anyway
[21:51:52] <fuzzie> seems fine at a glance
[21:52:13] <fuzzie> had to stop myself from asking why it wasn't a pull request, alas :(
[21:52:31] <edsrzf> gemrb's not on GitHub, is it?
[21:52:57] <edsrzf> Otherwise I'd be happy to submit a pull request somewhere :)
[21:53:20] <fuzzie> it is not in a useful form :-/
[21:55:06] <brad_a> what exactly is a pull request?
[21:55:59] <-- Yoshimo has left IRC (Quit: Yoshimo)
[21:56:54] <fuzzie> brad_a: it's a github way of requesting that a git branch be merged into a main repository
[21:57:10] <brad_a> ok :) thank you
[21:57:21] <fuzzie> the devs get auto-notified, you can add comments, new commits to the branch get automatically added, etc
[21:57:26] <fuzzie> basically a convenient code review mechanism
[21:58:04] <lynxlynxlynx> yep, but alas, send the full patch in the meanwhile
[21:58:21] <edsrzf> Send it where?
[21:58:49] <lynxlynxlynx> a gist is fine
[21:59:15] <edsrzf> Ok, I updated mine with a git format-patch generated patch
[22:07:58] <-- wrotek has left IRC (Ping timeout: 272 seconds)
[23:18:09] <lynxlynxlynx> ups
[23:18:29] <lynxlynxlynx> i'll apply it tommorow err yeah, if nobody beats me to it
[23:19:16] <lynxlynxlynx> thomas_sch started working on merging all these silly copies of guiopt.py, but i don't know how far he's come
[23:19:31] <-- lynxlynxlynx has left IRC (Remote host closed the connection)
[23:46:27] --> kettuz has joined #gemrb
[23:46:27] <thomas_sch> yeah I started it and got the basics together but right now I'm swamped with work
[23:46:43] <thomas_sch> I will update you all in a week or so^^
[23:53:10] --> edheldil_ has joined #gemrb