[00:17:33] --> raevol has joined #GemRb
[00:28:02] <-- raevol has left IRC (Quit: Leaving.)
[00:46:59] --> tomprince has joined #GemRb
[01:40:45] <tomprince> What's happening with GetPalette in PNGImporter, is that GetPalette is that it had completely different meaning in BMPImporter vs. PNGImporter, despite being a virtual function. I just pushed a fix to repo.or.cz that fixes PNGImporter, so it doesn't crash, and fixes the generic implementation. It also get rid of the implementation in BMPImporter, and makes the generic version non-virtual.
[03:40:57] <-- Maighstir_laptop has left IRC (Quit: Maighstir_laptop)
[05:01:01] <-- Nomad010 has left IRC (Ping timeout: 264 seconds)
[06:04:24] --> Nomad010 has joined #GemRb
[06:26:49] --> xrogaan has joined #GemRb
[08:20:56] --> raevol has joined #GemRb
[08:37:52] --> lynxlynxlynx has joined #GemRb
[08:37:53] --- ChanServ gives channel operator status to lynxlynxlynx
[09:18:40] <fuzzie> tomprince: aha! thankyou. and for the other thing, I guess you've just removed the original GetPixel/SetPixel entirely? seems like the 24bpp codepath for Bitmap is going to lose data, but (again) haven't looked in detail
[09:45:21] --> Maighstir_laptop has joined #GemRb
[09:47:04] <-- |Cable| has left IRC (Remote host closed the connection)
[10:16:41] <-- raevol has left IRC (Quit: Leaving.)
[10:16:52] --> nomad__ has joined #GemRb
[10:17:33] <-- Nomad010 has left IRC (Remote host closed the connection)
[10:59:21] <-- nomad__ has left IRC (Ping timeout: 245 seconds)
[10:59:51] --> nomad__ has joined #GemRb
[11:01:20] <-- Maighstir_laptop has left #GemRb
[11:11:01] <-- nomad__ has left IRC (Ping timeout: 245 seconds)
[11:32:07] <-- xrogaan has left IRC (Quit: Why ?)
[12:09:48] --> nomad__ has joined #GemRb
[13:02:39] <-- Forgetful_Lion has left IRC (Quit: HydraIRC -> http://www.hydrairc.com <- Go on, try it!)
[13:29:13] <-- nomad__ has left IRC (Ping timeout: 264 seconds)
[14:28:30] <tomprince> As far as I can tell, the GetPixel/SetPixel interface only worked sanely for palettized images. There was code for RGB images, which I tried to duplicate in GetBitmap, which does lose data.
[14:28:44] <tomprince> I don't know if that code is ever used, or if it works in that case.
[14:29:18] <tomprince> The only use for Bitmap, is for things like searchmap, that use the index into the palette, rather than the color.
[14:31:33] <tomprince> Also, feel free to ask me about any of the other code, whether I am here or not. I do track the logs here.
[14:33:08] <fuzzie> well, another obvious thing is the disabled searchmap debug code
[14:34:13] <tomprince> That is mostly just me being lazy.
[14:34:39] <tomprince> Since the searchmap is now a Bitmap, not an image, there is no easy way to display it.
[14:35:17] <tomprince> It wouldn't be to hard to code a function to take a Bitmap and a Palette and turn it into and Sprite and print it.
[14:36:19] <tomprince> I didn't have any use for it at the time, and did not know how useful it was, so I didn't bother to add that bit of code.
[14:37:30] <fuzzie> not sure how useful it is either; FOG_DRAWSEARCHMAP is the important one, which is still fine
[14:40:35] <tomprince> I commented it out to show that it was dropping functionallity, and because it is too hard to add it back.
[14:43:45] <fuzzie> The less messy design is definitely worth it. I seem to remember the searchmap accesses are high on the profile list, too; since Bitmap::GetPixel will be inlinable, I hope it vastly improves that.
[14:50:54] <tomprince> That is what I am trying to do, decreasing the coupling and the subtle interactions.
[16:43:13] --> Nomad010 has joined #GemRb
[21:43:20] --> |Cable| has joined #GemRb
[22:57:26] <-- lynxlynxlynx has left IRC (Remote host closed the connection)