#gemrb@irc.freenode.net logs for 9 Jun 2012 (GMT)

Archive Today Yesterday Tomorrow
GemRB homepage


[00:27:58] --> brad_a has joined #gemrb
[00:47:49] <-- wrotek has left IRC (Ping timeout: 248 seconds)
[01:03:46] --> joneirik has joined #gemrb
[02:39:10] <-- joneirik has left IRC (Ping timeout: 244 seconds)
[02:41:28] <-- Drakkar has left IRC (Ping timeout: 246 seconds)
[02:47:55] --> Drakkar has joined #gemrb
[03:42:14] <-- kida_laptop has left IRC (Read error: Connection reset by peer)
[03:44:00] --> kida_laptop has joined #gemrb
[04:56:58] <-- nutron has left IRC (Quit: I must go eat my cheese!)
[06:04:16] <-- brad_a has left IRC (Quit: brad_a)
[07:38:00] --> lynxlynxlynx has joined #gemrb
[07:38:00] <-- lynxlynxlynx has left IRC (Changing host)
[07:38:00] --> lynxlynxlynx has joined #gemrb
[07:38:00] --- ChanServ gives channel operator status to lynxlynxlynx
[09:24:28] <-- Drakkar has left IRC (Ping timeout: 245 seconds)
[09:28:20] --> Drakkar has joined #gemrb
[09:32:23] --> Yoshimo has joined #gemrb
[11:43:03] --> weird000 has joined #gemrb
[11:45:40] <-- Yoshimo has left IRC (Quit: Yoshimo)
[12:19:22] <-- weird000 has left IRC (Quit: Page closed)
[12:31:38] <-- alexander__b has left IRC (Ping timeout: 240 seconds)
[12:41:31] --> alexander__b has joined #gemrb
[12:47:28] --> wrotek has joined #gemrb
[13:22:29] <-- cfchris6 has left IRC (Ping timeout: 248 seconds)
[13:41:44] --> cfchris6 has joined #gemrb
[16:25:59] <-- cfchris6 has left IRC (Ping timeout: 245 seconds)
[17:09:22] --> brad_a has joined #gemrb
[18:33:36] --> kettuz has joined #gemrb
[19:00:29] --> decker^ has joined #gemrb
[19:03:57] <decker^> hello
[19:05:33] <decker^> can i fork a git from sourceforge over to github?
[19:06:30] <decker^> or is sourceforge better anyway
[19:15:57] <decker^> The encumbrance text (both in inventory elsewhere) is broken. <-- I fixed this bug for the inventory GUI, well actually I circumvented the bug...
[19:16:05] <decker^> who do I talk to about submitted this
[19:20:09] --- decker^ is now known as olathuss
[19:27:38] <olathuss> maybe i'll read this guidelines first real quick lol
[19:31:22] <lynxlynxlynx> how did you fix it?
[19:31:26] <olathuss> is this correct, 8 spaces wide for tabs?
[19:31:37] <lynxlynxlynx> tabs for tabs
[19:31:49] <olathuss> ah
[19:31:59] <olathuss> in GUIScripts.cpp
[19:32:07] <olathuss> err GUIScript.cpp
[19:32:34] <olathuss> in
[19:32:37] <olathuss> static PyObject* GemRB_DragItem(PyObject * /*self*/, PyObject* args)
[19:32:44] <olathuss> I put
[19:32:55] <olathuss> actor->inventory.CalculateWeight(); int encumbrance = actor->inventory.GetWeight(); actor->SetStat(IE_ENCUMBRANCE, encumbrance, false);
[19:33:01] <olathuss> after RefreshEffects()
[19:33:13] <lynxlynxlynx> oh
[19:33:16] <olathuss> RefreshEffects(NULL) seems to set encumbrance to zero for some reason
[19:33:22] <lynxlynxlynx> was the wrong thing displayed?
[19:33:30] <olathuss> wrong thing?
[19:33:41] <lynxlynxlynx> that todo line was actually meant for the positioning of the text (and cutoff)
[19:33:48] <lynxlynxlynx> the wrong number
[19:33:58] <olathuss> oh
[19:34:15] <olathuss> No I noticed that whenever you pick up items from inventory it display 0 lbs being carried
[19:35:06] <lynxlynxlynx> yeah, i see that now
[19:35:33] <olathuss> then when you put the item back into inventory, the weight becomes your original weight minus the item moved.
[19:35:52] <olathuss> So like if you are carrying 120 lbs and pick up 15 lbs item, then put it back it shows 105
[19:36:26] <olathuss> it's probably not the best fix for it though
[19:36:35] <lynxlynxlynx> why not just call Actor::CalculateSpeed ?
[19:36:58] <olathuss> yeah that could work since calculate speed does it
[19:37:03] <lynxlynxlynx> it also does the encoumbrance feedback
[19:37:08] <olathuss> yeah
[19:37:16] <olathuss> might be a better fix
[19:37:56] <lynxlynxlynx> could get spammy
[19:38:05] <olathuss> considering I copied that code from calculate speed lol
[19:38:56] <CIA-33> GemRB: 03bradallred * r8dc631cf1901 10gemrb/apple/GemRB.xcodeproj/project.pbxproj: Xcode: update project to xcode 4.3 and iOS SDK 5.1
[19:39:06] <CIA-33> GemRB: 03bradallred * r29a0423bb342 10gemrb/gemrb/plugins/SDLVideo/SDLVideo.cpp: SDLVideo: fix SDL 2.0 compilation by adding defines to match some SDL 1.2 constants.
[19:39:07] <lynxlynxlynx> if you're already carrying too much, shuffling potions or other lightweight items would make you complain again
[19:39:41] <olathuss> hmm? what do you mean
[19:40:53] <lynxlynxlynx> any drag causes a recalc and thus feedback
[19:41:20] <lynxlynxlynx> we should only give feedback if the status changes, but CalculateSpeed doesn't do that
[19:41:28] <lynxlynxlynx> where it is used, it doesn't need to care
[19:41:39] <olathuss> oh i think i see what you mean
[19:42:07] <lynxlynxlynx> so i guess the first approach is fine and the feedback can be done in the python script
[19:44:16] <olathuss> which feedback do you mean
[19:44:49] <olathuss> sorry still learning here
[19:45:26] <lynxlynxlynx> encumbered / can't move
[19:45:46] <lynxlynxlynx> i actually don't remember if that was ever displayed in the inventory or just when you were trying to move
[19:46:17] <lynxlynxlynx> and re github: it's complicated
[19:46:22] <olathuss> yeah, GUICommons.py gives feedback on SetEncumbranceLabel
[19:47:09] <olathuss> which happens once, drag item causes refreshinventory to be called
[19:47:28] <olathuss> drag item also calls drag item, and in this case would then call calculatespeed
[19:47:35] <olathuss> it all happens once
[19:47:46] <olathuss> When an item is picked up by the cursor and set to drag
[19:48:30] <olathuss> i made a sourceforge account a few days ago when i posted that load game bug for iwd
[19:49:11] <lynxlynxlynx> sf is not nice for sharing patches
[19:49:43] <lynxlynxlynx> a pastebinned git format-patch is the easiest
[19:50:11] <lynxlynxlynx> there are github repos, but none up-to-date and we can't merge them yet
[19:50:54] <lynxlynxlynx> bbl
[19:51:00] <olathuss> ok
[20:09:16] <olathuss> calling CalculateSpeed looks nicer, good idea on that.
[20:11:38] <olathuss> anyway here is my fix if you want to use it: http://tgull.php.cs.dixie.edu/gemrb/GUIScript.7z
[20:11:50] <olathuss> search for **!** to find the three parts I put in there
[20:20:46] <brad_a> why not just put a diff on pastebin?
[20:24:05] <olathuss> i don't know what i am doing
[20:24:07] <olathuss> :(
[20:24:39] <olathuss> if you would not mind explaining how to do that I would be happy to
[20:25:00] <olathuss> or maybe a url that explains how...
[20:26:23] <brad_a> http://linux.die.net/man/1/git-diff
[20:26:55] <olathuss> ok thanks
[20:41:25] <olathuss> use Diff or C++ syntax coloring?
[20:42:57] <olathuss> nm
[20:55:26] <olathuss> so like this:
[20:55:27] <olathuss> http://pastebin.com/arLNX69T
[20:57:24] <olathuss> much nicer, thanks
[20:59:03] <olathuss> except somehow refresheffects got in there twice on the first, fixed that just now
[21:00:09] <olathuss> anyway, I appreciate your help guys and patience with my learning.
[21:00:18] <olathuss> i'm out so tty later
[21:00:23] <-- olathuss has left IRC (Quit: Page closed)
[21:09:53] <-- kettuz has left IRC (Quit: Leaving)
[21:57:28] <-- |Cable| has left IRC (Remote host closed the connection)
[22:02:17] --> |Cable| has joined #gemrb
[22:30:19] <-- lynxlynxlynx has left IRC (Remote host closed the connection)
[22:53:49] --> nutron has joined #gemrb
[22:55:25] <-- |Cable| has left IRC (Remote host closed the connection)
[22:57:02] --> |Cable| has joined #gemrb
[23:06:15] <-- |Cable| has left IRC (Remote host closed the connection)
[23:07:53] --> |Cable| has joined #gemrb
[23:10:06] <-- |Cable| has left IRC (Remote host closed the connection)
[23:11:46] --> |Cable| has joined #gemrb
[23:15:17] <-- |Cable| has left IRC (Remote host closed the connection)
[23:16:52] --> |Cable| has joined #gemrb
[23:18:44] <-- |Cable| has left IRC (Remote host closed the connection)
[23:20:15] --> |Cable| has joined #gemrb
[23:51:28] <-- |Cable| has left IRC (Remote host closed the connection)
[23:52:59] --> |Cable| has joined #gemrb