[02:54:51] <Malignant_Manor> Dominus: (much later) I don't care if it is forced atm. I just care if it is being built.
[02:54:58] <-- Malignant_Manor has left IRC (Quit: ChatZilla 0.9.90.1 [Firefox 27.0/20140127194636])
[09:02:57] <Dominus> Malignant, no, didn't build with joystick support since the configure thing needed sorting out (AC_DEFINE(HAVE_JOYSTICK_SUPPORT, 1, [Enable Joystick Support]))
[09:03:09] <Dominus> but now I'm running in other problems
[09:05:42] <Dominus> keybinding/KeyActions.cpp:181:25: error: no member named 'set_enable_joy_repeat'
[09:05:42] <Dominus> in 'KeyBinder'
[09:48:40] <Dominus> ok, that's odd, probably something wjp can explain to me
[09:52:31] <Dominus> ok, this patch makes joystick support actually work somewhat
[09:53:51] <Dominus> wjp, my question is: I had to move the #ifdef HAVE_JOYSTICK_SUPPORT in JoystickDialog.cpp further down, otherwise the final linking stage would choke because of this
[09:54:50] <Dominus> why does the ifdef need to be further down?
[09:55:06] <wjp> hm?
[09:55:26] <Dominus> http://pastie.org/8721747#5
[09:55:36] <Dominus> sorry, forgot zhe patch link
[09:56:37] <Dominus> the #ifdef HAVE_JOYSTICK_SUPPORT in JoystickDialog.cpp was in the first line and only when I moved i down did the final linking of nuvie work
[10:12:21] <Dominus> and curiosly I needed to move the #include "nuvieDefs.h" in Keys.h out of the ifdef, too
[10:13:17] <Dominus> otherwise the compile would abort with the keybinding/KeyActions.cpp:181:25: error: no member named 'set_enable_joy_repeat' in 'KeyBinder'
[10:13:33] <Dominus> I'm a bit puzzled about this
[10:16:17] <wjp> I can look later
[10:16:24] <Dominus> thanks
[10:16:29] <wjp> (but do remind me :-) )
[10:16:35] <Dominus> :)
[12:49:13] --> TheCycoONE has joined #nuvie
[18:00:06] --> Malignant_Manor has joined #nuvie
[18:03:10] <Malignant_Manor> Dominus: Try this. http://pastebin.com/erdzNRUF
[18:03:50] <Malignant_Manor> I have to build without tool support but otherwise this compiled fine.
[18:11:47] <Malignant_Manor> Trying your way of AC_DEFINE(HAVE_JOYSTICK_SUPPORT, 1, [Enable Joystick Support]) has the error
[18:43:24] <-- Malignant_Manor has left IRC (Quit: ChatZilla 0.9.90.1 [Firefox 27.0/20140127194636])
[18:56:05] --> TheCycoTWO has joined #nuvie
[18:56:40] <-- TheCycoONE has left IRC (Read error: No route to host)
[19:15:37] <Dominus> malignant, I'm not sure whether appending cppflags is the right way for doing this
[19:16:55] <Dominus> wjp: if you have time this evening can you take a look at my questions of today and what the right way is for doing the HAVE_Joystick...?
[19:17:45] <Dominus> I'm busy for the next two hours with household stuff so my answers will be delayed ;)
[19:37:41] <wjp> probably busy myself until then too, so... :-)
[21:34:36] <wjp> hm, something changed in svn just now related to this?
[21:34:47] <wjp> not good to add that to CPPFLAGS though
[21:35:03] <Dominus> hi, wjp, just sat down :)
[21:35:10] <wjp> since that won't trigger rebuilds if the option changes
[21:36:48] <wjp> AM_CONDITIONAL is for checks in Makefile.am, not in source files
[21:38:34] <wjp> AC_DEFINE is the thing to use
[21:39:59] <Dominus> using that as per my patch (when ignoring the AM_Conditional), produced some errors that I could work around but didn't understand
[21:46:05] <Dominus> wjp, why is using AC_DEFINE messing other things up, while the CPPFLAGS appending doesn't?
[21:46:17] <-- TheCycoTWO has left IRC (Quit: And then there were n-1)
[21:47:37] <wjp> maybe somewhere config.h isn't being included
[21:51:48] <Dominus> hmm, right. let me check which has ifdef HAVE Joystick...
[21:52:29] --> Malignant_Manor has joined #nuvie
[21:53:06] <Malignant_Manor> I doubt many files with it have config.h includes
[21:56:25] <Malignant_Manor> I'm not on my build comp and won't be for quite awhile.
[22:02:27] <-- Malignant_Manor has left IRC (Quit: ChatZilla 0.9.90.1 [Firefox 26.0/20131205075310])
[22:02:46] <Dominus> no file has it included. it should be nuviedefs.h which explains both cases
[22:04:04] <Dominus> nuviedefs.h includes config.h but if nuviedefs.h is *inside* the ifdef HAVE_JOYSTICK_SUPPORT it obviously can't check :)
[22:21:06] <Dominus> ok, I got it right now. Malignant, I will commit this
[22:24:18] <Dominus> thanks wjp for making me see what the culprit was :)
[22:24:43] <Dominus> now checking whether all ifdef MACOSX have nuvieDefs.h as well :)
[22:24:43] <wjp> np