#nuvie@irc.freenode.net logs for 5 Nov 2013 (GMT)

Archive Today Yesterday Tomorrow
Nuvie homepage

[00:15:32] <Malignant_Manor> Some notes about the tiles http://pastebin.com/8n3Pfh7L
[00:54:09] <-- Malignant_Manor has left IRC (Quit: ChatZilla [Firefox 24.0/20130910160258])
[00:58:12] <-- SugarCube has left IRC (*.net *.split)
[00:58:38] --> SugarCube has joined #nuvie
[07:24:06] --- Shozan is now known as SHODAN
[16:25:13] --> TheCycoONE has joined #nuvie
[19:19:48] --> Malignant_Manor has joined #nuvie
[20:25:34] --> Yuv422 has joined #nuvie
[20:32:04] <Malignant_Manor> Yuv422: I'm working on getting text class depreciated.
[20:33:20] <Yuv422> hi Malignant_Manor
[20:33:21] <Yuv422> cool
[21:01:55] <Malignant_Manor> Yuv422: I'm not sure what to do with Text.cpp and Text.h
[21:03:47] <Malignant_Manor> 44 files were changed when you don't consider Text.cpp and Text.h
[21:03:59] <Malignant_Manor> Hopefully there won't be any issues.
[21:11:04] <Yuv422> Maybe put a deprecated comment at the top
[21:11:15] <Yuv422> and after awhile we'll delete from from svn
[21:13:19] <Malignant_Manor> Yuv422: you might want to look over this. http://pastebin.com/PAYte7p8
[21:15:07] <Malignant_Manor> The overloaded drawChar function in Font is virtual. I don't know if this is an issue.
[21:28:41] <Yuv422> are you maintaining the default color when color isn't supplied?
[21:28:55] <Malignant_Manor> Yes
[21:29:18] <Malignant_Manor> It wasn't doing that before for MD and SE. It used U6 defaults.
[21:30:18] <Yuv422> ah k
[21:30:25] <Yuv422> how about gargish text in U6?
[21:30:44] <Malignant_Manor> That shows up when I look at books.
[21:31:08] <Yuv422> cool
[21:31:19] <Malignant_Manor> Is there any in conversation that I need to look at?
[21:31:36] <Yuv422> they are the only edge cases I can think of
[21:32:26] <Yuv422> I've got to go to work now
[21:32:29] <Yuv422> cya
[21:32:36] <Malignant_Manor> bye
[21:32:53] <wjp> you're changing the drawChar in font but not in the subclassses?
[21:32:59] <wjp> s/font/Font/
[21:33:03] <wjp> bye Eric
[21:33:04] <-- Yuv422 has left IRC (Quit: Yuv422)
[21:34:08] <Malignant_Manor> wjp: Yeah, that is one thing I need to look at.
[21:36:52] <Malignant_Manor> wjp: will removing the default assignment be enough?
[21:37:29] <wjp> what do you want to do?
[21:38:02] <Malignant_Manor> they have color = default in the last argument.
[21:38:21] <-- TheCycoONE has left IRC (Quit: And then there were n-1)
[21:38:37] <Malignant_Manor> I have an overloaded function instead that uses defaults based on the game
[21:39:39] <Malignant_Manor> They're private values in Font that get set on init.
[21:41:37] <Malignant_Manor> You might be able to understand better by reading the Font.* changes than me trying to explain it.
[21:43:39] <wjp> well, the new function you add in the subclasses is hidden, but that's not necessarily a problem
[21:43:48] <wjp> um
[21:43:55] <wjp> well, the new function you add is hidden in the subclasses, but that's not necessarily a problem
[21:45:21] <wjp> i.e., if you have a U6Font* x; you can't call x->drawChar() without the color argument
[21:45:29] <wjp> while that will work fine if you have a Font* x
[21:50:24] <Malignant_Manor> Weird, the ConvFont seems to work without the argument.
[21:50:42] <wjp> (that's if you remove the default argument, by the way)
[21:51:51] <wjp> keeping the default argument will be very confusing
[21:52:26] <wjp> because then calling x->drawChar() will use the default argument if x is a ConvFont*/U6Font*/... but call the new function is x is a Font*
[21:54:27] <wjp> so you should in any case remove the default arguments from all the subclasses I think. That may cause compile errors, but those highlight the case where currently the default argument would probably incorrect get used
[23:18:14] <-- Malignant_Manor has left IRC (Quit: ChatZilla [Firefox 24.0/20130910160258])