[00:00:57] --- ChanServ gives channel operator status to Dominus1
[00:00:57] --- Dominus1 is now known as Dominus
[06:30:54] <-- Dominus has left IRC (Read error: Connection reset by peer)
[06:31:11] --> Dominus has joined #pentagram
[06:31:11] --- ChanServ gives channel operator status to Dominus
[07:43:56] --> Dominus1 has joined #pentagram
[07:43:56] <-- Dominus has left IRC (Read error: Connection reset by peer)
[09:15:31] --- ChanServ gives channel operator status to Dominus1
[09:15:31] --- Dominus1 is now known as Dominus
[14:46:57] <-- Kirben has left IRC ()
[20:06:17] --> jvlee has joined #pentagram
[20:07:22] <-- jvlee has left IRC (Remote host closed the connection)
[21:07:28] <Dominus> wjp, taking this from #exult, my patch for pentagram is http://pastebin.com/CrSvfmEm
[21:08:21] <Dominus> I couldn't think of another way to make it work other than the "@WITH_OSX_CODE_SIGNATURE_TRUE@CODE_SIGN..." stuff in makefile.in
[21:10:48] <wjp> hm, using AM_CONDITIONAL?
[21:11:29] <wjp> maybe something like
[21:11:42] <wjp> ifneq (OSX_CODE_SIGNATURE,)
[21:11:45] <wjp> codesign -f -s ....
[21:11:58] <wjp> endif
[21:12:06] <wjp> would work?
[21:12:53] <wjp> (AM_CONDITIONAL is an automake macro)
[21:13:02] <Dominus> testing...
[21:13:18] <Dominus> gimptool is using am_conditional, too
[21:13:32] <Dominus> and it worked for some reason
[21:15:00] <wjp> yeah, it'll work (as you saw), but it's a bit hacky
[21:15:47] <Dominus> ifneq (OSX_CODE_SIGNATURE,) is not being detected
[21:15:53] <wjp> oh, $(OSX_CODE_SIGNATURE) of course
[21:16:09] <wjp> fully: ifneq ($(OSX_CODE_SIGNATURE),)
[21:17:38] <Dominus> ifeq (Developer ID Application,)
[21:17:39] <Dominus> /bin/sh: -c: line 0: syntax error near unexpected token `Developer'
[21:17:39] <Dominus> /bin/sh: -c: line 0: `ifeq (Developer ID Application,)'
[21:17:52] <Dominus> or ifneq, I tried both to be sure
[21:21:09] <wjp> in module.mk?
[21:21:15] <Dominus> yes
[21:21:27] <wjp> did you maybe indent it?
[21:21:50] <wjp> (the codesign line should have a tab, the ifneq/endif ones not)
[21:22:14] <Dominus> that was it
[21:22:31] <Dominus> I didn't think that would matter
[21:22:41] <Dominus> I'm a bit baffled now
[21:23:01] <Dominus> I have thought that is just style and not function
[21:23:38] <wjp> tabs in Makefiles identify the commands to execute
[21:24:30] <wjp> and the ifneq is make-syntax specifying a conditional part of the Makefile that is ignored if the test fails
[21:24:49] <Dominus> thanks for clarifying
[21:25:01] <Dominus> only underlines that I'm flying blind at most times...
[21:25:11] <wjp> it would also be possible to do this with a shell check like if test blah != blah; then codesign ....; fi, which would have to be indented then...
[21:25:42] <wjp> another part of this mixing languages fun that I mentioned yesterday :-)
[21:25:57] <Dominus> with all your help I wonder if you couldn't have made this for nuvie, exult and pentagram much faster :)
[21:26:36] <Dominus> (but it was funa nd frustrating but mostly fun to figure these things out and fail anyway at times :))
[21:26:59] <Dominus> So I'll scratch that AM_Conditional
[21:30:37] <Dominus> so this is the new version http://pastebin.com/AFteygMB
[21:32:21] <Dominus> bah, did it again with the echo stuff
[21:35:45] <Dominus> (actually I did that right before you told me that I did it wrong again)
[21:38:33] <Dominus> corrected http://pastebin.com/bqSNejHh
[21:40:45] <wjp> seems ok
[21:45:39] <Dominus> I just tested a bit and wonder if we can make a test for valid signature. If I run "codesign -s "invalid ID"" - I get "invalid ID : no identity found", I run "codesign -s "valid ID", I get the short usage summary.
[21:45:47] <Dominus> so per https://developer.apple.com/library/mac/#documentation/Darwin/Reference/ManPages/man1/codesign.1.html
[21:46:25] <Dominus> diagnostics: I see exit code 1 for invalid ID and exit 2 for vlaid ID but argument missing
[21:48:38] <Dominus> but that is really over my head
[21:48:55] <Dominus> so I'm committing this now :)
[21:50:00] <wjp> does something like this work? codesign -s "Developer ID Application" --dryrun configure
[21:50:25] <wjp> (or any other random file instead of configure)
[21:50:47] <Dominus> yes
[21:50:57] <Dominus> any random existing file
[21:51:01] <wjp> and an error with an invalid id?
[21:51:21] <Dominus> yep, identity not found
[21:51:47] <Dominus> "some invalid ID : no identity found"
[21:52:00] <wjp> and exit code 1 I guess?
[21:52:18] <Dominus> is there any easy way to check exit code?
[21:52:21] <wjp> echo $?
[21:54:19] <Dominus> how do I apply this to that? (tried "echo $(codesign...)"
[21:56:00] <wjp> do you mean for testing in a terminal or in the configure script?
[21:56:06] <Dominus> terminal
[21:56:16] <wjp> just run the command, and after it exits run "echo $?"
[21:56:23] <wjp> $? is the exit code of the last command
[21:57:21] <Dominus> thanks, exit code 1
[21:58:42] <wjp> so then you'd just need a reliable random file to use and it could provide an easy test
[22:00:31] <wjp> (but this can wait)
[22:01:02] <Dominus> yes :)
[22:03:14] * wjp wonders if it has already cooled down enough to try and sleep
[22:03:29] <Dominus> the big heat hits us on monday
[23:48:00] --> Dominus1 has joined #pentagram
[23:48:00] <-- Dominus has left IRC (Read error: Connection reset by peer)