#pentagram@irc.freenode.net logs for 21 Jul 2008 (GMT)

Archive Today Yesterday Tomorrow
Pentagram homepage


[00:25:43] --> Kirben has joined #pentagram
[00:25:44] --- ChanServ gives channel operator status to Kirben
[04:35:47] --> ShadowChas has joined #Pentagram
[04:35:58] <ShadowChas> 'Evenin
[04:36:10] <watt> hello
[04:37:52] <ShadowChas> I'm interested in helping with the Pentagram project - what's the best way to get started?
[04:39:34] <watt> Depends on what your interested in specifically, but naturally the first thing is to compile the code.
[04:40:24] <watt> I started by mucking about in the internals of the gumps directory to see what would happen
[04:40:39] <ShadowChas> I have the code compiling and can run the game directly in the debugger
[04:40:49] <watt> excellent.
[04:41:03] <ShadowChas> Awhile back I fixed a large number of W4 level warnings in Visual Studio and submitted a patch but I dont think anything ever happened with it
[04:41:43] <watt> oh.
[04:42:24] <ShadowChas> If I remember right, there was only one or two devs that worked in VS, right?
[04:44:04] <ShadowChas> When testing code before submitting/committing, what's the proper procedure? Test it in the local build obviously - but what about other build environments?
[04:44:14] <watt> I believe so - I just looked up the patches - I'll read through in one sec
[04:44:58] <ShadowChas> (Its an old patch, I should probably redo it before it gets merged in)
[04:45:27] <watt> Well, I think a check against a msys build environment wouldn't hurt, but might be overkill in most situations.
[04:45:47] * ShadowChas nods
[04:49:44] <watt> I would go as far as to say that you've already gotten started :-)
[04:50:33] <ShadowChas> I suppose ;) But making the leap from "code lurker" to contributor is a bit of a jump :)
[04:55:00] <watt> hmmm, well I might look into the CPPWarnings patch myself, but I don't feel comfortable murking about in the VS build stuff.
[04:55:56] <ShadowChas> No worries. Like I said, it's fairly old - I'd rather resubmit a newer version
[04:56:03] <ShadowChas> Probably would have a lot of conflicts
[04:57:07] <watt> It was ignored for a year... so maybe
[05:02:13] <watt> Not really sure what else to point at right now - I'm sure there must be a few fixmes and todos if you're looking for something - wjp might have a hit list of items that might be of interest at the moment.
[05:02:44] <watt> As for me, I should consider sleep soon
[05:04:08] <ShadowChas> Alright, talk to you later
[05:18:55] <ShadowChas> I tested the build on VS2008, there's one issue that causes it to fail
[05:19:12] <ShadowChas> Very easy fix - anyone else here to approve it? :)
[05:20:57] <ShadowChas> msvc_include.h(186)
[05:21:21] <ShadowChas> vsnprintf is pre-defined in Visual Studio 2008. The line needs to be commented out for VS2008 builds
[05:21:24] <ShadowChas> #if (_MSC_VER < 1500)
[05:21:28] <ShadowChas> #define vsnprintf _vsnprintf
[05:21:31] <ShadowChas> #endif
[05:21:37] <ShadowChas> That's it - once that fix is made it will compile
[05:29:49] <Colourless> sounds harmless enough :-)
[05:30:45] <ShadowChas> What should I do? Send you the file? Create a patch?
[05:31:02] --- ShadowChas is now known as ShadwChsr
[05:34:14] <Colourless> good question. needs to be a way that'll actually get me to get around to putting it in
[05:36:16] * Colourless does an update to his pentagram source tree
[05:36:29] * Colourless grumbles at crappy isp
[05:36:54] <ShadwChsr> I found it fairly slow today for me as well
[05:36:54] <ShadwChsr> Might be SF
[05:37:08] * Colourless still grumbles at crappy isp
[05:37:10] <Colourless> :-)
[05:37:23] <Colourless> so you only want msvc_include.h modified?
[05:38:04] <ShadwChsr> Right now, yes. It removes the barrier for people wanting to upgrade the project files.
[05:38:29] <ShadwChsr> Checking in the project/solution files would probably make all of the Pentagram coders that use Visual Studio 2005 a little cranky ;)
[05:38:48] <Colourless> so thats the only problem for vs2008?
[05:39:08] <ShadwChsr> The only build error
[05:39:20] <ShadwChsr> There are a few warnings but I remember the same ones in vs2005
[05:39:21] <Colourless> okies. Cool. will commit this
[05:39:47] <ShadwChsr> Maybe add a comment about why the #if is there too
[05:40:22] <ShadwChsr> at the top of msvc_include.h Is a "#if (_MSC_VER != 1300) && (_MSC_VER != 1310) && (_MSC_VER != 1400)"
[05:40:39] <ShadwChsr> It puts in a bunch of warnings if VS2008 is used "untested version" message/etc
[05:40:48] <ShadwChsr> Up to you if you want to add && (_MSC_VER != 1500)
[05:40:49] <ShadwChsr> :)
[05:41:26] <Colourless> yeah i added that too
[05:41:32] <ShadwChsr> Thanks
[05:41:37] <Colourless> i should probably remove that warning
[05:42:05] <ShadwChsr> The other warnings are mainly size_t conversion issues and the use of "mkdir" instead of the iso "_mkdir"
[05:43:01] <ShadwChsr> There are a few missing files in the project
[05:43:40] <ShadwChsr> Will look into them tomorrow :)
[05:46:45] <Colourless> ok comitted that
[05:49:35] <ShadwChsr> Thanks
[05:53:27] <ShadwChsr> Night!
[05:53:31] <-- ShadwChsr has left IRC ()
[06:50:22] <-- Colourless has left IRC ("casts improved invisibility")
[08:07:06] --> Colourless has joined #Pentagram
[12:22:39] <-- Mrrrrz0r has left IRC (Remote closed the connection)
[12:22:51] --> Mrrrrz0r has joined #pentagram
[13:34:39] <-- Mrrrrz0r has left IRC (Remote closed the connection)
[13:37:00] --> Mrrrrz0r has joined #pentagram
[13:43:23] <-- Mrrrrz0r has left IRC (Remote closed the connection)
[13:48:47] <-- Kirben has left IRC (Read error: 110 (Connection timed out))
[13:51:57] --> Mrrrrz0r has joined #pentagram
[13:54:57] <-- Mrrrrz0r has left IRC (Remote closed the connection)
[13:55:11] --> Mrrrrz0r has joined #pentagram
[13:56:32] <-- watt has left IRC ()
[13:59:48] <-- Mrrrrz0r has left IRC (Remote closed the connection)
[14:06:57] --> Mrrrrz0r has joined #pentagram
[14:09:58] <-- Mrrrrz0r has left IRC (Remote closed the connection)
[14:10:52] --> Mrrrrz0r has joined #pentagram
[14:18:33] <-- Mrrrrz0r has left IRC (Remote closed the connection)
[14:18:51] --> Mrrrrz0r has joined #pentagram
[14:21:48] <-- Mrrrrz0r has left IRC (Remote closed the connection)
[14:21:59] --> Mrrrrz0r has joined #pentagram
[14:22:44] --> watt has joined #pentagram
[14:22:44] --- ChanServ gives channel operator status to watt
[14:28:09] <-- Mrrrrz0r has left IRC (Remote closed the connection)
[14:30:25] <-- watt has left IRC ()
[14:31:14] --> watt has joined #pentagram
[14:31:15] --- ChanServ gives channel operator status to watt
[14:31:38] --> Mrrrrz0r has joined #pentagram
[16:28:58] --> watt_ has joined #pentagram
[16:29:02] <-- watt has left IRC (Read error: 104 (Connection reset by peer))
[20:54:34] <wjp> just got a report by e-mail (in Dutch, so won't forward to the ML) that U8 is still completable in pentagram
[21:15:34] <watt_> cool.
[21:15:48] <watt_> tiny actors huh?
[21:16:49] * watt_ hums Tiny Dancer
[21:18:33] <wjp> skellots, spiders :-)
[21:19:06] <wjp> oh, going over the feature requests: "alpha background on the console" is now very doable
[21:19:50] <wjp> (in fact, except for the debugging notification area it's already implemented but commented out, it seems)
[21:19:58] <watt_> I've done it in fact.... just never bothered completing it.
[21:23:04] <wjp> ah, ok
[21:24:15] <watt_> I think I got obsessed over the scrolling of it since changing it made it jumpy.
[21:24:31] <-- watt_ has left #pentagram ()
[21:25:01] --> watt_ has joined #pentagram
[21:32:10] <wjp> hm, I don't really see what you mean
[21:43:18] <wjp> time to go; good night
[21:53:58] <watt_> night.
[21:54:06] --- watt_ is now known as watt
[21:54:07] --- ChanServ gives channel operator status to watt
[21:57:41] <watt> Oh. Actually that's one I worked out to completion in December - just still didn't switch add the background.
[22:05:09] <watt> ConsoleGump.cpp:114 - I think uncommenting this is what bothered me.
[22:39:12] --> fackue has joined #pentagram
[22:39:37] <fackue> i believe I've found a bug and making a save is possible
[22:48:18] <fackue> http://dchelp.dcemulation.org/personal/pent12.zip
[22:51:13] <-- fackue has left #pentagram ()
[23:03:47] --> Kirben has joined #pentagram
[23:03:47] --- ChanServ gives channel operator status to Kirben
[23:04:17] <watt> Can't properly unzip that save - was it ftp'ed up without the bin flag on?